GitLab

Some preliminary work to remove PlatformEvent abstractions.

Rename a constant to pass check-webkit-style.

BUG=625684
TBR=rbyers@chromium.org

Review-Url: https://codereview.chromium.org/2173073003
Cr-Commit-Position: refs/heads/master@{#407186}

The font cascade reconfiguration which was introduced as fix for AAT
shaping performance regressions in crbug.com/547912 seems to
occasionally cause CoreText crashes on OS X 10.9. We don't have a better
way of detecting this than by OS or CoreText API version number. This is
one of our top Mac crashers on Mac OS 10.9 with Chrome across versions [1].

This crash does not occur in newer versions of OS X and we can keep this
important performance optimization enabled there.

A big thanks to Robert Sesek (rsesek@) for the patient and thorough
initial investigation. Discussing and working together on this issue we
were able to identify the crash triggering code in HarfBuzz in this
case.

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=576941#c74

BUG=576941, 625902

Review-Url: https://codereview.chromium.org/2173883002
Cr-Commit-Position: refs/heads/master@{#407185}

I wrote this while investigating a Promise issue. I think it wouldn't
hurt to land it :)

BUG=None

Review-Url: https://codereview.chromium.org/2178463002
Cr-Commit-Position: refs/heads/master@{#407184}

libyuv offers a new API, Android420ToI420, to convert the
Android YUV_420_888 frame (which has interleaved UV planes)
to normal I420 frame.
This can significantly reduce the de-interlacing time on
Android, up to dozens of milliseconds, which can help a lot
on the overall end-to-end video delay.

BUG=629342

Review-Url: https://codereview.chromium.org/2156003006
Cr-Commit-Position: refs/heads/master@{#407183}

Android lint tool pointed out that ... should really be … (U+2026).
Tested that this glyph renders well on Mac + Win as well, so
applying to all OS's by default.

TBR=flackr
BUG=621772

Review-Url: https://codereview.chromium.org/2112653003
Cr-Commit-Position: refs/heads/master@{#407182}

WindowServer::GetTreeWithId can be null in the case of
|in_nonclient_area|. It looks like |tree| was used without check in
4d3588cb.

BUG=630402

Review-Url: https://codereview.chromium.org/2170053003
Cr-Commit-Position: refs/heads/master@{#407181}

BUG=

Review-Url: https://codereview.chromium.org/2148293005
Cr-Commit-Position: refs/heads/master@{#407180}

This patch arranges the payment instruments in the following order:
> Non-autofill payment apps
> Complete credit cards from Autofill.
> Incomplete credit card from Autofill (need editing before sending to
  the merchant).

BUG=629882

Review-Url: https://codereview.chromium.org/2165163002
Cr-Commit-Position: refs/heads/master@{#407179}

Both Chromium and Blink code can use std::unique_ptr<> recently, so now
we can express the ownership passing on the type of WebTaskRunner::clone.
This CL replaces the return type of WebTaskRunner::clone from a raw pointer
to a std::unique_ptr<>, removes adoptClone, and updates the call-sites.

Review-Url: https://codereview.chromium.org/2148363004
Cr-Commit-Position: refs/heads/master@{#407178}

When escape is pressed to hide the spectrum, use commitEdit to return to
the original color text.

R=lushnikov

Review-Url: https://codereview.chromium.org/2171003002
Cr-Commit-Position: refs/heads/master@{#407177}

Revert of mus: Rename .*PointerWatcher.* to .*PointerDownWatcher.*. (patchset #5 id:80001 of https://codereview.chromium.org/2158273003/ )

Reason for revert:
As discussed (https://codereview.chromium.org/2163453002/), changing PointerWatcher to watch for all events instead.

Original issue's description:
> mus: Rename .*PointerWatcher.* to .*PointerDownWatcher.* to avoid confusion with PointerEventWatcher (https://codereview.chromium.org/2163453002/).
>
> Committed: https://crrev.com/b2db88d57e677ab3ff4b3fc7f58896603816053c
> Cr-Commit-Position: refs/heads/master@{#406584}

Review-Url: https://codereview.chromium.org/2167643005
Cr-Commit-Position: refs/heads/master@{#407176}

The original archives were recorded on Chrome Public (android-chromium)
and used an encoding that is not yet supported by Chrome Stable
(reference).

BUG=630004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq

Review-Url: https://codereview.chromium.org/2172263002
Cr-Commit-Position: refs/heads/master@{#407175}

https://chromium.googlesource.com/skia.git/+log/d01a8f470f43..d50e2401787d

$ git log d01a8f470..d50e24017 --date=short --no-merges --format='%ad %ae %s'
2016-07-22 csmartdalton Fix SkClipStack bug with inverse-filled difference elements
2016-07-22 mtklein Don't ask GLX for EGL procs.
2016-07-22 borenet Change SKPs to new asset management format

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2175823002
Cr-Commit-Position: refs/heads/master@{#407174}

It's not being called, as of https://codereview.chromium.org/2123093002.
And none of the implementations actually do anything.

BUG=479994
TBR=rdsmith@chromium.org

Review-Url: https://codereview.chromium.org/2164113002
Cr-Commit-Position: refs/heads/master@{#407173}

Found crash in apk, but there is no offset, like below
DEBUG   :     #04 pc 0000000000209998  /data/app/org.chromium.chrome-1/base.apk

BUG=630620

Review-Url: https://codereview.chromium.org/2176693002
Cr-Commit-Position: refs/heads/master@{#407172}

'Cancel' isn't really the right word for what this change does.
In the event of an image decoding failure, ImageResource will
synthesize a call to ResourceLoader::didFinishLoading, killing
the actual network request but reporting it as a successful
completion to the rest of blink. This matches our traditional
behavior of decoding errors looking like a successful
resource load (for the most part).

This requires some plumbing changes to image decoding, because
the decoder selection logic doesn't report why it wasn't able to
create an ImageDecoder. It might be because insufficient data has
been received to sniff the image type, or it may be that we
definitely don't have a valid image type. This change exposes enough
information to tell the difference.

BUG=471272

Review-Url: https://codereview.chromium.org/2108033003
Cr-Commit-Position: refs/heads/master@{#407171}

No need to pre-configure the net::DnsClient and it will pick up changes to the
system DNS config automatically via net::NetworkChangeNotifier.

BUG=612439

Review-Url: https://codereview.chromium.org/2152143003
Cr-Commit-Position: refs/heads/master@{#407170}

BUG=615157

Review-Url: https://codereview.chromium.org/2179493002
Cr-Commit-Position: refs/heads/master@{#407169}

Fix bugs in attrib-type-match.html

BUG=628459
TEST=conformance2/rendering/attrib-type-match.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2148723004
Cr-Commit-Position: refs/heads/master@{#407168}

https://chromium.googlesource.com/skia.git/+log/da626aadcced..d01a8f470f43

$ git log da626aadc..d01a8f470 --date=short --no-merges --format='%ad %ae %s'
2016-07-22 mtklein Fix SW sRGB dst + LCD coverage bug.
2016-07-22 brianosman Update SkImage_NewFromTexture test, to just test release procs of SkImage::MakeFromTexture.
2016-07-22 bsalomon Revert of Retract PipelineBuilder some more (patchset #9 id:160001 of https://codereview.chromium.org/2092893003/ )
2016-07-22 brianosman Cleanup of code that converts from GPU-backed resources to SkImageInfo
2016-07-22 msarett Add clamp to sk_linear_to_srgb, reorder instructions
2016-07-22 benjaminwagner Add SK_SUPPORT_LEGACY_ACCESSBITMAP to public.bzl.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2173703004
Cr-Commit-Position: refs/heads/master@{#407167}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2cf82064..1852b91a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2171343002
Cr-Commit-Position: refs/heads/master@{#407166}

As we continue to split WebView/WebWidget, this change renames
WebTestProxy to WebViewTestProxy, since it should only used for
proxying RenderView calls. A future change will introduce a new
WebWidgetTestProxy for use with RenderWidget.

BUG=583347

Review-Url: https://codereview.chromium.org/2171503005
Cr-Commit-Position: refs/heads/master@{#407165}

Review-Url: https://codereview.chromium.org/2174783003
Cr-Commit-Position: refs/heads/master@{#407164}

Cleaning up track-webvtt* http tests to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Review-Url: https://codereview.chromium.org/2179433002
Cr-Commit-Position: refs/heads/master@{#407163}

This was lifted in https://codereview.chromium.org/2165873002/,
failing in builds since:

https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28New%20Intel%29/builds/1174

BUG=628863
TBR=zmo@chromium.org,kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2172253002
Cr-Commit-Position: refs/heads/master@{#407162}

Revert of BubbleFrameView: add top padding even when close button is hidden (patchset #7 id:120001 of https://codereview.chromium.org/2148963002/ )

Reason for revert:
Caused https://crbug.com/630539

Original issue's description:
> BubbleFrameView: add top padding even when close button is hidden
>
> If there's no title or close button present, BubbleFrameView still needs some
> top padding to avoid the content being hard up against the top edge. Always pad
> as though the close button was visible, even if it's not, unless there's a
> title.
>
> BUG=622859
>
> Committed: https://crrev.com/f06ef4ac6ac3dd2f3a76486d2efde9ec35583ae6
> Cr-Commit-Position: refs/heads/master@{#406856}

TBR=msw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=622859

Review-Url: https://codereview.chromium.org/2177533002
Cr-Commit-Position: refs/heads/master@{#407161}

Revision b779ce61 broke the
generate_build_files step on the Dr. Memory build:

gyp: Key 'conditions' repeated at level 6 with key path
'targets.0.conditions.5.1' while reading
C:\b\build\slave\drm-cr\build\src\printing\printing.gyp

BUG=607668
TEST=none
TBR=skau@chromium.org

Review-Url: https://codereview.chromium.org/2173063002
Cr-Commit-Position: refs/heads/master@{#407160}

BUG=629867

Review-Url: https://codereview.chromium.org/2173493002
Cr-Commit-Position: refs/heads/master@{#407159}

This CL modifies the way in which account credentials (URL/username) are displayed on PasswordEntryEditor.java and adds buttons which will allow users to view/copy their credentials.

BUG= 628669

Review-Url: https://codereview.chromium.org/2156613002
Cr-Commit-Position: refs/heads/master@{#407158}

BUG=626827

Review-Url: https://codereview.chromium.org/2165413002
Cr-Commit-Position: refs/heads/master@{#407157}

This CL retains the maximum autofill profile use-count,
instead of summing the use-counts, when merging two
profiles.

The previous behaviour, summing, inflates the use-count
during profile deduplication, double counts on profile
usage, and falsely counts a fully-typed submission as a
reuse of any profile it matched. All of these skew the
frecency score of the resulting merged profile.

BUG=629978
R=mathp@chromium.org, sebsg@chromium.org

Review-Url: https://codereview.chromium.org/2164143002
Cr-Commit-Position: refs/heads/master@{#407156}

The interface has been broken for a long time.

BUG=

Review-Url: https://codereview.chromium.org/2165313002
Cr-Commit-Position: refs/heads/master@{#407155}

BrowsingDataRemover::RemoveImpl runs on the UI thread. It schedules several
operations on other threads and flips a boolean flag to "true" for each of
them. Each operation responds with a callback on the UI thread flipping its
flag back to "false" and call NotifyIfDone(), a method that checks if all
flags are already false, in which case it reports that the deletion was
completed.

In addition, NotifyIfDone() is also called at the end of
BrowsingDataRemover::RemoveImpl - this is in case that no tasks on other
threads were scheduled.

Consider the following simplified scenario with arbitrary task "X":

BrowsingDataRemover::RemoveImpl() {
  DCHECK_CURRENTLY_ON(BrowserThread::UI);
  waiting_for_task_x_ = true;
  ScheduleTaskX(&OnXDone);

  // ...

  NotifyIfDone();
}

BrowsingDataRemover::OnXDone() {
  DCHECK_CURRENTLY_ON(BrowserThread::UI);
  waiting_for_task_x_ = false;
  NotifyIfDone();
}

While this pattern should only be used if X is on a different thread,
consider what would happen if X was on the UI thread and yielded to the UI
thread. NotifyIfDone() in OnXDOne() would find all flags false and notify
about the deletion being complete. Immediately after, NotifyIfDone() in
RemoveImpl() would do the same. The observer would receive two deletion
notifications.

This is not hypothetical - clearing with remove_mask == REMOVE_COOKIES
will run OnClearedDomainReliabilityMonitor() before RemoveImpl() is finished.

This CL fixes that by considering the execution of RemoveImpl() as a task
of its own, having its own boolean flag to indicate that the body of
RemoveImpl() has finished.

This was discovered during the implementation of a task scheduler for
BrowsingDataRemover in a different CL and will be covered against regression
by the tests of that CL. It was not caught by our tests before because
BrowsingDataRemoverCompletionObserver that is commonly used in the unittests
always unregisters itself after the first callback and thus never spotted
the second callback.

BUG=630327

Review-Url: https://codereview.chromium.org/2173443002
Cr-Commit-Position: refs/heads/master@{#407154}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bf66428a..2cf82064

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2169293003
Cr-Commit-Position: refs/heads/master@{#407153}

Latest crash dumps suggest that callback is invoked
re-entrantly during QuicHttpStream::DoLoop(). This can be
problematic because the caller can delete the
QuicHttpStream when the callback is run. This CL changes
QuicHttpStream::OnClose() to not invoke callback when
already in DoLoop().

This CL also adds a unit test which will crash without the
change or the CHECKs.

BUG=629043

Review-Url: https://codereview.chromium.org/2163883004
Cr-Commit-Position: refs/heads/master@{#407152}

Currently ESCAPE key event is not handled correctly while playing
full screen video. Now exiting full screen video when receives
ESCAPE key event to match desktop behavior.

BUG=614185

Review-Url: https://codereview.chromium.org/2124003004
Cr-Commit-Position: refs/heads/master@{#407151}

This CL calls WillStartRequest on the current NavigationHandle when a
navigation is starting. This mimics the SimulateRedirect call, and enables
NavigationThrottles which override WillStartRequest to be unit testable
using the content unit test framework.

Note: like SimulateRedirect, there is no current support for the throttles
actually cancelling / deferring the navigation.

BUG=627501

Review-Url: https://codereview.chromium.org/2157153003
Cr-Commit-Position: refs/heads/master@{#407150}

Smoothly scroll effect also triggers TalkBack read previous screen after navigate to new screen.

BUG=602373, 628255

Review-Url: https://codereview.chromium.org/2166383002
Cr-Commit-Position: refs/heads/master@{#407149}

This test case is passing now.

BUG=none

Review-Url: https://codereview.chromium.org/2172983002
Cr-Commit-Position: refs/heads/master@{#407148}

Bump the priority of BACKGROUND threads to NORMAL during shutdown.
This will prevent TaskTracker::Shutdown() from waiting for work to
be done by threads that never get a time slice.

BUG=553459

Review-Url: https://codereview.chromium.org/2161213002
Cr-Commit-Position: refs/heads/master@{#407147}