GitLab

BUG=480721
TBR=amistry@chromium.org

Review URL: https://codereview.chromium.org/1108493002

Cr-Commit-Position: refs/heads/master@{#326711}

These conditions are coming from windows.update API.
- minimized with 'focused'.
- maximized, fullscreen with 'not-focused'
- Having bounds with minimized, maximized, fullscreen state.
- panel type with minimized, maximized, fullscreen state.

BUG=459841
TEST=browser_tests --gtest_filter=ExtensionWindowCreateTest.*

Review URL: https://codereview.chromium.org/1055933009

Cr-Commit-Position: refs/heads/master@{#326710}

GetKnownTimezoneOrNull() is supposed to find a matching timezone entry
to an input tz id in the CrOS tz list.  When looking for a match, the
canonical ids have to be taken into account.

Note: This CL started as a speculative fix to bug 466014, but
I couldn't verify that it fixes the bug on CrOS. It does fix the bug
when I tested 'Chrome with cros=1' on Linux (i.e. stub implementation.)
with tz changed on Linux.

BUG=466014
TEST=manual: see the bug

Review URL: https://codereview.chromium.org/1082323003

Cr-Commit-Position: refs/heads/master@{#326709}

Revert of mac: Weakly link against the CoreBluetooth framework. (patchset #2 id:80001 of https://codereview.chromium.org/1101513003/)

Reason for revert:
The GN file wasn't formatted correctly.

http://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20%28dbg%29/builds/8764/steps/compile/logs/stdio

Original issue's description:
> mac: Weakly link against the CoreBluetooth framework.
>
> In the OSX 10.10 SDK, CoreBluetooth became a top level framework. Previously,
> it was nested in IOBluetooth. In order for Chrome to run on OSes older than OSX
> 10.10, the top level CoreBluetooth framework must be weakly linked.
>
> BUG=463170
>
> Committed: https://crrev.com/9fde3e00865650009c7e85fcb7157719372b97a8
> Cr-Commit-Position: refs/heads/master@{#326705}

TBR=rsesek@chromium.org,keybuk@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=463170

Review URL: https://codereview.chromium.org/1065453003

Cr-Commit-Position: refs/heads/master@{#326708}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5e6fb43..bbf1039

TBR=rjwright@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/1094743004

Cr-Commit-Position: refs/heads/master@{#326707}

BUG=424419
TEST=components_unittests
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/663693002

Cr-Commit-Position: refs/heads/master@{#326706}

In the OSX 10.10 SDK, CoreBluetooth became a top level framework. Previously,
it was nested in IOBluetooth. In order for Chrome to run on OSes older than OSX
10.10, the top level CoreBluetooth framework must be weakly linked.

BUG=463170

Review URL: https://codereview.chromium.org/1101513003

Cr-Commit-Position: refs/heads/master@{#326705}

This picks up the changes for 'gn help all' and
the markdown docs, fixes a bug related to the
transitive propagation of public_deps across
shared objects, and includes a speculative fix
for the WriteFile() failures we're seeing on
Windows.

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/1082813004

Cr-Commit-Position: refs/heads/master@{#326704}

BUG=477457
R=rdevlin.cronin@chromium.org

Review URL: https://codereview.chromium.org/1100333006

Cr-Commit-Position: refs/heads/master@{#326703}

Move the cursor warp logic into separate class.

Also improve the test to use the logic closer to real one.

This is to implement different mouse warp logic for unified desktop mode (and also useful when ozone has its own logic in lower level)

BUG=365662
TEST=no functional change. All tests should pass.

Review URL: https://codereview.chromium.org/1100303002

Cr-Commit-Position: refs/heads/master@{#326702}

Adding Intent.FLAG_GRANT_READ_URI_PERMISSION only worked on specifit URIs
(EXTRA_STREAM, or MULTIPLE_STREAM).

So the URI should be put in ClipData to give read access to an Intent
target.

BUG=480047

Review URL: https://codereview.chromium.org/1101743003

Cr-Commit-Position: refs/heads/master@{#326701}

the omnibox dropdown.

In the case where the description space was so small that the entire description
was eliminated, the contents space was set to whatever the desired contents size
was, which might be larger than the available space.  Instead, clamp this
correctly to the available space, including space we'd previously reserved for
the separator.

Also, in some cases, the previous code would allocate more space to contents
and/or description than they actually wanted.  Because the caller simply used
the returned values to elide, this had no functional effect, but it was arguably
confusing, and could cause bugs if anyone else calls this function in the
future, so this was fixed.  Now both will be given space that's at most as large
as they request.

Another quirk of the old code was that if the available width was less than
kMinimumContentsWidth, the assigned contents width would exceed the available
width.  Again, the caller would ultimately clamp this, but like the above
behavior, this was confusing and seemed error-prone, so this was fixed as well.
This required some other minor adjustments to ensure that this wouldn't result
in returning a negative max width, even if the available width on entry to the
function was less than the separator width.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1082833006

Cr-Commit-Position: refs/heads/master@{#326700}

Update the help button of the system tray to no longer flip while in the Hebrew
locale.

The asset used is a question mark, which is flipped in most RTL locales. Hebrew
is the exception, which uses the same question mark as LTR locales.

TEST=Manual testing on device
BUG=475237

Review URL: https://codereview.chromium.org/1072423004

Cr-Commit-Position: refs/heads/master@{#326699}

Add benchmark and measurement for measuring quiescent power, and enable
it on Mac.
Moved the workaround for http://crbug.com/419786 so that we don't lose idle
wakeups numbers for the renderer process.

Review URL: https://codereview.chromium.org/1092393002

Cr-Commit-Position: refs/heads/master@{#326698}

This patch moves the specific logic for handling USB devices and
device permissions out of the DevicePermissionsPrompt class and into
a set of subclasses that are hidden in device_permissions_prompt.cc.

This should allow a parallel set of subclasses for handling HID devices
to be added without any more modifications to the base classes.

BUG=457899

Review URL: https://codereview.chromium.org/1098823003

Cr-Commit-Position: refs/heads/master@{#326697}

BUG=479274

Review URL: https://codereview.chromium.org/1079163004

Cr-Commit-Position: refs/heads/master@{#326696}

We attempt to match Windows behaviour for the value of VKEY on
a keystroke. Some XKB layouts generate characters for AltGr+key
combinations that are not present in the reference (Windows-based)
sources, which led to mismtaches in the mappings, and incorrect VKEY
values for those keys. To avoid this, we match on any AltGr+key result
in cases the reference has none.

The corresponding test is revised to use a valid dummy character
for those cases, rather than 'NoSymbol'.

BUG=480529

Review URL: https://codereview.chromium.org/1100393005

Cr-Commit-Position: refs/heads/master@{#326695}

Revert of Delete session cookies immediately after loading the cookie DB. (patchset #4 id:120001 of https://codereview.chromium.org/1097593002/)

Reason for revert:
This CL broke the Win7 Tests (dbg)(1) bot.

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/37364

Original issue's description:
> Delete session cookies immediately after loading the cookie DB.
>
> Previously, the session cookies were deleted after all cookies were loaded into
> memory. This allows for a race condition where new session cookies are inserted
> into the database while the cookies are being loaded into memory, which causes
> the new session cookies to also be deleted.
>
> BUG=
>
> Committed: https://crrev.com/ca924dcfb4f3c6b89e0c40898e42aec349b6b843
> Cr-Commit-Position: refs/heads/master@{#326672}

TBR=erikwright@chromium.org,erikchen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1077963006

Cr-Commit-Position: refs/heads/master@{#326694}

Summary of changes available at:
https://chromium.googlesource.com/external/libyuv/+log/32ad6e0..01db3d1

BUG=libyuv:426

Review URL: https://codereview.chromium.org/1104623002

Cr-Commit-Position: refs/heads/master@{#326693}

Notification title has 2-line limit, therefore sometimes long
messages are cut off. The 'body' field has much more space for
longer text.

BUG=454827
R=oshima@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/1094863006

Cr-Commit-Position: refs/heads/master@{#326692}

BUG=470984
TEST=

Review URL: https://codereview.chromium.org/1097663003

Cr-Commit-Position: refs/heads/master@{#326691}

Updates the script to handle recent changes:
  html_viewer has moved to components.
  kiosk_wm is run by default.
  services built locally, don't need origin mapping?
  avoid html_document.cc:150 Check failed: !is_headless_
  --args-for is deprecated (pass app args as shell args)

Also update mojo_media_application.cc arg init.

Tested that this works with:
  gn gen out/Debug --args='is_debug=true use_goma=true proprietary_codecs=true ffmpeg_branding="ChromeOS" enable_media_mojo_renderer=true'
  ninja -C out/Debug/ -j 1500 -l 10 mojo media/mojo/services components/html_viewer mojo/services/network
  media/mojo/scripts/run_mojo_media_renderer.py --build-dir out/Debug --verbose http://wxh.kir/ensemble/kqed.html

BUG=NONE
TEST=Script works (or closer to working...)
R=sky@chromium.org,xhwang@chromium.org

Review URL: https://codereview.chromium.org/1088993004

Cr-Commit-Position: refs/heads/master@{#326690}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/eb0e71e..5e6fb43

TBR=rjwright@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/1105763002

Cr-Commit-Position: refs/heads/master@{#326689}

This CL only hooks up the new WebUI for ChromeOS. The page itself is just placeholder for
now.

BUG=chromium:409158
TEST=manual

Review URL: https://codereview.chromium.org/1080163002

Cr-Commit-Position: refs/heads/master@{#326688}

BUG=455942

Review URL: https://codereview.chromium.org/1105743002

Cr-Commit-Position: refs/heads/master@{#326687}

Revert of Optimizes the operation of DeleteDatabase when no backing store exists. (patchset #5 id:120001 of https://codereview.chromium.org/1071553002/)

Reason for revert:
This appears to have made IndexedDBBrowserTest.DiskFullOnCommit flaky, starting at http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%20Browser%20%28DrMemory%20full%29%20%286%29/builds/380

[ RUN      ] IndexedDBBrowserTest.DiskFullOnCommit

[1028:1768:0423/085845:4229748:INFO:mock_browsertest_indexed_db_class_factory.cc(258)] FailOperation: class=2, method=2, instanceNum=5, callNum=1
[1028:1768:0423/085845:4229873:INFO:indexed_db_browsertest.cc(77)] Navigating to URL and blocking.
[3872:2724:0423/085859:4243383:ERROR:renderer_main.cc(200)] Running without renderer sandbox

[1028:1096:0423/085958:4302491:ERROR:indexed_db_backing_store.cc(4197)] IndexedDB Write Error: TRANSACTION_COMMIT_METHOD
[1028:1768:0423/090005:4309621:INFO:indexed_db_browsertest.cc(79)] Navigation done.
c:\b\build\slave\drm-cr\build\src\content\browser\indexed_db\indexed_db_browsertest.cc(88): error: Failed
Failed: Starting...<span>FAILED: unexpectedErrorCallback<br></span>
[  FAILED  ] IndexedDBBrowserTest.DiskFullOnCommit, where TypeParam =  and GetParam() =  (130664 ms)

Original issue's description:
> Optimizes the operation of DeleteDatabase when no backing store exists.
>
> When deleting the non existing database in a origin with no existing
> backing store, then in DeleteDatabse(), early exiting before OpenBackingStore,
> so that it wont results in multiple transaction as earlier.
>
> BUG=460236
>
> Committed: https://crrev.com/a4c618a142515773709688bfe3c5753e589afd43
> Cr-Commit-Position: refs/heads/master@{#326473}

TBR=cmumford@chromium.org,jsbell@chromium.org,payal.pandey@samsung.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=460236

Review URL: https://codereview.chromium.org/1106703003

Cr-Commit-Position: refs/heads/master@{#326686}

BUG=478929

Review URL: https://codereview.chromium.org/1096133003

Cr-Commit-Position: refs/heads/master@{#326685}

This test is timing out consistently on the Win7 Tests (dbg)(1) bot.

TBR=jennb@chromium.org
BUG=253417

Review URL: https://codereview.chromium.org/1061543005

Cr-Commit-Position: refs/heads/master@{#326684}

OS X sometimes returns an empty certificate chain on unrecoverable certificate
chain. This was leaving the verified certificate NULL and causing crashes.

BUG=472291

Review URL: https://codereview.chromium.org/1094983002

Cr-Commit-Position: refs/heads/master@{#326683}

BUG=

Committed: https://crrev.com/29b6f6fa8785ed80c2fcf043bb0619f3f8b80065
Cr-Commit-Position: refs/heads/master@{#326534}

Review URL: https://codereview.chromium.org/1098403002

Cr-Commit-Position: refs/heads/master@{#326682}

Previously we'd had this behavior just for main frames (via
AttachToFrameTree) but we should do it for child frames too.

Eliminate AttachToFrameTree altogether. Move tracking of the focused
frame to hinge on removal of a frame from the tree. Note that this
means that frame focus is retained on cross-process navigation,
which matches the behavior of an in-process navigation, and also
matches the behavior we had [on cross-process RVH nav] before
focus was tracked per-frame.

Add a test that exercises the interaction of focus and detach.

Bonus: Add a covariant getter for WebContentsImpl::GetFocusedFrame()

BUG=476628,444563,425248

Review URL: https://codereview.chromium.org/1104723002

Cr-Commit-Position: refs/heads/master@{#326681}

When hitting enter while over a text field/text area, value changed events fire. This results in ChromeVox echoing the entire text field/text area again.

Review URL: https://codereview.chromium.org/1101883002

Cr-Commit-Position: refs/heads/master@{#326680}

We expect the type to be ObserverType*, so let's use nullptr.

Review URL: https://codereview.chromium.org/1101103002

Cr-Commit-Position: refs/heads/master@{#326679}

BUG=446575, 465722
TEST=No behavior change

Review URL: https://codereview.chromium.org/1105753002

Cr-Commit-Position: refs/heads/master@{#326678}

TBR=eae@chromium.org
BUG=480650

Review URL: https://codereview.chromium.org/1100423002

Cr-Commit-Position: refs/heads/master@{#326677}

1) --wait-for-debugger alone makes all child processes wait for a debugger
2) --wait-for-debugger=app1,app2... make only these apps wait for a debugger
3) the app name is added to the command line to make it easier to attach debugger after the process starts
4) MessageBox is used on Windows like chrome

BUG=478251

Review URL: https://codereview.chromium.org/1107633002

Cr-Commit-Position: refs/heads/master@{#326676}

Revert of New UMA settings fragment using Android prefs. (patchset #6 id:160001 of https://codereview.chromium.org/1080723002/)

Reason for revert:
breaks clank downstream bots

Original issue's description:
> New UMA settings fragment using Android prefs.
>
> This CL is part of new UMA upload logic for 3g uploads. Previous three-option model is replaced with a new binary on/off-switch for users assigned to experimental group.
>
> Previous reverted CL (https://codereview.chromium.org/978623002/) used chromium preferences for the settings fragment, which caused problems. Crash reporting which also gets enabled/disabled by the same settings can not always support chromium preferences. Therefore this CL introduces new Android preferences for the new settings fragment.
>
> As the new logic with be enabled for users assigned to a particular experiment group, that info is also cached into Android pref so that the experiment group info can be accessible anytime.
>
> BUG=455847
>
> Committed: https://crrev.com/a44343327c0174fbbf4f1125f3eee25977be1652
> Cr-Commit-Position: refs/heads/master@{#326612}

TBR=asvitkine@chromium.org,dfalcantara@chromium.org,nyquist@chromium.org,noms@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=455847

Review URL: https://codereview.chromium.org/1101073003

Cr-Commit-Position: refs/heads/master@{#326675}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/3d9005c..aa31ee7

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=tomhudson@google.com

Review URL: https://codereview.chromium.org/1107623002

Cr-Commit-Position: refs/heads/master@{#326674}

BUG=

Review URL: https://codereview.chromium.org/1105633002

Cr-Commit-Position: refs/heads/master@{#326673}

Previously, the session cookies were deleted after all cookies were loaded into
memory. This allows for a race condition where new session cookies are inserted
into the database while the cookies are being loaded into memory, which causes
the new session cookies to also be deleted.

BUG=

Review URL: https://codereview.chromium.org/1097593002

Cr-Commit-Position: refs/heads/master@{#326672}