- 17 Jan, 2020 40 commits
-
-
Anastasia Helfinstein authored
Bug: 1023035 Change-Id: Ie227ad87af4bba0cdb6f864e609b8b4103a2d603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001412 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#732726}
-
Demetrios Papadopoulos authored
The Polymer 2 version is not used anymore, therefore no auto-generation is necessary and the v3 version can be directly checked in. Fixed: 1042545 Change-Id: Ia0267cef30dcf1eb08677d369fd3f8ded21c679f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006421 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#732725}
-
chrome://sandboxAlex Gough authored
This should be useful as more services with finer grained sandboxing are introduced. Bug: 997273 Change-Id: I2996c8b32fa9f46bd1a32aa7b80d99d094f020a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006129Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#732724}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d968972519ba..41f6150edb16 git log d968972519ba..41f6150edb16 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 sugoi@google.com Stubs for new required extensions 2020-01-16 sugoi@google.com Add blendable checks to GL_EXT_color_buffer_float 2020-01-16 rafael.cintron@microsoft.com Fix FL10_0 multisampling Created with: gclient setdep -r src/third_party/angle@41f6150edb16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1036367 Tbr: jonahr@google.com Change-Id: I6b0e6ec62522a3bf607cc0c85e0b00a0beb42ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006621Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732723}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c86e356c31a9..7891b46fd46e git log c86e356c31a9..7891b46fd46e --date=short --first-parent --format='%ad %ae %s' 2020-01-16 dhoss@chromium.org Add nullptr checks prior to accesses of CPDF_Document::GetDocExtension() 2020-01-16 tsepez@chromium.org Remove unused one-arg form of IsAppearanceValid(). 2020-01-16 tsepez@chromium.org Add test for growing gap in CFDE_TextEditEngine::AdjustGap(). 2020-01-16 tsepez@chromium.org Avoid underflow before calling CFDE_TextEditEngine::AdjustGap(). Created with: gclient setdep -r src/third_party/pdfium@7891b46fd46e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029437 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I9219e3f50942bdc59bd2c03d723e85040948ef14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006611Reviewed-by:
-
Simon Que authored
Bug: 1040754 Change-Id: I8dd70f96b3299797721d2f41f1516028d650484b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004348Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#732721}
-
Azeem Arshad authored
This CL adds a comment in settings_ui.cc to clarify usage of MultideivceHandler. Bug: 845706 Change-Id: Ib2d1b34dac11b52ba8374f146400f3a9c5ac8001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006618 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#732720}
-
Akihiro Ota authored
This change modifies the behavior of the darken screen feature. Previously, the user could use [Search + Shift + f7] to darken the screen and [Search + f7] to un-darken the screen. Now this feature behaves like a toggle, so users can press [Search + f7] to toggle between the two states. Bug: 949198 Change-Id: I5003de4983b6d8b730b2e5c823fd48981e05d45a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951965Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=mrefaat@chromium.org Bug: 1041419 Change-Id: If6f5add12f826fc758e76b6540736e540b871b2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997910 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#732718}
-
Hiroki Sato authored
Bug: None Test: browser_tests --gtest_filter="AccessibilityFeaturesApiTest*" Change-Id: I075f1c3c563ee311e733bf7dea59cbcf1c41cf47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994551 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#732717}
-
Caleb Rouleau authored
With the work to move gtests onto the shard maps, the overhead should be reduced and we can change this from 5.5 hours to 6 hours. This will reduce the chance of timeouts of these shards. This is an adjustment from the earlier change https://chromium-review.googlesource.com/c/chromium/src/+/1977965 Bug: 1041692, 1041696 Change-Id: I88661366c3f2ed058ed3d3b247c309d0f3e48957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006612 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#732716}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: Icc68359187a88ce497e8c6df546031e11bffea0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006443Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#732715}
-
Luciano Pacheco authored
Follow up of CL:1991038: Renames parameters from windowId to appId and make their documentation consistent. Bug: 778674 Change-Id: Idc7790795f547ad6a2ff054341c4cbee28561dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997005 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#732714}
-
Li Lin authored
The feature is guarded by a feature flag that is currently disabled by default. This CL implements a temporarily UI for getting early feedback on product and data quality while we are figuring out the final UI. More detail at: go/quick-answers-cros and go/quick-answers Bug: 1020004 Test: Unit tests Change-Id: I17dac669c230f5fbd2052cd5683344fa30c41b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961210Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#732713}
-
Bettina authored
There was an extra "and" in between the domains. Bug: 1037953 Change-Id: I6c8c81f7a1bdd27f5891fe3aa86619038efd5543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982702 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#732712}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/251c76530213..91096f77a581 git log 251c76530213..91096f77a581 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 dberris@chromium.org Remove cron.yaml from automatic deployment Created with: gclient setdep -r src/third_party/catapult@91096f77a581 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1040775 Tbr: rmhasan@google.com Change-Id: Ib1bec1381f5618a264bfe1a79e0341fd3ef0b561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006608Reviewed-by:
-
Ben Kelly authored
This CL converts an unsafe base::Unretained() to target the MediaStreamTrackMetricsHost object directly which is deleted on the same thread as the callback. This comes at the cost of pre-allocating the object instead of lazily creating it when the first receiver is bound. This cost does not seem too great since the object consists of an empty std::map and mojo::ReceiverSet. In addition, the CL attempts to document why the remaining base::Unretained() usage is safe. Bug: 1040396 Change-Id: I094091c4672c412086059c56804efb3d743a2c11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005291 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#732710}
-
chrome://flagsDavid Staessens authored
This CL adds a flag to chrome://flags to manually enable/disable the ChromeosVideoDecoder feature. This Feature enables the new media::VideoDecoder-based video decoders on ChromeOS. TEST=enabled/disabled flag in Chrome on nocture, and verified logs BUG=None Change-Id: I5df33207f7f2081260a66c8406fc0dceed7a0cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997431 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#732709}
-
Kazuki Takise authored
CTS requires a PIP window to stay at the initial position that Android calculates. However, Chrome sometimes adjusts the bounds unexpectedly when always on top is set because setting always on top triggers UpdatePipBounds, and depending on the density, the initial bounds is adjusted by one pixel. With this CL, PIP bounds update is defered while always on top is set. Other possible ways to fix this issue are: - Don't update PIP bounds for WM_EVENT_ADDED_TO_WORKSPACE. - Ignore bounds change for PIP if it's one (or a few) pixel difference. Note, changing bounds calculation logic on either Android or Chrome side so there's no gap between the bounds calculated by them doesn't work because because DP -> pixels is not a surjection and Chrome may be unable to place the PIP window in the place Android wants (and vice versa). BUG=b:147396441 BUG=b:145881485 TEST=atest android.server.am.ActivityManagerPinnedStackTests TEST=#testEnterPictureInPictureSavePosition Change-Id: I60bfef4620459c0d3f604d3c1641864fc589c1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969090Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Cr-Commit-Position: refs/heads/master@{#732708}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/5c6a3c247590..2cb1db08e5f1 git log 5c6a3c247590..2cb1db08e5f1 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 bclayton@google.com SpirvShaderDebugger: Implement OpenCL.Debug.100 Created with: gclient setdep -r src/third_party/swiftshader@2cb1db08e5f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic212aaf520c20bc6d5158abea208f078e76d87cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006476Reviewed-by:
-
Peter Boström authored
This filters extensions when they are added/removed from the ToolbarActionsModel. This happens not only on uninstall but also during reload which is why we need to re-filter on adding extensions. This leaves a TODO to actually remove pinned-extension IDs when uninstalling an extension to keep traces of previously-installed extensions. For now it'll address a crash where entries in pinned_action_ids() could refer to extensions that were no longer installed, resulting in a null-pointer dereference when trying to update their position in the toolbar. Bug: chromium:1040856 Change-Id: I3928e931c12d6571c8eb5ad9bd255f0602cfa3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005373 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#732706}
-
Harald Alvestrand authored
I noticed that both owners of this directory were no longer working on webrtc, so I thought we should add some more owners. Bug: none Change-Id: I4975757aee6d7b51980e360b8420366805387002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983178 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#732705}
-
Ahmed Fakhry authored
When Alt-tab ends, leading to a desk switch, we should query the traget active desk, not the currently active desk, since the desk switch animation will be in progress. BUG=1042486 TEST=Added new tests Change-Id: I17481169bf9cd1b9a66bec702a9fafafeac6cc85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004059 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#732704}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I20fc48c994e76947027296a5469b3bac7f71bcae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005863Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732703}
-
Thanh Nguyen authored
This is a reland of e6beeda6 Original change's description: > [smart-charging] Collect last charge features > > Adds code to collect last charge related features. > > Bug: 1028853 > Change-Id: I2b152139db0777acbd40534128ed8c92004799b5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994035 > Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> > Reviewed-by: Jia Meng <jiameng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#731862} Bug: 1028853,1042262 Change-Id: I2c868897d2bff653d34c5b9afa55602934543151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006428 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#732702}
-
David Staessens authored
When we dequeue a buffer on the V4L2 device queue, we will immediately schedule another poll on the device when there are more buffers left to dequeue. It is possible however that we're notified of an event while there are no buffers ready to dequeue. Trying to dequeue a buffer at this time would cause polling to not be resumed, and we won't be notified when future buffers are ready to be dequeued. TEST=./video_encode_accelerator_unittest on hana with CL:1994545 BUG=b:147786740 Change-Id: Ieb2becd246ecbdb632ed930471cbc3fbfcf15e20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004354 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
-
Prabir Pradhan authored
Exo previously dispatched all touch events to one focused surface: the surface where the first touch point landed. For ARC++, this does not work for supporting multiple displays because the display for the touch is determined from the surface of the touch event. Therefore each touch down event needs to be sent to the correct surface that it was directed to. This CL adds two unordered_maps to track the touch pointers and their target surfaces: one mapping the touch pointer id to its surface, and mapping the surface to the number of pointers on the surface. The latter is needed to know when to stop tracking the surface's lifecycle. Bug: b/145027838 Change-Id: I4121dac9c39bd9fb569df94330107ed382fe7234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931584 Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org> Reviewed-by:
-
zhaoyangli authored
Changed from matching UIButton with a11y label to using grey_buttonTitle API. The new API matches UIButton with titleLabel underneath. Bug: 1036578 Change-Id: I4db291d8279aba74d6eca3a53a16a8a70784d6f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006260Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#732699}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cf0fcdbfc9a0..649f757cc08b git log cf0fcdbfc9a0..649f757cc08b --date=short --first-parent --format='%ad %ae %s' 2020-01-16 ilkos@google.com Merge "Remove symbols that are definitely not obfuscated" Created with: gclient setdep -r src/third_party/perfetto@649f757cc08b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Idd6f625ab71b7b186970f43df6403bce66ac140a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006484Reviewed-by:
-
Shakti Sahu authored
This CL contains : 1 - Fixed InflateException on Kitkat when it is unable to handle vector drawables. 2 - Fixed an issue with tablets where clicking on 'See more' results in crash. Bug: 1042459, 1042424 Change-Id: I6981d794e1a44cfbc19da1f990113d54e67dc60d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006075Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#732697}
-
Francois Marier authored
Bug: 1042140 Change-Id: I6bf3b28d21c4f6918fe3dc7af52fb163fa22ec50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001856 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Francois Marier <francois@brave.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#732696}
-
James Cook authored
We now have a final mock at go/cros-sync-mock, so update the strings to match. These strings are used by the consent auditor system, so add back the consent-description tags. This requires a workaround for the "Sync your Chromebook" string, since the device type is set at runtime. Bug: 1023854 Test: browser_tests Change-Id: Idddb83ff66a14922a57303f2064cfb4440791977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006135Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#732695}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=marq@chromium.org Bug: 1041419 Change-Id: I496244536e4d0b7bc5261518276512b5adb14110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994451 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732694}
-
Kent Tamura authored
This reverts commit ae012e64. Reason for revert: The culprit CL was reverted. Original change's description: > [Sheriff] Disable flaky ChromeVoxBackgroundTest.SelectSingleBasic > > TBR=akihiroota > > Bug: 1042673 > Change-Id: Iccf2064ee5b817bc9e7f12c026cd8569e39d22b7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002816 > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732396} TBR=jdoerrie@chromium.org,akihiroota@chromium.org Change-Id: I1c098ec50bd7feb5d3d0c0780bc01a094b087570 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1042673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006831Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#732693}
-
Dale Curtis authored
We correctly handled context loss when using GPU compositing, but if we transition to software compositing from GPU compositing, we were not correctly starting the frame sink. It's possible we also hit this case outside of context loss if the OnReceivedContextProvider() is delayed until after EnableSubmission(); I was able to reproduce this by adding a delay to when the context came back. So likely this fixes some broken video playback for some users on the software compositor! R=liberato Bug: 1027518 Test: Updated unittest. Change-Id: I738a1a36f4d850248730cd61b9ae4adcb5c1cd06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006193 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732692}
-
Martin Kreichgauer authored
This was requested by srahim. TBR=dpapad@chromium.org Change-Id: I45d280fd644d5fcd87bbdd5a1b13847cdfca4c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006424Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#732691}
-
Kyle Horimoto authored
Fixed: 993658 Change-Id: Ia5bc38bccab5cb83d74d727730b9a0dee8d87f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006071 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Peter Collingbourne authored
This is a reland of 27453d76 Split out the is_a_target_toolchain change to another change. Original change's description: > Add a flag for building HWASAN splits. > > The new build_hwasan_splits flag causes HWASAN splits to be created for > the Monochrome6432 and TrichromeChrome6432 bundles, as well as any of its > DFMs that contain native code. The intent is that this flag will eventually > default to true in official builds. > > The library is deliberately installed in TrichromeChrome6432 rather than > TrichromeLibrary6432 (where the regular native library lives) because the > Android platform does not support splits for the library containing the > WebView implementation. This means that only Chrome will use the HWASANified > native library, and WebView will use the regular native library. > > Bug: 916828 > Change-Id: Ie92bb36e83df245ab431b0123a44b0f0a3182100 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769731 > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729945} Bug: 916828 Change-Id: I2c64720b72572a1c718cbd44d79d3fb2a44afcac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994671Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#732689}
-
rbpotter authored
https://chromium-review.googlesource.com/c/chromium/src/+/1984717 fixed an issue with the iron-list sometimes setting an infinite displayed item count by setting the height of iron-list using JS so that it was always set to something nonzero before the list items were updated. Unfortunately, this causes the list to never increase in size if the dialog is resized larger after it has been opened, leaving an odd empty space between the destinations list and the buttons. Fix by adding a listener for the resize event that updates the height of the list. Change-Id: I7e010293831e5e1459cf1f0f6ba429dd52825b94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006110 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Daniel Nicoara authored
The underlying EXO surface should only be resized when the main RenderFrameHost changes. Embedded RHF (eg: iframes) should not cause the EXO surface to resize. Bug: b/147835637 Test: On device Change-Id: I24cab3f2cb99d0b2a3693adc815d445522c1cec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006420Reviewed-by:
Albert Chaulk <achaulk@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#732687}
-
