- 17 Jul, 2019 40 commits
-
-
Wei-Cheng Xiao authored
Histograms: Cryptohome.ChecksumStatus Cryptohome.TimeToMountGuestAsync Bug: 972785 Change-Id: Ic3d800cdf30b7fc95e17d329b8fd006917a752ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704757 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#678288}
-
Yoshifumi Inoue authored
On <div><b>x y<b></div>, we do following steps: 1. "x y".splitText(1) -> " " "x y" 2. " ".splitText(0) -> "" " " "x y" Before this patch, we have following layout tree: LayoutInline {<pseudo:first-letter>} at (0,0) size 8x19 LayoutTextFragment (anonymous) at (0,0) size 8x19 text run at (0,0) width 8: "x" LayoutText {#text} at (8,0) size 4x19 text run at (8,0) width 4: " " <======= This is for " " before "x y" LayoutTextFragment {#text} at (12,0) size 8x19 text run at (12,0) width 8: "y" This is invalid because " " should be collapsed and placed before <pseudo:: first-letter>. After this patch, |Element::UpdateFirstLetterPseudoElement()| detects this case then rebuild first-letter part of layout tree. Bug: 984389 Change-Id: I7eaa613045da44e09caa80435a04ad9615f4c40f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706030 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#678287}
-
Javier Ernesto Flores Robles authored
Updates the tab strips backgrounds with the new vertical ones. Deletes unused ones @1x. Updates constants specific to each assets: tab overlap and cap inset. Bug: 976817 Change-Id: Ida3b95548ac33c0740c2375eb2153f5bafc569e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706436Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#678286}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/134aeeec27e1..f43cc6905fc2 git log 134aeeec27e1..f43cc6905fc2 --date=short --no-merges --format='%ad %ae %s' 2019-07-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 33130413..b5dcfdfc (678125:678230) Created with: gclient setdep -r src/third_party/webrtc@f43cc6905fc2 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I00e8733888880aeecfcccd57ed5bf48eacb9fab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706610Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678285}
-
Alex Ilin authored
The following tests are being disabled: - VrBrowserCompositorViewHolderTest#testResizeWithCompositorViewHolderDetached - VrBrowserTransitionTest#test2dtoVrShellNfcUnsupported - VrBrowserTransitionTest#test2dtoVrShellto2dUnsupported - WebXrVrDeviceTest#testGvrlessMagicWindowCapabilities__ChromeTabbedActivity - WebXrVrDeviceTest#testGvrlessMagicWindowCapabilities__CustomTabActivity - WebXrVrDeviceTest#testGvrlessMagicWindowCapabilities__WebappActivity TBR: bsheedy@chromium.org Bug: 984943 Change-Id: If391b8cd7f66d7f3ca81e2081f21e0e2096c724d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706437Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#678284}
-
henrika authored
These are monitored as part of experiments from time to time. Bug: 984192 Change-Id: Ib7fba49f58906d5b9c18b5d4bccef8fd5174cadd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706513Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#678283}
-
Ben Kelly authored
Bug: 984125 Change-Id: I0c3c88a410a3697040dd1b508ee3b78fb75ec08c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702523 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#678282}
-
Lan Wei authored
In order to run the web-platform-tests automatically, we will use testdriver Action API in all the wpt to simulate inputs. Here we are changing some touch input tests with touch action in pointerevents/extension. Bug: 606367 Change-Id: Icd5b11236bf3ec575cb93b7cb7403cea1f983034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704690Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#678281}
-
Michael Lippautz authored
Otherwise, they are not considered on benchmarks. Bug: 948807 Change-Id: I9b4b6b4d6cc1ed1e6dd65f804e1bfe4d06b0ba4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706505 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#678280}
-
Adam Raine authored
Originally we got the device scale factor in PaintWorklet::Paint, but now we get the value is CSSPaintValue::GetImage so that future patches can use it in the off thread case as well as the main thread case. Bug: 980594 Change-Id: Idff87f901de7a821d37d1631ad33babab795fd4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702146Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Adam Raine <asraine@google.com> Cr-Commit-Position: refs/heads/master@{#678279}
-
Tim van der Lippe authored
This CL refactors the mojo callback for push events to provide a PushSubscription instead of the individual fields. This refactoring is then used to define a new DispatchPushSubscriptionChangeEvent method that takes the old and new subscription to fire the event. Bug: 646721 Change-Id: If72d2e587013fc82d8e724ec8033ab7e5527640b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702343Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@google.com> Cr-Commit-Position: refs/heads/master@{#678278}
-
Andrew Grieve authored
These started getting discarded when we switched to r8. Two of these were previously fixed by adding @UsedByReflection, but it seems safer to just keep all fragment constructors and does not seem to keep anything unused. Bug: 983904 Change-Id: I60bbc5a32dc49732aebd8048d674375cbc133f7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703595 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#678277}
-
Maksim Ivanov authored
Extend the OobeTest.NewUser test to verify the parameters passed to the MountEx call to cryptohomed, including the verification that the key label is "gaia". To simulate the flow that is close to the real flow, the FakeCryptohomeClient class is slightly enhanced to support replying to MountEx with CRYPTOHOME_ERROR_ACCOUNT_NOT_FOUND when no "create" proto field is provided. This allows to achieve the simulation of the following flow: (1) Chrome calls MountEx for the new user without specifying |create|; (2) cryptohomed checks that this user doesn't exist, and replies with the CRYPTOHOME_ERROR_ACCOUNT_NOT_FOUND error; (3) Chrome sees this errors and repeats the MountEx request with specifying |create|; (4) cryptohomed creates the new mount and succeeds. Bug: 983103 Test: browser_tests --gtest_filter=OobeTest.NewUser Change-Id: If27bcb05187219e046025f469ffe8bfe5c214562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690880 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#678276}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Please review and LGTM before July 16th or the CL will be submitted as-is. TBR=sky@chromium.org NOTRY=true Bug: 977050 Change-Id: I931d31a5f716e469e52e85fdaa0ff9781febba00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700842Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#678275}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: I12a0d472ab0bb37e77981f5059ad23ebb512e34f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703628Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#678274}
-
Antonio Gomes authored
There are some trailing includes, and also some forward declarations that can be removed. Drive by CL. BUG=704136 R=guidou@chromium.org Change-Id: I2cf0d2e9fcc0e273d759ba870718f87a5359e405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704719 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#678273}
-
Mike West authored
Spec change: https://github.com/whatwg/fetch/pull/916 Bug: 979946 Change-Id: Ic1cd8691c9b06371b94de29a5648fb6c8d7bebed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702311 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#678272}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: Ib8e79d7ab0748536e5a75a13153bcbc29039dabf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702375Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#678271}
-
Sergey Poromov authored
DeviceLocalAccounts are supplied by |username| that is not a user email and can't be converted into AccountId. Because of that ValidateUser() can't be used and ValidateUsername() should be returned back that won't convert into AccountId. The same applies for component policy validations as they can belong to DeviceLocalAccount and also not have real username. This is an adapted partial "revert" of https://crrev.com/c/980873 and https://crrev.com/c/1003193. Before that ValidateUsername() existed and was used for all accounts. Bug: 983523 Change-Id: I11fab29bebd3770d6983206574595c2fab577cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698537 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#678270}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: Ifef1b1bb0ad29da61559db4e92a57cf982afbcd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703227Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#678269}
-
Dave Tapuska authored
It is obvious that even though the renderer has requested main frames the browser may not deliver it until a much later time. So we will definitely keep the raf fallback timer code. BUG=975271 Change-Id: I868bc32a7e95c59585dfa72fe3c56959979a17f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703092Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#678268}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/63fdd0191be0..e574f1e409aa git log 63fdd0191be0..e574f1e409aa --date=short --no-merges --format='%ad %ae %s' 2019-07-17 halcanary@google.com [reland] SkMetaData: move from src/ to tools/ Created with: gclient setdep -r src/third_party/skia@e574f1e409aa The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=nifong@google.com Change-Id: Id4ef5dc90d78903ac3724fd12e36ceaed8b38fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706608Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678267}
-
Robbie Gibson authored
This does not change the color on the placeholder background + icon for when a suggestion has no image because that will be removed before dark mode is finished. Bug: 976641 Change-Id: I0bf0e26e7ce087917c38017d15a85c0a2ecbf6b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706431 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#678266}
-
Yutaka Hirano authored
Discussion: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/GF1Wg0JbEhw Bug: 983200 Change-Id: I27e02f2b195a93a7f2b0630af632ec0122581da9 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697481Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#678265}
-
Greg Thompson authored
external/wpt/referrer-policy/unsafe-url/http-rp/cross-origin/http-http/img-tag/no-redirect/generic.http.html and friends time out. BUG=982149 TBR=jochen@chromium.org Change-Id: I80773a464d18e243ece2f0677177ac32a5d13b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706501Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#678264}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2faec47d8d6a..45086ca6db84 Created with: gclient setdep -r src-internal@45086ca6db84 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=pdr@google.com,grt@google.com Change-Id: I8585d0f5ae07426f3ff6a76089cf5ea26b47974f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706389Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678263}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dcdb80df..aec429d1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I28e9b469cd9635866c3a9bb8431605128a0181c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706448Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678262}
-
Richard Knoll authored
This adds an icon in the omnibox via PageActionIconView. This is the ancher point of the Click to Call bubble dialog. Bug: 972059 Change-Id: I69aeb6bfcfd47082ad1a3460d58c2dd107746353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695551Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#678261}
-
Yi Gu authored
In the constructor of AggregatedHitTestRegion there is a DCHECK to verify that async_hit_test_reasons is set if and only if the kHitTestAsk flag is set [1]. This assertion stands for most cases but HitTestManagerFuzzer where we manually set the flag without setting async_hit_test_reasons. It was missed when introducing async_hit_test_reasons in crrev.com/c/1318078. [1] https://cs.chromium.org/chromium/src/components/viz/common/hit_test/aggregated_hit_test_region.h?q=AggregatedHitTestRegion&dr=CSs&l=48 Bug: 910872 Change-Id: I1d9e79e2583a0a180c8905ec4cf80d48bb1072f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705052Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#678260}
-
Javier Ernesto Flores Robles authored
Updates the close button for the tab grid, this is also used in the tab strip on iPads. Deletes the unused resolution @1x. Bug: 976817 Change-Id: I4144df5b4bf00bba65aff5919ed29e70f1e2f6eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706688Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#678259}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a7fc7a353fbd..c182e466c1b0 git log a7fc7a353fbd..c182e466c1b0 --date=short --no-merges --format='%ad %ae %s' 2019-07-17 treehugger-gerrit@google.com Merge "Remove stale comment." Created with: gclient setdep -r src/third_party/perfetto@c182e466c1b0 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I23b0e47f5fd17876606f895fa7be5f1fef54eab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706528Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678258}
-
Emily Stark authored
This CL flips the HTTP auth committed interstitials feature flag to enabled by default, and adapts affected tests. The affected tests are password manager tests, and they mostly involve changing the tests to not rely on the navigation oddities of traditional interstitials. With committed interstitials, the navigation completes before the auth prompt shows, whereas with traditional interstitials, the tests didn't wait for the navigation to complete because it only completed after the auth prompt was dismissed. I've also fixed one bug revealed by these password manager tests, related to how the password manager (HttpAuthManagerImpl, in particular) decides when a password form is gone. Previously, HttpAuthManagerImpl assumed that a password form was gone when a navigation completed, but this is no longer the case because some error pages (including committed interstitials) show up as double-commits from the browser process's perspective. See comment inline in http_auth_manager_impl.cc. To fix this, we have the LoginHandler explicitly tell HttpAuthManagerImpl when the password form has been dismissed. Bug: 963307 Change-Id: I812bed808e35947fe89714d205896a24a2dcf8f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688022Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#678257}
-
Hans Wennborg authored
To reduce the risk of forgetting to run one of them. Bug: none Change-Id: I5ecae435571a1cd7e0993f8857ae1041fbb9b309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705200 Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#678256}
-
Antonio Gomes authored
This CL moves webmediaplayer_ms.cc|h|unittest as well as its dependency webmediaplayer_ms_compisitor.cc|h to Blink. The header of the former got moved to public/web/modules/mediastream, while the rest now reside in renderer/modules/mediastream. This CL wraps phase 4.4 on the design doc [1]. [1] https://docs.google.com/document/d/1rHJGi1U72qZsOGIctIf7GKRaY8d7BgtVW8MaMYumzYY/ Given the non-trivial size of this particular CL, a set of TODOs were left (properly flagged in the code), so one can follow up: - There is one instance of base::BindOnce that still needs to be replaced by WTF::Bind. - There is a use of std::map that needs to be replaced by WTF::HashMap. BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I36b0347dde02c368925a2a7355acc9a94aebe0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698170 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#678255}
-
Greg Thompson authored
BUG=984926 TBR=wangxianzhu@chromium.org Change-Id: I11edca703d8581bca0cfc9f7ffba6430aedbf2be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706508Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#678254}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ea3dddf1d088..134aeeec27e1 git log ea3dddf1d088..134aeeec27e1 --date=short --no-merges --format='%ad %ae %s' 2019-07-17 oprypin@webrtc.org Allow using base jni targets on Linux 2019-07-17 jonasolsson@webrtc.org Reland "Remove the injectable bitrate allocation strategy API." Created with: gclient setdep -r src/third_party/webrtc@134aeeec27e1 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id4a0cd4d5f1065e745942fabc9a59ae185e7e3fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706388Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678253}
-
Gustavo Avena authored
Introduce KidsChromeManagementClient's interface, implementation and factory class. Since KidsChromeManagementClient is derived from KeyedService, its lifetime will be associated with the user's `Profile`. Detailed information about KidsChromeManagementClient and its rollout plan can be found on the issue's bug. Bug: 978130 Change-Id: I2e61f4f17c4f7f0dada853f84a9c6df9cb2fecd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675250 Commit-Queue: Gustavo Avena <gustavoavena@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Henrique Grandinetti <hgrandinetti@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#678252}
-
François Beaufort authored
Following https://dawn-review.googlesource.com/c/dawn/+/8863, we can now use the new constant DAWN_WHOLE_SIZE to indicate that the whole size of the buffer should be used in a buffer binding. Bug: 877147 Change-Id: I617792a23cbdc03a2912a7231bf7d2cfea756eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705789Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#678251}
-
Alex Chau authored
- Follow-up on https://crrev.com/c/1702313 - Even if FCM should not be invoked, we should still update device info in preference in case device capabilities has changed (e.g. feature flag enabled) Bug: 984002 Change-Id: I80923c5a681686838d994b1d0ae8e7ecc64e366f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705898Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#678250}
-
Nazerke authored
ios/chrome/app/. Bug: 973040. Change-Id: I80189b5c0e844aa9559713163666794412f69a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706510Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#678249}
-