- 24 Jul, 2019 40 commits
-
-
dpapad authored
Specifically: - Replace var with let/const (using lebab) - Fix missing/extra semicolon violations - Fix missing curly braces violations - Fix double quotes violations - Fix JS naming violations - clang-format - Add PRESUBMIT to catch these automatically moving forward. Bug: 986001,792774 Change-Id: I1d180fd3557243e08b0009c4fdc122ffa742b505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716094 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#680372}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/532f86826d5c..93c16af35dfb Created with: gclient setdep -r src-internal@93c16af35dfb The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=nhiroki@google.com,pmonette@google.com,sky@google.com,kolos@google.com Bug: chromium:None Change-Id: Ib56716af9669443d219d172ab8c330df20b757e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716197Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680371}
-
Jenny Blessing authored
Also stores the domains of the deleted cookies for later use in removing additional storage for these domains. Bug: 987177 Change-Id: I600be2dcdbe4fdacd52cf6cdba65de049f9d4bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699668 Commit-Queue: Jenny Blessing <jblessing@google.com> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#680370}
-
Makoto Shimazu authored
Previously ServiceWorkerNewScriptLoader returns kErrorExists when the main worker script was just truncated because it calls CommitCompleted() when the Mojo data pipe is closed. However, it's a problem because it doesn't tell the cache writer about the end of the body so that the cache writer isn't aware of the truncation. This CL is to trigger MaybeWriteData() at connection close for the cache writer to give a chance to run script comparison at the end of the body. Bug: 986688 Change-Id: I8a816ab1ab1a2e236c1a21c1f0950437cd1e50ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714584Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#680369}
-
Marc Treib authored
Previously, https://crrev.com/c/1681768 added migration logic from the old "SyncSuppressed" pref to a new "SyncRequested" pref (which better matches what it means, and has the correct default value). However, the migration code was only triggered on non-iOS platforms, leaving iOS Sync users in a bad state (new pref is used, but has no value). The fix is simply to trigger the migration logic also in iOS's version of browser_prefs. This also bring users back into a good state. Bug: 906034 Change-Id: Ib52ea658bf616ca47e947980d2ddc1fb50f02b5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715285Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#680368}
-
Pâris MEULEMAN authored
This merges signin_manager_android_wrapper.* into signin_manager_android.* and updates the factory accordingly. This is in the scope of a change of strategy regarding the identityManager implementation on Android, using a layering strategy similar to what was done on iOS. Due to this, the wrapper is no longer required. Change-Id: Ic4ecd68b07c07c77fb1d8a2756dd30103eeb4434 Bug: 985256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703410Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#680367}
-
Findit authored
This reverts commit 68335421. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 680135 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNjgzMzU0MjEzMGQyODg4YzMxNDQ2ZjI0MGQxNjkwOGY0NWFiNjhjYQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/13542 Sample Failed Step: browser_tests Sample Flaky Test: PromiseResolverModuleTest.All Original change's description: > Web UI Polymer 3: Port tests for shared JS Modules > > Port tests for the shared JS resources migrated to modules in > https://crrev.com/c/1682889. > > Note: Tests only run if optimize_webui is false, since these > resources only exist in this case. > > Bug: 965770 > Change-Id: Ia45584f59617165b3d230d551351ea51f3385add > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703424 > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680135} Change-Id: I90be6d4a72a24e15a0bbf7f7004aed32153b65a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 965770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716636 Cr-Commit-Position: refs/heads/master@{#680366}
-
Richard Knoll authored
To reach devices in doze mode, we need to send sharing messages with high urgency. Bug: 966037 Change-Id: I5521a2bb97727b9b1077e82e4ec3e6167c5e789c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710318 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#680365}
-
Ricky Liang authored
We only need to map and unmap the JPEG buffers when the video capture stack uses GpuMemoryBuffer-based buffers from the buffer pool. BUG=b:138274061 TEST=Manually on device Change-Id: I64a2bf8a7fc26bab684a28e8a5ddd971a393cbab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716449Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#680364}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/67440068b934..0cf661b2a81d git log 67440068b934..0cf661b2a81d --date=short --no-merges --format='%ad %ae %s' 2019-07-24 primiano@google.com Merge "Client API: Expose Flush() method" 2019-07-24 treehugger-gerrit@google.com Merge "client api: Support data sources across translation units" 2019-07-24 treehugger-gerrit@google.com Merge "client api: Select a tracing backing automatically" Created with: gclient setdep -r src/third_party/perfetto@0cf661b2a81d The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I1131acc82f1a3c6bc3ee6dbf57aabe89887a7f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716593Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680363}
-
Clemens Arbesser authored
Before this patch, we would wait for AA to be shown before invoking the espresso check. This would sometimes fail on slower devices, because asynchronous events on the native side might not have finished processing at that point. This CL instead continuously polls the UI thread until the specified condition is matched or the default timeout is reached. Bug: b/986026 Change-Id: I311f94dd8fd4383dfcce35656299bddce366b7bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712564 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#680362}
-
David Jean authored
TBR=rockot@google.com Bug: 987155 Change-Id: I72c9a3d235acbc76012d6dee78832ce8ca89f678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715368Reviewed-by:
Yi Su <mrsuyi@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#680361}
-
Yasmin authored
Bug: 980542 Change-Id: I02a499fc4c1878be3ad25ff62d5f9b437988e510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715345Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#680360}
-
Joel Hockey authored
Change running check from VM to container. Bug: 968060 Change-Id: I8340931a4cdfea205b52ef40162e6e99120ec8b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715760 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#680359}
-
Roman Sorokin authored
Also rsorokin@ takes over ownership. Bug: 969925 Change-Id: I18d8885b5ea0db420095dcc346969e5e28de389b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713509 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#680358}
-
Xinglong Luan authored
This reverts commit 69753f33. Reason for revert: crashes reported https://crbug.com/987045 and https://crbug.com/987007 Original change's description: > Reland "Refactor Smart Dim, making it a D-Bus service" > > This is a reland of 1b42c60c > > Fix the failure of the reverted CL on the chromeos-amd64-generic-rel trybot. > The reason of failure is that in chromeos-amd64-generic-rel vm, DEVICETYPE is > empty, which fails the constructor of UserActivityController. > Add an if statement to MachineLearningDecisionServiceProvider::ShouldDeferScreenDim > to get around this. > > Original change's description: > > Refactor Smart Dim, making it a D-Bus service > > > > Add a Chrome D-Bus service, export ShouldDeferScreenDim method for > > powerd to call > > > > Bug: 933199 > > Change-Id: I275f4eb5f406d6ecdd1fca3590a00c2a0618eb4d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598921 > > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > > Reviewed-by: Mattias Nissler <mnissler@chromium.org> > > Reviewed-by: Dan Erat <derat@chromium.org> > > Reviewed-by: Andrew Moylan <amoylan@chromium.org> > > Commit-Queue: Xinglong Luan <alanlxl@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#671533} > > Bug: 933199, 977830 > Test: Tested on local vm and trybots. > Change-Id: Icff1edda1c81a655ad99fc717625914af1dae6bb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675364 > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Andrew Moylan <amoylan@chromium.org> > Reviewed-by: Mattias Nissler <mnissler@chromium.org> > Commit-Queue: Xinglong Luan <alanlxl@chromium.org> > Cr-Commit-Position: refs/heads/master@{#675470} TBR=derat@chromium.org,stevenjb@chromium.org,achuith@chromium.org,mnissler@chromium.org,amoylan@chromium.org,jiameng@chromium.org,alanlxl@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 933199, 977830 Change-Id: Icae53c14e913d0ae7abd9e7cef763ef2a41730f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715507Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Xinglong Luan <alanlxl@chromium.org> Cr-Commit-Position: refs/heads/master@{#680357}
-
Domenic Denicola authored
Follows https://github.com/WICG/kv-storage/pull/71. Bug: 931263 Change-Id: I19abd6bc26ef29870a4ed45e7a65ddbc724d5584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712950Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#680356}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0f9c660aa939..3ae30cc2e6e0 git log 0f9c660aa939..3ae30cc2e6e0 --date=short --no-merges --format='%ad %ae %s' 2019-07-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 02407743bd72..8bb46c5b9ffc (3 commits) Created with: gclient setdep -r src/third_party/skia@3ae30cc2e6e0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Bug: chromium:None Change-Id: Iff7dc2ff04d4904d35294f3850914d97a201d6c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716587Reviewed-by:
-
David Munro authored
install-build-deps requires lsb_release, add a note for Crostini to install lsb-release before running install-build-deps Bug: None Test: sudo apt install lsb-release; install-build-deps.sh --no-arm Change-Id: I642275a4aa6ac22ff9c71733a4b4911db23bc392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716605 Auto-Submit: David Munro <davidmunro@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#680354}
-
Mike West authored
We realized in a conversation around issue 951540 that we don't have settings UI that allows users to reconsider decisions they've made around external protocol support. Until we work that out, and make longer-term decisions about the permission model around the feature generally, we should stop making the problem worse by removing that checkbox from the UI. Based on existing telemetry (`BrowserDialogs.ExternalProtocol.HandleState`), this will affect ~8% of users who interact with the dialog, which itself is a fairly small group of Chrome's users overall. Bug: 982341, 987149 Change-Id: I723979aab9606d1c2337a36a8f5a0686b95bb9be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708070 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#680353}
-
Hiroki Nakagawa authored
This reverts commit d3cda01a. Reason for revert: This causes compile failures on multiple bots: https://ci.chromium.org/p/chromium/builders/ci/Win%20Builder/77590 Original change's description: > Show Click to Call dialog if sync is disabled. > > We want to show the Click to Call dialog even if sync is disabled to > show the user some help text on how to enable sync. > > Bug: 986273 > Change-Id: I5f920822f21761ee5f167af0622b11304140cda4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713533 > Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > Commit-Queue: Richard Knoll <knollr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680351} TBR=mvanouwerkerk@chromium.org,alexchau@chromium.org,knollr@chromium.org Change-Id: Icd69f58275aea8ca1655b560f3b41d186a2a7847 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 986273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716704Reviewed-by:
-
Richard Knoll authored
We want to show the Click to Call dialog even if sync is disabled to show the user some help text on how to enable sync. Bug: 986273 Change-Id: I5f920822f21761ee5f167af0622b11304140cda4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713533Reviewed-by:
-
Alex Ilin authored
The test was flaky because it depended on the state of Android master sync. If a test device had the master sync off, the test would fail. This CL mocks the state of the master sync in the test. Bug: 984582 Change-Id: I48c362dec631c8fdb484d16ba836e4c7fa027391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715284Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#680350}
-
Sergio Villar Senin authored
This is a reland of 475fb228 TBR=haraken@chromium.org,mkwst@chromium.org Original change's description: > Move histogram(_test).[cc|h] to platform/instrumentation > > They're much better placed there than directly under platform/ > > Bug: 919385 > Change-Id: I9583741da31e28217a9f331322ca8246984b94eb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713190 > Commit-Queue: Sergio Villar <svillar@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#679926} Bug: 919385 Change-Id: Ib6757d24b090ff6b64ba37cbf80d3b0e61ede913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715347Reviewed-by:
Sergio Villar <svillar@igalia.com> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#680349}
-
Matthias Körber authored
autofill_attribute=*password. Change-Id: I98c70ff7cc4f3f64777a1e46a67c5491d4fe3f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712679Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#680348}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/886321015e1d..1fee49ba988e git log 886321015e1d..1fee49ba988e --date=short --no-merges --format='%ad %ae %s' 2019-07-24 miahsanchez@google.com vm_unittest: testSystemQemuPath fixed after failing. 2019-07-24 vapier@chromium.org bootstrap: clean up scripts subdir 2019-07-24 gchenchen@google.com Mark Mistral Important Created with: gclient setdep -r src/third_party/chromite@1fee49ba988e The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I6f9e08a5cb97f1634da2dfc0187e63de7ac321b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716586Reviewed-by:
-
Mario Sanchez Prada authored
Now that we have blink::SurroundingText inside Blink and implemented using internal Blink types like WTF::String and LocalFrame, we can finally migrate blink::SurroundingTextImpl away from WebLocalFrame and remove the DEPS exception rule we previously introduced during this process of Onion Soup'ing the SurroundingText API. Additionally, we move the instantiation of blink::SurroundingTextImpl from WebLocalFrame to LocalFrame as well and, with that, we remove any reference to public Blink classes from SurroundingText-related code. Bug: 980151 Change-Id: I1a1014dbf6671b9327a068ceca4f62d873cb5fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698413 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#680346}
-
Armando Miraglia authored
The bug crbug.com/970153 has identified an issue which is present in the way unplugged default and communications devices are handled. In fact, due to the way the IDs for such devices are stored, Chromium was not notifying that such devices were unplugged. This CL addresses the issue by making sure that the event is triggered on both the actual device as well as the virtual default or communications device associated to it BUG=970153 Change-Id: I30949cb8ca6f1d904dbdf94c4002c4c86d6cafc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708136Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#680345}
-
David Staessens authored
This reverts commit 5531d748. Reason for revert: Some issues still persist after the CL was re-landed with fixes. Currently all binary video decoder (perf) Tast tests are broken. The test launcher spawns a new process to run the tests, passing arguments to the new process. Unfortunately positional arguments are not passed, causing the test to be run without a video file. This can be circumvented by specifying "--single-process-tests" on the command line, but this would complicate manual usage of the video decoder tests. crrev.com/c/1708621 moved the test-launcher-specifc arguments to the video encoder tests, so it's no longer required to use a test-launcher here. Original change's description: > Reland "media/gpu: VDA tests and perf tests uses base::TestLauncher." > > This CL relands commit 372610a8, which broke the > test when enabling DCHECK. The breakage has now been fixed. > > Original change's description: > > media/gpu: VDA tests and perf tests uses base::TestLauncher. > > > > In CL:1679774 we added a TestLauncher specific argument for each > > Chrome test binary at Tast framework. However, currently VDA test and > > VDA perf test doesn't use base::TestLauncher, so they failed at > > parsing arguments. > > In this CL, we use base::TestLauncher at both VDA tests and perf > > tests. > > > > BUG=chromium:985179 > > TEST=./video_decode_accelerator_tests --test-launcher-timeout=3600000 > > > > Change-Id: I8155aae78be81bedcb252bfbdb534760e788d3be > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708150 > > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > > Reviewed-by: Alexandre Courbot <acourbot@chromium.org> > > Reviewed-by: David Staessens <dstaessens@chromium.org> > > Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#678603} > > BUG=chromium:985179 > > Change-Id: Iae3a514972498f2f51f0a087662f009fdec72ab1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710071 > Commit-Queue: David Staessens <dstaessens@chromium.org> > Reviewed-by: Chih-Yu Huang <akahuang@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#679032} TBR=akahuang@chromium.org,hiroh@chromium.org,dstaessens@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:985179 Change-Id: I22f15d4185cccbdd702be1b2ef2e8d111ea1b002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716366Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#680344}
-
Wei Lee authored
This CL changes the behavior to throw error when the given device id is invalid for CrosImageCapture API. Bug: b/137605244 Test: Manually Change-Id: I8a6b6e6e2a3edce600eb1f84759ed92aa491cdf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705854Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#680343}
-
Jinsuk Kim authored
This CL makes the top corners of BottomSheet round shape (of radius 4dp). The round corners resides inside the top shadow and takes the half the height. Bug: 985644 Change-Id: Ibfc26c06a9ca4c83aa5f7304e27a91f50fba9df7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710016 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#680342}
-
Jose Dapena Paz authored
A GCC build regression has happened on DisjointRangeLockManager, as its move operator and constructor were declared noexcept. This was failing because the default implementation depended on base::WeakPtr, that did not provide noexcept declaration for them. So make base::WeakPtr noexcept. Bug: 819294 Change-Id: I936784b881c7c1afea136ceedbe9341e76464f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708141Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#680341}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e29b1cf3. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" 6a6b173b "Add type option to showToast helper" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ifd05031ccd172eeb1eb6a6a2f9fcf075017194d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715919Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680340}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d15571af2e1b..0f9c660aa939 git log d15571af2e1b..0f9c660aa939 --date=short --no-merges --format='%ad %ae %s' 2019-07-24 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps Created with: gclient setdep -r src/third_party/skia@0f9c660aa939 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Bug: None Change-Id: I68f62db4898c93e3066991d7a89ccf87eeee3f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716403Reviewed-by:
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: Idfe097d692ac6a347f364d48d3a1d99769d161af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715365Reviewed-by:
-
Ren-Pei Zeng authored
Instead of using Ozone platform to create NativePixmap, this CL makes it create NativePixmapDmaBuf directly which doesn't rely on Ozone. Bug: b:120057531 Test: video_decode_accelerator_tests Test: media_unittests --gtest_filter=PlatformVideoFrameUtils* Change-Id: I85ecfa4ca550c4f80f6f6f08b0c71ceeee5dbde1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688834 Commit-Queue: Ren-Pei Zeng <kamesan@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
This is for strange error in https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux/24185 Change-Id: Ief72e01492d5f2567985cb66857763bc955cd4ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714947 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#680336}
-
Jeevan Shikaram authored
This is a reland of d44f4549 Original change's description: > Revert "[App Management] Enable App Management by default." > > This reverts commit 2fd01309. > > Reason for revert: Disabling App Management before branch point. > > Original change's description: > > [App Management] Enable App Management by default. > > > > Enable App Management by default. Current entry points are about:settings > > and about:app-management. > > > > Bug: 906508 > > Change-Id: I0118a4b51eda6e65bc72186e771fc2ede2acb45f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610658 > > Reviewed-by: Dominick Ng <dominickn@chromium.org> > > Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#659341} > > TBR=dominickn@chromium.org,jshikaram@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 906508 > Change-Id: I302364e6573eaf21b7a0a3a93ecf517fc473740a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636652 > Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> > Commit-Queue: Dominick Ng <dominickn@chromium.org> > Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664595} TBR=dominickn@chromium.org Bug: 906508 Change-Id: Iae08c2de1231360e6882b74aeee5d02f4a7fae2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716045Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#680335}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ac7c4af504d5..532f86826d5c Created with: gclient setdep -r src-internal@532f86826d5c The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=nhiroki@google.com,pmonette@google.com,sky@google.com,kolos@google.com Bug: chromium:None Change-Id: Idef56a831c3002ee14fa8f866bb5e5f42f536f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716402Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: I04ec1ffa64070b9a76fa5c9d9dc82a59ab4cf014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714810Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#680333}
-
