GitLab

> Added basic browser test for window.print() from Chrome apps.
> 
> This just tests the success of the call to window.print(). It does not
> test whether the call leads to a print preview window and ultimately to
> a printout. It will be extended over time to provide additional coverage
> of the print functionality.
> 
> BUG=NONE
> 
> Review URL: https://chromiumcodereview.appspot.com/23054002

TBR=dharcourt@chromium.org

Review URL: https://codereview.chromium.org/23597011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220472 0039d316-1c4b-4281-b951-d872f2087c98

Created a default URLFetcherFactory to fix the flaky tests.

BUG=280247
TEST=none

Review URL: https://chromiumcodereview.appspot.com/23440010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220471 0039d316-1c4b-4281-b951-d872f2087c98

BUG=245025
R=eroman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19757011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220470 0039d316-1c4b-4281-b951-d872f2087c98

> Revert 219657 "Roll Clang r186332:r188423."
> 
> BUG=266815
> 
> > Roll Clang r186332:r188423.
> > 
> > BUG=none
> > 
> > Review URL: https://chromiumcodereview.appspot.com/23172018
> 
> TBR=hans@chromium.org
> 
> Review URL: https://codereview.chromium.org/23801002

TBR=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/23559013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220469 0039d316-1c4b-4281-b951-d872f2087c98

This just tests the success of the call to window.print(). It does not
test whether the call leads to a print preview window and ultimately to
a printout. It will be extended over time to provide additional coverage
of the print functionality.

BUG=NONE

Review URL: https://chromiumcodereview.appspot.com/23054002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220467 0039d316-1c4b-4281-b951-d872f2087c98

BUG=266815

> Roll Clang r186332:r188423.
> 
> BUG=none
> 
> Review URL: https://chromiumcodereview.appspot.com/23172018

TBR=hans@chromium.org

Review URL: https://codereview.chromium.org/23801002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220466 0039d316-1c4b-4281-b951-d872f2087c98

Add a NetworkActivationHandler for handling cellular activation calls to Shill.

BUG=188753
TEST=tested Verizon LTE (on link) and Verizon 3g (on Lumpy) activation

Review URL: https://chromiumcodereview.appspot.com/22611005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220463 0039d316-1c4b-4281-b951-d872f2087c98

This patch prevents LTHI from background ticking
animations if there is no active tree to
animate since animating with no active tree will
often result in segfaults.

BUG=280706

Review URL: https://chromiumcodereview.appspot.com/23593003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220462 0039d316-1c4b-4281-b951-d872f2087c98

If metro viewer instance was connected before crash then we won't show crash dialog.

BUG=273185
R=cpu,ananta
TBR=sky
TESTS:Please see comment#2 in bug description and check if you see restart dialog when crashed from metro mode.

Review URL: https://chromiumcodereview.appspot.com/23405002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220460 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220459 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=156928:156936&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/23559011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220458 0039d316-1c4b-4281-b951-d872f2087c98

This isn't necessary in the browser since if there are 2 requests for 
the same translation we don't care which one wins, 
(i.e. which one gets the temp file and does the translation and which one 
blocks to wait) but the unit tests do care because they try to hit particular
corner cases. This is why they were flaky. So just always sequence the temp
file creation, which will have minimal cost in practice.
Also re-enable the disabled tests.
R=jvoung@chromium.org
BUG=272492

Review URL: https://chromiumcodereview.appspot.com/23737002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220457 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/14025/steps/cc_unittests/logs/stdio#failure7

> cc: Block commit on activate by setting a flag on LayerTreeHost.
> 
> Currently the ThreadProxy recursively asks all layers in the tree if
> they should block the commit. This is problematic as when you remove
> a layer from a the tree, it may want to block the commit to get back
> resources from its active-tree impl-layer.
> 
> Instead, have layers call SetNextCommitWaitsForActivation() when they
> want the next commit to block on activate. This way we only block
> commits that matter, not every commit when there's a texture layer
> present. And we can allow a layer to block the commit when it is
> leaving the tree.
> 
> Tests:
> TextureLayerNoMailboxIsActivatedDuringCommit
> TextureLayerMailboxIsActivatedDuringCommit
> DelegatedFrameIsActivatedDuringCommit
> 
> R=enne, piman
> BUG=277953
> 
> Review URL: https://chromiumcodereview.appspot.com/23530003

TBR=danakj@chromium.org

Review URL: https://codereview.chromium.org/23702010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220455 0039d316-1c4b-4281-b951-d872f2087c98

Crash data seems to indicate AutocompletePopupWidget is getting
destroyed when we Init() it. This seems wrong, so I'm adding a CHECK
to helkp isolate why.

BUG=275794
TEST=none
R=pkasting@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23490017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220451 0039d316-1c4b-4281-b951-d872f2087c98

R=isherman@chromium.org
BUG=150084,281527,281541, 281582

Review URL: https://chromiumcodereview.appspot.com/23548003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220450 0039d316-1c4b-4281-b951-d872f2087c98

On windows, web page replay server fails to do cleanup such as restoring dns settings if it gets terminated.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/23455009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220448 0039d316-1c4b-4281-b951-d872f2087c98

To open the gallery, dowloads dir is needed, but the code was wrong.
This fixes it by using VolumeManager.
This is also the preparation to switch rootsList to volume info list.

BUG=268817
TEST=Ran browser_tests --gtest_filter="*FileSystemExtensionApiTest*:*FileManagerBrowserTest*:*FileBrowserPrivateApiTest*" and tested manually.

Review URL: https://chromiumcodereview.appspot.com/23599004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220445 0039d316-1c4b-4281-b951-d872f2087c98

BUG=272715
TEST=existing tests

Review URL: https://chromiumcodereview.appspot.com/23601005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220444 0039d316-1c4b-4281-b951-d872f2087c98

** Will need to be updated/rebased when https://codereview.chromium.org/22883011/ lands 
BUG=273827

Review URL: https://chromiumcodereview.appspot.com/23465003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220443 0039d316-1c4b-4281-b951-d872f2087c98

BUG=274658

Review URL: https://chromiumcodereview.appspot.com/23771002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220441 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220440 0039d316-1c4b-4281-b951-d872f2087c98

1705: Land a test change that should have been part of r1704.
1706: ninja/mac: Allow more than one ld process at a time, based on RAM.
1707: ninja&make/mac: Convert .strings files to UTF-16LE, not just UTF-16.

BUG=280718
TBR=mark@chromium.org

Review URL: https://codereview.chromium.org/23790003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220439 0039d316-1c4b-4281-b951-d872f2087c98

These objects will soon be added to PasswordForm, which needs to be persisted
by the PasswordStore.

BUG=240559

Review URL: https://chromiumcodereview.appspot.com/23033010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220437 0039d316-1c4b-4281-b951-d872f2087c98

BUG=276334
TEST=Manual, see bug.

Review URL: https://chromiumcodereview.appspot.com/23311008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220435 0039d316-1c4b-4281-b951-d872f2087c98

We need to switch to googlestorage first.

This change reverts r220393 and r220374.

TBR=ilevy@chromium.org
BUG=276076

Review URL: https://codereview.chromium.org/23647005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220434 0039d316-1c4b-4281-b951-d872f2087c98

219882 has been tested in 31.0.1614.0 (Official Build 220153) canary.

> Turn off TLS 1.2 to work around the TLS 1.2 client authentication
> problems on Android and Windows.
> 
> R=agl@chromium.org
> TEST=net_unittests
> 
> Review URL: https://chromiumcodereview.appspot.com/23442006

TBR=wtc@chromium.org
BUG=278370,280275

Review URL: https://codereview.chromium.org/23559012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220433 0039d316-1c4b-4281-b951-d872f2087c98

. Makes tooltip hide on exit. This is necessary on windows else we can
  leave tooltips on screen after an exit.
. Changes desktop aura to only create a single TooltipController. This
  isn't strictly necessary, but better matches what we're doing on
  ash.

BUG=275488
TEST=covered by test.
R=varunjain@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23477022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220432 0039d316-1c4b-4281-b951-d872f2087c98

If we do an online revocation check because a certificate is EV and we don't
have CRLSet coverage then we would like to mark the certificate as revoked
if the check indicates that, rather than just removing the EV badge.

However, on non-Windows platforms we don't get enough information from the
verification so this change just adds a test for Windows.

This also fixes a small memory leak.

BUG=279282

Review URL: https://chromiumcodereview.appspot.com/23441005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220429 0039d316-1c4b-4281-b951-d872f2087c98

* Consolidate the flush left/right logic for new window with one for visibility change.
* The logic to get initial tab should be same as one for tabbed browser window.
  This CL should address this issue.

Next step. move the initial bounds logic (incl. window positioner) to ash and
remove window_sizer_ash.cc

BUG=273825,272460
TEST=covered by test. moved relevant tests to ash.

Review URL: https://chromiumcodereview.appspot.com/23205027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220428 0039d316-1c4b-4281-b951-d872f2087c98

BUG=280609,163464
R=klobag@chromium.org, piman@chromium.org

Review URL: https://codereview.chromium.org/23483023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220427 0039d316-1c4b-4281-b951-d872f2087c98

This causes tricky reordering of OnDeviceScaleFactorChanged() for
the transition from mirroring to extended with 1x display and 2x display.

BUG=267698
R=oshima@chromium.org, sky@chromium.org
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/23444019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220426 0039d316-1c4b-4281-b951-d872f2087c98

Android does not support Shared Workers right now, but is exposing the
window.SharedWorker constructor to web pages. Returning NULL when
trying to get the shared worker repository fixes this.

BUG=154571

Review URL: https://chromiumcodereview.appspot.com/23764002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220425 0039d316-1c4b-4281-b951-d872f2087c98

When we added the logging before, due to time constraints we didn't log
everything that we were using. Now that we have a bit more time, I've added
more logging to help as we enter the bug fix phase for Synced Notifications.
This logging should help with specific outstanding bugs as well as being
generally useful moving forwards.

BUG=281510

Review URL: https://chromiumcodereview.appspot.com/23526005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220424 0039d316-1c4b-4281-b951-d872f2087c98

Somehow i ended up uploading a 0-byte file before. Now updating
media/test/data/bear-opus-end-trimming.webm with the correct
file.

It's probably because i tried to upload both the binary file
and the README in the same CL.

R=tomfinegan@chromium.org, xhwang@chromium.org

Review URL: https://codereview.chromium.org/23477024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220423 0039d316-1c4b-4281-b951-d872f2087c98

This is cleanup from the addition of Webdriver support.
The new folder core/backends/ will have backend interfaces that must be implemented by both Chrome and WebDriver, e.g. browser_backend; as well as backends that are common to both, e.g. form_based_credentials_backend.

BUG=None.
TEST=./run_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218886

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220263

R=chrisgao@chromium.org, nduca@chromium.org, tonyg@chromium.org

Review URL: https://codereview.chromium.org/23072018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220422 0039d316-1c4b-4281-b951-d872f2087c98

Added histogram definitions for 2 new data points from the
Quickoffice spreadsheet extension - fomattedCellCount will log the
total number of cells in the default worksheet that have any
formatting content. This will allow us to better understand typical
spreadsheet use and schedule performance work accordingly.

One histogram tracks compound binary format spreadsheets, the
other OOXML spreadsheets.

BUG=276229
NOTRY=true

Change-Id: I3ef3b81eade4916447daac5aa281c0eda2a3694f

Review URL: https://chromiumcodereview.appspot.com/23534019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220421 0039d316-1c4b-4281-b951-d872f2087c98

- This refactor broke a component that required the ContentViewCore to hold an
Activity Context.

BUG=277135
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23794002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220420 0039d316-1c4b-4281-b951-d872f2087c98

BUG=227004

UPDATED DOC: https://chrome-apps-doc.appspot.com/_patch/23617008/apps/notifications.html

R=kalman@chromium.org

Review URL: https://codereview.chromium.org/23617008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220419 0039d316-1c4b-4281-b951-d872f2087c98

Currently the ThreadProxy recursively asks all layers in the tree if
they should block the commit. This is problematic as when you remove
a layer from a the tree, it may want to block the commit to get back
resources from its active-tree impl-layer.

Instead, have layers call SetNextCommitWaitsForActivation() when they
want the next commit to block on activate. This way we only block
commits that matter, not every commit when there's a texture layer
present. And we can allow a layer to block the commit when it is
leaving the tree.

Tests:
TextureLayerNoMailboxIsActivatedDuringCommit
TextureLayerMailboxIsActivatedDuringCommit
DelegatedFrameIsActivatedDuringCommit

R=enne, piman
BUG=277953

Review URL: https://chromiumcodereview.appspot.com/23530003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220418 0039d316-1c4b-4281-b951-d872f2087c98

The full fix for the crashes in the associated bugs in trunk is too
risky to merge into M30. After discussions among kareng and sky, the
best approach was to disable dragging of tabs while a web contents modal
dialog is displayed, to prevent the crashes. This only affects Chrome
OS and will be reverted after testing in Canary and merging to the
branch.

BUG=275274, 274856
R=sky@chromium.org

Review URL: https://codereview.chromium.org/23698003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220417 0039d316-1c4b-4281-b951-d872f2087c98