- 24 Apr, 2018 40 commits
-
-
Robert Ogden authored
Also makes a small change to the GetWarmupURL() function in order to allow this testing to work by preserving existing query params. Cleans up a bit of whitespace in bypass.py Bug: 724704 Change-Id: Ia84d1199911725684c00538f9ef651a427a9d279 Reviewed-on: https://chromium-review.googlesource.com/1024727 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#553187}
-
Eric Holk authored
See https://crrev.com/c/1024646 for the V8 side of this change. Change-Id: I7638ff7ee0b8469be704a71b6e6968b35d2e855b Reviewed-on: https://chromium-review.googlesource.com/1025181Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#553186}
-
Xida Chen authored
This reverts commit 0b61ff47. Reason for revert: <INSERT REASONING HERE> Original change's description: > Disable DeleteActiveSession on Win > > TBR=thestig@chromium.org > NOTRY=true > > Bug: 836289 > Change-Id: I669edb4d3ec8af8e144e5fac812ed0b1422e5e55 > Reviewed-on: https://chromium-review.googlesource.com/1026155 > Commit-Queue: Xida Chen <xidachen@chromium.org> > Reviewed-by: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553165} TBR=thestig@chromium.org,xidachen@chromium.org Change-Id: I6b1f989a749c7cbda554d5d8b4ccee735ded64e7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836289 Reviewed-on: https://chromium-review.googlesource.com/1026132Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#553185}
-
Christopher Grant authored
The URL bar color should animate when switching to and from incognito mode. BUG=836236 R=asimjour Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I4bd0eda60d5bc0852dfc739e5fd20c5b6c970291 Reviewed-on: https://chromium-review.googlesource.com/1025955Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#553184}
-
Chris Blume authored
The LSI allocators previously did not store a copy of the last generated LSI. As a result, many call sites would have to keep their own copies. Now that the LSI allocators have their own copies, the call sites can be updated to no longer store a separate copy. DirectLayerTreeFrameSink is one such call site. BUG=759031 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I3b02013078ac09330eb076f542886a14b545ad73 Reviewed-on: https://chromium-review.googlesource.com/1024748Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#553183}
-
Yi Gu authored
Animating multiple effects is not fully supported yet (tracked via crbug.com/767043). For origin trial we should log a warning when an array with multiple effects is passed to the WorkletAnimation constructor. Bug: 834456 Change-Id: Ie0a37e0d36464e595b54f140d2e3f3331280dd61 Reviewed-on: https://chromium-review.googlesource.com/1024952 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#553182}
-
Misha Efimov authored
Bug: b/78182827 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: If2a6eea9db1b80c15e05ff0e33767367e1e472e5 Reviewed-on: https://chromium-review.googlesource.com/1025642Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#553181}
-
Bence Béky authored
Reland https://crrev.com/c/1000487. Remove HttpStreamFactory interface, also rename HttpStreamFactoryImpl to HttpStreamFactory. Bug: 829429 Change-Id: I298879817785174d1d7290520f889f0252074e14 Reviewed-on: https://chromium-review.googlesource.com/1023321 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#553180}
-
Xiaohui Chen authored
This reverts commit 89dbe1f8. Reason for revert: This needs to be merged together with upstream rolldeps Original change's description: > Fix build errors with upstream libassistant change > > Test: build locally with upreved libassistant > Bug: None > Change-Id: I3db67f5a77824fcf0831447f353baba6167b0801 > Reviewed-on: https://chromium-review.googlesource.com/1025268 > Reviewed-by: Muyuan Li <muyuanli@chromium.org> > Commit-Queue: Muyuan Li <muyuanli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552972} TBR=xiaohuic@chromium.org,muyuanli@chromium.org Change-Id: I9b3b13b11381b3100203428343251d2522b1c638 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/1026131Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#553179}
-
Xida Chen authored
TBR=thestig@chromium.org NOTRY=true Bug: 836297 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I775ed2b20cd8ffb4503505aa9e63290e8d92de1c Reviewed-on: https://chromium-review.googlesource.com/1026160 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#553178}
-
Matt Menke authored
When the network service is restarted, the disk cache entry may be not be recovered, for reasons that aren't completely clear (corruption? disk contention?), which causes the test to flake. This CL modifies the test to not fail in that case. Bug: 836073 Change-Id: I3eedeceae6145b1d386749125c8232d552be8308 Reviewed-on: https://chromium-review.googlesource.com/1025646 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#553177}
-
Egor Pasko authored
Reason: they are flaky. TBR=rouslan@chromium.org NOTRY=true Bug: 836027 Change-Id: I93d5903a0d2d4bd1cbed6257dd4887924b2a84fd Reviewed-on: https://chromium-review.googlesource.com/1025775Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#553176}
-
Jialiu Lin authored
Remove prefs::kPasswordProtectionEnterpriseName and ~EnterpriseEmailDomain to eliminate the mis-configuration by admins. Instead, deriving enterprise organization name from AccountInfo.email. If it is not available, use generic term "your organization" instead. This CL also simplifies the trigger logic by not comparing logged-in domain with enterprise email domain, since the org name string derived from logged-in account should be always correct. Bug: 824501 Change-Id: Ie8c82940774d35783f14ce500742d1e3db74ff7d Reviewed-on: https://chromium-review.googlesource.com/1022732Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#553175}
-
https://chromium.googlesource.com/angle/angle.git/+log/b3474d9d77de..66410530a78d $ git log b3474d9d7..66410530a --date=short --no-merges --format='%ad %ae %s' 2018-04-20 lucferron Vulkan: Textures mipmaps support Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I64d9f63c74d265e018a0a9bc488228ed3894dca9 Reviewed-on: https://chromium-review.googlesource.com/1025322Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553174}
-
Hans Wennborg authored
The test fails in official builds (see bug). Probably this is due to fieldtrial_testing_config.json not affecting official builds, and so the feature needs to be explicitly enabled in the test fixture, perhaps similarly to https://crrev.com/452026 Bug: 834010 Change-Id: If0909e90d03f05596cc44f3a1022a0f5eca66762 Reviewed-on: https://chromium-review.googlesource.com/1026113Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#553173}
-
arthursonzogni authored
Removes usages of the stream for loading the main resource response in the renderer process. Other CLs: 1) https://chromium-review.googlesource.com/c/chromium/src/+/1015005 * 2) https://chromium-review.googlesource.com/c/chromium/src/+/1021631 3) https://chromium-review.googlesource.com/c/chromium/src/+/1022790 4) https://chromium-review.googlesource.com/c/chromium/src/+/1024038 Bug: 705744 Change-Id: I2fa52775d24f12d16c71f615f0c9d7618d1edb1e Reviewed-on: https://chromium-review.googlesource.com/1021631 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#553172}
-
Elly Fong-Jones authored
The listed test suites appear most frequently in the immediate history of bots prior to windowserver deaths. See the linked bug for details. Bug: 828031 Change-Id: I0f8a4937fff23a94a628493331dc51191de5b072 Reviewed-on: https://chromium-review.googlesource.com/1025638 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#553171}
-
Greg Daniel authored
In skia, getTextureHandle is deprecated and this change moves to using the new API. Change-Id: I69b507744e21187cfa9da74a960e5394acb2b524 Reviewed-on: https://chromium-review.googlesource.com/1024370Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Greg Daniel <egdaniel@chromium.org> Cr-Commit-Position: refs/heads/master@{#553170}
-
Xida Chen authored
TBR=thestig@chromium.org NOTRY=true Bug: 836295 Change-Id: Ie96425b623849d7ca24bfba40b472605be01903f Reviewed-on: https://chromium-review.googlesource.com/1026158Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#553169}
-
Jan Krcal authored
This CL splits the part of the Bridge's interface that is used by ModelTypeController into a separate Delegate interface. For the reasons of a smooth transition for follow-up CLs, the Bridge inherits from this new Delegate. In the future, we will make the Processor extend this new interface instead of the Bridge. Bug: 819993 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ieacafd872a16f2f587965c1710c6abacb3517efc Reviewed-on: https://chromium-review.googlesource.com/1007134Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#553168}
-
Greg Daniel authored
In skia, getTextureHandle is deprecated and this change moves to using the new API. TBR=zmo@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I8885909baff92c6c4e68a2ad859604e4928a2255 Reviewed-on: https://chromium-review.googlesource.com/1024291Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Greg Daniel <egdaniel@chromium.org> Cr-Commit-Position: refs/heads/master@{#553167}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=olka@chromium.org Bug: 825327 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I296b69513d2205d1cba2d75d6a89891ec60a5b38 Reviewed-on: https://chromium-review.googlesource.com/1024249Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553166}
-
Xida Chen authored
TBR=thestig@chromium.org NOTRY=true Bug: 836289 Change-Id: I669edb4d3ec8af8e144e5fac812ed0b1422e5e55 Reviewed-on: https://chromium-review.googlesource.com/1026155 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#553165}
-
Erik Chen authored
Previously, we checked that at least 1 renderer exists and that all renderers are being profiled. This recently started causing the tests to flake. I suspect this is related to warm-up/spare renderers. So instead, we check that at least 1 renderer exists and is being profiled. Bug: 835826, 833590 Change-Id: I45ef8e1ad9ba1689ae3f0292ab80306b9d7a731f Reviewed-on: https://chromium-review.googlesource.com/1023716Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#553164}
-
Edward Jung authored
Makes the string consistent with other Google products. Bug: 836214 Change-Id: I28a3fa35be8c29960b93eed208acd934a4eb4787 Reviewed-on: https://chromium-review.googlesource.com/1025098Reviewed-by:
Edward Jung <edwardjung@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Edward Jung <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#553163}
-
Fernando Serboncini authored
Lazily init CompositorFrameSink on BeginFrameProvider, execute RAF callbacks when requested. Bug: 833902 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I757e8731c9e39d6900109a383630bc1b59ddfead Reviewed-on: https://chromium-review.googlesource.com/1024376 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#553162}
-
https://pdfium.googlesource.com/pdfium.git/+log/2dca1cbf5956..90e03b9b3f45 $ git log 2dca1cbf5..90e03b9b3 --date=short --no-merges --format='%ad %ae %s' 2018-04-24 dsinclair Remove duplicate data extraction from CFX_XMLParser Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0a9a161c7f07b1235a85a2654154e441c78041b8 Reviewed-on: https://chromium-review.googlesource.com/1026041Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553161}
-
Sergey Berezin authored
ios-* builders may run on a mix of VMs with cores:8 and Mac Mini's with cores:4. Bug: 731546 Change-Id: I056fbb5bd80ca50ef8005aa8bb99643853acd923 Reviewed-on: https://chromium-review.googlesource.com/1024729Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553160}
-
Vaclav Brozek authored
On some places in the autofill code, IsWebElementVisible is used, on other that function is "inlined". This CL changes one such inlined call to call IsWebElementVisible explicitly. There should be no visible behaviour changes caused by this CL. Bug: 833838 Change-Id: Ia0efb92d1a2b781467af929848c8999d8bb72d34 Reviewed-on: https://chromium-review.googlesource.com/1017202Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#553159}
-
Gauthier Ambard authored
This CL shows the 'Add to Bookmark' action in the activity menu even if the bookmark model isn't loaded yet. If the model isn't loaded and the user tries to add the page to the bookmarks, the action will silently fails. Bug: 834723 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id4ae21e3c20cdfad5487d95a928b52103614807d Reviewed-on: https://chromium-review.googlesource.com/1025101 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#553158}
-
Xida Chen authored
TBR=thestig@chromium.org NOTRY=true Bug: 836275 Change-Id: Idff1c4a5a600193bb8b3803ce4bcbbf205e5ccb7 Reviewed-on: https://chromium-review.googlesource.com/1026083Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#553157}
-
Xida Chen authored
TBR=thestig@chromium.org, xlai@chromium.org NOTRY=true Bug: 836278 Change-Id: I4fba063d1782c9d623a2c57ba8bfaf1fa52abadd Reviewed-on: https://chromium-review.googlesource.com/1026088Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#553156}
-
Noel Gordon authored
Fixed on issue 831074 issue 804413 issue 829310. Tbr: yamaguchi-san Bug: 836254 Change-Id: I71fc9416f0459810ed64d2d96dc033e52087d93f Reviewed-on: https://chromium-review.googlesource.com/1025453Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#553155}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=lhchavez@chromium.org Bug: 825327 Change-Id: I40de071dcef2e6356ce03a851a36e85722b4f00a Reviewed-on: https://chromium-review.googlesource.com/1024317 Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#553154}
-
Mike Meade authored
These flags are needed in multiple locations. Rather than duplicate these they are now able to be retrieved from test_installer. Change-Id: I569dbe9b004fc2a91a055c57370f1433429abbd5 Reviewed-on: https://chromium-review.googlesource.com/1025210Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: James Meade <mmeade@chromium.org> Cr-Commit-Position: refs/heads/master@{#553153}
-
Noel Gordon authored
Comment only change. Tbr: slangley Bug: 833834 Change-Id: I3e554d4fc2dd55811453601947016b49df2f63f7 Reviewed-on: https://chromium-review.googlesource.com/1025500Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#553152}
-
arthursonzogni authored
Removes the following classes: - NavigationURLLoaderImpl - NavigationURLLoaderImplCore - NavigationResourceHandler Other CLs: * 1) https://chromium-review.googlesource.com/c/chromium/src/+/1015005 2) https://chromium-review.googlesource.com/c/chromium/src/+/1021631 3) https://chromium-review.googlesource.com/c/chromium/src/+/1022790 4) https://chromium-review.googlesource.com/c/chromium/src/+/1024038 Bug: 705744 Change-Id: Icc74aa1e6adfd42a2018a3b96aa8d5cb9d8daeb9 Reviewed-on: https://chromium-review.googlesource.com/1015005 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#553151}
-
John Chen authored
When elements are inside iframe with padding, ChromeDriver didn't take into account the padding while calculating element locations, and end up getting wrong the wrong locations. Fixing by adding the padding value. Bug: chromedriver:2259 Change-Id: If3b37a6f891636df7b22679ea91e00e31fa66a83 Reviewed-on: https://chromium-review.googlesource.com/1010886Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#553150}
-
Gauthier Ambard authored
This CL updates the bottom inset of the WebView to match the disappearance of the bottom toolbar. Bug: 823712 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idb71c1e780e5ab1949e39122b303aeddd787385e Reviewed-on: https://chromium-review.googlesource.com/1016561Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#553149}
-
Max Moroz authored
Bug: 790747, 759794 Change-Id: Ic95c5217c6781ed5a8628200397a128f418d1a0d Reviewed-on: https://chromium-review.googlesource.com/1024444Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#553148}
-