- 10 Nov, 2019 7 commits
-
-
Ken Rockot authored
This needs to be implemented in the Storage Service. Moving is easy, and avoids a lot of future potential for Blink dependencies creeping into the service's client library. StorageArea and related types are moved into the Storage Service's mojom, with a "Dom" prefix since they are specific to DOM Storage. The KeyValue type is also renamed to KeyValuePair and placed in its own mojom. Bug: 1000959 Change-Id: I9d81c2444be833b643746103a85803002a84bb35 Tbr: kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900537Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#714115}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I929f328cae34479f9859f702f09e250faaad982b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908053Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714114}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/10706d4d4d82..c40495063dba git log 10706d4d4d82..c40495063dba --date=short --no-merges --format='%ad %ae %s' 2019-11-10 tvanderlippe@chromium.org Migrate cm/ to ESM Created with: gclient setdep -r src/third_party/devtools-frontend/src@c40495063dba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC v8-waterfall-sheriff@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=v8-waterfall-sheriff@grotations.appspotmail.com Bug: chromium:1006759 Change-Id: If9d8524a57e40e0b40cf0a03fb1601e2860475f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908054Reviewed-by:
-
Mike Wasserman authored
Adds a basic implementation of the Window Placement blink feature. Affects window.open/moveTo/moveBy/resizeTo/resizeBy coordinate clamping. This feature simply disables Blink's window rect adjustments for now. Chrome's UI still clamps windows in the multi-screen display space. That effective allows popup windows to be placed on any connected display. Future work will implement & test multi-screen clamping in Blink. This is simply a rough first pass to hopefully be used for a CDS demo. Update existing web_tests to handle experimental and stable behavior. Add a basic browser test for popup window bounds clamping. Test with chrome://flags#enable-experimental-web-platform-features or --enable-blink-features=WindowPlacement Bug: 897300 Test: Automated; window.open/moveTo/moveBy/resizeTo/resizeBy has experimental behavior. Change-Id: I8ab70aff2b638ec1f9c41f730b485cb013995bf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756384 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#714112}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/601965061c9c..10706d4d4d82 git log 601965061c9c..10706d4d4d82 --date=short --no-merges --format='%ad %ae %s' 2019-11-10 tvanderlippe@chromium.org Migrate color_picker/ to ESM 2019-11-09 tvanderlippe@chromium.org Migrate formatter/ to ESM Created with: gclient setdep -r src/third_party/devtools-frontend/src@10706d4d4d82 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC v8-waterfall-sheriff@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=v8-waterfall-sheriff@grotations.appspotmail.com Bug: chromium:1006759,chromium:1006759 Change-Id: I3209b200ebd8a90e355bc0d27043f65082e2bae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908707Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c6814905..70bbd167 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7b869f2a41ad81f2a8ba2f7038575aa81e8dab7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908588Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714110}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f7bc2e33670a..601965061c9c git log f7bc2e33670a..601965061c9c --date=short --no-merges --format='%ad %ae %s' 2019-11-09 tvanderlippe@chromium.org Migrate diff/ to ESM Created with: gclient setdep -r src/third_party/devtools-frontend/src@601965061c9c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC v8-waterfall-sheriff@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=v8-waterfall-sheriff@grotations.appspotmail.com Bug: chromium:1006759 Change-Id: If791ae8936d28ca6552e3960936fa48389a3a065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907225Reviewed-by:
-
- 09 Nov, 2019 33 commits
-
-
Abhishek Arya authored
This reverts commit da07f633. Reason for revert: Broke libFuzzer ChromeOS bot https://ci.chromium.org/p/chromium/builders/ci/Libfuzzer%20Upload%20Chrome%20OS%20ASan?limit=200 ../../chrome/browser/chromeos/printing/printer_info_cups.cc:95:3: error: [chromium-style] auto variable type must not deduce to a raw pointer type. auto iter = std::find_if( ^~~~ auto* 1 error generated. Original change's description: > Add a histogram to record IPP versions. > > Adding Printing.CUPS.HighestIppVersion which will record the largest > version a printer supports when it is queried during setup. > > Bug: chromium:1020016 > Change-Id: I7180ed1f147b812d660903381af7aaba6e500bcb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892193 > Reviewed-by: Bailey Berro <baileyberro@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Commit-Queue: Sean Kau <skau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714028} TBR=jwd@chromium.org,skau@chromium.org,baileyberro@chromium.org Change-Id: I603b7c6535f386416d718e2034462aa544fcbd05 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1020016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908627Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#714108}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b88663fc599c..f7bc2e33670a git log b88663fc599c..f7bc2e33670a --date=short --no-merges --format='%ad %ae %s' 2019-11-09 tvanderlippe@chromium.org Revert "Simplify build" 2019-11-09 tvanderlippe@chromium.org Migrate inline_editor/ to ESM Created with: gclient setdep -r src/third_party/devtools-frontend/src@f7bc2e33670a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC v8-waterfall-sheriff@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=v8-waterfall-sheriff@grotations.appspotmail.com Bug: chromium:1006759 Change-Id: I868d0dc041e180c1762c733840e252488e8f266b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907521Reviewed-by:
-
David Grogan authored
We had been doing row, column, and column-reverse correctly, but not row-reverse. So the items in row-reverse containers with asymmetric inline padding/border were positioned incorrectly. Bug: 845235 Change-Id: Icbfd2bae96070cd14590d4ffe6224278cc3da353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907197Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#714106}
-
Sanket Joshi authored
The manual color picker allows users to select colors by manually entering color values in the RGB, HSL or HEX formats. If a user enters an invalid value, the value will be entered into the channel value container but will not be committed. While this behavior is reasonable, the problem is that user's invalid value continues to be reflected until they either choose a different color or close and re-open the popup. This change addresses this by resetting channel value containers to their last valid value whenever the container is blurred. Bug: 1021234 Change-Id: I4481f02d3a86d1c582bc87481743e96ae5aa6c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906118 Commit-Queue: Sanket Joshi <sajos@microsoft.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/80a89976c142..b88663fc599c git log 80a89976c142..b88663fc599c --date=short --no-merges --format='%ad %ae %s' 2019-11-09 tvanderlippe@chromium.org Migrate source_frame/ to ESM Created with: gclient setdep -r src/third_party/devtools-frontend/src@b88663fc599c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC v8-waterfall-sheriff@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=v8-waterfall-sheriff@grotations.appspotmail.com Bug: chromium:1006759 Change-Id: Ib409a28c37cb50029aea7bf09bbd127b557af38a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907572Reviewed-by:
-
wutao authored
This patche renames/adds features for the preparation to deprecate Assistant standalone UI. Specifically, 1. Rename the feature “app_list_features::kEnableEmbeddedAssistantUI”, to “app_list_features::EnableAssistantLauncherUI” to control open Assistant in Launcher. 2. We still need to use the old feature name “EnableEmbeddedAssistantUI” to guard stable users to use Assistant search because it is used in finch experiment. So we can change the feature struct to “app_list_features::kEnableAssistantSearch”. This feature needs to replace the old checks in the multiple places. Bug: b/137873091 Test: manual Change-Id: Ie8dee00163c23508f152edacf897c88ddafdff51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898619Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#714103}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I9bebbca35ef03551032bd251bde69d3d7ebc0201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907571Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I9f8edfc739f508cd9ed0ede56dee5e3bb212215d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907553Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#714101}
-
Nektarios Paisios authored
This patch is a followup to https://crrev.com/c/1894159/ In that patch, the CreateBoundaryStart/EndPosition methods were updated to handle offset boundaries. This patch takes advantage of that improvement by re-writing all the word navigation methods to use CreateBoundaryStart/EndPosition. This patch also fixes a bug in CreatePositionAtFirstOffsetBoundary, which occurs in the cases when an anchor has no offset boundaries. Additionally, I took the opportunity to fix some tests that check affinity of word positions and to update the comment explaining what affinity is used for. R=aleventhal@chromium.org, ethavar@microsoft.com Bug: 1008031 Change-Id: If9a4c9e37b9abcec856dacbf513f9bf95049d06b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904537 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#714100}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ie940119a2ba5b358187d526d999462ac39bd6b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906513Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714099}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8f729062729e..72fe40d810a1 Created with: gclient setdep -r src-internal@72fe40d810a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Iced64320e7c00602dec850dc62a8480fba124fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907833Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714098}
-
Brian Salomon authored
This is a reland of 448ec6f6 Original change's description: > Build internals of Skia with c++17 > > Change-Id: I7fedc818b6fad5c08f37c8002268c65eefdf57a2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757345 > Commit-Queue: Brian Salomon <bsalomon@google.com> > Reviewed-by: Mike Klein <mtklein@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713492} Tbr: mtklein@google.com Change-Id: If971b90ac7e6d24a2d42af8fa7da24c65169bc5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906306 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#714097}
-
Omer Katz authored
Heap snapshot filters ephemeron entries with null keys. Also, because heap snapshot doesn't do stack scannig, we are not guaranteed to trace all ephemeron entries by the end of the snapshot. Replacing ephemeron/worklist handling with a fixed-point computation to guarantee we cover as many objects as we can. Followup CL will filter untraceable ephemeron values. Bug: 1021991 Change-Id: I4f27a631d03672823f6b35a03509559122426743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907007 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#714096}
-
Ian Kilpatrick authored
Beginning to look at more of the crash reports, and there are a lot of cases where the layout tree is in a bad state, particularly around OOF-positioned elements. In parallel to fixing these: https://chromium-review.googlesource.com//1906708 ...this patch aborts if we don't have a paint fragment. Bug: 1022545 Change-Id: Ia4941c0da187f1de9b3f1e882dfcb841207e654a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906777 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#714095}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ied2b3904cf5a33e2feb1ce26228c32e34736b116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907948Reviewed-by:
-
Miyoung Shin authored
This CL converts ColorChooserFactory mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: Ie667fcb4919ef1f0e020d9b62973028d0795b72b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886552Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#714093}
-
Wei-Yin Chen (陳威尹) authored
TBR=yusufo@chromium.org Bug: 1023079 Change-Id: Ia7c4d37734ae424792ffc1e6e6f278fc780760fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907518Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#714092}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I3b4b205f0cce6c5b6fa17472939942957957895f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907217Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d6b9b0a1f413..a4c1aaad8d5f git log d6b9b0a1f413..a4c1aaad8d5f --date=short --no-merges --format='%ad %ae %s' 2019-11-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e615bdb3..5145d23f (713980:714086) 2019-11-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2b5d8199..e615bdb3 (713876:713980) 2019-11-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b19a2944..2b5d8199 (713775:713876) 2019-11-08 ilnik@webrtc.org Reset RtpFrameReferenceFinder on long pause 2019-11-08 brandtr@webrtc.org Remove dead kDummyVideoSsrc and FPS_TO_INTERVAL from video_common.h. 2019-11-08 danilchap@webrtc.org Revert "Cleanup MultiStreamTester" Created with: gclient setdep -r src/third_party/webrtc@a4c1aaad8d5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None Change-Id: Ic51ab5fe1ac1851ddaf04cfcf0485921cc0a8d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907220Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9b2e22593bbf..3573aac4baff git log 9b2e22593bbf..3573aac4baff --date=short --no-merges --format='%ad %ae %s' 2019-11-09 bhogeswararao@google.com Add gwifi to usergroup_baseline Created with: gclient setdep -r src/third_party/chromite@3573aac4baff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I9085cc49b81a520343fbf5168ce025431b16db33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907215Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f2af41c8..c6814905 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I450e1ce7145606daa233564323c673d0b74d2dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906813Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I909922f9b849d970c49fe307036eda76348a81d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907777Reviewed-by:
-
Anupam Snigdha authored
Problem: Input panel policy only gets evaluated when textinputstore acquires focus. We call AssociateFocus and SetFocus for every focus change that led to multiple redundant focus messages to TSF. Input panel policy is set to auto only when the user taps on the edit control. It calls AssociateFocus and SetFocus instead of just OnStatusChange on the focused textinputstore. This leads to an inconsistent showing of the virtual keyboard because the policy switch sometimes happens after the focus gets evaluated by TSF. Solution:When browser launches, address bar is focused and the text input state is set to URL. The input pane policy is manual on focus. The text input state change notification calls AssociateFocus which also calls SetFocus internally on the document manager in TSF. Calling SetFocus again queues up redundant focus messages in TSF that interferes in other focus messages so we removed this call in this patch. When user taps on the address bar, input pane policy is changed to automatic on ShowVirtualKeyboardIfEnabled call. This notifies TSF with just a status change of the dynamic flag instead of calling AssociateFocus and SetFocus (which would have triggered lot of redundant focus messages to TSF. When the user opens google.com, the script sets focus on the input box which triggers a DetachTextInputClient from the address bar and also a text input state change notification. This sets the text input type to be SEARCH. In between this transition, null TSFtextStore gets focus that also calls AssociateFocus and TSF transitions its focus from URL to null and then from null to SEARCH. The input pane policy is set to manual until the user taps on the search box as we don't want to raise the virtual keyboard on focus and without user interaction on the page. Once the user taps on the search box, we set the input pane policy to automatic and call status change to notify TSF about the change. When TSF calls GetStatus to query for the dynamic flag, it will have the manual input pane policy disabled and the virtual keyboard will come up. Current flow of focus notification to TSF: When text input type is none i.e. no editable element is in focus, we call AssociateFocus on text input type and set the input panel policy to manual only when the text input client is detached or changed. This happens when user switches focus between address bar and a webpage. We call SetFocus only when the text input type is anything other than none. We don't call AssociateFocus and SetFocus at the same time to reduce redundant focus changes that leads to VK issues. Test: ui\base\ime\win\tsf_input_policy_unittest.cc Bug:1014365 Change-Id: I2a2dd28a8ae514cfa4912f5051cde351928b2ab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895750 Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#714086}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I3a5aa758a93af2d21f3dc617e51dd6d2fa4cc272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907867Reviewed-by:
-
Austin Eng authored
This is a reland of 32cfad60 The original CL was reverted because it uncovered a state leak elsewhere in ANGLE. Original change's description: > Merge WEBGL_multi_draw_instanced into WEBGL_multi_draw > > The WebGL working group decided there is enough WebGL 1 support for > instancing that it would be simpler to only expose the instanced > version of the extension. > > This also rolls WebGL 2701c13..69e333c which includes the spec and > conformance test changes. > > Bug: chromium:890539 > Change-Id: Ib4dccf56f488cedf8161268ac3467d27c9b371c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881712 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Austin Eng <enga@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710310} Bug: chromium:890539, chromium:1022080 Change-Id: I25fce02e99f0298b2f585f6ecdf47c0a0d0657d7 TBR: dcheng@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890541 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#714084}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/39b4b38f4f36..600a26d50a04 git log 39b4b38f4f36..600a26d50a04 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 rafael.cintron@microsoft.com Fix ResourceHeapAllocation Memory Leak Created with: gclient setdep -r src/third_party/dawn@600a26d50a04 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: Iaf14869659e69bf4abd6765abe11c4f0bc4eae89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907515Reviewed-by:
-
Bettina authored
Bug: 1010764 Change-Id: I8ab0a2f7fe028a68698be93741e20779c4209f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902230Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#714082}
-
Aidan Wolter authored
This reverts commit 8db01995. Reason: Broke downstream repository that doesn't have required dependencies Bug: b/143701391 Change-Id: Icb8c9bd3be5637b5766083991ea799068814c5a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907768 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Aidan Wolter <awolter@chromium.org> Cr-Commit-Position: refs/heads/master@{#714081}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I3d538948fc753f31601a42894448f66d00d0003f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906342Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714080}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/eddbd257ba24..9b2e22593bbf git log eddbd257ba24..9b2e22593bbf --date=short --no-merges --format='%ad %ae %s' 2019-11-09 vapier@chromium.org run_tests: run xbuddy unittests inside the SDK Created with: gclient setdep -r src/third_party/chromite@9b2e22593bbf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Iba6409567304e10c26af9ce83f93aa37485e0abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907600Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5c0e6e52bd5e..012d15196023 git log 5c0e6e52bd5e..012d15196023 --date=short --no-merges --format='%ad %ae %s' 2019-11-09 jdarpinian@chromium.org Stop using __has_include<Cocoa/Cocoa.h> Created with: gclient setdep -r src/third_party/angle@012d15196023 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: chromium:1015591 Change-Id: I680677f2c716bb02849aec42726c9101006a5eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907167Reviewed-by:
-
Etienne Pierre-doray authored
Change-Id: Ic9ec415c89d5637ccc992abeeacb4b72c847411a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906629Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#714077}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/33f2ff73aa70..eddbd257ba24 git log 33f2ff73aa70..eddbd257ba24 --date=short --no-merges --format='%ad %ae %s' 2019-11-09 achuith@chromium.org dev_server_wrapper: Conditionally import cherrypy. Created with: gclient setdep -r src/third_party/chromite@eddbd257ba24 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I949fa010c5b68d212af05bc6dd9296c9e96c4dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907712Reviewed-by:
-
