- 18 Nov, 2019 40 commits
-
-
Peter Kasting authored
Previously, ChromeTypographyProvider overrode these to implement the Harmony colors. This override makes it harder to understand where colors are set or to control how native themes interact with Chrome's built-in colors. Oversights in the ChromeTypographyProvider also led to bugs, e.g. unreadably dark text in disabled textfields in dark mode. Instead this pushes the Harmony colors down into the core classes. This has the following effects: * Users with the GTK theme enabled will now get GTK colors in cases where the ChromeTypographyProvider previously forced Harmony colors. This makes sense since these users are getting GTK colors, not Chrome colors, for all other aspects of secondary UI. * "Should ignore Harmony" native themes will now use correct color IDs for disabled buttons and message box bodies. * Windows non-high-contrast "should ignore Harmony" users (light mode, button text != black) will now get Harmony colors for buttons as well as unselected labels and textfields. It's not clear to me this is ideal, but we already fail to use some of the system colors for these users (for example, for dialog/bubble backgrounds), and the user segment should be small (Win 7 classic theme users who've customized their button colors). Long-term, I suspect the right course if we really care about these users is to supply a GTK-like "use system theme" mode for Windows. * The Chrome-side typography provider will now return the correct colors for disabled textfields and dark mode STYLE_LINKs. * After some research into the Harmony specs for its original intent, I changed STYLE_HINT from matching message box body text to matching disabled text. With some upcoming changes to disabled text colors, this will have the net effect of making the hint text a bit "fainter" (it should ultimately be #72777c/#8c9196 in light/dark mode instead of the current #5f6368/#9aa0a6). This also removes kColorId_ButtonHoverColor, which is unused, and uses the native selection background color for selected labels on Windows light mode, since I was touching that code anyway. Bug: 1024091 Change-Id: Idf62606ac6278289cf7f715979df105e4d9b9986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920433Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#716332}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/515a3848e23d..fa20b0b9db94 git log 515a3848e23d..fa20b0b9db94 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 zakerinasab@google.com Merge "Update Vulkan memory tracker counters" Created with: gclient setdep -r src/third_party/perfetto@fa20b0b9db94 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I38c0db25aacca12beae5627f33211111573d4713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921562Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716331}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/430d4059adb3..e4b3136913c6 git log 430d4059adb3..e4b3136913c6 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 syoussefi@chromium.org Update front-end image test failures' bug number 2019-11-18 syoussefi@chromium.org Vulkan: Fix col-major transformation of unsized arrays Created with: gclient setdep -r src/third_party/angle@e4b3136913c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=courtneygo@google.com Bug: None Change-Id: I2b9ae60b6459cac40ba60466cbbe0d981eb1d21d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917977Reviewed-by:
-
Jia authored
Add a field trial testing config. Bug: 881215 Change-Id: I8b1a911807df8f18cb44ab89259192cc11ff673a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921022Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#716329}
-
James Hollyer authored
We are eliminating base::Bind in favor of base::BindOnce and base::BindRepeating in order to be more explicit. While working on this issue I also went ahead and changed the Callback to RepeatingCallback and Closure to RepeatingClosure. Bug: 1007747 Change-Id: I4ee2fa0c375d8d102cee342603bb552153a6b50f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862866 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#716328}
-
Mirko Bonadei authored
This is a speculative CL to temporarily workaround the issue reported on crbug.com/1025796. It seems that starting from [1] the bot started to report errors like: >>> referenced by string_traits_wtf.cc >>> obj/mojo/public/cpp/bindings/wtf_support/string_traits_wtf.o:(sancov.module_ctor_8bit_counters) And they look quite similar to what was reported on crbug.com/912919 (which was blocked on the WebRTC component build support) and it that case the solution has been to temporarily switch back to release builds (see https://chromium-review.googlesource.com/c/chromium/src/+/1367652). [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1874722 TBR: ehmaldonado@chromium.org Bug: 1025796 Change-Id: Ic5261df5cd4569fb5b76ffc7d82e8aacc9d9191b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920824 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#716327}
-
Kai Uwe Broulik authored
This interface lets an application ask the file manager to scroll to and highlight a specific file in its parent folder. It is supported by at least KDE's Dolphin and Gnome's Nautilus and removes the need for filemanager-specific code. In case the interface is not available or the call fails, the parent folder is opened as before. Bug: 352988 Change-Id: Id4e2b61cc77a12698fe6f02b307c9b1e815ab4ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905947Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#716326}
-
Chris Cunningham authored
These are a relic of the blink/media divide that was recently flattened. Now we can just use the blink types. Removing the same for encodingInfo() will be done in a follow up CL. Change-Id: I7e53ce07322e3d97d4aa5ee0e679ed1c27ab67a9 TBR: rtoy@chromium.org Change-Id: I7e53ce07322e3d97d4aa5ee0e679ed1c27ab67a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914974 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#716325}
-
Chase Phillips authored
This test became flaky after https://crrev.com/c/1891461 which introduced a console deprecation notice for AppCache. Converting this test to a testharness.js test to mark its success explicitly once it reaches completion. Bug: 1022915 Change-Id: I42f707773f9a58bdb0a3a62a5d6d1648aa40dc33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917939 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#716324}
-
John Lee authored
Bug: 1023492 Change-Id: I368bafe618a885a5c068ba04dfb4a6e779514368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919744 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#716323}
-
chromium-autoroll authored
Roll airmont AFDO profile from 80-3945.24-1573469012-benchmark-80.0.3964.0-r1 to 80-3945.24-1574075354-benchmark-80.0.3964.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: Id4c4e7dff04a9d9a0500cdeb245e0ce1409bef05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922507Reviewed-by:
-
chromium-autoroll authored
Roll broadwell AFDO profile from 80-3904.92-1573478033-benchmark-80.0.3964.0-r1 to 80-3945.24-1574073272-benchmark-80.0.3964.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I7444dec6c7cb832fa8271b0795b89c3f6701c1b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920646Reviewed-by:
-
Edward Jung authored
Still need these metrics while we look for a replacement LinkDoctor service. Bug: 988708 Change-Id: Idd6816b8b8d7fbbfd885181ade39b02f43a486dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920176Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#716320}
-
Emircan Uysaler authored
This can be useful for low memory devices. This CL enables setting it as a LayerTreeSettings param and modifying it via command line. Bug: 1025408 Change-Id: Ica54c44525c9c5dab08422e9f3e1dd0ed2a12f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919949Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#716319}
-
Rakesh Soma authored
Change-Id: I5a386d0aaff29657792c5ca7a5cc30451d7bec8d Bug: 1020797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918658Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#716318}
-
Alex Cooper authored
Updates all WebXR metrics to expire at the same time (July 1, 2020). WebXr rolls out to stable in M79 (~early December). Thus the new expiry corresponds with ~7 months of WebXr being released. Also updates several webxr owners who have transitioned off of chrome. Loosely the following replacements were made: billorr -> alcooper samdrazin -> xr-dev sumankancherla -> alcooper + mlamouri Fixed: 988697 Change-Id: Ib2415ed027795a8d3aa8204eaa247385688d4c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922329 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#716317}
-
Jesse Doherty authored
Change-Id: I5717898f8f8a38190001b4af6723a20ea0d33039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917424Reviewed-by:
-
Matthew Mourgos authored
Bug: 1012833 Change-Id: I41558269e892d27ebacfa2e060369680467f098f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919951Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#716315}
-
Tina Wang authored
Bug: 1025967 Tbr: johnchen@chromium.org Change-Id: I0a1dbc915683d76248c8392cb641978e8a7c5441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921637Reviewed-by:
Tina Wang <tinazwang@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#716314}
-
liberato@chromium.org authored
In order to track down a long-standing GPU hang on intel graphics devices on beta, this CL adds three finch flags that affect the D3D11VideoDecoder only. Since crashes seem to spike ~6X on beta compared to canary when this decoder is enabled, it provides an excellent opportunity to try out different behaviors to see which ones contribute to the spike in crashes compared to DXVA. The flags are: - don't enable MultiThreaded mode on the d3d11 device - always copy rather than bind decoded textures - don't mark VideoFrames as overlayable, even if they are Bug: 597700 Change-Id: I27d8b6af87b8684ec04566f4358d57379fa64c98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920028Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#716313}
-
rbpotter authored
Move the test stores out of suiteSetup() calls, and instead add cr/ui/store.js to the extraLibraries as needed. This will prevent the need to modify the js_modulizer tool when autogenerating a JS module version of the TestStore. Bug: 1022213 Change-Id: Iff7eb3ed65a46125bca5483be8a3b15e21c6fafb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920189Reviewed-by:
-
Lukasz Anforowicz authored
As pointed out in //docs/security/origin-vs-url.md, origins should be represented as url::Origin (not as GURL). This CL applies this guideline to predictor-related code and changes the type of the following fields from GURL to url::Origin: - OriginRequestSummary::origin - PreconnectedRequestStats::origin - PreconnectRequest::origin The old code did not depend on any non-origin parts of GURL (like path and/or query). Therefore, this CL has no intended behavior change. Bug: 973885 Change-Id: Idd14590b4834cb9d50c74ed747b595fe1a4ba357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895167 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#716311}
-
Sebastien authored
Bug: 1018201 Change-Id: I9752126b76ceed85f13bbf4636eb6fc87cef290d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921652 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#716310}
-
Samuel Huang authored
This CL adds the "META": {"align": align_value} field for resource_ids items, to specify that start ID of the item should be a multiple of align_value (preexisting default = 10). Also update the main resource_ids (and fix some missing "join"s), so that sections has a greater (>= 100) "align" value. In addition to making numbers look nicer, this also reduces the likelihood of large diffs in resource_ids when using update_resource_ids. Bug: 979886 Change-Id: Icd3b57a9670556d0858368ee14f2776aa6a9b530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921212 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#716309}
-
Kelvin Jiang authored
This CL adds an ALLOW type for a RequestAction, which is required for recording which rules have been matched via getMatchedRules and OnRuleMatchedDebug. Bug: 967942 Change-Id: I251c608425cf17ae762547ac97d8e4c1482a1928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894278 Auto-Submit: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#716308}
-
Nick Peterson authored
Bug: 988664 Change-Id: If3f198b3322546a9192f940119c782e60258b0ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921462Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Nick Peterson <nrpeter@chromium.org> Auto-Submit: Nick Peterson <nrpeter@chromium.org> Cr-Commit-Position: refs/heads/master@{#716307}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f86f81aa33da..7740980a8de4 git log f86f81aa33da..7740980a8de4 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 thestig@chromium.org Add CFWL_Widget::ScopedUpdateLock. 2019-11-18 thestig@chromium.org Make FSRECTFFromCFXFloatRect() return a FS_RECTF directly. 2019-11-16 thestig@chromium.org Roll build/ 381237e19..3ba4b9cdc (57 commits) 2019-11-16 thestig@chromium.org Roll tools/clang/ 22ecf175f..fdd604820 (14 commits) 2019-11-16 thestig@chromium.org Roll buildtools/ fce87d1a3..140e4d7c4 (4 commits; 1 trivial rolls) Created with: gclient setdep -r src/third_party/pdfium@7740980a8de4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Ibcba5604b24c27e9cbf5691f70833c0fb5397d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922254Reviewed-by:
-
Robbie McElrath authored
We don't currently schedule a seed download in WebView if the previous download occurred less than 24 hours ago, which can add an additional 24 hours to the time between seed downloads. This CL reimplements the 24 hour throttle to be a delay in the scheduled job, meaning a job will always be scheduled when a new seed is requested, but Android will only run the job once 24 hours have past since the last download. This CL also adds a missing hamcrest dependency to //aw/test:webview_instrumentation_test_apk Test: ninja -C out/aw webview_instrumentation_test_apk Test: out/aw/bin/run_webview_instrumentation_test_apk -f 'AwVariationsSeedFetcherTest#*' Bug: 979075 Change-Id: I0ea1cc8197f66b77634e8de2b145fe4228c74067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906121Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#716305}
-
Daniel Rubery authored
This flag has been deprecated since M76 and is not needed any more. Change-Id: Ie614630b930e3cfeaa016228b9e76102578a08b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917971Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#716304}
-
Megan Jablonski authored
Fix the close button location and the hover shadow shape to a circle on the close and more buttons. Also adjust the margins. Before: https://drive.google.com/file/d/1M0PEsK-l3RZZnyZpoZ3kiOKYeQyzseBY/view?usp=sharing https://drive.google.com/file/d/1BJ5NxsFsIKTb5aM0SKEQN3zFoQLEdUOC/view?usp=sharing https://drive.google.com/file/d/16vqHzbacBGV-l-jfSPiGN99x4VIV7D1t/view?usp=sharing After: https://drive.google.com/file/d/12A7lKLbZkIWYWtO3mh17cOVa06sHj0Mw/view?usp=sharing https://drive.google.com/file/d/1nFJvfbM-DCkjJ6xj29XCIut4h1a43MsY/view?usp=sharing https://drive.google.com/file/d/1iBGk3n6ALKG7oeL9jvxe2jx36CIsykjN/view?usp=sharing Bug: 1017498, 1017405 Change-Id: If80f6edd9b9dd05926fb8024404f349a2f1a970c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906933 Commit-Queue: Megan Jablonski <megjablon@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#716303}
-
Andreas Haas authored
In this CL we remove another use of ArrayBuffer in image_bitmap.cc, similar to https://crrev.com/c/1835659. However, this time it cannot be avoided to create a SkPixmap object, due to scaling and color settings. Therefore we still create the SkPixmap object to call scalePixels and setColorSpace on it, but then we only use info() and rowBytes() from it to create the SkImage from the initially allocated SkData. R=jbroman@chromium.org Bug: chromium:1008840 Change-Id: I82ad357db16f11139e799fbee4423a777d5c2a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916476 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#716302}
-
minch authored
Let the affordance to go back faster on reverse drag. See recorded video: https://drive.google.com/file/d/0B5I0jFeLxqIiZEs1bzNTbEdqV01VNUZFMkVrakhTUmVidkZF/view?usp=sharing Bug: 1022479 Change-Id: I4dac3aa6525be4364855836e7e871f61ef85d47a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918643 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
The layer tree mode is not supported in CompositedAfterPaint. Remove it and rewrite the tests so that the tests will pass in CompositeAfterPaint. Change-Id: Ided24dc50b6804397777fec8fbce45d8d6cb3174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918295Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#716300}
-
Manu Cornet authored
Bug: 1011110 Change-Id: Id6173a911fd4fbc3b85ceb90dfc56901f3c796b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922266Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#716299}
-
Takumi Fujimoto authored
CastMediaNotificationProvider depends on MediaRouter, which is a keyed service. So the instance held by MediaNotificationService needs to be destroyed in Shutdown(). Change-Id: Idf522c88838f2acc4116005865379b76428bbada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919754Reviewed-by:
-
Mason Freed authored
Because the origin trial system cannot (yet) support file:// URLS for re-enabling deprecated features, we will temporarily re-enable WCv0 for all file:// URLs. Additionally, this CL renames the function RequiresHtmlImports() to RequiresWebComponentsV0(), as that is more descriptive of how it is used. Bug: 1021137, 1025782, 937746 Change-Id: I54a4794334edeaa25b3e4c2102be60f118f2372b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920482 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Lei Zhang authored
PDF accessibility code would like to get all the links and images on a particular page. With links for example, there are two methods: - uint32_t GetLinkCount(); - bool GetLinkInfo(uint32_t;link_index); The accessibility code has to call GetLinkCount() and then call GetLinkInfo() multiple times. Instead of doing this, just have a unified std::vector<AccessibilityLinkInfo> GetLinkInfo() method to get all the link info at once. Do the same simplification for image info. Bug: 981448 Change-Id: I8ccb9b70d69998f4a6c3a8bf365781d91456a254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917954Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#716296}
-
Aaron Gable authored
By virtue of being FYI builders, these builders were specifying 4 cores, which doesn't work so well for macs which always have 8. This CL brings them into line with the other non-FYI mac builders, which don't specify a core count at all. Bug: 1018846, o/35112879 No-Try: True Change-Id: Ic4bbebe62651824b548e2195a5042d64d90e1aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918394 Auto-Submit: Aaron Gable <agable@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#716295}
-
Jesse Schettler authored
Bug: b:144701221 Test: android-sh -c getprop | grep ro.boot.arc_print_spooler Change-Id: I7336cce9687369dc7e62558694c8378b46aab0a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921338Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#716294}
-
Rayan Kanso authored
It would be good to know how often shared addresses return only an address string without any derived fields. Change-Id: Ibbe4273bdd42bb95bdefc7ebafc04a701ddab3cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919346 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#716293}
-
