- 29 Feb, 2020 23 commits
-
-
Lily Chen authored
This makes it easier to debug cookie issues, as the SameSite cookie context is calculated based on these two parameters. Bug: None Change-Id: I05bf03533fb1a481fc71a610971da9f8e40de2f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068580 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#745699}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=boliu@chromium.org Bug: 1026641 Change-Id: I444e19558bbb66741294e1b7035fc1897062906e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078659Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#745698}
-
Li Lin authored
In some cases (clicking on top of the screen in full screen mode), there are not enough space to show Quick Answers view above the context menu. We would like to show it below the context menu instead. Mock at: go/quick-answers (slide 20). This CL also update the hover background color to match the context menu item hover background color. Bug: b/150388694 Change-Id: I281d091ecb8f8b039cda902c331f92db61fbaa4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079044 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#745697}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/953278adbf3e..55ab41d1856d git log 953278adbf3e..55ab41d1856d --date=short --first-parent --format='%ad %ae %s' 2020-02-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-28 ehmaldonado@google.com depot_tools: Make it possible to run custom git scripts using Python 3. 2020-02-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@55ab41d1856d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:984182 Tbr: agable@chromium.org Change-Id: I80b6cd4826d9f322523465673f56b6616207a7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080991Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745696}
-
Yulun Wu authored
Other changes: Add test methods to drag_handle class Modified shelf_widget GetDragHandle() to return DragHandle* instead of View* Modified DragHandle::ShowDragHandleNudge() to fetch timeout for current pref instead of taking it as an argument. Fixed bug where ShowDraghandleNudge did not call handleNudgeShown. Revert "Revert "Add unit tests for drag handle nudge."" This reverts commit 4b6df1eb. Bug: 1034168 Change-Id: I73258ce83cd681a936fec907b04ef065b6d10592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080558Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#745695}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fb551728d77b..54bc3dab2064 git log fb551728d77b..54bc3dab2064 --date=short --first-parent --format='%ad %ae %s' 2020-02-28 geofflang@google.com Add the ANGLE Android developer options to the ANGLE repository. 2020-02-28 xiaoxuan.liu@arm.com Vulkan: Add robust init for NULL texture image. 2020-02-28 b.schade@samsung.com Add Android boot animation and rounding error test Created with: gclient setdep -r src/third_party/angle@54bc3dab2064 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: I6aafa12c1906e41bff26255e6cfa7f781967f76a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080730Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745694}
-
Pavel Yatsuk authored
This CL moves InfoBarControlLayout, InfoBarMessageView, tests and related resources to chrome/browser/ui/messages BUG=1056346 R=mdjones@chromium.org Change-Id: I2d24ae99bcbe2186486154c883288eb6ddecb50a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076398 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#745693}
-
Brian Sheedy authored
Disables BrowserMinidumpTest on Linux since there are unexpected crashes occurring either in the test or in previous tests which are causing it to fail. TBR=crouleau@chromium.org Bug: 1056235 Change-Id: I7d03de0f09df52c2ab6cb3f45809a71357500650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080080Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#745692}
-
Dale Curtis authored
https://chromium.googlesource.com/external/github.com/videolan/dav1d.git/+log/296d1dc00641..d398da88c0b6 $ git log 296d1dc00..d398da88c --date=short --no-merges --format='%ad %ae %s' 2020-02-17 janne-vlc fuzzing: link the fuzzing binaries as C++ 2020-02-17 janne-vlc fuzzing: split the fuzzing targets to their own meson.build file 2020-02-20 gramner x86: Add mc w_mask 4:4:4 AVX-512 (Ice Lake) asm 2020-02-20 gramner x86: Add mc w_mask 4:2:2 AVX-512 (Ice Lake) asm 2020-02-20 gramner x86: Add mc w_mask 4:2:0 AVX-512 (Ice Lake) asm 2020-02-20 gramner x86: Add mc avg/w_avg/mask AVX-512 (Ice Lake) asm 2020-02-14 victorien x86: optimize cdef_filter_{4x{4,8},8x8}_avx2 2020-02-12 victorien x86: add a seperate fully edged case to cdef_filter_avx2 2020-02-19 gramner checkasm: Improve the cdef input randomization algorithm Created with: roll-dep src/third_party/dav1d/libdav1d TBR=tguilbert Change-Id: Ic1389410c6338ad343bfdffb132e8f4a38960845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080893Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#745691}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=sorin@chromium.org Bug: 1026641 Change-Id: Id06e6e33fc0031390bc227a698af034b7da15385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079082 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#745690}
-
Ben Joyce authored
Bug: 1052460 Change-Id: I9b9530362c4a17f78ee6f0907f15527c6fd4f99b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078848Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: benjamin joyce <bjoyce@google.com> Cr-Commit-Position: refs/heads/master@{#745689}
-
Jerome Jiang authored
https://aomedia.googlesource.com/aom.git/+log/625cded0550b..f83d681765cd $ git log 625cded05..f83d68176 --date=short --no-merges --format='%ad %ae %s' 2020-02-27 jingning Reduce the tpl model memory usage 2020-02-27 huisu Remove mi_row and mi_col from CFL_CTX 2020-02-27 kyslov AV1 RT: Tune pruned ref frame search for nonRD 2020-02-14 deepa.kg Do not split 32-byte unaligned load and store 2020-02-26 jingning Remove unneeded if condition in tpl model 2020-02-26 jingning Use local variable to count tpl frames 2020-02-25 huisu Assign gld_stack frames to ALTREF2 when applicable 2020-02-25 marpan rtc: Add source content metrics to nonrd_pickmode 2020-02-26 jzern update .mailmap 2020-02-20 huisu Code refactoring in av1_get_ref_frames() (...) 2019-01-31 niva213 avx2 dr prediction z2 valgrind issue fix 2019-02-01 chiyotsai Add av1 prefix to partition model parameters 2019-01-31 urvang Introduce SUPERRES_AUTO mode. 2019-01-30 remya.prakasan Reuse compound type rd data for new_mv 2019-01-31 elliottk Remove template for collect rd stats; it is always on 2019-01-25 yunqingwang Handle unsupported bitstream while large-scale-tile=1 2019-01-30 debargha Misc fixes for RD stats collection 2019-01-31 yuec Prevent mismatch when chroma diff q is enabled 2019-01-28 satish.suman Revert decoder frame buffer padding to 64 2019-01-31 satish.suman Fix crash issue of oss-fuzz stream for frame padding Created with: roll-dep src/third_party/libaom/source/libaom R=jzern@google.com BUG=1055917 Change-Id: I397227b8db1eb7316b8b73c7073aa186d0607b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080723Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#745688}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=mmenke@chromium.org Bug: 1026641 Change-Id: I27367524acb218264fa4b61471a128da637a2b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079074 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#745687}
-
Wez authored
Add fuchsia.memorypressure.Provider to the test sandbox, so that test suites don't report errors connecting to it. Bug: 1020698 Change-Id: I15f7a0b3faaddf973c22fd72f215f533c00be695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072217 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#745686}
-
Jun Cai authored
This CL converts base::Bind and base::Callback in //ppapi/shared_impl to Once or Repeating Bug: 1007817 Change-Id: I5045b05239dfe9302b4df5bb035f709123de3bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080856Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#745685}
-
Stephen McGruer authored
This diff was generated by running: find . -type f -print0 | xargs -0 perl -pi -e 'BEGIN { $/ = undef; } s/assert_throws\(([ \n]*)new ([A-Za-z]*Error) *(, *.)/assert_throws_js(\1\2\3/gs' Then making the following manual changes: * Whitespace fixups * custom-elements/constructor-context-dies-cross-context-call.html - using right global * fast/dom/dataset.html - using assert_throws_dom * presentation/presentationrequest-ctor.html - using assert_throws_dom Bug: 1051932 Change-Id: I220ebd9d4388685506332e8c51ed552284aba3c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078846 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#745684}
-
Yue Zhang authored
http://crrev.com/c/2023197 makes message card adapt to the span count when it changes. This is achieved through updating the span size based on spanCount that we calculate when orientation change is detected. However, there is a corner case where the span size lookup happens but the orientation change is not detected and therefore the spanCount is not updated. This CL fixes this issue by letting SpanSizeLookup() to dynamically get the current span count from GridLayoutManager instead of replying on a calculation when orientation change is detected. Also, this CL adds some render tests for the IPH message card so that we have some coverage on the orientation change related logic. Bug: 1050494 Change-Id: Ie86a8583db926c41a46451a1c5eff3c6a4a5ec54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076550 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#745683}
-
James Cook authored
"setting-box.middle" doesn't match anything. Before: http://screen/V28K1n5VXqZ http://screen/MfXDMJpGHVt After (unchanged): http://screen/R6mUCiqbXpP http://screen/U3Fc6LTTBNP Bug: none Change-Id: If741302d192b248c988d30aa892231cc252c189f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079015 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#745682}
-
Peter Kasting authored
Still many, many more to convert. Bug: 1056332 Change-Id: I19d411d7583031779bad0a8ff4da4699df6df284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080046Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#745681}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=jkardatzke@chromium.org Bug: 1026641 Change-Id: Ia186179ca831edf161da9a31a249e175444bca41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078665Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Commit-Queue: J Kardatzke <jkardatzke@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#745680}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=jkardatzke@chromium.org Bug: 1026641 Change-Id: Id008ffcead00c6787d40b56c9370d09b56df87bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078418 Commit-Queue: J Kardatzke <jkardatzke@chromium.org> Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#745679}
-
Brian Geffon authored
The inotify_reader thread is a dedicated thread and ScopedBlockingCall is not needed here. It's polluting slow reports. Bug=CHROMIUM:1057202 Change-Id: I42cadcc9b1f7553252e5643c3af080fdd7d53b77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078981 Auto-Submit: Brian Geffon <bgeffon@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#745678}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/55f681faf391..7122d8cec827 git log 55f681faf391..7122d8cec827 --date=short --first-parent --format='%ad %ae %s' 2020-02-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-28 mtklein@google.com sqrt 2020-02-28 nifong@google.com Add WASM os target to public.bzl 2020-02-28 jvanverth@google.com Drain autorelease pool after each bench run. 2020-02-28 mtklein@google.com index 2020-02-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-28 herb@google.com SkVM round test 2020-02-28 mtklein@google.com i16x2 ops 2020-02-28 borenet@google.com [recipes] Re-order DM flags in test.py 2020-02-28 fmalita@chromium.org [skottie] Fix handling of time-reversed precomp layers 2020-02-28 mtklein@google.com bit_clear, pack, round, and a TODO for assert 2020-02-28 mtklein@google.com allow fmas 2020-02-28 mtklein@google.com select + stores 2020-02-28 kjlubick@google.com [canvaskit] Roll to v0.13.0 2020-02-28 robertphillips@google.com Add GrSimpleMeshDrawOpHelper::CreateProgramInfo 2020-02-28 bsalomon@google.com Simplifications to GrTextureProducers 2020-02-28 westont@google.com Format GN, isn't checked in third_party, so missed it the first time. 2020-02-28 fmalita@chromium.org [skottie] Add support for text grouping alignment 2020-02-28 egdaniel@google.com Fix CompatibleCoverageAsAlpha flag when reducing src-over to src. 2020-02-28 rmistry@google.com Exclude G3 trybot for non-master branches 2020-02-28 herb@google.com Generate the correct instruction for neq_f32. 2020-02-28 nifong@google.com Add a condition to prevent a thread annotation meant for blaze from showing up to emscripten 2020-02-28 westont@google.com Add Dawn on Windows job. 2020-02-28 jlavrova@google.com Bugs 2020-02-28 mtklein@google.com fix bitcode 2020-02-28 mtklein@google.com fill out loads, uniforms, and gathers 2020-02-28 mtklein@google.com initialize once 2020-02-28 herb@google.com Add comparisons (eq|neq|gt|gte)(i32|f32) 2020-02-28 fmalita@chromium.org [skottie] Fix default character transform origin 2020-02-28 herb@google.com Add shl_i32, srs_i32, and shr_i32 ops 2020-02-28 bsalomon@google.com Disable Programs test on TechoSpark3Pro Release 2020-02-28 bsalomon@google.com Remove code from GrTextureMaker that tries to make a MIP map copy. 2020-02-28 mtklein@google.com add mad, to_f32, trunc 2020-02-28 mtklein@google.com simplifications 2020-02-28 robertphillips@google.com Rename 'dstView' to 'outputView' to avoid confusion w/ 'dstProxyView' 2020-02-28 csmartdalton@google.com Revert "Move setupGeometry() from GrGLGpu to GrGLOpsRenderPass" Created with: gclient setdep -r src/third_party/skia@7122d8cec827 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I465d905fc0af29d5af5be52473c0b5811fbbe28b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080725Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745677}
-
- 28 Feb, 2020 17 commits
-
-
Sorin Jianu authored
Mechanical change. Change-Id: I181a9f660529f167878ea1d0ff95a919fbea1b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080858Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#745676}
-
Collin Baker authored
Change was reverted due to benign TSan failures. They should be gone as of https://crrev.com/c/2076278 This is a reland of 756673ee Original change's description: > Enable WebUITabStrip in fieldtrial_testing_config.json > > Bug: 1009881 > Change-Id: I0c784e4ac16bb14e5515b95680adfea3b5e3148c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069499 > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Commit-Queue: Collin Baker <collinbaker@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744385} TBR=jwd@chromium.org Bug: 1009881 Change-Id: I9bcb92aa29bcbf8d4d03e54b00b80d3b7b3826b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079646Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#745675}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bab986cc. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I9601355de8bd5d2f740c201a1d8bd3e9ac9851c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079647Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745674}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea63c21e644f..5871deb30826 Created with: gclient setdep -r src-internal@5871deb30826 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1057083 Tbr: jbudorick@google.com Change-Id: I434584da461087cc7937fd8f07c25ad44e1d5a6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080724Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745673}
-
Tim Song authored
BUG=1040648 Change-Id: I889021d0515c1246f3dce3ca8c69f5964f8a04e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079673Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#745672}
-
Sean Kau authored
We handle some uris for printers in chromeOS. Add a fuzzer for our usage of the url parser. Bug: None Change-Id: Ica7098f6f9d5e7fa90244f9cf36de30d44a603a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079133Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#745671}
-
Chris Mumford authored
TBR=kyleju@chromium.org Bug: 1047818 Change-Id: I1a3d001dbb3f901044dc084afc45b0915d80ffc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080557Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#745670}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=dominickn@chromium.org Bug: 1026641 Change-Id: I459605163ef0c2a48b8e6e803721c5a16dd80ef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078658 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#745669}
-
dalyk authored
This text field is used in secure mode to allow custom configuration of secure DNS templates. The underlying templates pref is only updated to a value from the custom text field upon validating that the value is formatted correctly. This validation occurs when the custom text field has been blurred. Change-Id: I17f6bbc47ca37087ea11ebc29e61608cbe3a25cb Bug: 1040145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984254 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#745668}
-
Jack Lynch authored
This CL adds telemetry for keyboard shortcut usage, which will help us evaluate the success of the upcoming custom keyboard shortcut and settings discoverability experiments. Discrete actions are added for each of what we expect to be the most-used shortcuts in the most-used tools (e.g. debugger.step), and other shortcuts are recorded in an OtherShortcut bucket. There is a corresponding CL in the DevTools frontend to log these actions: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2053105 Design doc for custom keyboard shortcuts: https://docs.google.com/document/d/1oOPSWPxCHvMoBZ0Fw9jwFZt6gP4lrsrsl8DEAp-Hy7o/edit?usp=sharing Change-Id: Icbf579880e983c1c25b76f1fb1dd8672c1bd3402 Bug: 174309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053084 Commit-Queue: Jack Lynch <jalyn@microsoft.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#745667}
-
Carlos IL authored
This test had the wrong expectations in cases where kPassiveMixedContentWarning was enabled and kMarkHttpAsParameterDangerWarning was disabled. This fixes that and re-enables the test. Bug: 1052731 Change-Id: Ibfe5ee7c10230eb2fb62c76d14e4cfb31e505ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078909Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#745666}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e299afa9ec11..3ded65e8072e git log e299afa9ec11..3ded65e8072e --date=short --first-parent --format='%ad %ae %s' 2020-02-28 enga@chromium.org Default initialize all descriptors Created with: gclient setdep -r src/third_party/dawn@3ded65e8072e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I14730a8bbe9addff8b38a4b20d7f8f0301d4a5cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079438Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745665}
-
Wez authored
ComponentContextForCurrentProcess() returns a sys::ComponentContext connected to the process' incoming service directory, outgoing directory for services & debugging APIs, etc. Provide a TestComponentContextForProcess, which overrides the process' ComponentContext with one which by default has no services available, and which allows services to be provided by the test itself, and for services available in the test process environment to be exposed to the test. This is a re-land of https://chromium-review.googlesource.com/c/chromium/src/+/2064908 with fixed Debug build. Also added TODO to migrate to ComponentContextProvider. Bug: 1038786 Change-Id: I401ce50a948b5426ac3b4ebb6e9a75674edf7011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077912Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#745664}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/96c6bce9e4f3..933525c2bdcf git log 96c6bce9e4f3..933525c2bdcf --date=short --first-parent --format='%ad %ae %s' 2020-02-28 cjamcl@chromium.org Audits: Roll Lighthouse to front_end/third_party Created with: gclient setdep -r src/third_party/devtools-frontend/src@933525c2bdcf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:772558 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I998a4ad965425418908b026a135e2b4a72cc057f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080715Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745663}
-
Anastasia Helfinstein authored
A recent change to how the Switch Access extension is loaded caused the Switch Access menu and Switch Access back button (both rendered in the SwitchAccessPanel) to stop showing up. This change fixes the string referencing menu_panel.html to match the new relative path. TBR=dtseng@chromium.org Bug: None Change-Id: I64d39e623c7d81ecf197ab9b5c35b83c2cecfd3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079269Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#745662}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c6bde393..2d7b0de1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1aa9271dc18460dce5956518e18325a581eded2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079645Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745661}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4f489240742b..953278adbf3e git log 4f489240742b..953278adbf3e --date=short --first-parent --format='%ad %ae %s' 2020-02-28 sokcevic@google.com Print content of description backup on exit 2020-02-28 ehmaldonado@chromium.org Revert "my_activity.py: Run using vpython3 by default." Created with: gclient setdep -r src/third_party/depot_tools@953278adbf3e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I974d539ca51c32bfaa01a359c8ed1b4f9e44619e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080722Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745660}
-