- 11 Jul, 2019 40 commits
-
-
Eric Stevenson authored
212f516e changed the way R.java files work so that all resources are stored in a base R.java file, but accessed through R.java classes that subclass the base R.java. Currently for synchronized proguard, we combine all of the jars produced by the APK's java_library_impl() step. This dedupes class files, but also requires classes with the same name to be identical. With R.java inheritance, each APK will have a base module R.java with different contents, and Chrome will crash at runtime due to missing resources. We can't just rename the base module name in the various APKs that are part of synchronized proguarding because the subclass R.java files can only be included once, and can only have one direct superclass. Instead of creating a more complex R.java class hierarchy, this CL changes the compile_resources() step of the static library APK to generate a base R.java that contains the resources of both Chrome and Webview. Bug: 901465 Change-Id: Iaa2a05c75cd431b95afe6318da8c7982fffbc242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695699 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#676552}
-
Carlos IL authored
The data from this histogram is currently being used for efforts to change the optionally blockable mixed content UI. Change-Id: I43df2f777e6b96bc7b99615e4eb4f8784c1d7b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692450 Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#676551}
-
Danan S authored
Bug: 927957 Change-Id: Ice1b2239f8b8c5444be1c289b41d4fec09f0a3ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692730Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Danan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#676550}
-
yilkal authored
Bug: 977019 Change-Id: I4700f1c0a94951bccf0c521dde1b9790705f5f76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676875 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#676549}
-
Yi Fan authored
Mixer thread somehow gets stuck forever, not able to recover. Using ThreadHealthChecker to workaround Bug: b/136353019 Test: build & run Change-Id: Ifbc0bd1bca1da88124e5fc326e8db296f825a6d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697317Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Yi Fan <yfa@chromium.org> Cr-Commit-Position: refs/heads/master@{#676548}
-
Ian Vollick authored
This is a temporary fix until we can convert this dialog to using modal dialog properties (and thereby use the touchless modal dialog presenter). This change was pair-programmed with mahmoudi@ Bug: 982869 Change-Id: If4f24ff1ecdf7584af3ca64983ae6533edf2a3b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696344 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#676547}
-
Matthew Cary authored
base::SharedMemory, which is being deprecated, exposes a utilty method GetHandleLimit() which needs to be moved somewhere. process_metrics.h seems to be a more appropriate place for this anyway over base::SharedMemory. Bug: 795291 Change-Id: I1562cca6445c362654ba4a52195c0ec4d53757ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695284 Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#676546}
-
Abhijeet Kandalkar authored
This CL removes the unused definition of ToElementOrNull as all the occurrences of ToElementOrNull() is already replaced with DynamicTo<Element>. This CL uses To<Element> and CHECK() in place of ToElementOrDie() and removes subsequent definition of ToElementOrDie(). Bug: 891908 Change-Id: I41328a58a8540aa1a981ed3f5609585e92865001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692761Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#676545}
-
Tarun Bansal authored
Add field trial to throttle browser initiated traffic when there are active P2P connections (that may be streaming real time content). The browser initiated traffic is throttled for a limited duration and only if: (i) There are active P2P connections (ii) Traffic annotation tag matches one of the tags specified using finch. (iii) Network is estimated to be congested (currently a simple check that looks for effective connection type). Bug: 913424 Change-Id: I111bbf9eea1243d7f2194bc489034545bd18aee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693394 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#676544}
-
Suman Nelson Kancherla authored
This is a no-op. All that is done is to separate DFM and ArCore install into a separate class and call the install API from consent dialog instead of from ArCoreDevice. Bug: 907591 Change-Id: I742db94cf896a4955d4de1938d7323d19a04664e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694401Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Cr-Commit-Position: refs/heads/master@{#676543}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f3dce1123b38..4cd9767e6565 git log f3dce1123b38..4cd9767e6565 --date=short --no-merges --format='%ad %ae %s' 2019-07-11 capn@google.com Fix reporting VK_ERROR_OUT_OF_HOST_MEMORY Created with: gclient setdep -r src/third_party/swiftshader@4cd9767e6565 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/137093675 TBR=swiftshader-team+autoroll@google.com Change-Id: I93a60bcbad0e4b80b7db6791a3e04ca18c490b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697365Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676542}
-
Doug Arnett authored
Adds DeferAllScript enabled status display and flags link to intervention-internals page. Bug: 965277 Change-Id: I2fc616b3db3e1e12e60972bf8beccaf7ef2625be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696360 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#676541}
-
Francois Doray authored
Crash reports indicate that TabSwitchTimeRecorder::RecordHistogramsAndTraceEvents is occasionnally called with |tab_switch_start_state_| being nullopt. However: - TabWasShown() sets |tab_switch_start_state_| and issues a RecordHistogramsAndTraceEvents() callback. - RecordHistogramsAndTraceEvents() expects |tab_switch_start_state_| to be set, and resets it before returning. - TabWasHidden() invokes RecordHistogramsAndTraceEvents() directly and invalidates previous callbacks issued by TabWasShown(). For the crash to happen, there must be multiple calls to TabWasShown() without the tab being hidden in between, which shouldn't happen. This CL makes the following changes: - Dump without crashing when TabWasShown() is called and |tab_switch_start_state_| is set (indicates that neither TabWasHidden() nor the RecordHistogramsAndTraceEvents() were invoked since the last call to TabWasShown()). - Invalidate previous callbacks issued by TabWasShown(), to prevent the crash from happening. A version of this CL without the call to DumpWithoutCrashing() should be merged to M76 branch before it is promoted to stable. Bug: 981757 Change-Id: Ic67c696022a73eb21c2ad48577f5e22c176f7987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695747Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#676540}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/67a281286c52..944f7dee7dc1 git log 67a281286c52..944f7dee7dc1 --date=short --no-merges --format='%ad %ae %s' 2019-07-11 rsavitski@google.com fix one more instance of uint!=int in test 2019-07-11 rsavitski@google.com rm stray semicolon 2019-07-11 lalitm@google.com Merge "base: add waitable event header" 2019-07-11 lalitm@google.com trace_processor: properly handle and expose parent upids 2019-07-11 lalitm@google.com Merge "trace_processor: add kthreadd process if it doesn't exist" 2019-07-11 treehugger-gerrit@google.com Merge "Add chrome categories to perfetto record page" 2019-07-11 ilkos@google.com Merge "Add original anon and swap value" 2019-07-11 lalitm@google.com Merge "trace_processor: stop making diff tests depend on utid and upid" 2019-07-11 ilkos@google.com Merge "Add android package list proto" 2019-07-11 taylori@google.com Merge "perfetto-ui: Improve horizontal scrolling speed" 2019-07-11 rsavitski@google.com fix test comparison signs for chrome roll 2019-07-11 rsavitski@google.com Merge "args table: correct sort/filter behaviour for int-like & string-like objects" 2019-07-11 khokhlov@google.com Merge "Make JSON exporter compatible with a new version of jsoncpp" 2019-07-11 fmayer@google.com Merge "Roll clang. Make buildtools depend on default_deps." 2019-07-11 fmayer@google.com Add libtinfo5 to kokoro container. 2019-07-11 fmayer@google.com Merge "Use hermetic linker instead of system one." 2019-07-11 eseckler@google.com Merge "startup writers: Commit locally buffered data in batches" Created with: gclient setdep -r src/third_party/perfetto@944f7dee7dc1 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:136635390 TBR=perfetto-bugs@google.com Change-Id: I0dead33b4981e81d3454c210dde8422be865cf1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697366Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676539}
-
Abigail Klein authored
Introduce new text track properties for the window surrounding webvtt captions and wire them to the WebVTT caption display tree HTML element. This looks like an element surrounding the captions cue with 1% padding, rounded corners, and spanning the width of the video. If the user settings do not set the window to be visible, do not give it padding. To test, open a video that has a WebVTT captions file. For example, https://www.iandevlin.com/html5test/webvtt/html5-video-webvtt-sample.html and http://mounirlamouri.github.io/sandbox/webvtt/regions-inline-styling.html are nice examples. To change the window style, open System Preferences > Accessibility > Captions and add a new captions/subtitle style. I explored several options to have the window not span the width of the video, as it seems more visually pleasing, and wouldn't block as much of the video. The options investigated were: 1. Make the window a flexbox element. This would require a refactor of: a. The media controls layout, or b. The algorithm to position the captions above the media controls. 2. Make the window a span surrounding the captions cue (prototype: https://www.software.hixie.ch/utilities/js/live-dom-viewer/?saved=7043). This would mean the window would appear more like a border to the captions cue, rather than a block surrounding the captions, which I believe is the intention. Since caption styles for mac are now behind a feature flag, we can come back to one of these options in a follow-up if we prefer the aesthetic of the captions window not spanning the entire width of the video. Now that the captions cue has 1% padding, the captions cues take up more space, and cues stacked on top of each other will be farther apart when the window is visible. Bug: 897730 Change-Id: I98844d1ca09f350c034156661ccb2f507419fe5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658914Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#676538}
-
Javier Ernesto Flores Robles authored
Dynamic colors are resolved before assignment as a workaround for a bug in MDCButton, where the colors are used in a CALayer which has no traits. Bug: 976640 Change-Id: I4af4322296e21bc39301e749207f0cc720947cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695297 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#676537}
-
Orin Jaworski authored
This CL makes OpenSearch description document fetching more robust by timing out old failed requests and retrying requests that would otherwise silently fail due to network change. Bug: 956689 Change-Id: I26e21194ea8911916b7766b3a6eb47d6d35643c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688437 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#676536}
-
Daniel Nicoara authored
This is disabled by default on regular builds to conserve space. Enable it in tests to gain coverage. Bug: None Test: None Change-Id: I215b80df0c2f7594310e94acb0e6ff313dd659ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678817Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#676535}
-
Alex Moshchuk authored
Bug: 975945 Change-Id: I6a9413d1f89cea042df59a99e5df7c4e72c3dd46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693482Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#676534}
-
Shivani Sharma authored
This CL changes the browser test to actually send a user gesture to a frame instead of calling the user activation API UpdateUserActivationState to be sure that the user activation API gets invoked correctly. *OnUserGestureResetSameDocumentEntriesSkipFlag Test: content_browsertests --gtest_filter= Bug: 907167 Change-Id: I4764f084095a162d5a6d0a7f603cdf3201c41d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690707Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#676533}
-
Fredrik Söderquist authored
When loading of images is disabled, ResourceFetcher will return an ImageResource{,Content} whose status is "not started". Since this resource will not get a "finished" notification, we didn't update the <img> to show fallback content when the image is first requested. Subsequent loads would yield the fallback correctly because the cached resource was returned. Add a case to ImageLoader::DoUpdateFromElement() to check for this case and call NoImageResourceToLoad(). Bug: 982603 Change-Id: I6377f87a45745c364f92ceb0e8c4dabd4fbc1b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695549Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#676532}
-
Scott Haseley authored
Setting expiry to M79 for various TabManager metrics that were previously set to M77, M78, or unset. Bug: 975494, 975864 Change-Id: I8cc98cbb8ef518f5e139dda033a7996db800a133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696530Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#676531}
-
Fredrik Söderquist authored
This collection of predicates are pretty intricate, and are a better fit for ImageLoader, so move them there into a new method called ImageIsPotentiallyAvailable(). Bug: 982603 Change-Id: I4825d833809cda7a9daa153a58c18d6fcbd92048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697650Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#676530}
-
Rayan Kanso authored
Change-Id: Ie80bd509889ce66372bd95b59cf75a9b7571723a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697251 Auto-Submit: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#676529}
-
Egor Pasko authored
I found that crazylinker tests are special enough not to be run during regular testing. I fixed a small issue and added a document about a few non-trivial-to-discover ways to test the crazylinker in Chromium checkout. After the fix all the off-CQ testing described in the doc passes on my Nexus5X, with the exception of fuzzers - I did not run those. Applying TBR for docs only. TBR=rmcilroy@chromium.org Bug: 981599 Change-Id: I7ead0ef59c6b402729393ba273798107afefed46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695309Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#676528}
-
Kristina Nelson authored
Previously these histograms were based off another histogram which resulted incorrect description and boolean bucket labels. Bug: 815290 Change-Id: I7fb9ced71e403317592c9f2adb8c6546b0ced4e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690814 Commit-Queue: Kristina Nelson <krstnmnlsn@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#676527}
-
Chris Blume authored
$ git log 76aabbd35..14eba7add --date=short --no-merges --format='%ad %ae %s' 2019-07-09 chrdavis Fix static const data duplication Change-Id: Iebb764e1af1ed4b7dd904f20e318549049207749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696481Reviewed-by:
Jonathan Wright <jonathan.wright@arm.com> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#676526}
-
jonross authored
The main expectation for scrollbar-layer-placement-negative-z-index-child has been changed: https://chromium-review.googlesource.com/c/chromium/src/+/1694249 However with the test running again it encounters a blurring related to using GPU Raster. Updating the expectations for skia_renderer_gl_blink_web_tests to account for this. We'll need the flag specific rebaseline. TBR=backer@chromium.org TEST=skia_renderer_gl_blink_web_tests Bug: 954328 Change-Id: I0fb92ff7ad7d6f463a28a0d45ae83c7af211011e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697305Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#676525}
-
Adam Langley authored
Several sites have not set a value for userVerification in either create or get calls. This means that they end up with “preferred”, which is generally not what they want. This change adds a warning to the console in this case. The warning can be silenced by explicitly setting userVerification to any valid value. BUG=980972 Change-Id: Ide02de81f654c7101744bbc36d66b7c0dee00cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696170 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#676524}
-
Will Harris authored
This API can't be relied on as it needs the NtMapViewOfSection intercept to be in place, which is not always the case. There were no callers to this API anyway. Also, tidy up the hardcoded values to make them more readable. BUG=None Change-Id: Ib45b524f465a2730f9164eac987ffa8b35181243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696526 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#676523}
-
Jun Cai authored
Per comment at: https://bugs.chromium.org/p/chromium/issues/detail?id=953075#c17 This CL fixes the string for translators. TBR=reillyg@chromium.org Bug: 953075, 960960 Change-Id: I005aaea8a8232eefbc07b981c57ba5af7bab2ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695930 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#676522}
-
Khushal authored
R=sunnyps@chromium.org Bug: 980122 Change-Id: Id45d60eb7cea1682badf1a02cc18dae572f24e32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694246 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#676521}
-
Meilin Wang authored
The append and remove icons should be Google Grey 700 according to the spec. Also update the color of bookmark icon to keep consistency. Bug: 977265 Test: manually. Change-Id: Iee48f612e4e3784480469c3f9fe237e7268fece4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696531Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#676520}
-
Javier Ernesto Flores Robles authored
This allows the ToS to be rendered correctly for dark mode on iOS 13. Bug: 976640 Change-Id: I9e870b1bb979febbbd0255a63e130a20a4691f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691181 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#676519}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/741b96b175cb..4e5a41a08674 git log 741b96b175cb..4e5a41a08674 --date=short --no-merges --format='%ad %ae %s' 2019-07-11 ilnik@webrtc.org Cleanup FEC code after refactoring 2019-07-11 ilnik@webrtc.org Refactor FEC code to use COW buffers 2019-07-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8bdf10df..3bcb1095 (676126:676409) 2019-07-11 sprang@webrtc.org Make new pacer padding more like old one Created with: gclient setdep -r src/third_party/webrtc@4e5a41a08674 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie00d26cf70005cac13c35eb046b4835847043fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698317Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676518}
-
Min Chen authored
- Delete NightLightToggleButton since there is no toggle button for night light in unified system tray now. - Delete all the unused night light related icons. Only kUnifiedMenuNightLightIcon is used in unified system tray now. Bug: 982950 Change-Id: Ib95fc9ac58906b0ddc04b37ccb9fe8cdf98047db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696688Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#676517}
-
Matt Mueller authored
Bug: 634470 Change-Id: I1a7d17d51b481ad3aabd220f3b88286c0d9ca405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693387 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#676516}
-
Collin Baker authored
Instead of snapping to fully highlighted or not highlighted at all, this implements an animation similar to current ink drops. A linear fade is used, but this can be changed easily using the utilities in gfx::Tween. Bug: 933384 Change-Id: Ife827b914064ac16eb9e549656ae05bfd049f517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696402 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#676515}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3efcccc6e77a..14d669b045c8 git log 3efcccc6e77a..14d669b045c8 --date=short --no-merges --format='%ad %ae %s' 2019-07-11 bpastene@chromium.org telemetry: Fetch binary deps for the host platform when running on CrOS. Created with: gclient setdep -r src/third_party/catapult@14d669b045c8 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:938502 TBR=zhanliang@google.com Change-Id: I7ffd841c92cf22f3caa67c48fd6bc26d697d99d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698313Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676514}
-
Daniel Bratell authored
In some non-default, extreme, jumbo builds, the kDefaultHeight in download and the kDefaultHeight in hats ended up in the same translation unit which then prevented compilation. To avoid that, this patch renames them kDefaultDownloadItemHeight and kDefaultHatsDialogHeight. Bug: 979530 Change-Id: I38246cdcbbd7665c999ab74b51cf77ed90efcd0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698362 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#676513}
-