GitLab

BUG=225911
TEST=manual + browser test ExtensionApi.AutotestPrivate

Review URL: https://chromiumcodereview.appspot.com/13520005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192655 0039d316-1c4b-4281-b951-d872f2087c98

It should be crystal clear when, and why, pin validation is and is not
performed.

TEST=net_unittests; with an OFFICIAL_BUILD: can still connect to pinned
sites, and https://pinningtest.appspot.com fails with
net::ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN.


Review URL: https://chromiumcodereview.appspot.com/13466020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192654 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://chromiumcodereview.appspot.com/13431003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192653 0039d316-1c4b-4281-b951-d872f2087c98

Currently we only get stats about missing plugins (including unregistered plugin and missing plugin file). It is also interesting to know how many plugin creation failed because it is disabled. User may forget that he/she disabled a particular plugin and he/she doesn't get an info bar in this case, which could cause confusion.

In this CL:

- Rename MissingPluginReporter to PluginUMAReporter.
- Add ReportPluginDisabled function.
- Call ReportPluginDisabled function if the plugin is disabled in CreatePlugin.
- Refactor PluginUMATest to remove duplicate code.

BUG=226107
TEST=Unittests pass.

Review URL: https://chromiumcodereview.appspot.com/13414007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192652 0039d316-1c4b-4281-b951-d872f2087c98

Support storing the VisibilityClient on windows other than the RootWindow. What this means is you can set an object implementing VisibilityClient on any window in the hierarchy and this impl will handle layer visibility changes for that subtree.

R=sky@chromium.org
Review URL: https://codereview.chromium.org/13638010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192651 0039d316-1c4b-4281-b951-d872f2087c98

This is effectively a revert of r184013 and r183849.

BUG=227057, 173295

Review URL: https://codereview.chromium.org/13674020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192650 0039d316-1c4b-4281-b951-d872f2087c98

Hide ContentClient getters from embedders so that they they don't reuse content's embedder API. The main reasons are that it makes content's embedder interfaces harder to change if they're reused by the embedder, and that its makes it confusing for embedder code when there are multiple ways to do the same thing.

BUG=227047
Review URL: https://codereview.chromium.org/13409003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192649 0039d316-1c4b-4281-b951-d872f2087c98

CID=105999
BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/13358002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192648 0039d316-1c4b-4281-b951-d872f2087c98

Also, turn on support for EXT_draw_buffers on Windows. To make it easy for debugging ANGLE implementation bugs.

BUG=180397
TEST=gpu_unittests,content_unittests
Review URL: https://codereview.chromium.org/13730008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192647 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140316
Test=Updated WebViewTest.NewWindow

Review URL: https://chromiumcodereview.appspot.com/13032003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192646 0039d316-1c4b-4281-b951-d872f2087c98

With this CL we no longer commit instant suggest text when the
omnibox loses focus.

Also see the following discussion:
https://code.google.com/p/chromium/issues/detail?id=179981#c15

BUG=179981, 12664004
TEST=On Mac, ChromeOS, and Windows tested the following:
  - Typed "hello w"
  - clicked on the page and verified that suggest text remained
    uncommited
  - clicked back in the omnibox and pressed right arrow, verified
    that the suggest text was commited
Did the same test except instead of clicking on the page I clicked
into the find bar. Verified that this also worked.

Also tested switching tabs and verified that suggest text is not lost.

Review URL: https://chromiumcodereview.appspot.com/12792013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192645 0039d316-1c4b-4281-b951-d872f2087c98

On Canary, the user data directory is affected by
[[NSBundle mainBundle] objectForInfoDictionaryKey:@"CrProductDirName"].
Unfortunately in app shims, [NSBundle mainBundle] refers to the app shim's
bundle, not Chrome's bundle. This patch parameterises the
user-data-directory-figuring-out code on the NSBundle, so that app shims can
pass an NSBundle for the real Chrome bundle.

R=thakis@chromium.org


Review URL: https://chromiumcodereview.appspot.com/12663023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192644 0039d316-1c4b-4281-b951-d872f2087c98

Fixes all AutofillDialogControllerTest which were failing on Windows.

R=xhwang@chromium.org,jam@chromium.org
BUG=227221

Review URL: https://codereview.chromium.org/13533026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192643 0039d316-1c4b-4281-b951-d872f2087c98

Implementation based on existing methods in Histogram.

BUG=


Review URL: https://chromiumcodereview.appspot.com/13469020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192636 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
R=maruel@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/13640006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192635 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None


Review URL: https://chromiumcodereview.appspot.com/12255023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192631 0039d316-1c4b-4281-b951-d872f2087c98

pre-cursor to moving Chrome OS + Aura away from legacy GTK+X11 dibs. Now, we
have just:
- Windows style dibs
- POSIX style dibs
- Legacy GTK+X11 style dibs.

There's some ifdef hoops that will be removed in a follow-up CL when
Chrome OS + Aura will be moved away from legacy GTK+X11 dibs and on to POSIX
dibs.

BUG=147622
Review URL: https://codereview.chromium.org/13582008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192629 0039d316-1c4b-4281-b951-d872f2087c98

Managing size information via the platform view has undesirable side effects.

For instance in aura, calls to SetBounds cause the platform view to take
resize locks, which are not needed for something that is displayed indirectly.

BUG=


Review URL: https://chromiumcodereview.appspot.com/13647006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192626 0039d316-1c4b-4281-b951-d872f2087c98

I don't think we want all of these histograms uploaded,
we just care about them on local runs. I switched them
to be non-UMA

This change also updates the RasterTimes histogram
to be in microseconds.


Review URL: https://chromiumcodereview.appspot.com/13575007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192625 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/13496006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192624 0039d316-1c4b-4281-b951-d872f2087c98

This is in preparation for removing content::GetContentClient calls outside of content.

BUG=227047
Review URL: https://codereview.chromium.org/13488009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192622 0039d316-1c4b-4281-b951-d872f2087c98

BUG=224948,227043
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/13735002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192621 0039d316-1c4b-4281-b951-d872f2087c98

This check was removed due to misinterpretation of the spec, but it
seems it's needed for some streams.

BUG=225787
TEST=manual playback

Review URL: https://chromiumcodereview.appspot.com/13726007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192620 0039d316-1c4b-4281-b951-d872f2087c98

Sergiu's fix for crbug.com/224081 inadvertently broke the layout
on Android. This fixes the problem.

BUG=None
TEST=Open chrome://history and ensure that the 'x' buttons on the
right hand side of each entry are all aligned.
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/13724008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192619 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/13668002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192618 0039d316-1c4b-4281-b951-d872f2087c98

With gyp_managed_install no shared libraries should be packaged in the
APK (except gdbserver).

When toggling gyp_managed_install, there may be left over libraries in
<(intermediate_dir)/libs. APK packaging should use a different
directory when doing a managed install, so that it does not include the
library from a non-gyp_managed_install build.

BUG=158821


Review URL: https://chromiumcodereview.appspot.com/13651003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192617 0039d316-1c4b-4281-b951-d872f2087c98

cancelling. This matches behavior of the win32 control.

BUG=163711
TEST=covered by unit tests
R=ben@chromium.org


Review URL: https://chromiumcodereview.appspot.com/13646008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192616 0039d316-1c4b-4281-b951-d872f2087c98

Suppose you have an intranet hostname "c" that you've previously visited.

After this change, the behavior will be as follows:
input  ->  inline suggestion (what happens what you hit return)
c -> navigate to URL
c/ -> navigate to URL
c#foo -> search (this behavior differs from before this change)
c# foo -> search (this behavior differs from before this change)
c#  foo -> search (this behavior differs from before this change)
c# -> search (this behavior differs from before this change)
c#  -> search (this behavior differs from before this change) (notice the extra spaces the URL parser drops them)
c/#foo -> navigate to URL

BUG=169449

Review URL: https://chromiumcodereview.appspot.com/13190020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192615 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben@chromium.org
BUG=181277

Review URL: https://chromiumcodereview.appspot.com/13650007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192608 0039d316-1c4b-4281-b951-d872f2087c98

NOTE: This does not run on perf test bots yet.

BUG=138280
TEST=components_perftests
R=boliu@chromium.org,kaiwang@chromium.org,joi@chromium.org,sky@chromium.org


Review URL: https://chromiumcodereview.appspot.com/13392002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192607 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192604 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/13703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192603 0039d316-1c4b-4281-b951-d872f2087c98

Timing out on regular and ASAN bots.

Note: Google Test filter = InstantExtendedTest.CommitWhenShownInFullHeightWithoutFocus
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from InstantExtendedTest, where TypeParam =
[ RUN      ] InstantExtendedTest.CommitWhenShownInFullHeightWithoutFocus
Right after fork
Right before base::type_profiler::Controller::Stop()
Right after base::type_profiler::Controller::Stop()
Right after signal/exception handler restoration.
Right after fd_shuffle push_backs.
Right after ShuffleFileDescriptors
Right after CloseSuperfluousFds
Right before execvp
/Volumes/data/b/build/third_party/zope/__init__.py:19: UserWarning: Module twisted was already imported from /Volumes/data/b/build/third_party/twisted_10_2/twisted/__init__.pyc, but /System/Library/Frameworks/Python.framework/Versions/2.6/Extras/lib/python is being added to sys.path
  import pkg_resources
  /Volumes/data/b/build/third_party/zope/__init__.py:19: UserWarning: Module zope was already imported from /Volumes/data/b/build/third_party/zope/__init__.pyc, but /System/Library/Frameworks/Python.framework/Versions/2.6/Extras/lib/python is being added to sys.path
    import pkg_resources
    HTTPS server started on 127.0.0.1:50602...
    sending server_data: {"host": "127.0.0.1", "port": 50602} (36 bytes)
    [0405/102718:ERROR:test_launcher.cc(365)] Test timeout (60000 ms) exceeded for InstantExtendedTest.CommitWhenShownInFullHeightWithoutFocus
    BrowserTestBase signal handler received SIGTERM. Backtrace:
    0   interactive_ui_tests                0x03a4fe9a base::debug::StackTrace::StackTrace() + 26
    1   interactive_ui_tests                0x03640083 (anonymous namespace)::DumpStackTraceSignalHandler(int) + 131
    2   libSystem.B.dylib                   0x951de05b _sigtramp + 43
    3   ???                                 0xffffffff 0x0 + 4294967295
    4   CoreFoundation                      0x97a702df __CFRunLoopRun + 2079
    5   CoreFoundation                      0x97a6f3c4 CFRunLoopRunSpecific + 452
    6   CoreFoundation                      0x97a6f1f1 CFRunLoopRunInMode + 97
    7   HIToolbox                           0x91cd1e04 RunCurrentEventLoopInMode + 392
    8   HIToolbox                           0x91cd1bb9 ReceiveNextEventCommon + 354
    9   HIToolbox                           0x91cd1a3e BlockUntilNextEventMatchingListInMode + 81
    10  AppKit                              0x980f2595 _DPSNextEvent + 847
    11  AppKit                              0x980f1dd6 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 156
    12  AppKit                              0x980b41f3 -[NSApplication run] + 821
    13  interactive_ui_tests                0x03a14a51 base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 737
    14  interactive_ui_tests                0x03a136b0 base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 448
    15  interactive_ui_tests                0x03ac44fa base::MessageLoop::RunInternal() + 650
    16  interactive_ui_tests                0x03b1efd5 base::RunLoop::Run() + 69
    17  interactive_ui_tests                0x0365be40 content::RunThisRunLoop(base::RunLoop*) + 144
    18  interactive_ui_tests                0x0365d343 content::WindowedNotificationObserver::Wait() + 611
    19  interactive_ui_tests                0x008f7749 InstantExtendedTest_CommitWhenShownInFullHeightWithoutFocus_Test::RunTestOnMainThread() + 12777
    20  interactive_ui_tests                0x0a6af765 InProcessBrowserTest::RunTestOnMainThreadLoop() + 581
    21  interactive_ui_tests                0x036405b9 base::internal::Invoker<1, base::internal::BindState<base::internal::RunnableAdapter<void (content::BrowserTestBase::*)()>, void ()(content::BrowserTestBase*), void ()(content::BrowserTestBase*)>, void ()(content::BrowserTestBase*)>::Run(base::internal::BindStateBase*) + 137
    22  interactive_ui_tests                0x05fd844c ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 23292
    23  interactive_ui_tests                0x05fd27cc ChromeBrowserMainParts::PreMainMessageLoopRun() + 28
    24  interactive_ui_tests                0x05677805 content::BrowserMainLoop::CreateThreads() + 1813
    25  interactive_ui_tests                0x0567b058 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 1080
    26  interactive_ui_tests                0x0567441e content::BrowserMain(content::MainFunctionParams const&) + 142
    27  interactive_ui_tests                0x0363fd44 content::BrowserTestBase::SetUp() + 1076
    28  interactive_ui_tests                0x0a6abdc7 InProcessBrowserTest::SetUp() + 1943
    29  interactive_ui_tests                0x0260b299 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 473
    30  interactive_ui_tests                0x025f0910 testing::Test::Run() + 752
    31  interactive_ui_tests                0x025f22d1 testing::TestInfo::Run() + 1601
    32  interactive_ui_tests                0x025f31ea testing::TestCase::Run() + 1418
    33  interactive_ui_tests                0x02604d83 testing::internal::UnitTestImpl::RunAllTests() + 3043
    34  interactive_ui_tests                0x0260cbd9 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) + 473
    35  interactive_ui_tests                0x02604133 testing::UnitTest::Run() + 307
    36  interactive_ui_tests                0x04e0bb51 base::TestSuite::Run() + 673
    37  interactive_ui_tests                0x00985d94 ChromeTestLauncherDelegate::RunTestSuite(int, char**) + 132
    38  interactive_ui_tests                0x0365277c content::LaunchTests(content::TestLauncherDelegate*, int, char**) + 3884
    39  interactive_ui_tests                0x00985b8c main + 172
    40  interactive_ui_tests                0x000030a5 start + 53

R=xhwang@chromium.org
BUG=227076

Review URL: https://codereview.chromium.org/13685015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192602 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192598 0039d316-1c4b-4281-b951-d872f2087c98

Also reorder the file alphabetically

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/13704013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192597 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=tkent
Review URL: https://codereview.chromium.org/13533018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192596 0039d316-1c4b-4281-b951-d872f2087c98

BUG=176857
Test=None
R=erg
TBR=sky (For ui/linux_ui/linux_ui.h)

Review URL: https://chromiumcodereview.appspot.com/13497002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192595 0039d316-1c4b-4281-b951-d872f2087c98

Once more with feeling. This time for sure.
I correctly figured out how to do a GOOGLE_CHROME_BUILD since apparantly
this does not get defined in any of the CQ chromeos bots.

BUG=192420
TBR=ben@chromium.org, et. al.

Review URL: https://codereview.chromium.org/13730003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192594 0039d316-1c4b-4281-b951-d872f2087c98

This logic was already added in scoped_ptr::reset() in
https://src.chromium.org/viewvc/chrome?view=rev&revision=185551.
this is a straightforward port of the logic to scoped_array to
prevent any accidental regressions during the transition.

BUG=162971,176091

Review URL: https://codereview.chromium.org/13433007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192590 0039d316-1c4b-4281-b951-d872f2087c98

BUG=225967
TEST=manual, lock screen, go to second terminal, kill render process for lock screen, login screen should be shown


Review URL: https://chromiumcodereview.appspot.com/13520006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192589 0039d316-1c4b-4281-b951-d872f2087c98