GitLab

BUG=485381

Review URL: https://codereview.chromium.org/1125343005

Cr-Commit-Position: refs/heads/master@{#329568}

This is a regression in https://codereview.chromium.org/1114633002c

BUG=485832
TEST=covered by unittests

Review URL: https://codereview.chromium.org/1132303005

Cr-Commit-Position: refs/heads/master@{#329567}

Quoting raymes: "What is happening is that while the
plugin is initializing it sends a sync IPC which results in re-entrancy.
ExecuteScript is being run during re-entrancy which runs a script on the page
which can result in layout changing and so reportGeometry can be called."

BUG=486674

Review URL: https://codereview.chromium.org/1137433004

Cr-Commit-Position: refs/heads/master@{#329566}

This matches the GYP build.

Review URL: https://codereview.chromium.org/1134833003

Cr-Commit-Position: refs/heads/master@{#329565}

There are more errors coming up after the latest libvpx roll.

TBR=oshima@chromium.org
BUG=468169

Review URL: https://codereview.chromium.org/1137993006

Cr-Commit-Position: refs/heads/master@{#329564}

Blink maintains state for popups whether they are hidden shown etc. So when a popup is shown and
an action causes the popup to be hidden then blink changes the state to hidden. If an action causes
the popup to be closed on the browser without notifying blink that the popup is going away due to focus
being lost on the parent view, then blink assumes that the popup is still visible.

As a result clicking again on a select box would just hide the popup as blink thinks the popup is visible.

This bug is only triggered in corner cases like ASH where you have one root window parenting everything else.
On regular desktop environments clicking outside the browser window while the popup is open would cause activation
changes to occur which would ensure that the Blur notification goes through to the browser.

The other change is a simple fix in delegate_execute which caused it to crash in debug mode on a multi dll build.
Crash occurred because we were looking for version information in base.dll while launching the crash server.

BUG=482937

Review URL: https://codereview.chromium.org/1136143005

Cr-Commit-Position: refs/heads/master@{#329563}

BUG=485381

Review URL: https://codereview.chromium.org/1132793005

Cr-Commit-Position: refs/heads/master@{#329562}

Sync changes could trigger UpdateDriveApps before DriveAppRegistry is
populated with data. An empty list from DriveAppRegistry causes all
Drive apps be uninstalled. And some Drive apps would cause Gaia cookies
to be lost.

BUG=449816
TEST=DriveAppProviderTest.UpdateAfterDriveAppRegistryUpdate

Review URL: https://codereview.chromium.org/1130903006

Cr-Commit-Position: refs/heads/master@{#329561}

BUG=485381

Review URL: https://codereview.chromium.org/1135733005

Cr-Commit-Position: refs/heads/master@{#329560}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6394784..76a74c1

TBR=dpranke@chromium.org,alancutter@chromium.org

Review URL: https://codereview.chromium.org/1128993006

Cr-Commit-Position: refs/heads/master@{#329559}

The "configurable" and "multipleMounts" should be optional and default to
false.

TEST=browser_tests: *FileSystemProvider*Configure*, *FileSystemProvider*Mount*
BUG=474146

Review URL: https://codereview.chromium.org/1127283003

Cr-Commit-Position: refs/heads/master@{#329558}

When one of the streams is much shorter than other(s), the
shorter stream reaches EOS first and then its media time
stops increasing, which blocks other streams due to using
BalancedMediaTaskRunner. Resetting the media task runner
will ensure other streams are not blocked by the shortest
one.

BUG=internal b/19560149

Review URL: https://codereview.chromium.org/1140003002

Cr-Commit-Position: refs/heads/master@{#329557}

This moves more of the transitive state of the tile to PrioritizedTile
which has a shorter lifetime, avoiding us to update properties on the
tile.

BUG=

Review URL: https://codereview.chromium.org/1132443003

Cr-Commit-Position: refs/heads/master@{#329556}

BUG=

Review URL: https://codereview.chromium.org/1141673002

Cr-Commit-Position: refs/heads/master@{#329555}

BUG=485381

Review URL: https://codereview.chromium.org/1135013005

Cr-Commit-Position: refs/heads/master@{#329554}

BUG=483276
TEST=none
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/1113043004

Cr-Commit-Position: refs/heads/master@{#329553}

BUG=485381

Review URL: https://codereview.chromium.org/1136273002

Cr-Commit-Position: refs/heads/master@{#329552}

SafeBrowsingDatabaseManager: Pure interface
  TestSafeBrowsingDatabaseManager: Dummy impl for tests
  LocalSafeBrowsingDatabaseManager: Existing full impl.
  RemoteSafeBrowsingDatabaseManager: New for Android

Wire up the safe_browsing=3 build-mode to switch Android to
use Remote*.  Move SafeBrowsingCheck into Local* and create
the Test* impl that can't accidentally call a real
implementation's methods.  Adjust tests to use either Test*
or Local*.

The initial implementation of Remote* does the bookeeping
of requests, but doesn't yet make calls to Java and isn't
tested.

BUG=474608

Review URL: https://codereview.chromium.org/1110723002

Cr-Commit-Position: refs/heads/master@{#329551}

This change allows the client to specify a target sampling rate, aside
from the maximum frame rate.  When animated content is detected, an
approprate subsampling of the relevant frames will be proposed.  This is
meant to be used for clients wishing to detect high-frame-rate content
(e.g., 48 or 60 FPS), but only sample at traditional rates (e.g., 24 or
30 FPS).

In testing this change, it became apparent that the current tests were
highly sensitive to phase issues, and were erroneously generating
discontinuous sequences of events in some scenarios.  The tests have
been fixed and additional testing for the new functionality added.

BUG=156767

Review URL: https://codereview.chromium.org/1123623005

Cr-Commit-Position: refs/heads/master@{#329550}

This way, the 64-bit bots will help us find regressions since they
build with warnings-as-errors.

BUG=467287

Review URL: https://codereview.chromium.org/1139493003

Cr-Commit-Position: refs/heads/master@{#329549}

This is a tiny feature rename, per request from the marketing team.

BUG=484541
TEST=none
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/1134163004

Cr-Commit-Position: refs/heads/master@{#329548}

Files in chrome/android/sync_shell/javatests use the
org.chromium.chrome.browser.sync Java package, but were located under
src/chromium/chrome/browser/sync. This fixes the problem by adding an
"org" directory.

R=nyquist@chromium.org, pvalenzuela@chromium.org
TBR=manisicalco@chromium.org

Review URL: https://codereview.chromium.org/1132173003

Cr-Commit-Position: refs/heads/master@{#329547}

R=sky@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1133893003

Cr-Commit-Position: refs/heads/master@{#329546}

Renamed a class in the HTML and forgot to update CSS.

R=estade@chromium.org
BUG=487234

Review URL: https://codereview.chromium.org/1133013004

Cr-Commit-Position: refs/heads/master@{#329545}

Currently the SourcePageHandleWebContents holds a scoped_ptr<WebContents>,
which means that when distillation of the source page is finished, the
WebContents will be destroyed. This makes it hard to distill the contents
from one WebContents, and view the result in another.

This CL makes the SourcePageHandleWebContents only optionally own the
WebContents by taking in a raw pointer an a bool flag of whether it should
own it or not.

In the current chrome-level API DistillCurrentPageAndView the old behavior
is kept, and the source WebContents is destroyed when distillation finishes.

In addition, this CL adds a new chrome-level API DistillAndView(...), where
the caller passes in two WebContents, one for the source page, and one for
where the caller wants to view the distilled content. The distiller code does
in this case not take ownership of any of these.

BUG=None
TEST=browser_tests,components_browsertests

Review URL: https://codereview.chromium.org/1058193002

Cr-Commit-Position: refs/heads/master@{#329544}

BUG=486889

Review URL: https://codereview.chromium.org/1141453003

Cr-Commit-Position: refs/heads/master@{#329543}

Adds handling to show the selection handles for a tap or long-press
on an existing selection that does not yet show the selection handles.

This approach works fine when the selection does not wrap,
and it's currently very rare that we have a multi-line selection.
However, some day we'll have the ability to expand the selection,
so we should revisit this implementation then.
More info on this in issue 393025.

Based on CL 1086393003 by jdduke@.

BUG=chromium:393025, chromium:420281

Review URL: https://codereview.chromium.org/1102933003

Cr-Commit-Position: refs/heads/master@{#329542}

When we close a tab that shows a modal dialog, and another tab has a modal
dialog pending, we'll end up deactivating the first tab after closing it. In
that case, just ignore the event.

BUG=484550
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/1141493002

Cr-Commit-Position: refs/heads/master@{#329541}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f0a5894..6394784

TBR=dpranke@chromium.org,alancutter@chromium.org

Review URL: https://codereview.chromium.org/1138813004

Cr-Commit-Position: refs/heads/master@{#329540}

There are four metrics for proxy resolution:
1. ResolvedUsingScript is whether a script was executed to resolve the URL.
2. ResolveTime is the total time taken to resolve a URL, including retries
   due to resolver crashes. This is regardless of whether or not the script
   was executed.
3. GetProxyUsingScriptTime  is the time taken to resolve a URL when executing
   the PAC script.
4. ScriptTerminated is whether or not a resolution caused the resolver to crash.
   Having this as a boolean on total resolutions indicates how crashy the
   out-of-process resolver is.

BUG=467832

Review URL: https://codereview.chromium.org/1121823004

Cr-Commit-Position: refs/heads/master@{#329539}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/dd4e568..8c9b6f1

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/1134283002

Cr-Commit-Position: refs/heads/master@{#329538}

This provides the implementation and tests to maintain an
exponentially-decaying average of feedback signal values.  This will
be used in soon-upcoming changes that will allow screen capture to
auto-adapt the frame resolution and frame rate to the user's
environment.

BUG=156767

Review URL: https://codereview.chromium.org/1097633005

Cr-Commit-Position: refs/heads/master@{#329537}

This works the same way as NativeAppWindowCocoa. Common code
is factored out to ui/gfx/mac/nswindow_frame_controls.

BUG=459877

Review URL: https://codereview.chromium.org/1105613002

Cr-Commit-Position: refs/heads/master@{#329536}

Sanitize |session_id| passed to load() and |response| passed to update().

BUG=456398
TEST=new blink layout tests

Review URL: https://codereview.chromium.org/1132223002

Cr-Commit-Position: refs/heads/master@{#329535}

This clobbers --extra_annotation_names in compile.py.

BUG=

Review URL: https://codereview.chromium.org/1140593003

Cr-Commit-Position: refs/heads/master@{#329534}

|level| is no longer used as a result of crbug.com/443151.
So currently video canvas painting is broken as the call has an empty implementation.

BUG=485482

Review URL: https://codereview.chromium.org/1138343004

Cr-Commit-Position: refs/heads/master@{#329533}

The new name indicates that the tests are using chrome_shell. Future
tests will live in the javatests folder and won't be based on
chrome_shell.

BUG=484934
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1139643006

Cr-Commit-Position: refs/heads/master@{#329532}

BUG=486231

Review URL: https://codereview.chromium.org/1135923004

Cr-Commit-Position: refs/heads/master@{#329531}

BUG=485381

Review URL: https://codereview.chromium.org/1138893003

Cr-Commit-Position: refs/heads/master@{#329530}

The new histograms measure the performance of session cookie deletion.

BUG=485694

Review URL: https://codereview.chromium.org/1131413004

Cr-Commit-Position: refs/heads/master@{#329529}