GitLab

It seems a lot of code moved out of this class, so remove various includes and forward references.

Review URL: https://codereview.chromium.org/302093006

git-svn-id: svn://svn.chromium.org/blink/trunk@175211 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Windows XP specific rebaselines for r175038 as the XP > Win7 fallback is
no longer valid for text tests.

TBR=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/301193007

git-svn-id: svn://svn.chromium.org/blink/trunk@175210 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Windows XP specific rebaselines for r175038 as the XP > Win7 fallback is
no longer valid for text tests.

TBR=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/308123005

git-svn-id: svn://svn.chromium.org/blink/trunk@175209 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/306083006

git-svn-id: svn://svn.chromium.org/blink/trunk@175208 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reason for revert:
This changed the subpixel positioning of glyphs on lines with first-letter renderers on Mac builds. See https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_6/28423/layout-test-results/results.html as an example.

I think the new results are benign - but would like to confirm with leviw and reland as NeedsRebaseline if we're both happy with them.


Original issue's description:
> Empty inline elements always get a line box.
> 
> CSS 2.1 (http://www.w3.org/TR/CSS2/visudet.html#leading) says: "Empty inline 
> elements generate empty inline boxes, but these boxes still have margins, padding, 
> borders and a line height, and thus influence [line-height calculation] just 
> like elements with content."
> 
> We weren't creating lineboxes for empty inline elements when they occurred
> between a single trailing space and a single leading space - this is because
> our linebox creation was based on the too-narrow premise that we were already
> ignoring spaces. However, if an empty inline element comes after a trailing 
> space but before one or more leading spaces then it will be ignored as part 
> of the collapsed space between the trailing space and the next non-collapsible 
> space - so we should force the creation of a linebox in such cases.
> 
> This allows us to pass Hixie's empty inline test: 
> http://www.hixie.ch/tests/evil/mixed/emptyinline.html
> 
> BUG=328939
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175205

TBR=leviw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=328939

Review URL: https://codereview.chromium.org/302233002

git-svn-id: svn://svn.chromium.org/blink/trunk@175207 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL also moves CompositingReasonOverflowScrollingTouch inside
hasOverflowScrollTrigger because needsCompositedScrolling cannot return true if
we don't have the overflow scroll trigger.

Review URL: https://codereview.chromium.org/309593003

git-svn-id: svn://svn.chromium.org/blink/trunk@175206 bbb929c8-8fbe-4397-9dbb-9b2b20218538

CSS 2.1 (http://www.w3.org/TR/CSS2/visudet.html#leading) says: "Empty inline 
elements generate empty inline boxes, but these boxes still have margins, padding, 
borders and a line height, and thus influence [line-height calculation] just 
like elements with content."

We weren't creating lineboxes for empty inline elements when they occurred
between a single trailing space and a single leading space - this is because
our linebox creation was based on the too-narrow premise that we were already
ignoring spaces. However, if an empty inline element comes after a trailing 
space but before one or more leading spaces then it will be ignored as part 
of the collapsed space between the trailing space and the next non-collapsible 
space - so we should force the creation of a linebox in such cases.

This allows us to pass Hixie's empty inline test: 
http://www.hixie.ch/tests/evil/mixed/emptyinline.html

BUG=328939

Review URL: https://codereview.chromium.org/300853007

git-svn-id: svn://svn.chromium.org/blink/trunk@175205 bbb929c8-8fbe-4397-9dbb-9b2b20218538

No one reads this state.

Review URL: https://codereview.chromium.org/310543002

git-svn-id: svn://svn.chromium.org/blink/trunk@175204 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Synchronise releasing / default activating this feature with the other platforms.

BUG=378195
R=eae,dglazkov,eseidel

Review URL: https://codereview.chromium.org/304723002

git-svn-id: svn://svn.chromium.org/blink/trunk@175203 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/Tu9pL7gMPyo/f-eYf_AkpQMJ

The conclusion of the thread was to deprecate only at this time.

Review URL: https://codereview.chromium.org/301403002

git-svn-id: svn://svn.chromium.org/blink/trunk@175202 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL reduces the number of required Heap::collectGarbage calls in
Heap::collectAllGarbage on Worker termination.

 - Make Event::m_target Member<>.
 - Make MessageEvent::m_source Member<>.
  MessageEvent is used to communicate between the main thread and workers.
  For consistency, this CL adjusts MessagePort argument/return types.

They reduce RefPtr to WorkerGlobalScope, which implements EventTarget.

BUG=375671

Review URL: https://codereview.chromium.org/304353004

git-svn-id: svn://svn.chromium.org/blink/trunk@175201 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adds Netinfo v3 to Blink.

The layout changes outside of netinfo/ are regolding.

Design doc: https://docs.google.com/a/chromium.org/document/d/1LTk9uVMGi4kurzcF5ellsAJReTF31fFJMHrQwSVtBjc/

BUG=368358

Review URL: https://codereview.chromium.org/291203002

git-svn-id: svn://svn.chromium.org/blink/trunk@175200 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The RestyleFlags are set based on selectors and DOM structure. Wether the
elements are attached or detached is irrelevant. Furthermore, when these
flags are reset, we must be sure all elements which may contribute to these
flags will have their style recalculated in order to set the flags properly.
That is not necessarily the case for attach/detach since siblings, or
descendants of siblings of the detached element will not have their style
recalculated in general.

Instead, reset RestyleFlags when an element is removed from its parent. If
the element is re-inserted into the DOM, siblings and sibling subtrees will
have the style recalculated to update the flags properly.

R=esprehn@chromium.org
BUG=376139

Review URL: https://codereview.chromium.org/304183009

git-svn-id: svn://svn.chromium.org/blink/trunk@175199 bbb929c8-8fbe-4397-9dbb-9b2b20218538

StringImpl::replace(UChar, UChar) is mentioned as one of the
hot spots by the Intel VTune Amplifier profile when running
the 'textarea-dom.html' performance test.

StringImpl::replace(UChar, UChar) is optimized (and simplified)
by using 'StringImpl::find' method instead of manual traversing
the internal buffer and checking 'is8Bit' property value on
each iteration.

This changes gives approx 2.25% improvement of the average
'textarea-dom.html' performance test results (linux desktop x64,
GCC 4.6.3, release content_shell build with enabled
'linux_dump_symbols' flag).

Review URL: https://codereview.chromium.org/304273003

git-svn-id: svn://svn.chromium.org/blink/trunk@175198 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reason for revert:
This patch closed the tree with a '"update" on "Win7 Tests"' message. Reverting

Original issue's description:
> Enable a srcset 0x descriptor
> 
> According to recent spec changes, a "0x" descriptor should be correctly parsed,
> and imply intrinsic dimensions of infinity to the image.
> This CL enables that, and tests that intrinsic dimensions are impacted accordingly.
> 
> BUG=378252
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175196

TBR=eseidel@chromium.org,pdr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=378252

Review URL: https://codereview.chromium.org/302083009

git-svn-id: svn://svn.chromium.org/blink/trunk@175197 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to recent spec changes, a "0x" descriptor should be correctly parsed,
and imply intrinsic dimensions of infinity to the image.
This CL enables that, and tests that intrinsic dimensions are impacted accordingly.

BUG=378252

Review URL: https://codereview.chromium.org/305643006

git-svn-id: svn://svn.chromium.org/blink/trunk@175196 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=327641

Review URL: https://codereview.chromium.org/306123005

git-svn-id: svn://svn.chromium.org/blink/trunk@175195 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=175189

BUG=370664
TBR=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/304283009

git-svn-id: svn://svn.chromium.org/blink/trunk@175194 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Allow sub-css-pixel font-sizes and thus smooth font scaling which in
turn allows for stable layout when zooming and drastically improves
readability and font rendering quality on high dpi devices.

This change enabled the experimental subpixel font scaling flag by
default across all supported platforms.

Entry in Chromium Dashboard
  http://www.chromestatus.com/features/6259163214643200

OWP launch tracking bug
  https://code.google.com/p/chromium/issues/detail?id=164167

Intent to ship
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/4-f2i7OEWeg

R=eseidel@chromium.org, dglazkov@chromium.org
BUG=164167

Review URL: https://codereview.chromium.org/307993009

git-svn-id: svn://svn.chromium.org/blink/trunk@175192 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is by far the slowest part of doing rebaselines.
We can do everything but the SCM commands in parallel.
Like we do for the other commands, save off the SCM commands
and do them all at the end.

Review URL: https://codereview.chromium.org/308793004

git-svn-id: svn://svn.chromium.org/blink/trunk@175191 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Windows XP specific rebaselines for r175038 as the XP > Win7 fallback is
no longer valid for text tests.

TBR=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/309503009

git-svn-id: svn://svn.chromium.org/blink/trunk@175190 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This fixes a mistake in crrev.com/301843002

Includes a test.

BUG=370664

Review URL: https://codereview.chromium.org/306093002

git-svn-id: svn://svn.chromium.org/blink/trunk@175189 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=175124

BUG=372502
TBR=h.joshi@samsung.com

Review URL: https://codereview.chromium.org/302223002

git-svn-id: svn://svn.chromium.org/blink/trunk@175188 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=174989

BUG=376306
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/307163002

git-svn-id: svn://svn.chromium.org/blink/trunk@175187 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=175010

BUG=314704
TBR=dtrebbien@gmail.com

Review URL: https://codereview.chromium.org/304413003

git-svn-id: svn://svn.chromium.org/blink/trunk@175186 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=174988

BUG=369358
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/306223002

git-svn-id: svn://svn.chromium.org/blink/trunk@175185 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=175147

BUG=377610
TBR=fs@opera.com

Review URL: https://codereview.chromium.org/309553006

git-svn-id: svn://svn.chromium.org/blink/trunk@175184 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously we use localToContainerPoint((0,0)) to calculate the offset
of a child when drawing focus rings. If the child is rotated, (0, 0)
won't be its top-left corner in container‘s coordinations.

Now use localToContainerQuad(childLocalFocusRingRect).enclosingBoundingBox().

Also updated RenderObject::absoluteFocusRingQuads() to be
transform-aware.

BUG=374168
TEST=transforms/transform-focus-ring.html

Review URL: https://codereview.chromium.org/288013005

git-svn-id: svn://svn.chromium.org/blink/trunk@175183 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Based on dsinclair@'s original patch https://codereview.chromium.org/174073002/

For the new world of text based repaint tests it can be hard
to visualize how the repaint rects appear on the screen. This
is a first pass at visualizing the difference between the old
and new repaint rects when one of the text based repaint tests
fail.

Review URL: https://codereview.chromium.org/303223008

git-svn-id: svn://svn.chromium.org/blink/trunk@175182 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=174983

BUG=164167
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/308913003

git-svn-id: svn://svn.chromium.org/blink/trunk@175181 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=174992

BUG=164167
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/304353011

git-svn-id: svn://svn.chromium.org/blink/trunk@175180 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=376506

Review URL: https://codereview.chromium.org/305723002

git-svn-id: svn://svn.chromium.org/blink/trunk@175179 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Windows XP specific rebaselines for r175038 as the XP > Win7 fallback is
no longer valid for text tests.

TBR=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/303163007

git-svn-id: svn://svn.chromium.org/blink/trunk@175178 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Replaced getShapeImageAndRect() in ShapeOutsideInfo.cpp with
ShapeOutsideInfo::createShapeForImage(). The original function
failed to protect the PassRefPtr return value returned by StyleImage::image(). 

BUG=378469

Review URL: https://codereview.chromium.org/305173003

git-svn-id: svn://svn.chromium.org/blink/trunk@175176 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL can't solve all issues when the source position approaches the listener position because when the locations are equal, we get a singular point in the equations.

This just makes it continuous as the source approaches the listener. If the source then goes past, there will be a unavoidable discontinuity.

TEST=Listen to http://jsfiddle.net/UxwGP/10. When the slider position is 0, there should be no sudden change in pitch.

TEST=Listen to http://jsfiddle.net/qWHAt/34/ using mono source and HRTF panner.  Initially, the pitch is very low. Move the slider just to the left or right of center and the pitch goes up. As you move the slider through center slowly, the pitch drops drastically at center.  With this CL, this the pitch does not start out low, and as you move the slider around, the pitch never drops low at center. There is a discontinuity moving from left to right, but this is because the source was moving away from the listener and is not moving towards the listener.

BUG=141739

Review URL: https://codereview.chromium.org/301733002

git-svn-id: svn://svn.chromium.org/blink/trunk@175175 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This should fix an uncommon crash during history traversal.

I believe the steps to get into this state are:
1. Load a page with a slow-loading iframe. The iframe load must begin before the main frame's load event fires.
2. While the iframe is still in the provisional load state, attempt a same-document history navigation in the child frame.
3. The child frame's provisional load is cancelled by the history navigation in FrameLoader::loadInSameDocument, which in turn causes the parent frame's load event to fire synchronously.
4. The parent frame's onload event handler detaches the iframe.
5. No checks are performed after cancelling the provisional load in FrameLoader::loadInSameDocument, leading to a null deref and crash.

We should be able to prevent a crash in this case by checking whether the frame is still attached after cancelling the provisional load in FrameLoader::loadInSameDocument.

BUG=374391

Review URL: https://codereview.chromium.org/303133004

git-svn-id: svn://svn.chromium.org/blink/trunk@175174 bbb929c8-8fbe-4397-9dbb-9b2b20218538

MSVC doesn't set __SSE__ or__SSE2__ defines:

http://msdn.microsoft.com/en-us/library/b0084kay.aspx

BUG=349320
TEST=compiles

Review URL: https://codereview.chromium.org/307963005

git-svn-id: svn://svn.chromium.org/blink/trunk@175173 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Combined RenderStyle::needsFullRepaintOnContainer(Width|Height)Change
and local function mustRepaintFillLayers() in RenderObject.cpp into
RenderObject::mustRepaintFillLayersOn(Width|Height)Change.

Added missing logics of the original mustRepaintFillLayers():
- repaint if background-repeat is not repeat and no-repeat;
- repaint if background-position is not left or top origin;
- don't repaint if background-position is of fixed length;

TEST=fast/repaint/background-resize-width.html
TEST=fast/repaint/background-resize-height.html

Review URL: https://codereview.chromium.org/306483011

git-svn-id: svn://svn.chromium.org/blink/trunk@175172 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When the only things that changed are not tree boundary crossing rules we
can skip invalidation in descendant ShadowRoots. This means that
if you have lots of nested components with duplicate class names then using
a descendant selector in an enclosing component won't invalidate style in
nested ShadowRoots.

I also packed the booleans on DescendantInvalidationSet since we keep growing
it with new flags.

In the future we can make this tree boundary crossing logic even smarter so that
if you have both tree boundary and not tree boundary crossing invalidation
sets on the same subtree we can skip running the non-tree boundary crossing
rules when recursing into a ShadowRoot.

I also took this as an opportunity to clean up the addFeaturesToInvalidationSets
logic and merged the new treeBoundaryCrossing flag and the wholeSubtreeInvalid
flag into the InvalidationSetFeatures.

Review URL: https://codereview.chromium.org/286903024

git-svn-id: svn://svn.chromium.org/blink/trunk@175171 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=174930

BUG=373240
TBR=dominik.rottsches@intel.com

Review URL: https://codereview.chromium.org/309613004

git-svn-id: svn://svn.chromium.org/blink/trunk@175170 bbb929c8-8fbe-4397-9dbb-9b2b20218538