- 20 Aug, 2018 40 commits
-
-
Donn Denman authored
Refactors the Contextual Search Component to use the layered directory layout recommended for iOS support. This CL splits the top-level directories into /core and /content. A few files that are clearly not dependent on any content have been moved to /core/, and everything else is moved to /content/. There will be some additional /core/ files landing soon. This CL doesn't change any logic or functionality, it just moves source files. BUG=646019,825428 Change-Id: Ia4bf5cdecaabf7d9515b2d4fca855db29b1c4b1c Reviewed-on: https://chromium-review.googlesource.com/1173019Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#584566}
-
Kenneth Russell authored
Mark: conformance2/textures/misc/tex-mipmap-levels.html failing on 10.12 with AMD GPUs. The previous failure suppression covered this configuration, and it turns out it's unacceptably flaky there, too. Mark: conformance2/textures/misc/tex-base-level-bug.html failing on 10.13 with AMD GPUs. When the test fails, it fails three times in a row. Tbr: cblume@chromium.org Bug: 870856 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibe020fabc74661dc4c8d8553a292ca5f8666ea77 Reviewed-on: https://chromium-review.googlesource.com/1181655Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#584565}
-
Kyle Qian authored
This CL includes concrete implementations for the abstract classes AtomicBoolean and AtomicReference defined in the Nearby library. An AtomicBoolean is a boolean value that may be updated atomically, and an AtomicReference is an object reference that may be updated atomically. Because the actual Nearby library has yet to be merged into the CrOS directory, this CL includes stand-in Nearby abstract classes under the temporary directory //chromeos/components/nearby/library. This directory will be removed after the Nearby library gets imported to //third_party (in-progress CL: https://chromium-review.googlesource.com/c/chromium/src/+/1113198). Bug: 861813 Change-Id: Ibbda1bd35e3fb63eed0ae492ecebb3d61fa43050 Reviewed-on: https://chromium-review.googlesource.com/1142478 Commit-Queue: Kyle Qian <kyleqian@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#584564}
-
Kenneth Russell authored
SwiftShader isn't available on 32-bit ARM yet. Bug: 875172 Change-Id: I3ddeec51d8ef156def5f5194c75cec31a4aa9412 Reviewed-on: https://chromium-review.googlesource.com/1181767Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#584563}
-
Tom Anderson authored
"Some compilers offer an extension that allows ## to appear after a comma and before __VA_ARGS__, in which case the ## does nothing when the variable arguments are present, but removes the comma when the variable arguments are not present: this makes it possible to define macros such as fprintf (stderr, format, ##__VA_ARGS__)" [1] This is problematic for Chromium since ##__VA_ARGS__ doesn't swallow the preceding comma in standards-compliant mode on gcc [2]. Since we use this feature in Chromium (eg base), switch the gcc config back to -std=gnu*. C++20 adds a standards-compliant macro called __VA_OPT__ that we can use to replicate the behavior of ##__VA_ARGS__ when we eventually enable it. [1] https://en.cppreference.com/w/cpp/preprocessor/replace [2] https://github.com/gcc-mirror/gcc/blob/6d6279f88e9678c458bc22ea3be03e73f462f9e7/libcpp/macro.c#L1167 R=thakis Change-Id: I6c0f3e64ad21b6270822011733d44098537b8f02 Reviewed-on: https://chromium-review.googlesource.com/1181657Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Jennifer Apacible authored
NOTRY=true (disabling test) Bug: 876050 TBR: mlamouri@chromium.org Change-Id: I194461ae3a8ca045dd0b9201331c191bc644ec5b Reviewed-on: https://chromium-review.googlesource.com/1182293Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#584561}
-
Fady Samuel authored
This CL converts some not so useful CHECKs in AsyncLayerTreeFrameSink into DCHECKs that can be caught in debug builds by developers. We would like to merge this CL into M69 as well to eliminate a source of renderer crashes. Bug: 871450 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I235d068ea72774b020ba7a241507d0f4201d8dc0 Reviewed-on: https://chromium-review.googlesource.com/1181766Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#584560}
-
Brian Sheedy authored
This reverts commit 4b3c7082. Reason for revert: Causing XR tests to disappear/not be listed https://bugs.chromium.org/p/chromium/issues/detail?id=875909 Original change's description: > Replace enum with @IntDef (javatests) > > @IntDef/@StringDef annotation are preferred way for declaring > set of String/int values. > > 1. they need less space in APK than enum, see > https://developer.android.com/topic/performance/reduce-apk-size#remove-enums > 2. they give more control over allowed values than "static final" values > > Main goal of patch is writing "static final" values, enum > and some classes in one common @IntDef/@StringDef form: > > 1. with @IntDef/@StringDef first, @Retention second > and related @interface third > 2. with values inside @interface > 3. with NUM_ENTRIES declaring number of entries if necessary > 4. with comment about numbering from 0 without gaps when necessary > 5. with @Retention(RetentionPolicy.SOURCE) > 6. without "static final" in the @interface > > Change-Id: I6aeb3571f6e72dd3599a4a6055189a227312d5c4 > Reviewed-on: https://chromium-review.googlesource.com/1154527 > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Amirhossein Simjour <asimjour@chromium.org> > Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> > Cr-Commit-Position: refs/heads/master@{#584198} TBR=tedchoc@chromium.org,asimjour@chromium.org,agrieve@chromium.org,marcin@mwiacek.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I2acb8a9712d544e86bcbcf4ace09f0bcb9ccb77e Reviewed-on: https://chromium-review.googlesource.com/1181802Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#584559}
-
Peter Collingbourne authored
These programs will be used to extract resource whitelists from PDBs. Not creating a new package because llvm-undname at our pinned revision cannot demangle resource whitelist function names without crashing. Bug: 684788 Change-Id: I75bb11abcaca456adbea53799359a3259b942b17 Reviewed-on: https://chromium-review.googlesource.com/1180646Reviewed-by:
-
Nico Weber authored
Bug: 330260 Change-Id: I7e2d9d6d12f28d92ef157911edab9f3a0769cae2 Reviewed-on: https://chromium-review.googlesource.com/1181871Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584557}
-
Rayan Kanso authored
TBR=peter@chromium.org Change-Id: Id0351debe9c0c99f885ce5fd324068279e050e4e Reviewed-on: https://chromium-review.googlesource.com/1181601Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#584556}
-
Jeremy Klein authored
R=azeemarshad@chromium.org Bug: 850823 Change-Id: If8779b18e39f498c75798b092816adb79b1a7bfb Reviewed-on: https://chromium-review.googlesource.com/1180487 Commit-Queue: Jeremy Klein <jlklein@chromium.org> Reviewed-by:
-
Bailey Berro authored
Bug: None Change-Id: Ibaa0d86ef700576a96d8b5a40e04c8cb4fb8b850 Reviewed-on: https://chromium-review.googlesource.com/1181769Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#584554}
-
Miguel Casas authored
crrev.com/c/1171566 got reverted due to a mishmash of performance improvements and regressions. Instead of relanding it verbatim, the innocent/innocuous parts were landed in crrev.com/c/1180295; this CL gets the tough parts, including restricting it to VP9 and Kabylakes. I also repeated the power consumption results (https://goo.gl/r88qPf), and in a nutshell I see improvements: w/ this CL: 1.88 0.63 0.41 0.52 (pkg - pp1 - gfx - dram) ToT : 2.72 0.76 1.03 0.57 Savings : 30.78% 17.51% 59.95% 7.60% TBR=dcastagna@, hoegsberg@ Original CL description ----------------------------------------------- vaapi: decode on client NativePixmaps This CL teaches VaVDA to use client VASurfaceIDs to decode onto, saving a buffer copy and removing a costly blit (DownloadFromSurface) on the GPU Main thread. Three groups of changes: 1. In AssignPictureBuffers(): if |vaapi_picture_factory_| Create()s a VaapiPicture with a VASurfaceID, we use those to decode onto and set a new flag: |decode_using_client_picture_buffers_| 2. When the decoder calls CreateVASurface(), instead of giving it the first |available_va_surfaces_|, we need to figure out the first VASurfaceID in this |available_va_surfaces_| such that the corresponding VaapiPicture in |pictures_| is available (i.e. in |available_picture_buffers_|). Reason: libva holds on to some VASurfaceIDs, there's no simple one-to-one correspondence like on ToT. 3. When we're ready to OutputPicture() to |client_|, instead of using the first |available_picture_buffers_|, we find the corresponding one for the passed |va_surface_id| (we could search all over |pictures_| but there's always less |available_picture_buffers_|. Some other notable developments: - s/output_buffers_/available_picture_buffers_/ - OutputPicture() loses a parameter. - |decode_using_client_picture_buffers_| is still false for e.g. VP9 Profile 2 or the ImportBufferForPicture() path. Bug: 822346, 717265 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Icf1a9a1fa71264a7367fa351e3b7d28fab346744 Reviewed-on: https://chromium-review.googlesource.com/1181464Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#584553}
-
Balazs Engedy authored
Bug: 875903 Change-Id: I82c0e154101e7fee7c74262eadfc1ce974ae0a67 Reviewed-on: https://chromium-review.googlesource.com/1181566Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#584552}
-
Mohamed Heikal authored
Toolbar inflation currently takes around 200-300ms on the critical path during startup. This cl creates the class AsyncViewStub so that the toolbar stub is inflated on a background thread outside of the critical path. This leads to an improvement of 60ms for startup and 50ms for startup to contentful paint. Improvements are less than the 200ms being saved due to the remeasure+redraw caused by adding new views to the view hierarchy after startup. Design doc https://docs.google.com/document/d/1lwfhlWqp6os_QhikuqCx60LW5FdSbJ-40Es8ACGd4fI/edit?usp=sharing Change-Id: I1841f5adbb01a853e952b2e61dedfd4c951e125e Bug: 762120 Reviewed-on: https://chromium-review.googlesource.com/1136797Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#584551}
-
Anna Offenwanger authored
Runtimes should only be handled by the XRRuntimeManager. Moving the logic which handles getting current display info as well as checking for session supports out of XRDeviceImpl is a step in that direction. Bug: 842025 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I95bd331a30c91deb665aa12853f8a80d79c0e51b Reviewed-on: https://chromium-review.googlesource.com/1181535Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Cr-Commit-Position: refs/heads/master@{#584550}
-
John Z Wu authored
This should alleviate flaky errors when translating on iOS. When translate is tapped, translate_ios.js polls translate.js to wait for translate element ready and then later polls again to wait for the translation result. Polling can often time out due to network slowness. Bug: 869729 Change-Id: I7e0e46fe279571f21b3aa0dd18f241dc83afee90 Reviewed-on: https://chromium-review.googlesource.com/1178691Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#584549}
-
chrome://interstitialschrome://chrome-urlsMustafa Emre Acer authored
Bug: 875623 Change-Id: I746ddd20e991615f875ca479aab4abca921f123c Reviewed-on: https://chromium-review.googlesource.com/1181659Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#584548}
-
Stephen McGruer authored
This class is intended to be used to facilitate the transition of Blink animations from double-based times to TimeDelta-based times. This CL introduces a dual-compiled class, AnimationTimeDelta, which is compiled by default as double-based but can also be compiled to use base::TimeDelta as the underlying value. Bug: 737867 Change-Id: Ibba92d9eb860b20659b0897c505000a91d042988 Reviewed-on: https://chromium-review.googlesource.com/1175859Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#584547}
-
Becky Zhou authored
Bug: 860051 Change-Id: I08b602d2f02f8e61f1539a81483d4af9ad2e0493 Reviewed-on: https://chromium-review.googlesource.com/1180505Reviewed-by:
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ee3986dc7034..1dc067f0d0f9 git log ee3986dc7034..1dc067f0d0f9 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 primiano@google.com Docs: add long-trace docs. Created with: gclient setdep -r src/third_party/perfetto@1dc067f0d0f9 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ie306b4a0f000757750ffcf7cab79a36d858c65a6 Reviewed-on: https://chromium-review.googlesource.com/1181441Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584545}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f1f363fae757..820ebd0f6616 git log f1f363fae757..820ebd0f6616 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 sprang@webrtc.org Add field trial flag for increased receive buffers 2018-08-20 ssilkin@webrtc.org Fix Vp9 flexible mode in RTP ref frame finder. 2018-08-20 nisse@webrtc.org Fix --logs flag to webrtc_perf_tests Created with: gclient setdep -r src/third_party/webrtc@820ebd0f6616 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5886b978b0c231360b9a570b02253fd2ab27408b Reviewed-on: https://chromium-review.googlesource.com/1181686Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584544}
-
Theresa authored
Apparently this behavior was only intended for experiment and not for launch. BUG=875867 Change-Id: Iae541d55d064123808376cb34f2336dee945517d Reviewed-on: https://chromium-review.googlesource.com/1181179Reviewed-by:
-
Robert Sesek authored
This is a reland of 7217c9c4 Original change's description: > Add a new BPF helper syscall_broker::BrokerProcess::IsSyscallAllowed(). > > This helper can be used in bpf_dsl::Policy::EvaluateSyscall() to make it > easier to craft BPF policies that trap to the broker process. > > Change-Id: I8588b0a934343d7d0009c0d07bf259a085451ece > Reviewed-on: https://chromium-review.googlesource.com/1175934 > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583407} Change-Id: I08600bc7fc0c4d060138f135fd9eef4a31bd16db Reviewed-on: https://chromium-review.googlesource.com/1178341Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#584542}
-
Dan Harrington authored
I think we should obsolete DownloadedArchiveSizeVsExpected because: 1. It's not very useful, most reports are above 200% 2. We've already learned what we're going to learn, and UMA should eventually be removed anyway. In this CL I've also updated DownloadExpectedFileSize's description. Change-Id: I2ebe9a41a0f16dd49348cd62e564b217ef8db996 Reviewed-on: https://chromium-review.googlesource.com/1174853Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#584541}
-
Michael Giuffrida authored
This reverts commit 241c941f. Reason for revert: Causes crash: crbug.com/875697 Original change's description: > Record discarded state in TabActivityWatcher. > > (1) TabLifecycleObserver is added for TabActivityWatcher to track > OnDiscardedStateChange event. > > (2) In DidReplace(replaced_tab), the ukm_source_id and is_discarded > state is copied to new_tab so that we can track discarded state > after reload or closing. > (3) A browser test is added. > > Change-Id: I9777b515d28d215f3409525b0201dc5916d35941 > > Bug: 872139 > Change-Id: I9777b515d28d215f3409525b0201dc5916d35941 > Reviewed-on: https://chromium-review.googlesource.com/1166763 > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Chris Hamilton <chrisha@chromium.org> > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Charles . <charleszhao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584217} TBR=chrisha@chromium.org,jam@chromium.org,michaelpg@chromium.org,holte@chromium.org,charleszhao@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 872139 Change-Id: Ic32c319d1a75ebf3237677ccb8935744f95dfae2 Reviewed-on: https://chromium-review.googlesource.com/1181586Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#584540}
-
chrome://conflictsChris Hamilton authored
This changes encompasses a few refactors to make that possible: - Exposing GetDiscardReason and GetDiscardCount on LifecycleUnit, and moving the implementations to LifecycleUnitBase. - This causes a naming collision in TabLifecycleUnitExternal and LifecycleUnit, and TabLifecycleUnit implements both of these. To solve that, TabLifecycleUnit instead owns an TabLifecycleUnitExternalImpl, which it vends out. This is a thin facade around the existing functions in TabLifecycleUnit. - Lifted TabLifecycleUnit declaration to be publicly visible to minimize the required friend declaration fallout. Change-Id: Ib8016511f9c5414abc1190cb3bfa60f53a804bb6 Reviewed-on: https://chromium-review.googlesource.com/1176267Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#584539}
-
Bence Béky authored
Use CompletionOnceCallback instead of CompletionCallback in //storage/browser. Bug: 807724 Change-Id: Ieadbb2e82c1035900ee672e3bb4994359143bc04 Reviewed-on: https://chromium-review.googlesource.com/1167366Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#584538}
-
Philip Rogers authored
https://crrev.com/580735 updated the wrong Blink.Compositing.UpdateTime metric due to a rebase mistake. This patch fixes the mistake so that the following is true: SPV175 (current): Only Blink.Compositing.UpdateTime BlinkGenPropertyTrees: Blink.CompositingCommit.UpdateTime and Blink.Compositing.UpdateTime SPV2: Only Blink.CompositingCommit.UpdateTime Bug: 865168 Change-Id: I50b3bc45454755ce82ba72da05c42000eca971b7 Reviewed-on: https://chromium-review.googlesource.com/1181647Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#584537}
-
Bailey Berro authored
Bug: None Change-Id: I671b521dfc6bc34214d680aec2556584820dd18c Reviewed-on: https://chromium-review.googlesource.com/1181525Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#584536}
-
Yuwei Huang authored
Currently the Android app doesn't adjust the desktop canvas for cutouts on a notched device, so part of the desktop will get obstructed by the cutout. This CL fixes this by introducing a concept of safe area to DesktopCanvas. User can still see through and interact with the content in the unsafe area and pan the canvas out of it, while we use the safe area to calculate the minimum zoom level. Bug: 831670 Change-Id: I6a42bab8f383fa682bd2d2363b41bc6bb7a6d1c3 Reviewed-on: https://chromium-review.googlesource.com/1174982Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#584535}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dd765da4dff7..dd0c341bd251 git log dd765da4dff7..dd0c341bd251 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 rrangel@chromium.org httplib: Update to 0.11.3 Created with: gclient setdep -r src/third_party/depot_tools@dd0c341bd251 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:none TBR=agable@chromium.org Change-Id: Icc557b784698a0e7e0c5af66d458fb7b4c5ef18e Reviewed-on: https://chromium-review.googlesource.com/1181682Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584534}
-
Mohsen Izadi authored
GpuClientImpl is moved from //content/browser/gpu/ into //components/viz/host/ and renamed to GpuClient. BUG=851488 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I27c1586bc269d7e6b7e55f1de16451e1c3528285 Reviewed-on: https://chromium-review.googlesource.com/1171665 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
-
Nick Harper authored
Bug: 875046 Change-Id: I1926513d3b4ad703306a7ff291ac7a9e7e47966b Reviewed-on: https://chromium-review.googlesource.com/1178980Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#584532}
-
David Bienvenu authored
With VC++ marking a function as non-optimized with MSVC_DISABLE_OPTIMIZE would prevent it from being inlined, however with clang-cl that does not work, leading to confusing crash stacks. The fix is to use NOINLINE instead of MSVC_DISABLE_OPTIMIZE, which is more explicit and specific anyway. Bug: 873359 Change-Id: I374c15af002c1864abac1d9a26f20026cc941a07 Reviewed-on: https://chromium-review.googlesource.com/1179961Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#584531}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/032b3bed2b18..5b10a4c713fb git log 032b3bed2b18..5b10a4c713fb --date=short --no-merges --format='%ad %ae %s' 2018-08-20 thestig@chromium.org Remove refcounting from CFPF_SkiaFont. Created with: gclient setdep -r src/third_party/pdfium@5b10a4c713fb The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8dc9e3394c80a978aaeb19743b6e83224df06396 Reviewed-on: https://chromium-review.googlesource.com/1181543Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584530}
-
Eric Foo authored
Bug: 731500 Change-Id: I1da2890c00fdc736733c97284bc0da143423ca96 Reviewed-on: https://chromium-review.googlesource.com/1181642Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#584529}
-
Dominic Mazzoni authored
In the layout tree, a LayoutText corresponds to a static text node in HTML, which can span more than one line. Each line of text is represented by an InlineTextBox. In the accessibility tree, we have an AXLayoutObject for the LayoutText, and an AXInlineTextBox for the InlineTextBox. The coordinates of the AXInlineTextBox need to be expressed relative to its parent object, just like everything in the accessibility tree. It turns out that we need the local bounding box of the parent object (the LayoutText) to compute this. However, this leads to an inefficiency, because when you have a very large LayoutText (as an example, a TEXTAREA element with thousands of lines of text), each AXInlineTextBox keeps querying its parent LayoutText for its bounds, but the LayoutText iterates over all of its InlineTextBox children to compute its bounds! This leads to n^2 complexity where n is the number of lines in the LayoutText. The solution is just to cache the bounds of the LayoutText, so it only needs to be computed once. Bug: 875344 Change-Id: I97578ec0eadc597f962b142fb074e6929e834802 Reviewed-on: https://chromium-review.googlesource.com/1180647Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#584528}
-
Justin Cohen authored
Bug: 843244 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie47a226f37869f26b99b35f6cb2fedb194f53ae1 Reviewed-on: https://chromium-review.googlesource.com/1181461Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584527}
-
