- 13 Jan, 2021 20 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I7d83d8a9d4fdfc9015e1b371fc4635b709fca37b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625688Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842792}
-
Xiaohui Chen authored
Bug: None Change-Id: I8d6725898a1633a87be4759d76f9a12fe2ea49fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625808 Auto-Submit: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#842791}
-
Yue Zhang authored
In this CL we add strings for: * Module title. * Module warm welcome message. * Module-level action menu items. * Cart-level action menu items. * Module dismiss undo message. * Cart dismiss undo message. Right now these strings are not consumed and they will be used in later CLs. Bug: 1165935 Change-Id: I9e01da7eb13dac8e920795883939ca491f5ad9e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625948Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#842790}
-
Bailey Berro authored
This change introduces a RoutineLog class to manage the logging of routine status. Calls to `LogRoutineStarted` and `LogRoutineCompleted` append lines to a log at a provided path. Bug: 1128204 Change-Id: I379d9310371b703220788c674b21e641c184bbe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618841 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#842789}
-
Ahmed Mehfooz authored
Bug: 1165451 Change-Id: I8095ef53ec141ef30bee22aec6930dc12b027637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623171 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#842788}
-
Roman Arora authored
This is a reland of 339975cc This CL was reverted because it broke the Tab search list item contents that are supposed to be visible once a search filter is applied and then removed. This is now fixed in the updated patchset. Original change's description: > Tab Search: Infinite list - Efficient list DOM item updates > > Leverage the ListPropertyUpdateBehavior logic that uses Polymer's > splices and calculateSplices functions to efficiently modify a single > list item on tab updates, and avoid unnecessary scroll height > calculations. > > Additionally, tab updates for not yet rendered items do not result in > DOM updates. > > Proposal doc & benchmarks: https://docs.google.com/document/d/1FcuhM98moL-BYB1DJGXrpwf-JqMz1aI-RQV08giArBY/edit#heading=h.xzptrog8pyxf > > Most relevant pinpoint benchmarks: > https://pinpoint-dot-chromeperf.appspot.com/job/15db6158d20000 > https://pinpoint-dot-chromeperf.appspot.com/job/107ab7f4d20000 > https://pinpoint-dot-chromeperf.appspot.com/job/16ccacccd20000 > > Bug: 1149400 > Change-Id: I07fae967033b13830708da3035db3e8b2f0ff9d6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578119 > Commit-Queue: Roman Arora <romanarora@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Reviewed-by: Esmael Elmoslimany <aee@chromium.org> > Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842182} Bug: 1149400 Change-Id: Ia8ccf6d9ecdd80006de7a132fefcbe0357a68d5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622723Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#842787}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c0ef8ccfcd8b..d38b9f86ff8c 2021-01-12 cnorthrop@google.com Allow GL_OES_shader_image_atomic when non-conformant 2021-01-12 jmadill@chromium.org Vulkan: Index mandatory support table by ANGLE format. 2021-01-12 syoussefi@chromium.org Vulkan: Increment buffer view serials only when used 2021-01-12 syoussefi@chromium.org Vulkan: Notify ContextVk when UtilsVk binds compute pipelines If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Test: Test: Fortnite on ANGLE Change-Id: I58180c4b2568a30fcb8d09172f89b12f878d315c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625565Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842786}
-
Nicholas Verne authored
This is a reland of 3ece5c0f Original change's description: > Move crostini section under Advanced in settings. > > Bug: 1163003 > Change-Id: I9b2b439007c80bc0385128da4817ac001ee7eb0c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610407 > Auto-Submit: Nicholas Verne <nverne@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840920} Bug: 1163003 Change-Id: If8e1b56cda55269d67df5e9aad21464dc9245f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623571Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#842785}
-
danakj authored
Use the new helpers in TestRenderWidgetHost everywhere, and don't keep around unused local variables. R=nasko@chromium.org Bug: 1158869 Change-Id: Ia7d484689c42efb95234ccaf5eeea03159a2f653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601062 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#842784}
-
John Z Wu authored
This was originally used to easily inspect string16 in Xcode lldb. It seems this is not needed anymore since I can see string16 just fine w/o this script. Also delete the OWNERS file to let this directory be owned by top level OWNERS. The OWNERS file was originally created for lldb_chrome.py, which is no longer needed per above. Change-Id: I676327e282d6243046df744f6e7de4184537ba98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625970Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#842783}
-
Juanmi Huertas authored
This metric can be useful as there are some bugs related to Pixel Image Rendering that happened during last year. Extending for one more year this metric. Bug: 1160786 Change-Id: I40341c20eb7c40672322c375ca9e11bd0a2ed4ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623952Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#842782}
-
Kyle Horimoto authored
Previously, we'd look at the notification's "priority" field to determine whether or not we'd show a popup or just add the notification to the notification shade. This caused confusion to some users, since some messaging apps would add this as a "minimum" or "no" priority notification, which would cause us to silently add the notification instead of adding it as a popup. This CL updates the logic so that we always show notifications as a popup. Fixed: 1165646 Change-Id: Ic76bcb4eb448547ecc61c2d79828c07a3e3352b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626030 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#842781}
-
Dana Fried authored
This reverts commit e1f49aca. Reason for revert: Breaks build - linker error (see bug) Bug: 1165994 Original change's description: > Move installer.cc file to updater/win directory. > > The installer API code is Windows-specific and it would be desirable > to isolate //chrome/updater from its implementation details. > > This change uses public_deps and visibility to make > updater:lib and updater/win:lib act as a unit, to resolve the issue > of the circular includes as suggested by the GN documentation. > > Bug: 1014630 > > Change-Id: Ib47dc9041af08651549d0feaf35790f336dfe193 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588508 > Commit-Queue: Sorin Jianu <sorin@chromium.org> > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842765} TBR=sorin@chromium.org,waffles@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I0acf2fce533e34424465c4ce65202a53881feb4d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1014630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626351Reviewed-by:
Dana Fried <dfried@google.com> Commit-Queue: Dana Fried <dfried@google.com> Cr-Commit-Position: refs/heads/master@{#842780}
-
Martin Kreichgauer authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/e5fc0c7ccb3c..42f3f3cea406 $ git log e5fc0c7cc..42f3f3cea --date=short --no-merges --format='%ad %ae %s' 2020-12-21 yichengli u2fd: Add dbus method to test legacy u2f credentials 2020-11-20 stevenjb shill: Eliminate shill::kCarrier Device DBus property 2020-12-16 dlunev cryptohome: remove support for hidden mounts 2020-12-10 hardikgoyal cryptohome: Add AuthenticateAuthSession API 2020-12-25 cherieccy system_api: Remove unused kOpenFileMethod Created with: roll-dep src/third_party/cros_system_api Change-Id: I44ea0f9512bebc1a89bd7947728277c7f61d8657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625394 Auto-Submit: Martin Kreichgauer <martinkr@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#842779}
-
Sam Sebree authored
and HC white This CL fixes an issue in which, when in ForcedColors mode, the data list control uses an the default color scheme Bug: 1157185 Change-Id: I5103d371fe69226be4ee495f237dd23c874f23f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623150Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#842778}
-
Wenbin Zhang authored
This CL added the parsing logic for the new shard map with "sections", which allow stories from multiple index ranges from the same benchmark to run on the same shard. The generated argument will be: --story-shard-indexes=<range_string> Bug: chromium:1140389 Change-Id: Ifcd9fc16b6ec1be1ea20e0d68687b0d14b5d1f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617002 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#842777}
-
Henrik Lundin authored
The metric is no longer reported as of M84, http://crrev.com/767709. Change-Id: Ib050a9c437856a680e6c37c5fc15c4616345a24c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624732 Auto-Submit: Henrik Lundin <hlundin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#842776}
-
Boris Sazonov authored
Renames AccountManagerFacadeLacros to AccountManagerFacadeImpl and moves it to components/account_manager_core so it is accessible by both Ash and Lacros. It also renames the corresponding test and moves it to the new //components/account_manager_core:unit_tests target which runs on both Ash and Lacros. This is a preparation step before the upcoming unification of AccountManagerFacadeLacros and AccountManagerFacadeAsh. Bug: 1161699 Change-Id: I88486df45685a04540f332031835eec34bf1e11b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601750 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#842775}
-
Avi Drissman authored
Somehow, a U+200B ZERO WIDTH SPACE snuck into the Info.plist. Remove it. Bug: none Change-Id: If7ec7231fe8a3b71041b5c7015d66339e6f0e783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625907 Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#842774}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I8b3d0a5aacd29865200208641dcc222fce259c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625852Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842773}
-
- 12 Jan, 2021 20 commits
-
-
Jesse Schettler authored
Change the max height of the settings section based on whether the More settings section is expanded. This ensures the Scan button is positioned correctly below the settings section. Before and after: http://shortn/_iDTmWnZ6Aa Bug: 1059779 Change-Id: I823d8b931cb55ba553c6cdb9cd57d4d66097e73c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623156Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#842772}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 203 histograms that show frequent access in the past 90 days. These are the 95% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2021-04-12. TBR=chromium-metrics-reviews@google.com Change-Id: If968c19edda316d09f3da7bfaba93d3cd12e3b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626047Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#842771}
-
Findit authored
This reverts commit 67eedb97. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 842593 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNjdlZWRiOTcwYzJhYWY0MDI5Mzc1ZmYxODBmZDgxNzU4YTUzN2Q0NQw Sample Failed Build: https://ci.chromium.org/b/8858279089687558800 Sample Failed Step: blink_web_tests on Mac-10.15 Sample Flaky Test: virtual/threaded-prefer-compositing/fast/scrolling/autoscroll-latch-clicked-node-if-parent-unscrollable.html Original change's description: > Reland "Change autoscroll latching to top-most delta-consumable scroller" > > This is a reland of 07b882d4 > > The original CL was reverted due to a few layout tests failing in ASAN. > The cause of these failures was that vertical_autoscroll_layout_box_ > and horizontal_autoscroll_layout_box were not being cleared in > StopMiddleClickAutocroll. This resulted in heap-use-after-free errors. > > In order to fix this issue, the two pointers are cleared in > StopMiddleClickAutoscroll. They are also cleared if necessary in > StopAutoscrollIfNeeded. In the latter, middle click autoscroll would be > stopped if both layout boxes are to be cleared. > > Original change's description: > > Change autoscroll latching to top-most delta-consumable scroller > > > > Users will now be able to use middle click autoscroll to scroll a > > parent div if the inner-most scroller is unable to scroll in that > > direction. > > > > If there is no delta-consumable scroller, the top-most autoscrollable > > scroller will be latched. > > > > Bug: 1107648 > > Change-Id: Iccd4efec3b1ce5d09c701d3d46052176275dbc32 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488042 > > Reviewed-by: Robert Flack <flackr@chromium.org> > > Reviewed-by: Rahul Arakeri <arakeri@microsoft.com> > > Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> > > Cr-Commit-Position: refs/heads/master@{#835318} > > Bug: 1107648 > Change-Id: Idf3c2253a25d2cfbe12a8ffe30bbf697c636d222 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582733 > Reviewed-by: Robert Flack <flackr@chromium.org> > Reviewed-by: Rahul Arakeri <arakeri@microsoft.com> > Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#842593} Change-Id: Ifb6a6fac520d4c9ad963cb329156a2b5d995817a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1107648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626451 Cr-Commit-Position: refs/heads/master@{#842770}
-
Toni Barzic authored
When the camera privacy switch state changes, and a toast describing the new state is shown, cancel the toast for the previous state so it gets hidden immediately (the new toast is enqueued, so it won't hide the old one). Also, do not show toast when the privacy switch state changes from unknown to off state, so "Camera is on" toast is not shown for the default initial state. BUG=1165937 Change-Id: Ief3be58a89b52e17a597475baa1230dc3f2fbd4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626187 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#842769}
-
adamta authored
Fixes issue where refactored NTP flashes a semi black screen when loading by setting the NTP view's background colour. Bug: 1114792 Change-Id: I25a004aa818d61394c0856543442da48601f55c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625351Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#842768}
-
Josh Nohle authored
The previous implementation required slicing by send/receive, device type, *and* contact/non-contact. These histograms were too specific to be very useful. In this CL, we only slice by one variation. Manually verified Nearby.Share.Transfer.FinalStatus[...] metrics. Bug: 1105579 Change-Id: I37ed2f3113f02884ae726c86b2318575546fc880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619998 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#842767}
-
Rohit Agarwal authored
Tests relying on not having primary OTR profile can fail in batch test where one of the test may have opened an Incognito tab. This CL: a) Ensures closing all Incognito tabs between each test run in the batch to not have any Incognito residue between batch tests. b) Modifies the ProfileTest to open an Incognito tab before asking for the primary OTR profile as asking for primary OTR profile by default creates a new primary OTR profile if it doesn't exists already. Like, this we can delete the profile just by closing the Incognito tab which is now taken care by BlankCTATabInititalStateRule. Bug: 1161449 Change-Id: I5b4205ded48c74e8104acf240764ce4801b768d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612271 Commit-Queue: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#842766}
-
Sorin Jianu authored
The installer API code is Windows-specific and it would be desirable to isolate //chrome/updater from its implementation details. This change uses public_deps and visibility to make updater:lib and updater/win:lib act as a unit, to resolve the issue of the circular includes as suggested by the GN documentation. Bug: 1014630 Change-Id: Ib47dc9041af08651549d0feaf35790f336dfe193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588508 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#842765}
-
Yu Han authored
This reverts commit b1ce4a4e. Reason for revert: FormControlsBrowserTest.Input is failing in step "bf_cache_content_browsertests on Android device Nexus 5" on builder "android-bfcache-rel" List of failed builders: Builder: android-bfcache-rel https://ci.chromium.org/p/chromium/builders/ci/android-bfcache-rel First failing build: https://ci.chromium.org/p/chromium/builders/ci/android-bfcache-rel/b8858287909548350672 Original change's description: > Reland "[Controls Refresh Android] Fixes input missing border" > > This is a reland of 909901eb > > The revert was due to greater pixels error difference between > Mac 10.12 & 10.15 and the baseline. > > After checking the error rate on failed Mac bots, the fix is > to increase the error_pixels_percentage_limit from 9f to 10.2f in > form_controls_browsertest::FuzzyPixelComparator. > > Original change's description: > > [Controls Refresh Android] Fixes input missing border > > > > Prior to this CL, controls-refresh text input is missing its border. > > > > The fix is to make sure property text_field.has_border is passed to > > native theme. This property is only used by form controls-refresh > > so it has no impact on existing text input. > > > > Bug: 1155397 > > Change-Id: I3cacd4d9550e10388b15122d7ff94a32ffa5e39d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612495 > > Reviewed-by: Camille Lamy <clamy@chromium.org> > > Reviewed-by: Mason Freed <masonfreed@chromium.org> > > Commit-Queue: Yu Han <yuzhehan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#841106} > > Bug: 1155397, 1164011 > Change-Id: I6f06173f677b45664ff4cb6dedfb9197b8ece95b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618675 > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Camille Lamy <clamy@chromium.org> > Commit-Queue: Yu Han <yuzhehan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842590} TBR=clamy@chromium.org,masonfreed@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,yuzhehan@chromium.org Change-Id: I50b6869b0bb25b37207920ff401fd8a33ba5d85e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1155397 Bug: 1164011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625779Reviewed-by:
Yu Han <yuzhehan@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#842764}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d0102e007e70..98eb0a70aead If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC dfried@google.com,zmin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: dfried@google.com,zmin@google.com Change-Id: I81c24491fb1108228a3ab0463d7c486e26270278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625376Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842763}
-
Jesse Schettler authored
Update the styling of the helper text to match the spec. Since the spec no longer requires part of the text to be bold, remove the special handling for the bold text. Before and after: http://shortn/_BqGKKkyAyF Bug: 1059779 Change-Id: I6dbf1d91b1060bc27b30a2fcc85cb62bd5561640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623161Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#842762}
-
Gordon Seto authored
Simplify EsimFlowUiTest by moving different flows into separate test suites. Bug: 1093185 Change-Id: I137b339604e0c3c1ceaf959b288074b273582abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622575 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#842761}
-
Abigail Klein authored
message to global media controls. Bug: 1055150 Change-Id: I49b7c4679dfb402bb41436173cc4c99f6d52953a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622328 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#842760}
-
Trevor Perrier authored
This CL removes the unused histogram Translate.UndisplayableLanguage. This histogram records languages that can be translated but are not displayable in the current UI language. This happens because some Chrome languages do not have language name translations in their ICU file (or in java.util for Android). We don't need a histogram to capture these. We can find them with a script. Also, this histogram doesn't report which UI language the language name isn't available in which is what we would need to make fix the problem. Bug: 1037346 Change-Id: I995611743c5f37d7a6fc0cca67a55f6356738933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617217 Commit-Queue: Trevor Perrier <perrier@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#842759}
-
David Van Cleve authored
The Platform-Provided Trust Tokens design doc lays out a few types of metric we're aiming to collect to analyze the performance and stability of this new feature (https://bit.ly/platform-provided-trust-tokens). This CL and its parent, crrev.com/c/2606141, implement one of these metrics goals, allowing slicing existing Trust Tokens operation outcome metrics by whether a given operation is platform-provided. This will allow comparing the performance characteristics and success rates of platform-provided versus web token issuance. The overall implementation approach is to add a new delegate to TrustTokenRequestIssuanceHelper that it notifies when it learns it will be attempting to execute its operation locally (i.e. that it will be calling into its LocalOperationDelegate's FulfillIssuance method). TrustTokenOperationMetricsRecorder receives these delegate calls and updates the names of the metrics that it will record for the operation at hand, so that they contain a "PlatformProvided" histogram name part. This change adds this delegate interface and the new metric name construction logic in TrustTokenOperationMetricsRecorder. It additionally takes the opportunity to update net/histograms.xml with a no-op refactor changing the operation outcome metrics Net.TrustTokens.Operation*Time.{success|failure}.{operation type}) to use histogram variants; this makes it easier to add the new optional ".PlatformProvided" suffix in histograms.xml. Test: Browser tests confirm the metrics are recorded on success and fail Change-Id: I4c8e42bfa99d524b95b9f341ca6a66b5f24c29af Fixed: 1163019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603584 Auto-Submit: David Van Cleve <davidvc@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#842758}
-
Khushal authored
Remove entries from chrome://flags for UsePreferredIntervalForVideo, which has already launched on platforms targeted by the feature. Also avoid unnecessary plumbing for a few settings. Delete feature and associated code for ForcePreferredIntervalForVideo. This was added to test the impact of always throttling web content. Change-Id: Iae97333d4ed17716832dc692bfbcd3740e663626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621963 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#842757}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4442901e. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ie506336d67a4877fa7ccd74a0788b269d6ce9a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624869Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842756}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610463436-2052566ba20716214eb6d7caa0887c28794c37bd.profdata to chrome-win64-master-1610474333-dd150f7e1f8853577c8d1e97bbf4737322a5d0b4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I08a8983d3484a41d06493052b2220764aec8d6d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625566Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842755}
-
Nate Fischer authored
This configures bundletool.py to print bundletool.jar's stdout if it's invoked as a script. This is necessary for commands like "bundletool version" which print to stdout. This does not change the default behavior for the programmatic interface. Bug: 1165897 Test: build/android/gyp/bundletool.py version Change-Id: I0422c46bcdb0399d63b205ca7b92db9c50de7851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625747 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#842754}
-
Chun-Heng Tai authored
Change-Id: I0a04d7537c9e313e2c5e5157f836b4b28de44216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616901Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#842753}
-