GitLab

Triggered by https://codereview.chromium.org/369703002.

R=lcwu@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/442213002

Cr-Commit-Position: refs/heads/master@{#288227}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288227 0039d316-1c4b-4281-b951-d872f2087c98

Use webrtc::MouseCursorMonitor for cursor shapes instead of
webrtc::VideoFrameCapturer, in preparation for deprecating cursor shape
functionality in the latter.

Fix memory corruption in VideoSchedulerTests_StartAndStop, where a lingering
capture task could trigger a expectation action declared on the stack during
tear down. My changes to the test somehow made the race condition more likely.

BUG=324033

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247689

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248045

Review URL: https://codereview.chromium.org/92473002

Cr-Commit-Position: refs/heads/master@{#288226}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288226 0039d316-1c4b-4281-b951-d872f2087c98

It broke Drive sync completely.

> Parse Drive API responses all at once in the blocking pool.
> 
> Previous implementation did the parsing of string to base::Value
> on blocking pool, and that of base::Value to specific data types
> either on UI thread or on yet another post to blocking pool.
> 
> The previous implementation is slightly inefficient and moreover
> involves a subtle bug 284244.
> 
> BUG=284244
> 
> Review URL: https://codereview.chromium.org/442193002

TBR=kinaba@chromium.org
BUG=401843

Review URL: https://codereview.chromium.org/449323002

Cr-Commit-Position: refs/heads/master@{#288216}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288216 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#288210}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288210 0039d316-1c4b-4281-b951-d872f2087c98

Through CQ this time.

R=iannucci@chromium.org
BUG=366924
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/452703002

Cr-Commit-Position: refs/heads/master@{#288207}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288207 0039d316-1c4b-4281-b951-d872f2087c98

R=vadimsh@chromium.org
BUG=366924

Review URL: https://codereview.chromium.org/453753002

Cr-Commit-Position: refs/heads/master@{#288204}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288204 0039d316-1c4b-4281-b951-d872f2087c98

Jankometer is the last instance of a MessagePumpObserver. Since it has been
removed, MessagePumpObserver can also be removed.

BUG=none
R=darin@chromium.org

Review URL: https://codereview.chromium.org/421173003

Cr-Commit-Position: refs/heads/master@{#288203}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288203 0039d316-1c4b-4281-b951-d872f2087c98

Test Runner changes to allow integration tests as well as the ability
to point the device's google_base_url (or any android shell flag) to
a specified value in stored in a .flags file.

BUG=None

Review URL: https://codereview.chromium.org/444243002

Cr-Commit-Position: refs/heads/master@{#288202}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288202 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds an event to the <extensionoptions> tag that fires
if the guest view is attempted to be created with an invalid
extension id.

BUG=386838

Review URL: https://codereview.chromium.org/429763002

Cr-Commit-Position: refs/heads/master@{#288201}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288201 0039d316-1c4b-4281-b951-d872f2087c98

BUG=398888

Review URL: https://codereview.chromium.org/450753002

Cr-Commit-Position: refs/heads/master@{#288200}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288200 0039d316-1c4b-4281-b951-d872f2087c98

As is discussed in the bug, it is important to occupy certain
area for logo mark in the home card, otherwise the area for
the search results is restricted.

Actual experimental app-list uses start_page webview for this,
which embeds the logo from our resource data. I think it's better
to create a dummy view with flat background instead of loading
the resource image to emphasize this is still work-in-progress.

BUG=400153
R=oshima@chromium.org
TEST=none

Review URL: https://codereview.chromium.org/441123002

Cr-Commit-Position: refs/heads/master@{#288199}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288199 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401536

Review URL: https://codereview.chromium.org/445363009

Cr-Commit-Position: refs/heads/master@{#288198}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288198 0039d316-1c4b-4281-b951-d872f2087c98

Layer::CalculateContentsScale and its overrides never use
device_scale_factor, page_scale_factor, maximum_animation_contents_scale,
or animating_transform_to_screen. This CL removes these arguments.

BUG=None

Review URL: https://codereview.chromium.org/453533002

Cr-Commit-Position: refs/heads/master@{#288197}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288197 0039d316-1c4b-4281-b951-d872f2087c98

Also, ensure that it stays in sync with the renderer's copy.

BUG=99379,369661
TEST=no CHECKs hit in the wild, all tests stay green

Review URL: https://codereview.chromium.org/423393008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288196 0039d316-1c4b-4281-b951-d872f2087c98

This is where things go wrong and cause crbug.com/385795

BUG=385795
TEST=None

Review URL: https://codereview.chromium.org/448123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288195 0039d316-1c4b-4281-b951-d872f2087c98

included the transform for fixing the video orientation.

BUG=47554

Review URL: https://codereview.chromium.org/388643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288194 0039d316-1c4b-4281-b951-d872f2087c98

SetFromString that allows setting TraceOptions from a string instead.

SetFromString returns true upon success.

BUG=400382

Review URL: https://codereview.chromium.org/443523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288193 0039d316-1c4b-4281-b951-d872f2087c98

R=vadimsh@chromium.org
BUG=366924

Review URL: https://codereview.chromium.org/453743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288192 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Looks like the cause of http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/22085 failing.

runtest.py was repeatedly unable to find the test targets it was supposed to run.

partial log:
@@@BUILD_STEP base_unittests@@@
> /b/build/scripts/slave/runtest.py '--factory-properties={"generate_gtest_json": true, "target": "Debug", "gclient_env": {}, "build_url": "http://build1-a1/b/build/slave/Android_Builder__dbg_/chrome_staging/full-build-linux.zip", "clobber": false, "GYP_DEFINES": " component=shared_library", "target_os": "android", "android_bot_id": "main-tests-dbg"}' '--build-properties={"parentname": "Android Builder (dbg)", "got_nacl_revision": "13580", "parent_wk_revision": "179716", "parent_got_v8_revision": "22960", "parent_got_swarming_client_revision": "bbf1fcca7932d92cca9d7dab46ea271a7f6d61fb", "got_revision": "288139", "parent_revision": "288139", "blamelist_real": ["achaulk@chromium.org", "jamescook@chromium.org", "mef@chromium.org", "morrita@chromium.org", "varkha@chromium.org", "zty@chromium.org (:zty)"], "got_webkit_revision_git": "08c40136a44dd5b3f5bf976d5c75e7623afb8e29", "parent_slavename": "build1-a1", "got_v8_revision_git": "9d72b8dd94263d9f500f18255d67f0c7b8c3527a", "got_webrtc_revision_git": "a288b8cbb568cbf1735e6d5d0012524f4f8e5f74", "buildnumber": 22085, "got_webkit_revision": "179716", "parent_scheduler": "android", "got_swarming_client_revision": "bbf1fcca7932d92cca9d7dab46ea271a7f6d61fb", "parent_buildnumber": "63404", "slavename": "build42-a1", "blamelist": "achaulk@chromium.org,jamescook@chromium.org,mef@chromium.org,morrita@chromium.org,varkha@chromium.org,zty@chromium.org", "branch": "src", "patchset": "", "issue": "", "revision": "288139", "workdir": "/b/build/slave/Android_Tests__dbg_", "repository": "svn://svn-mirror.golo.chromium.org/chrome/trunk", "buildername": "Android Tests (dbg)", "parent_try_job_key": "", "got_webrtc_revision": "6825", "mastername": "chromium.linux", "parent_got_webkit_revision": "179716", "parent_builddir": "", "parent_branch": "src", "got_nacl_revision_git": "1fb9738130a80c961cf1ed46cdb38caf0d165543", "scheduler": "android_trigger_dbg", "requester": "", "buildbotURL": "http://build.chromium.org/p/chromium.linux/", "parent_cr_revision": "288139", "got_revision_git": "3afe85ad", "rietveld": "", "parent_got_nacl_revision": "13580", "parent_buildername": "Android Builder (dbg)", "got_v8_revision": "22960", "parent_got_revision": "288139", "project": "", "patch_url": "", "parentslavename": "build1-a1", "root": "", "primary_repo": ""}' --test-platform android --generate-json-file -o gtest-results/base_unittests --annotate gtest --build-number 22085 --builder-name 'Android Tests (dbg)' base_unittests --verbose
[Running on builder: "Android Tests (dbg)"]
DBUS_SESSION_BUS_ADDRESS env var not found, starting dbus-launch
 setting DBUS_SESSION_BUS_ADDRESS to unix:abstract=/tmp/dbus-p2NSrlwT6t,guid=118a14e22115547464aef590000002f4
 setting DBUS_SESSION_BUS_PID to 8386
Additional test environment:
  LLVM_SYMBOLIZER_PATH=/b/build/slave/Android_Tests__dbg_/build/src/third_party/llvm-build/Release+Asserts/bin/llvm-symbolizer

src/build/android/test_runner.py gtest --release -s base_unittests
Traceback (most recent call last):
  File "src/build/android/test_runner.py", line 836, in <module>
    sys.exit(main())
  File "src/build/android/test_runner.py", line 832, in main
    return command_option_parser.ParseAndExecute(option_parser)
  File "/b/build/slave/Android_Tests__dbg_/build/src/build/android/pylib/utils/command_option_parser.py", line 75, in ParseAndExecute
    return cmd.run_command_func(argv[1], options, args, option_parser)
  File "src/build/android/test_runner.py", line 746, in RunTestsCommand
    return _RunGTests(options, devices)
  File "src/build/android/test_runner.py", line 527, in _RunGTests
    runner_factory, tests = gtest_setup.Setup(gtest_options, devices)
  File "/b/build/slave/Android_Tests__dbg_/build/src/build/android/pylib/gtest/setup.py", line 325, in Setup
    % test_options.suite_name)
Exception: Did not find base_unittests target. Ensure it has been built.
using JSON summary output instead of gtest XML
No data was available to update the JSON results

Original issue's description:
> Run android tests through runtest.py.
> 
> This CL re-lands https://codereview.chromium.org/410033002 while addressed a few issues.
> 1. --results-directory must be passed along with --generate-gtest-json
> 2. --test-platform, --annotate, --build-number, --builder-name should be passed in order to upload results to correct dashboard
> 3. This CL depends on https://codereview.chromium.org/414223011/ to fix a bug in runtest.py
> 
> BUG=329102
> R=yfriedman@chromium.org, navabi@chromium.org, jbudorick@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288134

TBR=jbudorick@chromium.org,navabi@chromium.org,yfriedman@chromium.org,zty@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=329102

Review URL: https://codereview.chromium.org/455493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288191 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
This looks like the most likely culprit for the crash in http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/32814.

Partial stack dump:
	[16752:16752:0807/140640:WARNING:password_store_factory.cc(215)] Using basic (unencrypted) store for password storage. See http://code.google.com/p/chromium/wiki/LinuxPasswordStorage for more information about password storage options.
	[16783:16783:0807/140640:ERROR:sandbox_linux.cc(304)] InitializeSandbox() called with multiple threads in process gpu-process
	[16783:16783:0807/140640:WARNING:x11_util.cc(1408)] X error received: serial 61, error_code 8 (BadMatch (invalid parameter attributes)), request_code 72, minor_code 0 (X_PutImage)
	ASSERTION FAILED: info.fAlphaType == m_imageInfo.fAlphaType
	../../third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp(78) : virtual bool blink::DecodingImageGenerator::onGetPixels(const SkImageInfo &, void *, size_t, SkPMColor *, int *)
	1   0x7f11fbdbcdd8
	2   0x7f11fb0ea18c SkImageGenerator::getPixels(SkImageInfo const&, void*, unsigned long, unsigned int*, int*)
	3   0x7f11fb0bc349
	4   0x7f11fb13e30b SkPixelRef::lockPixels(SkPixelRef::LockRec*)
	5   0x7f11fb13e479 SkPixelRef::lockPixels()
	6   0x7f11fb04a6ea SkBitmap::lockPixels() const
	7   0x7f11fb05032d
	8   0x7f11fb0c35ca
	9   0x7f11fb051f51 SkBitmapDevice::drawBitmap(SkDraw const&, SkBitmap const&, SkMatrix const&, SkPaint const&)
	10  0x7f11fb05223b SkBitmapDevice::drawBitmapRect(SkDraw const&, SkBitmap const&, SkRect const*, SkRect const&, SkPaint const&, SkCanvas::DrawBitmapRectFlags)
	11  0x7f11fb0a3d4a SkCanvas::internalDrawBitmapRect(SkBitmap const&, SkRect const*, SkRect const&, SkPaint const*, SkCanvas::DrawBitmapRectFlags)
	12  0x7f11fb0a3de1 SkCanvas::drawBitmapRectToRect(SkBitmap const&, SkRect const*, SkRect const&, SkPaint const*, SkCanvas::DrawBitmapRectFlags)
	13  0x7f11fb12c296
	14  0x7f11fb12b9e1
	15  0x7f11fb12241f SkPicture::draw(SkCanvas*, SkDrawPictureCallback*) const
	16  0x7f11fc67a2a7 cc::Picture::Raster(SkCanvas*, SkDrawPictureCallback*, cc::Region const&, float)
	17  0x7f11fc6adc59 cc::PicturePileImpl::RasterCommon(SkCanvas*, SkDrawPictureCallback*, gfx::Rect const&, float, cc::RenderingStatsInstrumentation*, bool)
	18  0x7f11fc6ae45e cc::PicturePileImpl::RasterToBitmap(SkCanvas*, gfx::Rect const&, float, cc::RenderingStatsInstrumentation*)

Original issue's description:
> Define SK_PICTURE_CLONE_NOOP.
> 
> This makes SkPicture::clone() a cheap ref, meaning impl-side painting will render
> tiles concurrently from the same source SkPicture rather than from clones.
> 
> After testing for a few months in Skia, we believe SkPicture is thread safe enough
> to try this out on the Chrome bots.  Please revert this at the slightest sign of
> crash, flaky drawing, etc.
> 
> CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel
> 
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288096

TBR=reed@google.com,robertphillips@google.com,mtklein@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/455463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288190 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288188 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400530

Review URL: https://codereview.chromium.org/439873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288187 0039d316-1c4b-4281-b951-d872f2087c98

df449c0  Change '>=' back to '>' in extension.h due to bad fix
2ee9c3a  gclient DEPS file for auto checking out deps
9047b8b  Clean up meaningless branch on commented-out code.
ef72d48  Fix the problem that memory is accessed after released due to invalid type-cast
1b9c5c4  Fix use-after-free in CPDF_Color::~CPDF_Color
06a8c87  Fix unninitialized 'tmp' in CJBig2_Image::composeTo_opt2
7b99cd3  Remove unused |m_pEvi| field.
f47ab54  Fix a segmentation fault in CPDF_DataAvail::CheckPage due to invalid usage of i++

BUG=392719,387979,387811,387774,375773,400662
TBR=tsepez@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/449093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288186 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/421433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288185 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/434613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288184 0039d316-1c4b-4281-b951-d872f2087c98

BUG=397356

Review URL: https://codereview.chromium.org/445503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288183 0039d316-1c4b-4281-b951-d872f2087c98

(PageTestTestCase should also be the place to merge the unit test helper
defined in TestPageTestResults.)

BUG=383635

Review URL: https://codereview.chromium.org/449943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288182 0039d316-1c4b-4281-b951-d872f2087c98

This is a follow up CL of r287687, which missed the corner case that an error
happened before Stop().

This CL also updated the PipelineTest so that we explicitly check that all weak
pointers must have been invalidated before the stop callback returns. With this
check PipelineTeardownTest.Error_* tests will cover this corner case.

BUG=399417
TEST=Updated unit test.

Review URL: https://codereview.chromium.org/444333007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288181 0039d316-1c4b-4281-b951-d872f2087c98

There is a problem with keycode generation for non-trivial characters
(i.e. those that have modifiers) because the event array generated is
not simply a KeyDown/KeyUp combination; each modifier also gets a pair
of events.

Instead, scan through the events and send the first KeyDown that isn't
a modifier key.  Also, don't send key events if nothing is changing
(as happens with the final "commit").

SendSythenticKeyEvent needed to be extended to accept modifier flags.

BUG=118639

Review URL: https://codereview.chromium.org/426063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288179 0039d316-1c4b-4281-b951-d872f2087c98

This CL instruments the interstitial pages to generate the experience sampling API onDecision event.

BUG=384635

Review URL: https://codereview.chromium.org/399773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288177 0039d316-1c4b-4281-b951-d872f2087c98

Also, remove notifications no longer needed after r272421.

BUG=364831
TEST=as in bug

Review URL: https://codereview.chromium.org/420413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288176 0039d316-1c4b-4281-b951-d872f2087c98

The stub class should only be built for Android, not Chrome OS.

BUG=401791
TEST=verify that screen capture notification UI is shown on ChromeOS.
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/450023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288174 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky

Review URL: https://codereview.chromium.org/447403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288170 0039d316-1c4b-4281-b951-d872f2087c98

The corresponding Blink side change is https://codereview.chromium.org/447233003/ . These two can be committed in any order.

Review URL: https://codereview.chromium.org/450733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288168 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288167 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r13581: (dschuff) Further deduplicate and simplify PNaCl SCons testing
r13582: (dschuff) Remove unneeded items from list of trusty cross toolchain packages.
r13583: (dschuff) Add toolchain_build/git_cache to list of SVN ignores
r13584: (sbc) Fix for ARM cross build with clang.
r13586: (dschuff) Update x86-64 linux prep script for Trusty
r13589: (noelallen) NaCl has it's own copy of the build files, including several GNI files which use "declare_args" to provide build options.
r13592: (sheyang) Add PROJECT field to codereview.settings for nacl

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/449063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288166 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288165 0039d316-1c4b-4281-b951-d872f2087c98

These DEPS have not been updated for ~2 years, so there is a good chance
something will blow up. Due to interdependancy between the repos,
rolling gtest required gmock also be rolled.

BUG=none

Review URL: https://codereview.chromium.org/425333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288164 0039d316-1c4b-4281-b951-d872f2087c98

Adapted from rsleevi's original patch. The initial version of the tool rewrites
all implicit conversions of scoped_refptr<T> to T*, even unsafe ones where a
temporary scoped_refptr<T> is assigned to a T*. A small tweak/hack has also
been added to run_tool.py to allow it to handle replacements that contain
embedded newlines.

BUG=110610
R=mdempsky@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/446203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288163 0039d316-1c4b-4281-b951-d872f2087c98

I also updated ProvisionalSaveFailure in histograms.xml, which was an oversight from a previous cl.

BUG=386402

Review URL: https://codereview.chromium.org/421563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288162 0039d316-1c4b-4281-b951-d872f2087c98