- 28 Sep, 2020 29 commits
-
-
Ahmed Mehfooz authored
Consolidate pin logic into HoldingSpaceItemView since it will now be common between screenshots and chip views. Bug: 1131262 Change-Id: I600f5e7bb78726fe4b07afd379dd77857cd6bef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429533 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#811108}
-
Noel Gordon authored
Rename ImagePreviewResponseData => PiexPreviewImageData. Change raw => RAW in comments. Mark private ImageBuffer function @private and rename the this.details member => this.details_ for consistency. Add @param to onAbort error, use !PiexWasmImageResult, cast the Module type !PiexWasmModule. No change in behavior, no new tests. Bug: 1132695 Change-Id: Ia20783dc000b7a3d40537e3811aba6f6f6f6a7c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433745 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#811107}
-
Noel Gordon authored
piex-wasm assumes a fileSystemURL input as the RAW image source. Allow other users to input the RAW image source in an ArrayBuffer. Bug: 1132695 Change-Id: I47bcb837d42a8ca96ccdc79e306e012e0a3a82c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433744Reviewed-by:
-
Javier Fernández García-Boente authored
In order to create a new ShapeResultView, we use segments of a previous instance, analyzing its runs based on a new index range for the new instance. Since the start/end of the RunInfo structure may be different than the start index of the ShapeResultView, we use an adjusted_start to adapt the logic to the different data structures. We assume that if the passed start_index for the new range is greater than the current run's part start being processed, we should define the new run's start as the difference of these two values. However, we must also ensure that start_index is at least equal to the the part_start value for such run. The problem described in the issue 1130153 comes from the fact that we use the start_index on cases where it's smaller than the run's part_start. This leads to an incorrect (longer than expected) run. Bug: 1130153 Change-Id: Id5dd505baf1f990d2fe7a9406e191979cbd6b9f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431523Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#811105}
-
Ahmed Mehfooz authored
This class will own pinned_files_container and recent_files_container. It will also be responsible for setting the max size for the pinned files container based on available screen space and update it when screen space changes. The reland fixes a bug caused by removing GetBubbleView override from holding_space_tray that broke browser tests. Bug: 1131268 Change-Id: Ia0bf21261bb8f3b96f37366b04e1519dbe85c7a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432367 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#811104}
-
Anupam Snigdha authored
This patch adds a restriction in |HighestEnclosingNodeOfType| to not cross the enclosing block. This is useful so we can get the "outer" block node without crossing block boundaries as that function only breaks when the loop hits the editable boundary or the parent element has an inline style(as we pass |IsInline| to it). This is useful in cases like <div contenteditable><i><table><tr> <td>Please |put cursor here</td></tr></table></i></div> where | is the selection position. When execCommand("insertUnorderedList") is called the markup ends up as shown below: <div contenteditable><i><table><tr><td><ul><li> |Please put cursor here</li></ul></td></tr></table></i></div>. Test: run_web_tests web_tests/editing/deleting/listify-paragraph-inside-table-cell.html Bug: 1016530 Change-Id: I51f19b35e69fcf57f2c583e6a521e6460e7cb305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433025Reviewed-by:Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#811103}
-
Kent Tamura authored
- Remove non-existent source files - Add missing dependencies - Move browser_interface_broker_proxy.h and thread_safe_browser_interface_broker_proxy.h from public:blink_headers to public/common:headers These files are included by common:common, however we can't add public:blink_headers to common:common's deps because of a circular dependency. This CL has no behavior changes. Bug: 800764 Change-Id: I61cc0c08978ed0594cb0a0f7b395721978a36a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434009 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#811102}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I2150bca28954626cc264132084a02bcada980f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434726Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811101}
-
Johann Koenig authored
This reverts commit ac56b3e7. Reason for revert: PhoneHubUiControllerTest.NotEligibleForFeature fails on msan builds: $ autoninja -C out/chromeos_msan ash_unittests && ./out/chromeos_msan/ash_unittests --gtest_filter="*PhoneHubUiControllerTest*" [==========] Running 9 tests from 1 test suite. [----------] Global test environment set-up. [----------] 9 tests from PhoneHubUiControllerTest [ RUN ] PhoneHubUiControllerTest.NotEligibleForFeature ==1672876==WARNING: MemorySanitizer: use-of-uninitialized-value https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20740 PhoneHubUiControllerTest.BluetoothOff PhoneHubUiControllerTest.NotEligibleForFeature PhoneHubUiControllerTest.OnboardingNotEligible PhoneHubUiControllerTest.PhoneConnected PhoneHubUiControllerTest.PhoneConnecting PhoneHubUiControllerTest.PhoneConnectingForOnboarding PhoneHubUiControllerTest.PhoneDisconnected PhoneHubUiControllerTest.ShowOnboardingUi_WithPhone PhoneHubUiControllerTest.ShowOnboardingUi_WithoutPhone Original change's description: > [CrOS PhoneHub] Add PhoneHubUiController. > > This class translates the PhoneHubManager state into the corresponding > UI state and view that is shown in the tray bubble. Each state has > it's own view class and the PhoneHubTray bubble transitions through > these content views as the UI state changes. > > This CL also refactors PhoneConnectedView into it's own class. > > BUG=1106937,1126208 > > Change-Id: Ie012077a1905f80be91fbfb0b084d89219bd6c26 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427060 > Commit-Queue: Tim Song <tengs@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810942} TBR=khorimoto@chromium.org,tengs@chromium.org,leandre@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1106937 Bug: 1126208 Change-Id: Ibd11174488010a7b210896d8f16943cfba90f918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434010Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#811100}
-
Findit authored
This reverts commit 278cb45f. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 811094 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzI3OGNiNDVmZDcxNzBjMGYzYWZhMGQ4ZGExYzRjYzRmOWU0YzkzZTgM Sample Failed Build: https://ci.chromium.org/b/8867949354369276768 Sample Failed Step: compile Original change's description: > Video Tutorials: Added video player UI > > This CL adds the video player UI. > 1 - Added VideoPlayerActivity at chrome layer, which creates > VideoPlayerCoordinator and passes a WebContent supplier in order to > create ThinWebView. > 2 - Added video player MVC, the mediator handles display logic between > loading screen, controls, thinwebview, and language picker. > It also handles callbacks for control buttons, and observes media > session through a PlaybackStateObserver. > > TODO : > Add screenshot. Add UI polish. Define share/watchnext behavior. > Polish media session logic. > > Bug: 1117172 > Binary-Size: Unavoidable method count increase (includes methods from previous CL). > Change-Id: Ide7c0d7bf4fa20a9bfbe0c10717e6983d0da88dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415672 > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811094} Change-Id: I8de44b83196ee7ac90090f2c6d765a9aa3429430 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1117172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434557 Cr-Commit-Position: refs/heads/master@{#811099}
-
tby authored
This replaces the placeholder request with one that correctly identifies ourselves, uses the right scenario, and limits the response details. Two notes: - There's no need for us to control any part of this request via Finch, because we can change what model the scenario maps to on the backend. - I've increased the number of requested results to 10, in case some are unavailable at display time. Bug: 1034842 Change-Id: Ibf37b912e0a2f115ba2bdb13c866b25e24e6e620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434007Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#811098}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/90a7c922079a..296dd3b4062e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC johannkoenig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099917 Tbr: johannkoenig@google.com Change-Id: I8601986a34d1d9da60f57c07e3ff5b80fac45d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434687Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811097}
-
Callistus authored
- Deleted manifest.json, pwa.html - Populated WebApplicationInfo with values from manifest.json - Updated installation for Help app in CreateSystemWebApps Bug: b/168159973 Change-Id: I3106cd8eba5806762afd24ce36b9ff522e93b375 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428490Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Auto-Submit: Callistus Tan <callistus@google.com> Commit-Queue: Callistus Tan <callistus@google.com> Cr-Commit-Position: refs/heads/master@{#811096}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601229184-a90fd4bcb76e7d51e9443afa58b53f4dbea26e4c.profdata to chrome-linux-master-1601250178-9224448c4ec6426aeb7b75620d909f898b369921.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org Change-Id: Idbe0632578ba821247311f2082e60f71b5b12022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434688Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811095}
-
Shakti Sahu authored
This CL adds the video player UI. 1 - Added VideoPlayerActivity at chrome layer, which creates VideoPlayerCoordinator and passes a WebContent supplier in order to create ThinWebView. 2 - Added video player MVC, the mediator handles display logic between loading screen, controls, thinwebview, and language picker. It also handles callbacks for control buttons, and observes media session through a PlaybackStateObserver. TODO : Add screenshot. Add UI polish. Define share/watchnext behavior. Polish media session logic. Bug: 1117172 Binary-Size: Unavoidable method count increase (includes methods from previous CL). Change-Id: Ide7c0d7bf4fa20a9bfbe0c10717e6983d0da88dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415672 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#811094}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601229184-d47c881ab947e7e0fd2f4d9c9f5a7e73566e67be.profdata to chrome-mac-master-1601250178-2f977882900933eb8f19c7762bd76dadbd9f342f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: I118bc7efde1e70e86796d0dc2412e0e2f75fb0a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434689Reviewed-by:
-
Kunihiko Sakamoto authored
This fixes a crash bug when a Subresource Web Bundle had a 3xx response. After this CL, non-200 responses in Subresource Web Bundles will result in ERR_INVALID_WEB_BUNDLE. Bug: 1127538 Change-Id: Ie03ca457477242ded92624e4c5274766bdc95378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428435Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#811092}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/d0e7ed37fc4e..f05c076e26b0 2020-09-28 cepheus@frii.com Revert "Add more flexible SpirvToolsDisassemble interface to allow specifying spv_target_env for disassembly output. (#2406)" 2020-09-27 dev@creatingtrouble.com Add more flexible SpirvToolsDisassemble interface to allow specifying spv_target_env for disassembly output. (#2406) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,syoussefi@google.com Change-Id: I3d91ebd15a3f1823e3cfe5c8c06b716918958e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434686Reviewed-by:
-
Charles Zhao authored
Bug: 1054628 Change-Id: I6eb96bbdc04736ecb17ca6d825b26f60f0bace6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428408Reviewed-by:
Xinglong Luan <alanlxl@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#811090}
-
Johann authored
Tests added in b85903de do not pass yet: out/Default/content_shell --run-web-tests webcodecs/basic_video_encoding.html BUG=chromium:1127073 Change-Id: Ib0dd41b9e05b7abefd9a6bdebcff1f45eba3e016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434585Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#811089}
-
Johann authored
./out/msan/sandbox_linux_unittests --gtest_filter=*BrokerRemote* TBR=mpdenton@chromium.org BUG=chromium:1117351 Change-Id: I4c833eb633ce8f93aa7846fa12cefd0f417202f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434586Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium d61e7903. With Chromium commits locally applied on WPT: 74e4b2fc "[COOP] access reporting: Use infinite timeout for receive." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I77b45af616b29570730f21af0436cef8ccb6fe27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434624Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811087}
-
Luke Zielinski authored
This will create a -diff.txt and -pretty-diff.html file for any test that has an actual output. Absence of expected output is fine, the diff will show the actual output as all new. Bug: 1127360 Change-Id: I7f73741ff6d24571a20160239ee17ae69c6804e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428826 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#811086}
-
Noel Gordon authored
piex-wasm assumes chrome.runtime.reload can be used to reload the page on Module failures. Other environments (normal web pages, web workers, NodeJS, etc) obviously can't use chrome.runtime.reload. Remove the chrome.runtime.reload assumption: change the client code to provide the failure handler to piex-wasm. Change image_request_task.js RAW image client code: pass in the chrome.runtime.reload handler. While here, add or adjust comments to image_request_task.js and change the direct loading case to arrow function. No change in behavior. Bug: 1132695 No-try: true Change-Id: I6a2b641cdc036dd208f4d64deb4f0b7fdff0835f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432705 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Yuheng Huang authored
Bug: 1099917 Change-Id: I7aeaf8c2f62f36576f418239531ae9c938f305cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433589Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#811084}
-
Weilun Shi authored
Split the rest of the histograms.xml into multiple smaller xmls. This makes all histograms are searchable from code search and reduces the load time to render a histograms.xml file. This cl hasn't deleted the old histograms.xml yet because there are other code referencing to it. Bug: 993193 Change-Id: If813a3aaaf1b60cc4db4860fef31d562a13ef23e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428796 Commit-Queue: Weilun Shi <sweilun@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#811083}
-
Tal Pressman authored
Although the AgentSchedulingGroupHosts's RenderProcessHost remains constant, the underlying process behind it might die and be restarted. When that happens, we need to create a new AgentSchedulingGroup in the new renderer process, and re-bind the mojo endpoints. This is done by resetting the mojo endpoints when the process exits, and having the various public methods rebind them when necessary. Bug: 1111231 Change-Id: I48169dad231b5912078ff59f7bf6a370017d2031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397057 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#811082}
-
David Bienvenu authored
Bug: 1010217 Change-Id: I8b8759103f6f34e65d1f28ee6dde52d9a69c87f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434364Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811081}
-
Darwin Huang authored
The constructor's argument order was flipped. Please see the "fill(6)" constructor for more info: http://www.cplusplus.com/reference/string/string/string/ Previously, this would cast ' ' to a size_t, and length to a char. Change-Id: I6eca18bfa48fa3f303ea2881f3ebfd342e72742c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432747 Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
-
- 27 Sep, 2020 11 commits
-
-
Yue Li authored
Add the browser client to get Access token. Bug: b/150034512 Test: Manual Test Change-Id: Ic3f87ee4299779797005d56daa411b122750bea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429528 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
-
Thomas Lukaszewicz authored
Bug: 1099917 Change-Id: Ie74de530af3fdb7aa87ed14ac14aba47c7fd5b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432677 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#811078}
-
Christopher Cameron authored
Add a method to media::VideoDecodeAccelerator to indicate whether SharedImage-backed picture buffers are supported. Make this return true only for the VTVideoDecodeAccelerator. Add a parameter to media::PictureBufferManager::CreatePictureBuffers to indicate if SharedImage-backed PictureBuffers are desired. Hook the two of these together in the ProvidePictureBuffersAsync method of media::VdaVideoDecoder. Video playback fails with the Metal-based command decoder, because it binds IOSurfaces as TEXTURE_2D, not TEXTURE_RECTANGLE. Plumb through a flag to specify if TEXTURE_RECTANGLE support is present. Bug: 1108909 Change-Id: I1e42aa38e122714517724cee87eb51987645e410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427545 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#811077}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4812e31f727c..90a7c922079a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I6ad8c09731f6e939152c4a97ff4caac31bb9e6de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433996Reviewed-by:
-
Bret Sepulveda authored
When the Permission Chip is enabled, you get a broken-looking UI when there's no short string written. This patch works around this by falling back to the old UI. Bug: 1019129 Change-Id: If214734f780a0423c4ef9bdb0198c433cffc3cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431429 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#811075}
-
Maciek Slusarczyk authored
ChromeOS.SAML.InSessionPasswordChangeEvent tracks usage of in-session SAML password change feature. Extending its validity by 6 months to collect additional data. Bug: 1130656 Change-Id: I2bae3dbe7cf9a08d599586d568529277aab6c89b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431886Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Maciek Slusarczyk <mslus@chromium.org> Cr-Commit-Position: refs/heads/master@{#811074}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bdcc75794121..4812e31f727c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I85cfff21da84e6fcdd03919e8744f84e694ddf6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434504Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Id5ba6dd7e98c3f1242044cb1142d4ff3c6f7fb46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434424Reviewed-by:
-
Jinsuk Kim authored
Class CustomToolbar inherits ToolbarLayout for the layout for Custom Tab Toolbar. It also provides an implementation of LocationBar interface used in omnibox. The concrete implementation classes for Custom Tab don't necessarily have to be a part of toolbar/. This CL moves the class to customtab/features/toolbar where other implementation of Custom Tab features are placed. This also helps reduce the outbound dependencies the class brought in to toolbar/. Bug: 1127732 Change-Id: I32a0d556a979d213293dd46aea5ff51afa966dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426155 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#811071}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601207727-a01abff7a6bd2da6f6116384bec1a348a3a7afe9.profdata to chrome-mac-master-1601229184-d47c881ab947e7e0fd2f4d9c9f5a7e73566e67be.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand@chromium.org Change-Id: Ibcf7d54c0a466dba3f90cbf1c939e2405ed45b05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433990Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601207727-0dd0eb0febc74c41e7a623fe044ff01ea199dede.profdata to chrome-linux-master-1601229184-a90fd4bcb76e7d51e9443afa58b53f4dbea26e4c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: Ic59f4ae4a064384b6dbe274a5e09b74ea250d62c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433989Reviewed-by:
-
