- 08 Feb, 2019 40 commits
-
-
Andrew Grieve authored
Bug: 928902 Change-Id: I8deed83f0d2ecfcfd01238e05f0f99bd231d7956 Reviewed-on: https://chromium-review.googlesource.com/c/1460481Reviewed-by:
David Turner <digit@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#630314}
-
Tien Mai authored
Base unit test has all the boiler plate code needed to run a fake gls from a unit test that derives from it. Added a helper function for creating fake users during GCPW unit test Fix timing of gls done event in unit test not being consistent when a gls run fails and when it doesn't. When the gls run fails, the completion event is sent too soon and causes some unit tests to start running and checking the results before they have been properly set. Change-Id: I3754d8fafc3ffce5c5b50eae71db007f980c872c Reviewed-on: https://chromium-review.googlesource.com/c/1458679 Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#630313}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cd4f1fbaabce..e03498f2d25a git log cd4f1fbaabce..e03498f2d25a --date=short --no-merges --format='%ad %ae %s' 2019-02-08 fjhenigman@chromium.org Increase instanced draw testing. Created with: gclient setdep -r src/third_party/angle@e03498f2d25a The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Id672d2d4c8aae622f6e93ec59472866f7f613d11 Reviewed-on: https://chromium-review.googlesource.com/c/1460152Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630312}
-
Dominic Battre authored
This code probably predates base::Optional which makes the code a bit simpler and uses less memory. Just a drive-by cleanup... Bug: 918846 Change-Id: I3b41250bdfff8283ce31a4c41f567b0f593fa4db Reviewed-on: https://chromium-review.googlesource.com/c/1459627Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#630311}
-
Christian Dullweber authored
On Chrome OS, we show an app named "Chrome" as hosted app in Clear Browsing Data. This is not an actual app but just a shortcut to the NTP, so we shouldn't list it there. Bug: 929635 Change-Id: I444177cec28d4ab28b7284ba871a4cc30eb3f248 Reviewed-on: https://chromium-review.googlesource.com/c/1458208 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#630310}
-
Mikel Astiz authored
The two KeyedServices should be around in non-test code, and otherwise the dependent datatypes shouldn't be registered. Bug: 915154 Change-Id: I9f3f4fcdbc6715b49e3d7c424ce408e2d1869b14 Reviewed-on: https://chromium-review.googlesource.com/c/1459631 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#630309}
-
Bruno Santos authored
Bug: 927809 Change-Id: I403bfae34f438d27aa072d9f80396e38228e699e Reviewed-on: https://chromium-review.googlesource.com/c/1450332Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Bruno Santos <brunoad@chromium.org> Cr-Commit-Position: refs/heads/master@{#630308}
-
Henrique Ferreiro authored
Replace usage of AccountTrackerService, ProfileOAuth2TokenService and SigninManager with IdentityTestEnvironment via IdentityTestEnvironmentBrowserStateAdaptor. Bug: 920252, 922797 Change-Id: Idf8709b3980e0130403e812843242464d15b1f70 Reviewed-on: https://chromium-review.googlesource.com/c/1424843 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#630307}
-
Henrique Ferreiro authored
Replace with IdentityManagerFactory. This matches what CustodianProfileDownloaderService is using. Bug: 927242 Change-Id: Ib4182ea61dce2ac5856e4dca8b046f51b9e7c771 Reviewed-on: https://chromium-review.googlesource.com/c/1449681Reviewed-by:
-
Alessio Bazzica authored
This is a reland of a2fafd30 Hopefully the last reland. This CL adds the following: - M_PI was also missing in fftpack.c - temporary disable SIMD for iOS as well - M_SQRT2 missing Original change's description: > Reland "Reland "Add build file for PFFFT"" > > This is a reland of c1086af0 > > This CL fixes the compile issues of the reverted CL by defining M_LN2 when not defined. > > TBR=thakis@chromium.org > > Original change's description: > > Reland "Add build file for PFFFT" > > > > This is a reland of 8e4cf155 > > > > This CL includes the following changes: > > 1. when fuzzing, PFFFT is compiled disabling SIMD > > 2. SIMD is also disabled on fuchsia and android because PFFFT only checks __arm__ > > 3. unit test to validate the output of PFFFT (compared against that of FFTPACK) > > > > The first change fixes the problem due to which the original CL has been reverted; > > however, it makes fuzzing slower and reduces the coverage since SIMD cannot be used. > > > > Similarly, the second change is a temporary solution to allow landing this CL. > > SIMD will be re-enabled in a follow-up CL. > > > > Original change's description: > > > Add build file for PFFFT > > > > > > - fuzzer corpus generator and fuzzer targets > > > - fftpack isolated as private test only target (only needed for the benchmark) > > > > > > Bug: webrtc:9577 > > > Change-Id: Idc904bc4b05f945a7461a14893518551bbe34b84 > > > Reviewed-on: https://chromium-review.googlesource.com/c/1452000 > > > Commit-Queue: Ale Bzk <alessiob@chromium.org> > > > Reviewed-by: Nico Weber <thakis@chromium.org> > > > Reviewed-by: Olga Sharonova <olka@chromium.org> > > > Reviewed-by: Max Moroz <mmoroz@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#629627} > > > > Bug: webrtc:9577 > > Change-Id: Icfbb4b966c3ad866e9e2970b63363e0e258b1fea > > Reviewed-on: https://chromium-review.googlesource.com/c/1458076 > > Commit-Queue: Ale Bzk <alessiob@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Reviewed-by: Max Moroz <mmoroz@chromium.org> > > Reviewed-by: Max Morin <maxmorin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#630085} > > Bug: webrtc:9577 > Change-Id: I6bfe6d5f103570cebb6ca7909bd0369ecd8a7c45 > Reviewed-on: https://chromium-review.googlesource.com/c/1460616 > Commit-Queue: Ale Bzk <alessiob@chromium.org> > Reviewed-by: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#630278} Bug: webrtc:9577 Change-Id: I0f5055026132d49357ebbf483dc6b0da9ed23c97 Reviewed-on: https://chromium-review.googlesource.com/c/1459630Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#630305}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7b4aa52e2435..b1dbb0c6184f Created with: gclient setdep -r src-internal@b1dbb0c6184f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I5b2986c3de42b0dc44ebe7883fd341bb17bdaa3c Reviewed-on: https://chromium-review.googlesource.com/c/1460153Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630304}
-
Tsuyoshi Horo authored
I will implement Signed Exchange Reporting for distributors behind this flag. https://www.chromestatus.com/features/5687904902840320 Bug: 910516 Change-Id: Ic96c1e13e00c94a524123322cb58201115de1add Reviewed-on: https://chromium-review.googlesource.com/c/1459875Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#630303}
-
chrome://resourcesDominic Battre authored
Bug: 929468 Change-Id: Ie612093464885d8f17ccea60082183327e39ab64 Reviewed-on: https://chromium-review.googlesource.com/c/1458205Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#630302}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/44bffbfc1c3e..e0c94a27a320 git log 44bffbfc1c3e..e0c94a27a320 --date=short --no-merges --format='%ad %ae %s' 2019-02-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 635f1120..3e6732ee (349 commits) Created with: gclient setdep -r src/third_party/skia@e0c94a27a320 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I2c1ef5040b086ae265a5a88467073476620120e5 Reviewed-on: https://chromium-review.googlesource.com/c/1460150Reviewed-by:
-
Noel Gordon authored
Reconsider that idea (failed on the win bots). - add support for benching multiple input image files - include the input image file name in the output - remove an old TODO Tbr: leon Bug: 601198 Change-Id: Ib324c224069707539393d22daf0d2e5bc9322258 Reviewed-on: https://chromium-review.googlesource.com/c/1460742Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#630300}
-
Fredrik Söderquist authored
kRunPostLayoutTasksAsyhnchronously -> kRunPostLayoutTasksAsynchronously Change-Id: Ice2387d068a38bfcbe6a6fc14b1a35db576fa289 Reviewed-on: https://chromium-review.googlesource.com/c/1460916 Commit-Queue: Fredrik Söderquist <fs@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#630299}
-
Alexandr Ilin authored
This CL prepares the reached code profiler for the finch experiment. It adds: - base::Feature "ReachedCodeProfiler", which state is cached in - Android shared preference "reached_code_profiler_enabled", that determines whether to set - command line switch "enable-reached-code-profiler", that eventually enables the profiler We cannot simply use a base::Feature for the reached code profiler because we have to know the feature state very early in the startup, before the FeatureList is initialized. To work around this limitation we cache the feature state in Android shared preferences that are available in Java before native is initialized. Since only the browser process has a right to read the shared preferences we pass the value of the cached feature state as a command line flag to all processes. Bug: 916263 Change-Id: I730b98c5484ca595bdfda46592572f5853784aa8 Reviewed-on: https://chromium-review.googlesource.com/c/1393328Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#630298}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/054df48c..b8e007d8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0d22585fca837ecf962d03351d5407149cdbdac1 Reviewed-on: https://chromium-review.googlesource.com/c/1460856Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630297}
-
Yang Guo authored
lld currently ignores -rpath-link. Given that, it's likely this isn't needed for any linker. Please shout (on the review) if you do need this. Change-Id: I928692772c649f172a88adbe5b4483721d2beb7c Reviewed-on: https://chromium-review.googlesource.com/c/1459634Reviewed-by:
-
Scott Violet authored
This is temporary to get the keyboard drawing again. I will swing back to this and refactor MusLsiAllocator to better accomodate embed roots. BUG=none TEST=none Change-Id: I22e48825daca32d69ef7591a5e8f2c81be35ebdd Reviewed-on: https://chromium-review.googlesource.com/c/1460440 Auto-Submit: Scott Violet <sky@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#630295}
-
Kush Sinha authored
|AccountReconcilor::EnableReconcile| DCHECKs for |delegate_->IsReconcileEnabled()|. However for an entity external to |AccountReconcilor| and / or its delegate, it is impossible to know if the delegate has reconciliation enabled. This was fine earlier because |AccountReconcilor::EnableReconcile| was only called by the delegate but after the introduction of |AccountManagerMigrator| on Chrome OS, the delegate is not the only caller of |AccountReconcilor::EnableReconcile|. Fix this by removing the DCHECK. This is fine because |AccountReconcilor::StartReconcile| already checks for |delegate_->IsReconcileEnabled| before actually starting any mutations. Check the attached bug for context. Bug: 929739 Change-Id: Iac4eddf3485221d4f3a0a5ebee08e287ecd0d7c4 Reviewed-on: https://chromium-review.googlesource.com/c/1459621Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#630294}
-
Miyoung Shin authored
This CL moves OAuth2TokenServiceDelegateAndroid that is ProfileOAuth2TokenService's Android delegate from the signin component's 'browser' GN target to its 'internals' GN target. Bug: 927231 Change-Id: Ifbddc513c0ceb42b6ca3af0f60e1ca94015da8ce Reviewed-on: https://chromium-review.googlesource.com/c/1457799Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Antonio Gomes authored
CL implements IdentityManager::StartObservingCookieChanges as a wrapper to GaiaCookieManagerService::InitCookieListener API. As for the unittest, the following was done: - Removed the call to GCMS::InitCookieListener() from IdentityManagerTest ctor. Reason: up to this point, all existing tests pass without this method being invoked, given that no calls to GCMS::OnCookieChange() were actually coming from network::CookieManager through mojo (GCMS inherits from network::mojom::CookieChangeListener). Instead SimulateCookieDeletedByUser() was being used to call GCMS::OnCookieChange(). - Actually calls GCMS::InitCookieListener() from the newly added IdentityManagerTest.StartObservingCookieChanges test, though the newly added IdentityManager::StartObservingCookieChanges API. From this test, dispatch a cookie change through the mojo pipe with a known cause, so that the test blocks on the expected IdentityManager observer call (OnAccountsCookieDeletedByUserAction). BUG=926864 Change-Id: I88d4499831e80252716a605e2fa346b73d5289d6 Reviewed-on: https://chromium-review.googlesource.com/c/1460016 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Tom Anderson authored
This is necessary to green-up the 'Build From Tarball' bot. The bot is running Trusty, which has a system libstdc++ that's too old to support many of the features in base that gn relies on. Here's the story of why this is now necessary: 1. Chromium's gn was originally built with libc++ to get around this exact issue. 2. gn was moved into a standalone repo. 3. The libc++ sources weren't copied into standalone gn, so their solution to fix this issue was to pull Chromium's debian sysroot that has newer libstdc++ headers. 4. For whatever reason, the option to build with the sysroot was removed from the public repository and now the bots have a step to pull the sysroot. This can be removed once Ubuntu Trusty reaches EOL, or when Chromium's infrastructure is upgraded from Trusty to Xenial, whichever comes second ideally. BUG=807400 R=thakis Change-Id: I00901b3df4005f6ac098774822fffe12dd67e561 Reviewed-on: https://chromium-review.googlesource.com/c/1460187 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7c539fa95b0a..7b4aa52e2435 Created with: gclient setdep -r src-internal@7b4aa52e2435 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic60c473776f638e7d31829ce6cb8068bf9449775 Reviewed-on: https://chromium-review.googlesource.com/c/1460146Reviewed-by:
-
Jan Wilken Dörrie authored
This change removes LoginPair from passwords_private.idl as only the PasswordUiEntry dictionary made use of it. Instead, the previous contents of LoginPair are inlined in PasswordUiEntry, removing an unnecessary layer of indirection. Bug: 377410 Change-Id: I85cc4467dc7aa00176416eec15257ca19992fe32 Reviewed-on: https://chromium-review.googlesource.com/c/1458443Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#630289}
-
Keishi Hattori authored
Disable heap compaction for incremental marking because crash in blink::HeapCompact::MovableObjectFixups::Relocate is not fixed. Bug: 918064 Change-Id: I459ec394539e139c8586fdb131f613b9488dad37 Reviewed-on: https://chromium-review.googlesource.com/c/1460740Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#630288}
-
dpapad authored
The code was triggering a navigation from within a currentRouteChanged observer, which triggers another round of observer notifications, which resulted in observers getting in a weird state. Unfortunately triggering a navigation from within such an observer is not well suported from the routing mechanism (no such use case previously AFAIK). Fixed by yielding first, such that all observers finish, before triggering a new navigation. Bug: 929026 Change-Id: Iee89af435bb2c8a7c738622abdc45d568173d07b Reviewed-on: https://chromium-review.googlesource.com/c/1460398 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#630287}
-
Anders Hartvoll Ruud authored
The base URL is really only needed for variables registered as <url>, so it's wasteful to store an entire KURL for every variable. Storing a String instead saves some memory. This saves around 110kB on the YouTube front page (desktop). Note: The ResolveRelativeUrls has been moved. The 'base_url' parameter was changed from a KURL to a String, but is otherwise identical. TEST=external/wpt/css/css-properties-values-api/url-resolution.html R=futhark@chromium.org Change-Id: I5438aefa15a77550f6ba2b261555c1d61b90ee1b Reviewed-on: https://chromium-review.googlesource.com/c/1458436Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#630286}
-
Mugdha Lakhani authored
Use BackgroundTaskScheduler to wake up Chrome for Android, if the newly introduced feature flag is enabled. Bug: 924490 Change-Id: Iaa42ff2c10af4fbb466e8d892ccf626ee1827cd6 Reviewed-on: https://chromium-review.googlesource.com/c/1432840 Commit-Queue: Mugdha Lakhani <nator@google.com> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#630285}
-
Takashi Toyoshima authored
PreflightController still have one more issue that didn't check headers existence before calling response_code(). Bug: 928394 Change-Id: I5841ba0b8d26c5d30b8eae257f6e4a88c6d158e3 Reviewed-on: https://chromium-review.googlesource.com/c/1457810 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#630284}
-
Nico Weber authored
This reverts commit f61b660b. Reason for revert: After today's clang roll, this should now work better. Original change's description: > Revert "win: Always set strip_absolute_paths_from_debug_symbols, independent of goma." > > This reverts commit 2bf513af. > > Reason for revert: Breaks the symbol step for the official build, see crbug.com/911873 > > Original change's description: > > win: Always set strip_absolute_paths_from_debug_symbols, independent of goma. > > > > There's no downside of doing this on Windows and it makes the build > > deterministic, so always enable it. > > > > Bug: 330260 > > Change-Id: I0e86a2ae5864af2fb4e1716cff1718c9606ab42f > > Reviewed-on: https://chromium-review.googlesource.com/c/1358700 > > Reviewed-by: Scott Graham <scottmg@chromium.org> > > Commit-Queue: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#613200} > > TBR=thakis@chromium.org,hans@chromium.org,scottmg@chromium.org,tikuta@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 330260 > Change-Id: I4a80dc0d3ce0a5125aa94b1367a11e66aefc1ea8 > Reviewed-on: https://chromium-review.googlesource.com/c/1362492 > Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> > Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#613838} Bug: 330260, 929108 Change-Id: I8175162afcbab9097cbfca6564edef3e95d10bd5 Reviewed-on: https://chromium-review.googlesource.com/c/1456294Reviewed-by:
Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#630283}
-
Ale Bzk authored
This reverts commit a2fafd30. Reason for revert: breaking ios-device-xcode-clang TBR=thakis@chromium.org Original change's description: > Reland "Reland "Add build file for PFFFT"" > > This is a reland of c1086af0 > > This CL fixes the compile issues of the reverted CL by defining M_LN2 when not defined. > > TBR=thakis@chromium.org > > Original change's description: > > Reland "Add build file for PFFFT" > > > > This is a reland of 8e4cf155 > > > > This CL includes the following changes: > > 1. when fuzzing, PFFFT is compiled disabling SIMD > > 2. SIMD is also disabled on fuchsia and android because PFFFT only checks __arm__ > > 3. unit test to validate the output of PFFFT (compared against that of FFTPACK) > > > > The first change fixes the problem due to which the original CL has been reverted; > > however, it makes fuzzing slower and reduces the coverage since SIMD cannot be used. > > > > Similarly, the second change is a temporary solution to allow landing this CL. > > SIMD will be re-enabled in a follow-up CL. > > > > Original change's description: > > > Add build file for PFFFT > > > > > > - fuzzer corpus generator and fuzzer targets > > > - fftpack isolated as private test only target (only needed for the benchmark) > > > > > > Bug: webrtc:9577 > > > Change-Id: Idc904bc4b05f945a7461a14893518551bbe34b84 > > > Reviewed-on: https://chromium-review.googlesource.com/c/1452000 > > > Commit-Queue: Ale Bzk <alessiob@chromium.org> > > > Reviewed-by: Nico Weber <thakis@chromium.org> > > > Reviewed-by: Olga Sharonova <olka@chromium.org> > > > Reviewed-by: Max Moroz <mmoroz@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#629627} > > > > Bug: webrtc:9577 > > Change-Id: Icfbb4b966c3ad866e9e2970b63363e0e258b1fea > > Reviewed-on: https://chromium-review.googlesource.com/c/1458076 > > Commit-Queue: Ale Bzk <alessiob@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Reviewed-by: Max Moroz <mmoroz@chromium.org> > > Reviewed-by: Max Morin <maxmorin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#630085} > > Bug: webrtc:9577 > Change-Id: I6bfe6d5f103570cebb6ca7909bd0369ecd8a7c45 > Reviewed-on: https://chromium-review.googlesource.com/c/1460616 > Commit-Queue: Ale Bzk <alessiob@chromium.org> > Reviewed-by: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#630278} TBR=thakis@chromium.org,mmoroz@chromium.org,olka@chromium.org,maxmorin@chromium.org,alessiob@chromium.org Change-Id: I00b1df98e043d2b845f3cee2a88e3307c7151939 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9577 Reviewed-on: https://chromium-review.googlesource.com/c/1459543 Auto-Submit: Ale Bzk <alessiob@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#630282}
-
Henrique Ferreiro authored
https://crrev.com/c/1456058 ported IdentityGetAccountsFunction::Run to talk to the IdentityManager C++ instead of Mojo. In doing so, it changed the returned account list order. This CL reworks the code to keep the primary account as the first account in the list. Bug: 928184 Change-Id: Ic6d305154fc4c46641e0ef2a3d58022ddfeb5de6 Reviewed-on: https://chromium-review.googlesource.com/c/1457316 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
Rune Lillesveen authored
When the BFCs being re-attached were detached from that method, we would sometimes nuke LayoutObjects later in the blocks_ vector, causing a crash later in the iteration. Use the new SetForceReattachLayoutTree() instead which means we do the DetachLayoutTree() from the RebuildLayoutTree() instead. Also, store the Elements instead of the LayoutObjects since they are traced GC objects which is more robust. We no longer need to check if any ancestors have already been marked for forced legacy layout before marking for forced reattach since the forced reattaches will be handled by the same passes over the dom tree for style recalc and layout tree rebuild, not doing multiple layout tree detaches. Needed to modify the ShouldRecalcStyleFor() in order to traverse into elements which are true for GetForceReattachLayoutTree() but not otherwise style dirty. This is the first time we do a forced layout tree re-attach without recalculating style. Bug: 927983 Change-Id: Idb08f7b9a4bda81dd5a00458ef9751b754d3bd2e Reviewed-on: https://chromium-review.googlesource.com/c/1455960 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#630280}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ife57cd235f6d0da77599c0cb94d9a0eb2a01920e Reviewed-on: https://chromium-review.googlesource.com/c/1460148Reviewed-by:
-
Alessio Bazzica authored
This is a reland of c1086af0 This CL fixes the compile issues of the reverted CL by defining M_LN2 when not defined. TBR=thakis@chromium.org Original change's description: > Reland "Add build file for PFFFT" > > This is a reland of 8e4cf155 > > This CL includes the following changes: > 1. when fuzzing, PFFFT is compiled disabling SIMD > 2. SIMD is also disabled on fuchsia and android because PFFFT only checks __arm__ > 3. unit test to validate the output of PFFFT (compared against that of FFTPACK) > > The first change fixes the problem due to which the original CL has been reverted; > however, it makes fuzzing slower and reduces the coverage since SIMD cannot be used. > > Similarly, the second change is a temporary solution to allow landing this CL. > SIMD will be re-enabled in a follow-up CL. > > Original change's description: > > Add build file for PFFFT > > > > - fuzzer corpus generator and fuzzer targets > > - fftpack isolated as private test only target (only needed for the benchmark) > > > > Bug: webrtc:9577 > > Change-Id: Idc904bc4b05f945a7461a14893518551bbe34b84 > > Reviewed-on: https://chromium-review.googlesource.com/c/1452000 > > Commit-Queue: Ale Bzk <alessiob@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Reviewed-by: Olga Sharonova <olka@chromium.org> > > Reviewed-by: Max Moroz <mmoroz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#629627} > > Bug: webrtc:9577 > Change-Id: Icfbb4b966c3ad866e9e2970b63363e0e258b1fea > Reviewed-on: https://chromium-review.googlesource.com/c/1458076 > Commit-Queue: Ale Bzk <alessiob@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Max Moroz <mmoroz@chromium.org> > Reviewed-by: Max Morin <maxmorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#630085} Bug: webrtc:9577 Change-Id: I6bfe6d5f103570cebb6ca7909bd0369ecd8a7c45 Reviewed-on: https://chromium-review.googlesource.com/c/1460616 Commit-Queue: Ale Bzk <alessiob@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
This patch adds a parameter to URLLoaderFactoryParam so to have a factory bound OriginAccessList in addition to the NextworkContext bound one. Bug: 909639 Change-Id: Iefa477becd4b869e29486315ea11bf057d450ad8 Reviewed-on: https://chromium-review.googlesource.com/c/1454065 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
Henrique Ferreiro authored
Previously, CreateChromeBrowserStateForIdentityTestEnvironment() would always create a FakeProfileOAuth2TokenService with a production PO2TSIOSDelegate. This CL makes the default behaviour use the default FakeProfileOAuth2TokenService constructor, which currently creates a FakeOAuth2TokenServiceDelegate, but allows to use the production delegate with an optional parameter. Bug: 926907 Change-Id: I06a3a7866643b95196dbe0e8e506bd4253c1f3e4 Reviewed-on: https://chromium-review.googlesource.com/c/1454536 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
Sergio Villar Senin authored
In crrev.com/c/1454618 FamilyInfoFetcher was migrated to PrimaryAccountAccessTokenFetcher as all the clients of FamilyInfoFetcher were using the primary account. It turns out that this allows us to do a nice cleanup by just moving from using Mode::kImmediate to Mode::kWaitUntilAvailable. This way the PrimaryAccountAccessTokenFetcher will listen for token updates and thus, FamilyInfoFetcher does not need to do so. Bug: 920965 Change-Id: I710120c784682e42a327b6656c63fc0a17225b40 Reviewed-on: https://chromium-review.googlesource.com/c/1458187 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
-
