- 07 Jan, 2021 40 commits
-
-
Alex Leung authored
Bug: b/174777644 Test: internal CQ Change-Id: I3d4ed076e290f1dd3cda60f111b0ad747d73bc27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615658Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Alex Leung <alexleung@google.com> Cr-Commit-Position: refs/heads/master@{#841168}
-
Nancy Wang authored
BUG=1146900 Change-Id: Iebbf4b53aef5723dfc71e394a302ff3f9557a17c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611144 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#841167}
-
Nick Czajka authored
This change cleans up type definitions in display_layout.js for improved readability. Bug: 1077365 Change-Id: Ib1aac690ca56db9a833cbc7c87985eb80922fc0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596063 Commit-Queue: Nick Czajka <czajka@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#841166}
-
Victor Costan authored
sql::Statement is not thread-safe. Add checks documenting this. The checks are currently excluded on Android, because the Android implementation of History uses sql::Statement in a thread-unsafe way -- see https://crbug.com/866218. Landing the checks on all other platforms now is a bit ugly, but has the benefit of preventing new errors from creeping into the codebase while the Android issues are figured out. Bug: 863724 Change-Id: Ia0d087f40bd892c2ed084e3acfc3cf1ecf12e6af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1137851 Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#841165}
-
Avi Drissman authored
base::SysInfo::OperatingSystemArchitecture() should return the architecture of the underlying OS, not the architecture of the Chromium binary. However, arch(3) under Rosetta will lie. Therefore, on the Mac, rely on the documented API to determine if Chromium is running under Rosetta and return correct values. Fixed: 1155315 Change-Id: I94e851b8e64eeacf776d1fed0579e5e543539402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613154 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#841164}
-
Michael Hansen authored
If we launch the settings app by navigating to the Nearby Share subpage, the "enabled" toggle can be seen animating from the off to the on state. This is because prefs are not bound until after the page is visible. Other elements also appear or update after the page loads, but this toggle is especially noticeable because of the animation. This fix wraps the toggle in a template so that it appears in the correct state after prefs have been bound. Fixed: 1158520 Change-Id: Ifbc753ca3faf6db65bba183621c861bc716c6746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602576Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#841163}
-
Francois Beaufort authored
This CL has no functional changes. It adds a manual web platform test case which navigates a second after requesting NFC permission. Bug: 1034607 Change-Id: I1174c4d53f192b5b8ff4639d360a39e9170212cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607885Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#841162}
-
Alex Ilin authored
This reverts commit 73bb9dcf. Reason for revert: failing test has been fixed Original change's description: > Revert "[ProfilePicker] Enable picker on startup only for active users" > > This reverts commit 82afac04. > > Reason for revert: This CL broke StartupBrowserCreatorPickerTest.TestSetup. > > Bug: 1163675 > > Original change's description: > > [ProfilePicker] Enable picker on startup only for active users > > > > Keep the picker disabled on startup until: > > - multiple profiles were used in the last 28 days, or > > - the picker has been shown once > > > > A new prefs::kBrowserProfilePickerShown pref is added to track whether > > the picker has been shown before. > > > > Bug: 1063856 > > Change-Id: Ia35a3b2212b3811ed592d81fa516bc1ffc07accc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598848 > > Commit-Queue: Alex Ilin <alexilin@chromium.org> > > Reviewed-by: David Roger <droger@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#840598} > > TBR=droger@chromium.org,alexilin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: I306f0b7fa225b9d4043e948ec4c7a15e82ed9859 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1063856 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612309 > Reviewed-by: Tsuyoshi Horo <horo@chromium.org> > Commit-Queue: Tsuyoshi Horo <horo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840869} TBR=horo@chromium.org,droger@chromium.org,alexilin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because this is a reland. Bug: 1163675 Bug: 1063856 Change-Id: Idfd5668b970ec0fcaf805ef8bb5ee52778987bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613970Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841161}
-
Dylan Cutler authored
This is part of a larger effort to make CanonicalCookie's generic constructor private. This CL replaces uses of the constructor with the factory CreateUnsafeCookieForTesting. This factory is meant for test-only code and should not be used in production. Bug: 1102874 Change-Id: I8a46712557129ddd7fcddca78d96ced6f174746a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594016Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#841160}
-
Yoav Weiss authored
Bug: 1157818 Change-Id: Ie5e75ccb239735f3500f8763e4d9255eba2056e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592792 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#841159}
-
Alex Ilin authored
This reverts commit e2029732. Reason for revert: WebViewLayoutTest#testWebViewIncludedStableInterfaces is failing because the new API doesn't set up whether it should be exposed in WebView. Interfaces which are intentionally not exposed in WebView need to be added to not-webview-exposed.txt Original change's description: > serial: Mark the API stable > > Updates runtime_enabled_features.json5 and the stable webexposed tests > to mark the Web Serial API stable on desktop platforms. > > Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/RCtZPCQLLOQ > > Bug: 884928 > Change-Id: Ifefaa045a239d3b482287016c98e72c0d8c1da15 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579840 > Commit-Queue: Reilly Grant <reillyg@chromium.org> > Auto-Submit: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840355} TBR=reillyg@chromium.org,chrishtr@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 884928, 1163922 Change-Id: Ib6cc7c3e2d5c323abf4d135da576a87d178653ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611260Reviewed-by:
Alice Wang <aliceywang@chromium.org> Auto-Submit: Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841158}
-
Yann Dago authored
Inclusive policies that have values because their older deprecated value has been migrated programmatically should not be in error, they should be in a warning state. Visual: http://screen/4XmySdAwkiTuor5 Bug: 1033069 Change-Id: I48a481ef60207516102f739a942a8c12093a980c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611548Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#841157}
-
Aya ElAttar authored
Introduced the following changed to DataTransferPolicyController: - Renamed IsReadAllowed to IsClipboardReadAllowed to be used for clipboard copy/paste. - Added IsDragDropAllowed to be used for drag-n-drop. - The logic for IsDragDropAllowed will be changed later upon confirmation from the PM & UX side. Bug: 1139886 Change-Id: Ie0594e1d68abed98145106c2aa8afe480c9b3b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595293Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
-
Jeroen Dhollander authored
Previously 2 places in the code were interacting with |CrasAudioHandler|: - |PlatformApiImpl| subscribes to device changes, and passes this information to |AudioInputHost|. - |AudioInputHost| posts the new hotword model to |CrasAudioHandler|. This made it hard/impossible to split |AudioInputHost| from |PlatformApiImpl|, which is needed to handle audio input in the Libassistant mojom service. To solve this I moved all interactions with |CrasAudioHandler| inside a new class |AudioDevices|, of which an instance is owned by |AudioInputHost|. This also allowed me to add a bunch of new unittests. deployed on real hardware. Bug: b/171748795 Test: chromeos_unittests --gtest_filter="Assistant*:Audio*" and manually Change-Id: I8ec9cec6672236f6365345b292efbe828518be69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610953 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:Xiaohui Chen <xiaohuic@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#841155}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5ff758df67da..603d14ec2a26 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I389176ef20478493eb5c86e73ad3a0c873eb6ba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614848Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841154}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/603d14ec2a26..070ef598892a 2021-01-07 ddrone@google.com Merge "Use Chrome's TrackEvent extensions in trace processor" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ifd709c5a57382bca35ac0c7f58415ebe600d6717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614728Reviewed-by:
-
Dominique Fauteux-Chapleau authored
This adds the basic internal changes to SafeBrowsingPrivateEventRouter needed to report per-profile events. This CL doesn't add new tests, as this is difficult without other per-profile CLs being submitted. Adding such tests is tracked in crbug.com/1159930 Bug: 1159533 Change-Id: I65f626941367fb31ac6005fa230624d01f861718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595833Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#841152}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Idcc33a8fe0e0c1591bc1a9d023ba3a6d2c2fd9bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614727Reviewed-by:
-
Toni Barzic authored
App list view state changes are animated whenever app list view bounds change, which includes cases where app list transition starts from position midway between app list view states - for example, after dragging app list view, or if a state transition interrupts another state transition. Reporting animation smoothness for all app list view state transition introduces some noise - this cl reduces the cases where animation smoothness is reported to only cover full app list state changes. I.e. the animation smoothness in now reported only if the initial bounds and transform match values expected for the starting (current) app list state. This requires OnStateTransitionAnimationCompleted() to be moved to the animation observer callback, rather then animation smoothness report callback, as the report callback will now not run for all transitions. With this change, state transition animation completion is reported sooner, before the metrics results are reported. This alone breaks launcher perf tests - the tests wait for the app list view state to get to a target state, and then close the app list view. New transition timing means that app list view state change may happen before the smoothness metric gets reported - the reporter target state gets reset when the app list view state changes, and causes the reporter not to reporting the metric for the just completed state transition. To fix this, the reporter callback creation is updated to return a callback with an argument bound to the current state at the time of callback creation, instead of using the cached app list state at the time the report callback is run. Additionally, not reporting smoothness for transitions that start mid way through previous transition broke reporting for directly showing app list in fullscreen mode. The app list was initially shown in peeking state and then immediately moved to fullscreen state, which meant that transition from closed to fullscreen state was always starting from an interrupted transition to peeking state. To address this, change AppListView::Show() interface to accept preferred initial state. The change exposed an issue where observers were notified of state change before the internal AppListView state was updated (in cases where transition animations were immediate), potentially causing nested state changes - specific case: app list close transition was causing search box to be cleared, which updates the app list view state, and because it happened before app list view state got updated to closed, this started transition to fullscreen state. The CL updates the state change flow to notify observers that the app list view transition finished only after internal state is updated. BUG=1114525 Change-Id: I38193b0101fea8c8fec6badb07a0e08b0776f8f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608848Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#841150}
-
Mitsuru Oshima authored
Bug: None Change-Id: Ic670b45600d30ec1b4e8a679d9033803c2cea3c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608655Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#841149}
-
Dan Harrington authored
This is provided for use by xsurface. It is backed by Chrome's shared ProtoDatabase. Data is automatically wiped on the same events that wipe other feed data. Bug: 1158468 Change-Id: Id215ec00311883acc65c7f3d6b87570c4b255278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590649Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#841148}
-
Nathan Zabriskie authored
Currently when using OneCopyRasterBufferProvider we perform an upload from CPU shared memory to the GPU and then a GPU to GPU copy during raster playback. This CL allows direct upload of CPU shared memory to the output shared image texture through the use of a new hint in RasterDecoder::CopySubTexture that indicates CPU memory should be used directly. This also allows us to unify how the copy is implemented in RasterDecoder to always use Skia. Bug: 984045 Change-Id: I6ac7d238cf3b2f43562481e2e1b36b3c4670a6f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517149 Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#841147}
-
Sophie Chang authored
Bug: 1154790 Change-Id: I737a56b26abf8cbe56e5f613e73b02dbffbcbc5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611649Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#841146}
-
Tanya Gupta authored
LongScreenshotsEntry allows for management of multiple FDT requests and generated bitmaps. EntryManager is responsible for managing all of the entries. Bug: 1153969 Change-Id: I11053f9b0ba0a47282f0e1e6153f37675de3ab1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605600 Commit-Queue: Tanya Gupta <tgupta@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#841145}
-
chromium-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/5820c040a91a..725a542f7776 2021-01-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 9f10caf9c4f3 to ebd3ea2ecbac (2 revisions) 2021-01-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from cc435b55410a to 9f10caf9c4f3 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC ianelliott@google.com,enga@google.com,radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com,enga@google.com,radial-bots+chrome-roll@google.com Change-Id: Ia2bb761654880fb7a54d1b68ed7e7fface908849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615178Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1609999114-48d6c013bfb0cf3d871ee24efc89ddcdc4d51629.profdata to chrome-win32-master-1610009713-66490881217dda72de1fa905fa3f863deeda7cfb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia0abd260f3999737ba7bf6ded870213e68900e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614566Reviewed-by:
-
Victor Costan authored
The ParameterizedVisibleUnitsSentenceTest test suite does not have any test case. This CL removes it. This problem was discovered by attempting to roll googletest past CL 315255779, which causes test binaries to fail when they include test suites / parametrized tests that are not instantiated, and when they include empty test suites. Bug: 1163396 Change-Id: I95213add5ed04cd08ef1b208141c9903075b686e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615659 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#841142}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ddb981175c35..61704b4db5d7 2021-01-07 jegarc@microsoft.com Styles: Prevent invisible properties to invalidate visible ones 2021-01-07 tvanderlippe@chromium.org Convert UIString.js to TypeScript-authored If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1163314 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I360e91ea928178f07ac6ac8e34a69c65b964f946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615179Reviewed-by:
-
Alison Maher authored
To handle layout of OOF positioned elements inside a nested fragmentation context, we will delay layout of the OOFs until they've reached the outermost context, at which point they will get laid out inside the inner multicol in which their containing block was found. This change stores such inner multicols in the container builder and physical fragment as a means to propagate the associated inner multicols up to the outer context where their OOFs will be laid out. This change also adds logic to halt the propagation of OOF positioned fragmentainer descendants up the tree if we've reached a multicol. In this case, we would know that we are in a nested context, and any OOFs that have reached their containing block should remain in the inner multicol's physical fragment rather than continuing up the tree. See design doc for more details: https://docs.google.com/document/d/13Pn7SSJjzskg9kQ4jErzlJrj2j4zGBfNBFLEeDVENUU/edit?usp=sharing Note: The OOF elements inside a nested context are not yet getting laid out, which will cause related tests to crash. This will be addressed in follow-up changes. Bug: 1079031 Change-Id: I87399a67c6fc5021f3323afe8fae0b15e6e13eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612392 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#841140}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609988385-9c096aa1bc5d021f182b9150cd47fcb15e7461d7.profdata to chrome-win64-master-1610009713-6f95aef060564dd70c8d09ec603d31a9c7b42ed0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If22004de98c832154e26fb81d53f84f3223a0b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614189Reviewed-by:
-
Kyle Horimoto authored
This reverts commit 3ece5c0f. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1163902 Original change's description: > Move crostini section under Advanced in settings. > > Bug: 1163003 > Change-Id: I9b2b439007c80bc0385128da4817ac001ee7eb0c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610407 > Auto-Submit: Nicholas Verne <nverne@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840920} TBR=khorimoto@chromium.org,nverne@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I77bde9769710657da5d0992728dd53006a83de2c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1163003, 1163902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615667 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
wutao authored
When ambient mode starts and exits, it will change the video visibility and update the video wake lock. For example, when a video is playing in browser, it will request a video wake lock to prevent screen dim and off. However, when we lock the screen while playing the video in an active tab, the ambient mode will start after several seconds. Ambient widget covers the fullscreen and change the browser visibility to not visible and release the video wake lock. After some time, screen is turned off and ambient mode exits. The browser visibility becomes visible again and acquire the video wake lock again and turn on the screen. The screen on event will start ambient mode in a few seconds again. To fix this bug, we set the opacity of the ambient widget to be translucent, which will not change the browser visibility and therefore the video wake lock. As long as the video wake lock is held, the ambient mode will not exit since there is no dim event. Bug: b/173806284 Test: manual Change-Id: I0bb7f3c8f6fdeb04d9831a85ffe97eeb769f3b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612386 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
-
Gavin Williams authored
Make whole row clickable to match the behavior of the More settings button. Bug: 1059779 Change-Id: Ia1da833b14cb835e090f3f37fb47faeef3c948be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613920Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#841136}
-
Jeffrey Kardatzke authored
BUG=1146646 TEST=Verified UI only shows hostname in dialog Change-Id: I80df7f5f0c5d582649e9cf30c9dfd00f65407d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615298 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Evan Stade authored
This required adding deps, which in turn created circular includes. To address this, the patch * moves settings_namespace.{cc,} into the //extensions/browser target * passes the task runner from GetExtensionFileTaskRunner() as a parameter into value store code Bug: 1158986 Change-Id: I91ae5c90d82c5cbe5eb1d2a62cd1dd65a003e74c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601640Reviewed-by:Erik Staab <estaab@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#841134}
-
rbpotter authored
The only valid use case involved the chrome://devices page, which has been removed. Bug: 1100748, 1162164 Change-Id: Ie1d62eecd00cec5e35fb76e7398c0ab40ea95b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585562Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1c3c93911966..e856b6bba826 2021-01-07 gbeaty@chromium.org Enable set_output_commit to be used with RevisionFallbackChain. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1141886,chromium:1159749 Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I5f92f9c4030573dc4cf825d76b0277554002152c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615180Reviewed-by:
-
Shane Fitzpatrick authored
calls. Instances found by searching for references to that field Fixed: 1162476 Change-Id: If64e74dd79e7c17859c3a7699e34abc497f9cc36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613358 Commit-Queue: Shane Fitzpatrick <shanefitz@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#841131}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/be0b3b7363a9..bdc3d3c60fa9 2021-01-07 johnstiles@google.com Simplify map of SPIR-V numeric constants. 2021-01-07 johnstiles@google.com Flatten nested vector constructors when emitting SPIR-V. 2021-01-07 johnstiles@google.com Implement getBVecComponent. 2021-01-07 csmartdalton@google.com Revert "Disable tessellation when we don't have indirect draw support" 2021-01-07 johnstiles@google.com Add getConstantBool as a sibling of getConstant(Int|Float). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1163441 Tbr: johnstiles@google.com Change-Id: I4cbdd09ef396746aa0ff0709b03e8baf93758597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614726Reviewed-by:
-
edchin authored
Bug: 1163074 Change-Id: I126b46a7ed308d6ab000f12206d1f050fd3e92d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615103 Commit-Queue: edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Auto-Submit: edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#841129}
-
