- 31 May, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bc30e72cb429..cc9bc65588ee git log bc30e72cb429..cc9bc65588ee --date=short --no-merges --format='%ad %ae %s' 2019-05-31 spang@chromium.org Vulkan: Fix synchronization with current surface Created with: gclient setdep -r src/third_party/angle@cc9bc65588ee The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Change-Id: I22fe424daed16a040bef709af23cf921937f2f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638487Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665209}
-
Rune Lillesveen authored
Change-Id: Ib1c0c2f927864729c9249af863e43f37128d657f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638457Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#665208}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0817a0661743..ef80e835027e Created with: gclient setdep -r src-internal@ef80e835027e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: Ifbc56fe14b0846d81acdc6530d43ab2933bbdca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638348Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665207}
-
Etienne Pierre-doray authored
This CL replaces ScopedNestableTaskAllower with kNestableTasksAllowed passed as argument to the RunLoop involved if any. Only native nested loops should use ScopedNestableTaskAllower (soon to be deprecated). For more details, see: https://cs.chromium.org/chromium/src/base/message_loop/message_loop_current.h?sq=package:chromium&dr=CSs&g=0&l=159 A small step towards deleting MessageLoop. This CL was generated with git cl split. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1635819 Please CQ if LGTY! This CL was uploaded by git cl split. R=rbpotter@chromium.org Bug: 766678 Change-Id: I58ca1e8bee1ff1e53d5daad628f83f6b310cc8f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635824 Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#665206}
-
Ben Pastene authored
These tests fail when built with official & chrome branding. Bug: 947531, 968349, 932269 Change-Id: I9617356070613c58165b1618e529fc4b8794e018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636089Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#665205}
-
Fred Mello authored
Bug: b/133669491 Change-Id: I61a9767a08a0024155a40ca4e88e5022209644a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638193Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Fred Mello <fredmello@chromium.org> Cr-Commit-Position: refs/heads/master@{#665204}
-
Mark Mentovai authored
This is a reland of 6a008993, which was reverted in 235d842a. (Thus, this is a revert of that revert.) Since the last attempt, the structure of the keystone_registration bundle_data rule in third_party/googlemac (via src-internal DEPS) has changed to avoid the dangling symbolic link problem previously encountered. The description from 6a008993: The copy_bundle_data tool is implemented in terms of pax for directories and ln hard links for files. The pax command does preserve symbolic links within the tree that is being copied. But with the way that pax is invoked by the tool, cd-ing into the source, if the source is itself a symbolic link to a directory, the tree will be logically copied rather than just as a symbolic link. A similar issue exists with the non-directory symbolic link source case, where a hard link will be produced instead of a symbolic link. Fix both of these cases by specifically testing if the source is a symbolic link and then re-creating it if so. Bug: 955936 Change-Id: Ia13ddf743603e98337c3523e9101e7627e1c31d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637673Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#665203}
-
Ian Kilpatrick authored
This allows callsites to pass in a lambda that does a capture by reference. There should be no behaviour change. Bug: 967830 Change-Id: I0253a9bb7dd8f95b9129d17eeabae1dc6c58c527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637588Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#665202}
-
Caleb Raitto authored
This CL finishes the chain of changes needed to call metrics listeners with RequestFinishedInfo, and it includes some sanity check tests verifying that the returned metrics are valid. RequestFinishedInfo includes more than request metrics, and those fields will be copied in later CLs. Bug: 879208 Change-Id: I0349d611943044bb16053fb0ab3262d5f36a4829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496495 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#665201}
-
Mason Freed authored
This is a reland of 5418a092 - this needed a rebaselined layout test for Mac. Original change's description: > Clean up backdrop-filter layout tests and expectations > > This CL cleans up the layout tests for backdrop-filter: > - The backdrop-filter-bleeding.html test was never really complete, and > the effect it was testing for is completely covered by the existing > external/wpt/css/filter-effects/backdrop-filter-edge-pixels.html > test. > - The backdrop-filter-boundary.html test never had a valid expectation > file. It now does, and the test has been made a bit more obvious. It > already passed. > - Another CL (http://crrev.com/663338) made the > backdrop-filter-clipped.html test pass. > > Bug: 497522 > Change-Id: Ib95edda9dfb15fc451eaeb225310d422d70787df > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637490 > Commit-Queue: Mason Freed <masonfreed@chromium.org> > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > Auto-Submit: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664954} Bug: 497522 Change-Id: I51f9f0bee8b5b3dd601adf27db4a25c3bdfacc56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638657 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#665200}
-
Lindsay Pasricha authored
We renamed the EG2 test targets in https://chromium-review.googlesource.com/c/chromium/src/+/1628171 but these files weren't updated. Bug: 866147 Change-Id: I59891bba8a0516fc9b5eca4867acb5e0fcde859a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637839Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#665199}
-
Felipe Cerqueira authored
Bug: 927957 Change-Id: I2353843752a270db375471e9faa62336fe50158d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635629 Commit-Queue: Felipe Cerqueira <cerqueira@google.com> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#665198}
-
Pâris MEULEMAN authored
This CL aims to remove OAuth2TokenService.Oauth2TokenServiceObserver, which is unused except for tests. The tests depending on this API were modified to test the behavior using a different way in parent CLs: - Test that saveStoredAccounts was successfully executed; - Test the C++ Oauth2TokenServiceDelegateAndroid instead, which gives access to the C++ OAuth2TokenService::Observer. Bug: 960281 Change-Id: I152f5c582d7795c05162e0ab3fca219c0db10a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602715 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#665197}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/887362fca7a7..8b079d6881fc git log 887362fca7a7..8b079d6881fc --date=short --no-merges --format='%ad %ae %s' 2019-05-31 mnissler@chromium.org Revert "Mark guado as experimental" Created with: gclient setdep -r src/third_party/chromite@8b079d6881fc The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Iba1e13e9eb126f79bd3a10b957cbf7531e6eab0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638564Reviewed-by:
-
Michael Thiessen authored
Restricting to NoTouchMode to lower riskiness/contentiousness of this change. Bug: 968573 Change-Id: I4b9247541179f8af0c0548d0d3bb6e6c05a0bba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637533Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#665195}
-
David Grogan authored
The FlexNG test failures shouldn't really have 591099 as their tracking bug, but that's a different CL. Bug: 963168 Change-Id: I96294fe71c2b20fcb8f50c00cf22603d69c386ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633533 Auto-Submit: David Grogan <dgrogan@chromium.org> Reviewed-by:
-
Fritz Koenig authored
When the source is a WebGL canvas the rectangle must be adjusted for flipping with MESA_framebuffer_flip_y. BUG=964010 TEST=https://www.khronos.org/registry/webgl/sdk/tests/webgl-conformance-tests.html?version=2.0.1 Change-Id: I20f5ac0a5049b23b3033a6d46f53606886f4e4f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627555Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#665193}
-
Dale Curtis authored
BUG=879406,969079 TBR=liberato Change-Id: Icdc2bc65226bce07331f56311d244e6c2212c551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637593Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#665192}
-
Victor Costan authored
Bug: 937761 Change-Id: I33b207351d2e1da2daf31a4388ee0e0aab5f2b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638282Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#665191}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/94246cb21c8f..78f6819b0e70 git log 94246cb21c8f..78f6819b0e70 --date=short --no-merges --format='%ad %ae %s' 2019-05-31 tsepez@chromium.org Reland "Split off CPDF_ModuleMgr:Create() from CPDF_ModuleMgr::Get()"" 2019-05-31 thestig@chromium.org Add CXFA_Node::GetXMLDocument() helper. 2019-05-31 thestig@chromium.org Update third_party/base/numerics/ code. 2019-05-31 thestig@chromium.org Update third_party/base/numerics/safe_conversions code. 2019-05-31 thestig@chromium.org Add a ReadArrayElementsToVector() helper function. 2019-05-31 thestig@chromium.org Break remaining dependency from fxge to fxcodec. 2019-05-31 thestig@chromium.org Fix some nits in SkiaState. 2019-05-31 tsepez@chromium.org Move PDF_{Adobe,Unicode}NameFrom{Unicode,Adobe}() to core/fxge. Created with: gclient setdep -r src/third_party/pdfium@78f6819b0e70 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: Id4bce88022cecedbe1c59f24be8337a9c897d3f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638489Reviewed-by:
-
Peter Kasting authored
This is banned by the Chromium style guide. Bug: none Change-Id: I417bb80ec06616583f9f10bbf4f197d46d0f45b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637861Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#665189}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2f0f5fb37d74..c8f285a7077e git log 2f0f5fb37d74..c8f285a7077e --date=short --no-merges --format='%ad %ae %s' 2019-05-31 jvanverth@google.com Fix DDL_Metal test configs 2019-05-31 jvanverth@google.com Reland "Added AutoreleasePool for managing pool memory in testing apps." 2019-05-31 halcanary@google.com SkShaderBase::isAPicture() 2019-05-31 bsalomon@google.com Color matrix effect rewritten as .fp 2019-05-31 jvanverth@google.com Use GrCFResource class to manage backend surface MtlTexture resources. 2019-05-31 robertphillips@google.com Clean update ETC1 data utilities (take 2) 2019-05-31 kjlubick@google.com Revert "Added AutoreleasePool for managing pool memory in testing apps." 2019-05-31 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 172e5d373fad..0a56f0e3d22d (6 commits) 2019-05-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 97d3c908..8e522297 (404 commits) 2019-05-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 37bc82ac64f5..c0d7ee45d45f (2 commits) 2019-05-30 bungeman@google.com Document SkShaper::RunHandler::Buffer 2019-05-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-30 herb@google.com Use strike spec for bitmap rendering 2019-05-30 ethannicholas@google.com added support for SkMatrix44 ctype 2019-05-30 jvanverth@google.com Added AutoreleasePool for managing pool memory in testing apps. 2019-05-30 reed@google.com share tiny bit of code for std language iter 2019-05-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-30 reed@google.com free formatctx when we're done 2019-05-30 robertphillips@google.com Revert "Clean update ETC1 data utilities" 2019-05-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-30 michaelludwig@google.com Remove old GrFillRectOp factories 2019-05-30 robertphillips@google.com Clean update ETC1 data utilities 2019-05-30 fmalita@chromium.org [skottie] Shaper: fission glyphs into separate fragments when needed 2019-05-30 robertphillips@google.com Use GrVkImage utilities in GrVkGpu::createTestingOnlyVkImage 2019-05-30 halcanary@google.com SkPDF: implement kDecal image shader TileMode 2019-05-30 halcanary@google.com SkPDF: MakeShader uses Color4f 2019-05-30 bungeman@google.com Correct shaper assert around iterator fonts. 2019-05-30 reed@google.com support assets for skottie2movie 2019-05-30 herb@google.com Collapse the SkTextInterceptsIter into base class 2019-05-30 brianosman@google.com Interpreter: Elide dup/pop around stores 2019-05-30 bungeman@google.com Add trivial implemenations of shaper run iterators. 2019-05-30 rmistry@google.com Add new G3 compile try bot 2019-05-30 rmistry@google.com Add recipe for triggering and waiting for G3 compile tasks 2019-05-30 rmistry@google.com Script to trigger and wait for G3 compile tasks 2019-05-30 reed@google.com Revert "Compare pixels for TypefaceWithNoPaths test" 2019-05-30 hcm@google.com Update Skia milestone to 77 Created with: gclient setdep -r src/third_party/skia@c8f285a7077e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:967418,chromium:964498 TBR=kjlubick@google.com Change-Id: Iac3e939ce64552ceb0915f199c0a0fe779e8c5be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638488Reviewed-by:
-
Mandy Chen authored
audits2 was renamed to audits: https://chromium-review.googlesource.com/c/chromium/src/+/1614691 Rename grdp file and its entry. I'll improve the autofix script to catch this case in another PR. Change-Id: I0f2eaa3528ed925d32feccd22762399d603491be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637591Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#665187}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=tsepez@chromium.org Change-Id: I41fd9666b91aa705eaeb1bf2432b8dcd1947453d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636053 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#665186}
-
Nate Chapin authored
Bug: 964768 Change-Id: I59c2384cda133f97730e88a266bba542aeaaa828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637864Reviewed-by:
Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#665185}
-
Natalie Chouinard authored
The Android Framework Preference classes are deprecated as of API level Q in favor of the v7 Preference Support Library. Add the required dependency so we can begin migrating. The net effect of this migration is expected to be a reduction in method count and binary size. Bug: 966073 Binary-Size: New support library import Change-Id: I6b1f2f762f131567db31a6d9c314c71142866cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605515 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#665184}
-
Suman Nelson Kancherla authored
A user-bounce metric is when the user clicks deny button on the consent dialog or otherwise closes the dialog by clicking outside of it, only to retry and click allow button this time. The metric is to count the number of times this happens. This cl has a no-op refactor. The ConsentFlowMetrics(Helper) classes in Java/C++ respectively are basically updating the same histogram. Metrics folks strongly discourage this. They would rather have one function update a metric and have all other functions call it. So, this cl replaces Java histogram calls with Jni ones. Bug: 965538,962755 Change-Id: Ie7e526caa7d18310b2c9580411d41df6ae618b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638098Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Cr-Commit-Position: refs/heads/master@{#665183}
-
Etienne Bergeron authored
The browser process is DPI aware. To be able to detect correctly the configuration on my win10 computer, I needed to add the code of this CL. To make the tests fails, I needed to change the system config to increase it to 125%, then I needed to sign-out and sign-in. see the output: ../../chrome/browser/ui/views/layout_provider_unittest.cc(70): error: Expected equality of these values: system_dpi_scale Which is: 1.25 1.0 Which is: 1 The test requires default display settings. The DPI of the display is not 100%. dpi_scale=1.25 Stack trace: Backtrace: base::debug::StackTrace::StackTrace [0x00007FFB86ADC648+40] (C:\src\chromium\src\base\debug\stack_trace.cc:203) StackTraceGetter::CurrentStackTrace [0x00007FF66C1DB986+86] (C:\src\chromium\src\third_party\googletest\custom\gtest\internal\custom\stack_trace_getter.cc:24) testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x00007FF66C1F172A+90] (C:\src\chromium\src\third_party\googletest\src\googletest\src\gtest.cc:827) testing::internal::AssertHelper::operator= [0x00007FF66C1F11F7+87] (C:\src\chromium\src\third_party\googletest\src\googletest\src\gtest.cc:404) LayoutProviderTest::SetUpTestSuite [0x00007FF66B9EA76D+1117] (C:\src\chromium\src\chrome\browser\ui\views\layout_provider_unittest.cc:70) R=tapted@chromium.org Bug: 963868 Change-Id: Ifcda84cbea88c42e9d3b2c5c81c024a1a9abc371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630978 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#665182}
-
Mike Wasserman authored
Replace the mojo interface with a pure virtual C++ interface. Add a static Create method; remove unused interface function. Update users. Bug: 958215 Test: Automated Change-Id: I1d697364fd090894cbc465400861e3fb7fcf5ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636677 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#665181}
-
Andrew Xu authored
A part of code to enable dragging AppList by mouse. To achieve this goal, three key functions are required: (1) Drag AppList by mouse from Peeking/Half state. (2) Drag AppList by mouse from Shelf. (3) Drag AppsGridView by mouse. This CL implements the first function: enable dragging AppList from Peeking/Half to FullscreenAllApps/FullscreenSearch Bug: 768484 Change-Id: I10b48afe111397f8cf962eec26304c853b868f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620783 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#665180}
-
Adithya Srinivasan authored
Portals can be activated in response to scroll events like overscroll and we want users to be able to continue scrolling after activation without tapping the screen again. This CL dispatches touch events targeted at the new ContentView after activation, which mirror where the pointers were before activation. Design doc: https://docs.google.com/document/d/12EsIEQIJAzh4-3aNQNhxoQ8Z7ayrSodmWbo06R9PbAQ/edit?usp=sharing Bug: 914376 Change-Id: I1ade7ac3da7451de14b38dd66056178cdcab7631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622906 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#665179}
-
Chris Harrelson authored
This avoids even more complicated code in GraphicsLayerUpdater. I don't think the performance will be a big problem in the short term, and longer-term CAP obsoletes this code. Bug: 968488 Change-Id: Id88ee31b47449ce752b004dd911b3918d035fc9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636858 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#665178}
-
Suman Nelson Kancherla authored
Bug: 969024 Change-Id: I1af3edd08def4792c2162313eb5d98a55897a730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637655 Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Reviewed-by:
-
Alex Chau authored
- message_id is already provided by IncomingMessage - sent_time is already provided by FCM, can be added to IncomingMessage Bug: 966028 Change-Id: Ia6247f262659f0748ffaa4c81d61757dbf84c54b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636052 Auto-Submit: Alex Chau <alexchau@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#665176}
-
Leszek Swirski authored
When a ScriptResource receives a datapipe for the response body, it starts watching that datapipe for data. Previously, watching the data pipe meant calling ArmOrNotify on a mojo SimpleWatcher. If there is no data, then this arms the watcher to trigger a callback once data arrives; if there is data then it posts a task onto the loading task runner to trigger the callback "immediately". Unfortunately, script streaming can only be started in this callback. This means that if the data pipe already has enough data in its buffer to start streaming by the time the ScriptResource receives it (which appears to often be the case), we "waste" some time on task posting overheads, and potentially are blocked from starting streaming by other activity on the main thread. Locally I've seen latencies of >100ms between receiving a datapipe that has enough data to stream, and actually starting streaming it (with preload streaming enabled). So, when the data pipe is first received, if there is data in its buffer already we now immediately synchronously call its callback. Bug: 865098 Bug: 945321 Change-Id: I140975b92bf80febf59edaad3e19670b3bc5e529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631374Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#665175}
-
Elly Fong-Jones authored
Also bump the milestone to provide more time to discuss the path forward for this feature. TBR=omrilio@chromium.org Bug: None Change-Id: I59907936b8a36dc919a485566a208269d90d0b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638662Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#665174}
-
Sven Zheng authored
Add the pixel_browser_tests target to waterfall. This is an experimental target that do pixel testing. The test result relies on Skia Gold server so we want to isolate the target. The test can pass locally now and I need to see how it behaves on bots. Design doc(Internal): https://docs.google.com/document/d/1Mz72RHWyQKsT6jynrDNGbCaTKQIy_77qMjRM5gpsr_w/edit?usp=sharing Design doc(Public): https://docs.google.com/document/d/1uvXp0AKfemJ9e1TXM1nH3UTcVlDKISK2jFd_g2gstX0/edit?usp=sharing Bug: chromium:958242 Change-Id: Ifcef0e94e924ca7c98c4909a42f9e54d87041ff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623226 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#665173}
-
Giovanni Panaro authored
Increased the left padding on the Status Bubble from 3 to 5 and the right padding from 1 to 5. This way the URL looks less cramped. Bug: 959890 Change-Id: I08eb80a057d0ea00096fb28c06f5a93654894f79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598028Reviewed-by:
-
Evan Stade authored
TBR=tsepez@chromium.org Bug: 958206 Change-Id: I66b1924d9ab0d49047a7ee3fe8d1b696b74ed726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637865Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
-
Yusuke Sato authored
This fixes a problem introduced in CL:1592713. Without this fix, 'storage-android-running-changed' is sent to JS only when either of the following happens: - AllowJavascript() is called. - ARC is fully started. - ARC shuts down. However, storage-android-running-changed's listener on the JS side is registered only after AllowJavascript() is called. Because of this, if the Settings app is launched in the following way, |androidRunning_| variable in storage.js remains false and the 'Android storage' link never shows up. 1. Sign in. 2. ARC is fully started. 3. Settings app is launched. |androidRunning_| variable is false at this point. 4. AllowJavascript() is called. 5. 'storage-android-running-changed' is sent to JS, BUT there's no listener. 6. The user moves to Devices > Storage management. 7. storage-android-running-changed's listener is registered. 8. The JS sends 'updateStorageInfo' to the C++ side, but the C++ handler doesn't fire storage-android-running-changed. This CL changes the C++ handler code so that HandleUpdateStorageInfo() fires storage-android-running-changed with the up to date ARC status. The C++ handler used to do that, but CL:1592713 removed it by mistake. This CL restores the code. BUG=968580 Change-Id: If1d0a6d1597bffcb37b82c1e4c44746c4c201106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637038 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
-
