GitLab

This reverts commit f8b7ec28.

Reason for revert: Causing all builds to fail on android-pixel2-perf failing

Original change's description:
> Reland "Android: Use locally-build devil deps only when build_with_chromium=true"
>
> This reverts commit b47e9c83.
>
> Reason for reland: Updated more .pydeps files.
>
> Original change's description:
> > Revert "Android: Use locally-build devil deps only when build_with_chromium=true"
> >
> > This reverts commit 49fdeca1.
> >
> > Reason for revert: Breaking presubmit due to stale .pydeps file:
> > android_webview/tools/run_cts.pydeps
> >
> > Original change's description:
> > > Android: Use locally-build devil deps only when build_with_chromium=true
> > >
> > > Bug: 1120190
> > > Change-Id: I763e42a7ae69d14eb61caebd220844b756d6d171
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480842
> > > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> > > Reviewed-by: Ben Pastene <bpastene@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#819489}
> >
> > TBR=agrieve@chromium.org,bpastene@chromium.org
> >
> > Change-Id: I960ad355283c66951e5931f61e25421c5a5dfdf7
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1120190
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490857
> > Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#819668}
>
> TBR=agrieve # reland
>
> Bug: 1120190
> Change-Id: I8f3e21182e83a3e88da52331d56a8bef76507939
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490558
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#819810}

TBR=agrieve@chromium.org,bpastene@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1120190, 1141891
Change-Id: I490f2e8a972b260a81b942e248c0f920af11db46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495335Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820355}

Make some of the problem descriptions more succint.

TEST=unit_tests --gtest_filter=CaptivePortalRoutineTest.*
BUG=chromium:956783

Change-Id: Ie3b666e0aa999a4d387ef0ed4634364df18966dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490176Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kartik Hegde <khegde@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820354}

This is a reland of 8699ff59

Original change's description:
> Enable JDK library desugaring by default
>
> Bug: 1056751
> Change-Id: Id517413e180ad7cc2f7688d47038587f2a3ecb5e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458853
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Commit-Queue: Ian Wells <iwells@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#817575}

Bug: 1056751
Change-Id: I7d6f7336057afd80960d3b6c6a37c595b7c84629
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493362Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Ian Wells <iwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820353}

https://skia.googlesource.com/skia.git/+log/15d8174fc944..530933006d3c

2020-10-23 johnstiles@google.com Add unit test demonstrating recursion codegen bug.
2020-10-23 johnstiles@google.com Fix use-after-free discovered by fuzzer.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC egdaniel@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: egdaniel@google.com
Change-Id: I7eaee3483812115ed06f9f6a5803ab774bbfd9e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495683Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820352}

Besides test targets, the lacros chrome target also depends on ash
chrome to run.

Bug: 1129223
Change-Id: I75e94cd2de624d0cb3740b6596cb14609a5c0af1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495508Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820351}

There's a notice on the top of base/test/metrics/OWNERS that mentions a
fixed bug. Cleaning that up.

Bug: 846421
Change-Id: Ia9131cabc24a54ec698b71d55d9be5e15fa98ca0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491101
Auto-Submit: Joshua Berenhaus <joshber@microsoft.com>
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820350}

Avoid conflicts with LOG_FOO in sys/syslog.h on Linux.

Convert LOG_FOO to LOGGING_FOO in base/, but leave the rest of the code
base untouched. Keep LOG_FOO defined for now to make it possible to
convert the rest of the code base in smaller increments.

BUG=849450

Change-Id: Icce5121f7cd036e9e9eddd7de68f57474f4ab73c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1086147Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820349}

The only usage of this API is for the RenderViewImpl notifying observers
that a commit has happened. This callback can simply occur on the
WebViewClient API.

BUG=1097816

Change-Id: Ic9f5fd946c18498ee87d6a3d5f58b04729b5081b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492887Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820348}

This is part of a larger cleanup effort of the Chrome cookie codebase
with the long term goal of making the CanonicalCookie constructor
private.

The cookie manager code checks whether the serialized/deserealized
cookie is valid, and since this code is a security boundary we think
this check is worth keeping with test coverage.

In order to do so, we need to remove the DCHECK in

that relied on the check we are removing.

CanonicalCookie: :FromStorage and include new checks at the callsites
Bug: 1102874
Change-Id: I9c9436827d668042ba41229ce8819ef925cb5d6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490242Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Cr-Commit-Position: refs/heads/master@{#820347}

The Trust Token API (https://github.com/wicg/trust-token-api) adds Web
Platform support for executing certain cryptographic operations
alongside resource requests. We're implementing an expansion,
"platform-issued trust tokens," where one of these operations
("issuance") can be executed against OS-mediated providers (e.g.
registered by some kind of system service).

This CL expands NetworkContextClient's interface to provide a method
that can answer Trust Tokens issuance requests locally. This will
subsequently be implemented by querying an embedder-provided Mojo
remote. This change's child (crrev.com/c/2491300) wires this interface
to the network service Trust Tokens implementation.

Design doc: bit.ly/platform-provided-trust-tokens

Bug: 1130273
Change-Id: Iea07b36cdd3369ca51a667e0f4f0cada05c2aad9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433104
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820346}

This reverts commit e0f87dec.

Reason for revert: next fuchsia-x64-cast build passed without this revert.
https://ci.chromium.org/p/chromium/builders/ci/fuchsia-x64-cast/97041

Original change's description:
> Reland "Introduce gfx::MaskFilterInfo to define a filter based mask on a layer."
>
> This reverts commit 593a7819.
>
> Reason for revert: Suspect this of breaking the build https://ci.chromium.org/p/chromium/builders/ci/fuchsia-x64-cast/97040?
>
> Original change's description:
> > Revert "Introduce gfx::MaskFilterInfo to define a filter based mask on a layer."
> >
> > This reverts commit 41d30701.
> >
> > Reason for revert: to investigate crbug.com/1139657. I did run revert and ony saw 0.5~0.9% improvements. I'll revert this first and reland with ctor change.
> >
> > Original change's description:
> > > Introduce gfx::MaskFilterInfo to define a filter based mask on a layer.
> > >
> > > This is a preparation to add GradientMask[1] support.
> > >
> > > [1] https://docs.google.com/document/d/1AXgfk66ROEr225roqAuPxrqWNsnDh91lHCQJ_cw8RrI/edit#
> > >
> > > Bug: 1039003
> > > Change-Id: Ib452c83e3408a1cbdcfb743e0a5ce819258f5ff3
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459429
> > > Reviewed-by: Scott Violet <sky@chromium.org>
> > > Reviewed-by: Khushal <khushalsagar@chromium.org>
> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > > Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#817987}
> >
> > TBR=sky@chromium.org,dcheng@chromium.org,oshima@chromium.org,khushalsagar@chromium.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: 1039003
> > Change-Id: If5c3d49100e0bbb4dcd712b0e158c29536f79d34
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491242
> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#819954}
>
> TBR=sky@chromium.org,dcheng@chromium.org,oshima@chromium.org,khushalsagar@chromium.org
>
> # Not skipping CQ checks because this is a reland.
>
> Bug: 1039003
> Change-Id: I135ae3074fb1e4af6bc44b21fb10910e7f09b5b8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493221
> Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#819989}

TBR=sky@chromium.org,dcheng@chromium.org,oshima@chromium.org,robertocn@chromium.org,khushalsagar@chromium.org

Change-Id: I3052d170cfc7551510b1777ffe73ebd4de1c11d5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1039003
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495712Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820345}

This reverts commit 448e1b37.

Reason for revert: Breaks translation, crbug.com/1141934

Original change's description:
> WebUI: Add support for producing/consuming grdp files in generate_grd.py
>
> This will be leveraged in follow up CLs, to auto-generate parts of
> webui_resources.grd.
>
> Bug: 1132403
> Change-Id: I5bd5f8a411c2cbc1f023220a779d74be209e902c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489920
> Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
> Commit-Queue: dpapad <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#820148}

TBR=dpapad@chromium.org,rbpotter@chromium.org

Change-Id: Ie0e71ef0d9a7dd8bbe5c0da452692b3e9c3f96db
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1132403
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495518Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820344}

This change records UKM, AdsIntervention_LastIntervention on page loads
to origins that have previously triggered ads interventions. This UKM
tracks the subresource filter activation status and the ads violation
that triggered the intervention.

This allows analysis of an ads interventions benefit to a user and
their frequency across different sets of sites.

BUG=1099741

Change-Id: I653b0468c387727902f95e00c14cba1da9ae6996
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419118
Commit-Queue: Justin Miron <justinmiron@google.com>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820343}

- Currently just initializes the result list and disables the button
- Follow up will run the tests and reenable the button on completion

Bug: 1125150
Test: browser_tests --gtest_filter=DiagnosticsApp*
Change-Id: Id5c4999e34f843e12bc51f329e32bdb6807a9773
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470016
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820342}

This flag controls a GPU workaround with the same name.

Bug: 1138979
Change-Id: I9e900aab600b5652fbc46e4b65d098d27de73cc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490991
Commit-Queue: kylechar <kylechar@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Auto-Submit: kylechar <kylechar@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820341}

This CL is moving the speech synthesizer code to a worker thread.

The TtsPlatformImpl is using an ISpVoice COM interface to perform
text-to-speech actions. The instance was living on the UI Main
Thread which was using STA Apartment.

This CL is splitting the logic in two parts. The first part is the
control logic which stay on the UI Thread. The second part is the
synthesizer logic which is running on a worker thread.

Bug: 869399, 1133813
Change-Id: I8f8d939950cc39637f87d101ed362123a51e985e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462341
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820340}

Typed events' phases, categories, and names are already exported to ETW
via TraceLog::ShouldAddAfterUpdatingState(). However, when the typed
event is emitted onto a different track, this wasn't yet reflected in
the phase of the event as exported by ETW.

This patch overrides the phase passed on to ETW export for such events
with explicit tracks.

Bug: 1141860
Change-Id: Ia7b0b5b3dcb44e415110396baf9c2239f2fc656b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494937
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Stephen Nusko <nuskos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820339}

This CL adds a Blink counterpart and client for the
PolicyContainer. The Blink PolicyContainer is connected via mojo to
the content PolicyContainer and can update policies.

On CommitNavigation, the Browser sends to Blink the PolicyContainer of
the target document, together with a mojo remote that connects to the
Browser counterpart. Blink stores it into the LocalFrame.

Change-Id: I8231d205057f0c3af720b339e409af86301c2add
Bug: 1130587
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418381
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820338}

This patch means the code change to apply first line style on the first
innermost in-flow block even if there are out-of-flow blocks.
Following the spec (https://drafts.csswg.org/css-pseudo-4/#first-line-pseudo),
The first formatted line of an element must occur inside a block-level
descendant in the same flow (that is not out-of-flow due to floating or
positioning). So, we should skip out-of-flow children in
LayoutBlock::EnclosingFirstLineStyleBlock().

Bug: 979253
Change-Id: I58836b223b58816f731096a7a9f93e612278d42f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485667
Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820337}

https://webrtc.googlesource.com/src.git/+log/213fa85f73cd..9d69cbeabf5d

2020-10-23 sprang@webrtc.org Changes default pacing factor to 1.1x

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Id2b678ad73a9258b1eaa8a7df6219ec7bd1991c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495386Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820336}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e323f012..42c17639

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I64c1f4bab6ff9dc7d4452167315dfbb1a4c14fab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495243Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820335}

This CL allows to change max number of stored and restored navigation
items via Finch within [40, 75] range. This experiment will allow to
understand if reducing stored session size can reduce out of memory
crashes.

Bug: 1115279
Change-Id: I2a4c40f6949631df4eaa503f21b909cd0c3994ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493120Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820334}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chonggu@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chonggu@google.com
Change-Id: Ic17a94146752dc154d2459e5f8eff063a9f2c827
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495387Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820333}

We needed the special SVG code to disable compositing. Now we can
composite the element while disable composited animation, so we can use
the common code path for unsupported CSS properties for animation.

Bug: 1134652
Change-Id: Ifa30c2ca90e0574be537b7f235aae027afa16653
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493724
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#820332}

https://android.googlesource.com/platform/external/perfetto.git/+log/6b3c8d667a5f..4cd11945c5a1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I50ce94cdf5b9f72708f35f403b5edd39cac13bc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495500Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820331}

Change-Id: I37cf93456db505479775fb05bf59cb32cacad2f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493096
Commit-Queue: Nate Chapin <japhet@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820330}

https://screenshot.googleplex.com/3D6kchnMu4Dx2Ez

Bug: 1125150
Test: browser_tests --gtest_filter=DiagnosticsApp*
Change-Id: I17237736ae391af7e82bc747b09bbb4749a3c548
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492969
Commit-Queue: Joon Ahn <joonbug@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820329}

Add pointer support to the mostVisited and shortcut buttons
on the NTP.

BUG=1139054

Change-Id: I9486aca3c27871312df0051149f8ed1e6f1dea22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476957
Auto-Submit: Mike Pinkerton <pinkerton@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Mike Pinkerton <pinkerton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820328}

Bug: 1136043
Change-Id: Ic77b9a0f7c91116931ef1f7f73b7d2f2108f9124
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495285
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820327}

Before, we had to manually add an obsolete tag to each variant when the
entire <histogram_suffixes> node was marked obsolete. This fix attaches
an <obsolete> tag to each generated variant.

Bug: 758782
Change-Id: I6986b912b3646de42b8564cdb302cb9eddf8decc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481789Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Commit-Queue: Karthika Pai <karthikapai@google.com>
Cr-Commit-Position: refs/heads/master@{#820326}

This CL adds a new onboarding dismiss prompt by:
- Introduced a superclass |PhoneHubContentView| for all content views
  with an |OnBubbleClose| function.
- Separate the previous |OnboardingView| to |OnboardingMainView| which
  is responsible for displaying the main page of the onboarding view,
  and |OnboardingDismissPromptView| which is responsible for displaying
  the dismiss prompt.
- Refactors the content view classes to inherit from the superclass.
- Updates and refactors the unittest.

Screenshot: https://screenshot.googleplex.com/7vqNqrD9im5vvVS.png

Future work:
Update the UI to spec by removing the phone status bar.

BUG=1106937,1126208

Change-Id: I6d4f164526d37e7018aa696324e8b1f7878492bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474253
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820325}

This CL is keeping track of the language returned by the speak
synthetizer. The language attribute is used by the TTS controller
GetMatchingVoice(...) to choose the most suitable voices.


For an empty test that do:
  speechSyntheizer.speak(...)

My local computer is choosing:
  Afrikaans espeak-ng
which is the first alphabetical entry.

With the patch, it is choosing:
  English (America) espeak-ng
since my app-locale are taken into account by the TTS controller.

Bug: 1133813
Change-Id: Ie04657dec7f947ddd91c9e672bcb36a54863d88e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493021Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820324}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/91ad80de0e11..1315d1d2d5a5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC bsep@google.com,mohsen@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: bsep@google.com,mohsen@google.com
Change-Id: I74c32f2f93ab8660ff15ee6f8116a9639b746be0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495381Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820323}

Bug: 1080832
Change-Id: I4ff90e0040dfba8a2432d51f4f3dcdd7aa2e7f65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495505
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820322}

On macOS versions running versions below 10.10 images did not conform to
NSSecureCoding protocol. Now that Chrome only supports macOS 10.10+ this
check is unnecessary.

Bug: None
Change-Id: Ief414b6e6e7f183b2e9e2b5065231579b92578e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494873Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Mohamed Adel <adelm@google.com>
Cr-Commit-Position: refs/heads/master@{#820321}

On Linux AMD ES3MapBufferRangeTest.ReadPixels has begun failing
consistently reporting errors from the drivers. A device reboot did not
resolve this.

This change skips the test on that configuration while we look into the
root cause.

TEST= gl_tests_passthrough
      ES3MapBufferRangeTest.ReadPixels

Bug: angleproject:5213
Change-Id: I8a25c357d8eeea7bd6dc17023402bc84a6309e7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495042Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820320}

a.Then(b) will return a new callback that when Run() will
1) run |a|
2) run |b|, passing it the return value from a
3) return the result from |b|

OnceCallbacks must be destroyed when joining them together with Then(),
so the method is rvalue-qualified. This means it is used in the
same way as Run(), for example, this function posts two callbacks to
run together as a single task:

void PostTwoTasks(base::OnceClosure c1, base::OnceClosure c2) {
  PostTask(std::move(c1).Then(std::move(c2)));
}

RepeatingCallback can be joined destructively via the rvalue-qualified
overload, or non-destructively otherwise. The latter is allowed for a
RepeatingCallback because it is meant to have multiple callers and
therefore having both the original callbacks and the joined callback
pointing to the same underlying functor is not problematic.

R=chrisha@chromium.org, gab@chromium.org

Bug: 1140582
Change-Id: Ie147f01d1c8adeb5ed34e4933f211e7d247e3c6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485642
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820319}

The page does not load because failing the trusted type policy.
Removing import "strings.m.js" since we are not using it.

Bug: 1141097
Change-Id: Ief36638834ac481f1da6ce98c94c6c60308f54c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492890Reviewed-by: Glenn Hartmann <hartmanng@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820318}

Bug: 1077217
Change-Id: Ie0081edc73c8b8ed0669c0aacaad9ccbb2ead003
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490800Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820317}

Bug: 1037760
Change-Id: Ie4043cc704a59da892638d07335080f47fe26ecd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469217
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820316}