GitLab

Expand the testing override for the extension warning bubbles from just forcing
enabled to also forcing disabled. As we roll this out on finch, it will begin
becoming the default on trybots, but we don't want to have these bubbles
interfering with our tests when we load unpacked extensions (which is in almost
all extension browser tests).

TBR=avi@chromium.org (micro changes to permission bubble test)
TBR=mmenke@chromium.org (micro changes to prerender test)

Review URL: https://codereview.chromium.org/1275623004

Cr-Commit-Position: refs/heads/master@{#342402}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b531751e..38a68d3b

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1282563002

Cr-Commit-Position: refs/heads/master@{#342401}

BUG=517307
TBR=dominickn@chromium.org

Review URL: https://codereview.chromium.org/1273013003

Cr-Commit-Position: refs/heads/master@{#342400}

[PresentationAPI, Android] Add ChromeMediaRouterDialogController.java and bind it with the native MediaRouterDialogControllerAndroid

BUG=517101

Review URL: https://codereview.chromium.org/1270353003

Cr-Commit-Position: refs/heads/master@{#342399}

BUG=463180

Review URL: https://codereview.chromium.org/1281953002

Cr-Commit-Position: refs/heads/master@{#342398}

Soon SpdyHeaderBlock will become a LinkedHashMap which does not have
operator== defined, and it doesn't look likely that it will gain such an
implementation (if cl/98825772 does get submitted, I'll revert this CL).

No behavior change.

relnote: n/a (test only)

Merge internal change: 99406076

R=rch@chromium.org

Review URL: https://codereview.chromium.org/1281763002

Cr-Commit-Position: refs/heads/master@{#342397}

BUG=none
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/1276043003 .

Cr-Commit-Position: refs/heads/master@{#342396}

Upstream changes for NetworkQualityProvider so that the
native code can call the APIs provided by operating system.
Downstream changes will come later for Chrome on Android.

BUG=472685

Review URL: https://codereview.chromium.org/1235373006

Cr-Commit-Position: refs/heads/master@{#342395}

* With the new manifest name/shortname changes, we don't always have null in the intent for the shortname.
  It could also be the empty string which we need to handle by displaying the page title in recents.
* This issue is present with Slashdot which does not have a shortname and so has an empty title.

TODO(lalitm): this is actually a temporary fix for the bigger issue of short name not being set to the meta tag title of the website if the short name is not present in the manifest. Some discussion is required for this before a CL which correctly fixes the issue is submitted.

BUG=517647

Review URL: https://codereview.chromium.org/1272563005

Cr-Commit-Position: refs/heads/master@{#342394}

BUG=none

Review URL: https://codereview.chromium.org/1281513003

Cr-Commit-Position: refs/heads/master@{#342393}

[PresentationAPI, Android] Add ChromeMediaRouter.java and bind it with the native MediaRouterAndroid

BUG=512549
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/1275893002

Cr-Commit-Position: refs/heads/master@{#342392}

Currently if networkingPrivate attempts to connect
to an unconfigured network, the request fails and the
UI is expected to handle configuraiton.

Until network configuration is fully integrated into the
new Settings UI, we need Chrome to handle the configuration
UI.

This CL:
* Adds HandleConnectFailed to NetworkingPrivateDelegate::UIDelegate
* Suppresses a redundant notification when a connect to an
  unconfigured network fails.
Also:
* Updates the logging in the notification code
* Handles "expected" errors in network_summary.js to avoid "unhandled lastError" messages when requesting a connect to an unconfigured network.

BUG=515987

Review URL: https://codereview.chromium.org/1272003002

Cr-Commit-Position: refs/heads/master@{#342391}

in https://codereview.chromium.org/1273813005/. The CL is unchanged,
except the DCHECKs that uncovered another bug have been removed. They'll
be added back once that bug is fixed.

Fix cancellation of a pair of URLRequestJob subclasses.

URLRequestSimpleJob and URLRequestChromeJob can call back into their
parent URLRequestJob class after Kill() has been invoked, which can
cause Bad Things.

Longer term, we should think about the interface between URLRequestJob
and its subclasses, to see if we can create a more robust interface.

BUG=508900
Committed: https://crrev.com/363ce98af274c07f43acac74b7ca7c23641c996e
Cr-Commit-Position: refs/heads/master@{#342211}

Review URL: https://codereview.chromium.org/1281943002

Cr-Commit-Position: refs/heads/master@{#342390}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/9bca526..ca1f07e

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Commits in this roll:
ca1f07e joshualitt@chromium.org Add Batch logging
f159518 mtklein@chromium.org This iOS crash makes little sense to me.  Add some debugging.
30e4d75 mtklein@chromium.org This iOS crash makes little sense to me.  Add some debugging.

Review URL: https://codereview.chromium.org/1276303002

Cr-Commit-Position: refs/heads/master@{#342389}

It is possible for user to choose chrome when url overriding results in an intent chooser.
In this case, we should let everything work as if nothing has happened.
However, intent handling will result in a new url request.
And that causes chrome to lose the user gesture bit, and introduces some side effects.
For example, when clicking a pdf link, the pdf will be auto opened by docs app.
However, if Adobe pdf reader is installed, an intent chooser will be shown when clicking the pdf link.
If user chooses chrome to handle the intent, the pdf will be downloaded, but not auto opened due to the missing user gesture

BUG=512633

Review URL: https://codereview.chromium.org/1243253004

Cr-Commit-Position: refs/heads/master@{#342388}

I'm interested in tracking this information on the chromium.perf bots.

BUG=

Review URL: https://codereview.chromium.org/1281733002

Cr-Commit-Position: refs/heads/master@{#342387}

According to the fetch spec (https://fetch.spec.whatwg.org/), once the request goes to the network, skip-service-worker flag must be set.
So if the server returns a redirect response, the next request must not be handled by service worker.

BUG=517364,512764

Review URL: https://codereview.chromium.org/1274973002

Cr-Commit-Position: refs/heads/master@{#342386}

Re-Land of https://codereview.chromium.org/1258563005/

- Made Google OS Sign-in Tests FlakyTest
- Fixed test account preferences that caused the real Google account sign-in tests to fail previously.

BUG=

Review URL: https://codereview.chromium.org/1279483003

Cr-Commit-Position: refs/heads/master@{#342385}

It was being used to allowed passing ownership of an error handler, but passing
a weak handle works just as well.

BUG=511235

Review URL: https://codereview.chromium.org/1275743002

Cr-Commit-Position: refs/heads/master@{#342384}

base::Version constructor already takes a std::string, so no need to
pass in result of c_str() which would just create a second std::string.

Review URL: https://codereview.chromium.org/1280673002

Cr-Commit-Position: refs/heads/master@{#342383}

Requires: //components/policy:policy_component_browser

BUG=507294

Review URL: https://codereview.chromium.org/1268443004

Cr-Commit-Position: refs/heads/master@{#342382}

This reverts the following:

  commit 5cb0c01e
  Author: oshima <oshima@chromium.org>
  Date:   Fri May 15 15:16:07 2015 -0700

      Compute the base dpi from X

  commit 42de8ba1
  Author: oshima <oshima@chromium.org>
  Date:   Wed Jul 22 15:17:49 2015 -0700

      Use org.gnome.desktop.interface text-scaling-factor directly

R=oshima@chromium.org, stapelberg@google.com
BUG=485183

Review URL: https://codereview.chromium.org/1276553007

Cr-Commit-Position: refs/heads/master@{#342381}

"units" should be "enum"

BUG=none
TEST=none
R=rouslan@chromium.org

Review URL: https://codereview.chromium.org/1274893004

Cr-Commit-Position: refs/heads/master@{#342380}

BUG=508935

Review URL: https://codereview.chromium.org/1280443003

Cr-Commit-Position: refs/heads/master@{#342379}

BUG=513399
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/1275103003 .

Cr-Commit-Position: refs/heads/master@{#342378}

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
R=nick@chromium.org
BUG=470994
TEST=

Review URL: https://codereview.chromium.org/1254103002

Cr-Commit-Position: refs/heads/master@{#342377}

This histogram shows that the measured event is generally quite fast, and any
future slowness should be identified with a profiler, rather than by remembering
to check the histogram.

BUG=517206
TEST=none
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/1275093002

Cr-Commit-Position: refs/heads/master@{#342376}

The keyboard layout ABC - AZERTY was added in 10.11, which maps 'm' to the
same keycode as the Belgian, Italian, and French layouts. Add this case.

BUG=none
TEST=NSMenuItemAdditionsTest.TestMOnDifferentLayouts

Review URL: https://codereview.chromium.org/1282543002

Cr-Commit-Position: refs/heads/master@{#342375}

This is the first step towards unifying client side and service side ServicePort
instances, but also removes a layer of abstraction in how connections to
services are setup. The abstraction layer will probably later be reintroduced
differently.

BUG=426458

Committed: https://crrev.com/9b053ed8f7b8893ad0a5a33d31546c70563ddf20
Cr-Commit-Position: refs/heads/master@{#341987}

Review URL: https://codereview.chromium.org/1224263007

Cr-Commit-Position: refs/heads/master@{#342374}

Add WebRTC.Video.AverageRoundTripTimeInMilliseconds histogram for measuring round-trip time in WebRTC calls.

BUG=507314

Review URL: https://codereview.chromium.org/1280933002

Cr-Commit-Position: refs/heads/master@{#342373}

This CL has a moderate chance of breaking the CFI buildbot:
while I don't observe any CFI failures, browser_tests and
interactive_ui_tests are extremely flaky on my machine,
so I could miss some.

Should the buildbot be broken, I will quickly remove the
failing tests.

BUG=chromium:457523

Review URL: https://codereview.chromium.org/1272563003

Cr-Commit-Position: refs/heads/master@{#342372}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f6ae725..494accf

TBR=hiroshige@chromium.org,junov@chromium.org

Review URL: https://codereview.chromium.org/1278153003

Cr-Commit-Position: refs/heads/master@{#342371}

* CMA backend interfaces moved into chromecast/public/media
* CMA backend implementation loaded from libcast_media through
  CastMediaShlib
* Backend API changes to remove dependency on Chromium types:
  * DecryptContext replaced with CastKeySystem
  * scoped_refptr replaced with raw pointers
  * In particular, DecoderBufferBase replaced in the backend API
    with non-refcounted DecoderBuffer.  In order to allow us to keep
    using refcounting and in particular use DecoderBufferBase in the
    rest of our pipeline, it gets wrapped in a DecoderBufferImpl
    (implementation of DecoderBuffer) for passing to the backend. So
    backends must delete the buffer pointer they're given but this is
    actually just decrementing the refcount on the underlying buffer.
  * base::Callback replaced with abstract interfaces
  * base::TimeDelta replaced with chromecast::TimeDelta in backend
    interface, essentially a stripped-down copy
  * NonThreadSafe removed (implementations can use ThreadChecker)
* TaskRunner interface provides PostTask/PostDelayedTask service to
  backend implementations
* Backend ownership / factory model changed.  Now, backend
  implementations return a MediaPipelineBackend which manages ownership
  and hookup of all the components.  It returns access to them as raw
  pointers.  The pipeline manages the lifetime of the MediaPipelineBackend
  instance.
* GetIsCodecSupportedOnChromecast refactored to remove calls back into
  cast_shell from backends (implementation can just return 'default' to
  indicate default logic should apply, including HDMI capabilities.

BUG=508534

Review URL: https://codereview.chromium.org/1257013003

Cr-Commit-Position: refs/heads/master@{#342370}

Reland of Add channel-specific product logo to chrome://help (patchset #1 id:1 of https://codereview.chromium.org/1280033002/ )

Reason for revert:
Official build bots were all happy with the change --- suspect the issue was a local config problem (such as not updating src-internal).

Original issue's description:
> Revert of Add channel-specific product logo to chrome://help (patchset #3 id:40001 of https://codereview.chromium.org/1269383005/ )
>
> Reason for revert:
> Reverting due to missing files.  See comments in cl:
> https://codereview.chromium.org/1269383005/
>
> Original issue's description:
> > Add channel-specific product logo to chrome://help
> >
> > BUG=511000
> >
> > Committed: https://crrev.com/9836302ea4ffb887ce6ffa597c1ee5484d2f1091
> > Cr-Commit-Position: refs/heads/master@{#342183}
>
> TBR=oshima@chromium.org,dbeam@chromium.org,estade@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=511000
>
> Committed: https://crrev.com/abd20f67987aaa47bb47e61288ec92b4ab761521
> Cr-Commit-Position: refs/heads/master@{#342324}

TBR=oshima@chromium.org,dbeam@chromium.org,tommi@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=511000

Review URL: https://codereview.chromium.org/1279093002

Cr-Commit-Position: refs/heads/master@{#342369}

Implements storing of per-frame selection offsets in the accessibility tree and adds Windows specific code for reporting these offsets across embedded objects according to the IA2 Spec.
BUG=491027
R=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/1195223006

Cr-Commit-Position: refs/heads/master@{#342368}

While trying to hook up new strings from crrev.com/1270793002 into TC,
I have realized that some changes need to be made to their definitions.

1. In Chrome, html fragments (grit 'structures') are not used. Instead, they
   just put into .grd files as regular messages, with markup being isolated
   inside fake placeholders to avoid the translators messing with it.
   (and grit also requires non-empty 'example' tags to present for them).
   Thus, removed 'structure.html' and put its contents into a scary-looking
   message.

2. .grd files containing messages must not include anything, as only .grd
   files themselves are copied into the internal tree for processing.
   Thus, split the messages into a separate .grd file with no includes.

3. From the strings .grd, per-locale .pak files must be produced, and then
   all those xxx_strings_xx.pak files repacked into a single xx.pak file.
   As WebView already uses content_strings, changed the script to pack
   content_strings together with the new strings, and renamed the script
   accordingly.

4. As I would not like to repeat this process again would we need some
   native strings on the browser part, and as we share native resources
   between the browser and the renderer, moved the .grd files out from
   'renderer' into a new 'ui' subdir.

BUG=515691

Review URL: https://codereview.chromium.org/1273263002

Cr-Commit-Position: refs/heads/master@{#342367}

Revert of GC plugin: consider references equal to raw pointers. (patchset #2 id:20001 of https://codereview.chromium.org/1274403002/ )

Reason for revert:
Turned the clang/win tot bots red: http://build.chromium.org/p/chromium.fyi/builders/ClangToTWin/builds/2327/steps/compile/logs/stdio

..\..\third_party\WebKit\Source\core/css/parser/CSSSupportsParser.h(13,1) :  error: [blink-gc] Class 'CSSSupportsParser' contains invalid fields.
class CSSSupportsParser {
^
..\..\third_party\WebKit\Source\core/css/parser/CSSSupportsParser.h(31,5) :  note: [blink-gc] Stack-allocated field 'm_parser' declared here:
    CSSParserImpl& m_parser;
    ^

Original issue's description:
> GC plugin: consider references equal to raw pointers.
>
> Unmanaged raw pointers to managed(GC) classes aren't safe across GCs,
> hence fields with raw pointer types to such GCed classes are identified
> and reported as errors or warnings.
>
> Extend that checking to also apply to reference pointer types.
>
> R=haraken
> BUG=420515
>
> Committed: https://crrev.com/70fe23896f81cd66ba1a205b0336f91c64e3fa4e
> Cr-Commit-Position: refs/heads/master@{#342320}

TBR=oilpan-reviews@chromium.org,sigbjornf@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=420515

Review URL: https://codereview.chromium.org/1275383002

Cr-Commit-Position: refs/heads/master@{#342366}

This allows an MITM to make the firs byte of a valid HTTP/1.x response
look like a valid HTTP/0.9 reponses, so best to be safe.

BUG=517106

Review URL: https://codereview.chromium.org/1276943003

Cr-Commit-Position: refs/heads/master@{#342365}

This CL add a device management request to send GCM id after registration to
the server, so that server can maintain a mapping between GCM id and DM token.

BUG=517466

Review URL: https://codereview.chromium.org/1258313002

Cr-Commit-Position: refs/heads/master@{#342364}

The "AndroidSessionNotifications" experiment disables session invalidations
because session sync invalidations represent the bulk of the invalidation
traffic. Session invalidations cause the client to fetch the updated
"Recent Tabs" from the sync server.

This CL enables session sync invalidations only after the user has had the
RecentTabsPage open for a while. This enables the Android RecentTabsPage to be
"live": If a user opens a tab on a device which is signed in to the same profile
as the Android device, the RecentTabsPage on the Android device is updated with
the new tab. The CL disables session sync when the RecentTabsPage is closed
because the invalidations are not longer useful at that time.

BUG=477054
TEST=InvalidationControllerTest.*

Review URL: https://codereview.chromium.org/1263773007

Cr-Commit-Position: refs/heads/master@{#342363}