GitLab

And move the functionality into gfx::Screen.

BUG=101507
R=ben@chromium.org

Review URL: http://codereview.chromium.org/8549008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113531 0039d316-1c4b-4281-b951-d872f2087c98

This is the first patch to get remove CHECK stmts from syncable layer.

BUG=100444
TEST=


Review URL: http://codereview.chromium.org/8804026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113530 0039d316-1c4b-4281-b951-d872f2087c98

This is basically a reversion of the final patch set (#4) of this:
http://codereview.chromium.org/8395012

The reason is because tasks posted to the query thread can extend the lifetime of the D3D device such that it is destroyed on the query thread. The D3D thread must be destroyed on the thread it was created on though.

The suggestion was a good one and I might revisit it in the future.

I also added a missing lock and switched it to load the D3D9 DLL rather than assume it is already loaded by something else.
Review URL: http://codereview.chromium.org/8867005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113529 0039d316-1c4b-4281-b951-d872f2087c98

was_origin_cert_sent()

This will help SpdySession decide to send a CREDENTIAL frame.

BUG=106103
TEST=none

Review URL: http://codereview.chromium.org/8869004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113528 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23898
TEST=go to chrome://os-credits and click on "show license"
Review URL: http://codereview.chromium.org/8869008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113527 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104645

Review URL: http://codereview.chromium.org/8826002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113526 0039d316-1c4b-4281-b951-d872f2087c98

Enable UndoRedo_CutCopyPasteTest

BUG=103988,97845
TEST=added new UndoRedo_BackspaceThenSetText, enabled CutCopyPasteTest


Review URL: http://codereview.chromium.org/8823007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113525 0039d316-1c4b-4281-b951-d872f2087c98

Reducing the number of tests should speed up bots, and we are unlikely
to ever need to separately enable/disable these.
Review URL: http://codereview.chromium.org/8857003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113524 0039d316-1c4b-4281-b951-d872f2087c98

Call browser::CreateBubbleView instead of BubbleDelegateView::CreateBubble for ExtensionInstalledBubble and AvatarMenuBubbleView.

BUG=105023
TEST=No visible bubble changes.

Review URL: http://codereview.chromium.org/8833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113523 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106255
TEST=see bug for repro


Review URL: http://codereview.chromium.org/8823015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113522 0039d316-1c4b-4281-b951-d872f2087c98

TBR=aa
BUG=62897
Review URL: http://codereview.chromium.org/8862004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113521 0039d316-1c4b-4281-b951-d872f2087c98

We could convert these tests to use manifest_version 2, but it's not worth the
effort.  (After this patch, I believe all the tests will pass when we require
manifest_version 2 for unpacked extensions.)

BUG=62897
Review URL: http://codereview.chromium.org/8864002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113520 0039d316-1c4b-4281-b951-d872f2087c98

This test makes assumptions that the native code will run, which is at odds with how valgrind works.

BUG=None
TBR=siggi@chromium.org

Review URL: http://codereview.chromium.org/8882001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113517 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106796
TEST=none

Review URL: http://codereview.chromium.org/8866009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113516 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: Bot redness. See http://build.chromium.org/p/chromium/builders/Mac10.6%20Tests%20%281%29/builds/15717

Original checkin notes:

This reverts commit bd45bd25.

TEST=ran webkit tests in DRT and webgl tests in chrome
BUG=103989

Review URL: http://codereview.chromium.org/8758026

TBR=gman@chromium.org
Review URL: http://codereview.chromium.org/8865008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113512 0039d316-1c4b-4281-b951-d872f2087c98

Revert 113470 - Makes tests either use mock compositor or mock WebGraphicsContext3D depending upon which compositor we're running. This is needed to enable ui tests on the bots.

BUG=104360
TEST=none

Review URL: http://codereview.chromium.org/8805033

TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/8873001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113507 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=plugin_tests makes a bit more noise in its logs.


Review URL: http://codereview.chromium.org/8341069

Review URL: http://codereview.chromium.org/8854008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113503 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106523
TEST=ui_unittests --gtest_filter=ClipboardTest.* and manual testing

Review URL: http://codereview.chromium.org/8801038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113502 0039d316-1c4b-4281-b951-d872f2087c98

This should turn some timeouts caused by a renderer crash into immediate failures.

BUG=106541
TEST=less timeouts


Review URL: http://codereview.chromium.org/8834012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113501 0039d316-1c4b-4281-b951-d872f2087c98

Since we're using the native spellchecker, this menu item is no longer needed.

BUG=None
TEST=Right click on a text field in web content, go to the "Spelling and Grammar" context menu. "Languages and Settings" should no longer appear as an option.


Review URL: http://codereview.chromium.org/8851010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113500 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113499 0039d316-1c4b-4281-b951-d872f2087c98

I suspect that the crashes reported in M17 are because the SQLitePersistentCookieStore is closed while it was still loading.

This CL adds checks that should abort all tasks that access db_, if db_ is NULL.

R=rdsmith@chromium.org
BUG=106722
TEST=None


Review URL: http://codereview.chromium.org/8855009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113498 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=trybots
TBR=bashi

Review URL: http://codereview.chromium.org/8854003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113497 0039d316-1c4b-4281-b951-d872f2087c98

trying to write to a socket.

Our old behavior caused network failures on servers that hang
up right after sending a file, but don't use
"connection: close".

BUG=105824

Review URL: http://codereview.chromium.org/8775044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113496 0039d316-1c4b-4281-b951-d872f2087c98

The "Languages and Settings" menu item should not be present in the first place in the spellcheck context menu on OS X.

I'll remove the menu item in a followup CL but in the meantime we can remove the code that specifically disables the command on Mac. In the interim having it enabled doesn't do any harm.

BUG=69944
TEST=None


Review URL: http://codereview.chromium.org/8850006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113495 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8571023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113494 0039d316-1c4b-4281-b951-d872f2087c98

Works fine now when I tried 20 iterations.

R=dennisjeffrey@chromium.org
BUG=91225
TEST=

Review URL: http://codereview.chromium.org/8863005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113493 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=

Review URL: http://codereview.chromium.org/8863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113492 0039d316-1c4b-4281-b951-d872f2087c98

This change has tendrils stretching throughout the code, but mostly this lets us delete a bunch of stuff.

This also does a slight refactor to put the PPB_Var implementations in 1 place, since they were already practically identical, and I didn't want to do the backwards-compat code in 2 places.

BUG=106596
TEST=N/A
TBR=darin,tony

darin,tony TBR for rubber-stamp of webkit/glue/webkit_glue.gypi

Review URL: http://codereview.chromium.org/8826011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113491 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106043
TEST=
R=rnk@chromium.org


Review URL: http://codereview.chromium.org/8806028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113488 0039d316-1c4b-4281-b951-d872f2087c98

Currently we assume that any profile picture URL that contains "AAAAAAAAAAI/AAAAAAAAAAA" represents a default profile picture.

It turns out that this is incorrect. There are valid profile pictures with that URL.

With the OAuth user info API we can simply detect default profile pictures by the existance of the "picture" field in the returned data. Accounts with a default profile picture don't have this field.

BUG=106444
TEST=Compiled and verified that unit tests passed.


Review URL: http://codereview.chromium.org/8801023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113487 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23764
TEST=Log in as guest, attempt to lock screen, nothing should happen.


Review URL: http://codereview.chromium.org/8842002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113485 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113484 0039d316-1c4b-4281-b951-d872f2087c98

Revision: 904
Author: apatrick@chromium.org
Date: 11:11:33 AM, Wednesday, December 07, 2011
Message:
Update version to 904.
Review URL: http://codereview.appspot.com/5449113
----
Modified : /trunk/src/common/version.h

Revision: 903
Author: apatrick@chromium.org
Date: 11:10:16 AM, Wednesday, December 07, 2011
Message:
Fixed leak of render target associated with ColorBuffer.

Following r853, I am assuming that any render target returned by FrameBuffer::getRenderTarget has to be released. Updating the usage of getRenderTarget to reflect that.

This is not reproducible in Chrome at the moment but it will be once I start rendering to pbuffers.

I ran the WebGL conformance tests. No regressions or crashes.
Review URL: http://codereview.appspot.com/5451110
----
Modified : /trunk/src/libGLESv2/Context.cpp

Revision: 902
Author: apatrick@chromium.org
Date: 6:05:22 PM, Monday, December 05, 2011
Message:
Implemented EGL_NV_post_sub_buffer.

The change to the sample is just to demonstrate how I tested it. I won't check in the stuff under samples/.

It's not clear to me what eglPostSubBufferNV should do if EGL_POST_SUB_BUFFER_SUPPORTED_NV is false. At the moment it fails silently as though it was called on the wrong surface type:

 "If <surface> is a back-buffered surface, then the requested portion
    of the color buffer is copied to the native window associated with
    that surface. If <surface> is a single-buffered window, pixmap, or
    pbuffer surface, eglSwapBuffers and eglPostSubBufferNV have no
    effect."
Review URL: http://codereview.appspot.com/5345050
----
Modified : /trunk/samples/build_samples.gyp
Modified : /trunk/samples/gles2_book/Common/esUtil.c
Modified : /trunk/samples/gles2_book/Common/esUtil.h
Added : /trunk/samples/gles2_book/PostSubBuffer
Added : /trunk/samples/gles2_book/PostSubBuffer/PostSubBuffer.c
Added : /trunk/samples/gles2_book/PostSubBuffer/PostSubBuffer.vcproj
Modified : /trunk/samples/samples.sln
Modified : /trunk/src/libEGL/Display.cpp
Modified : /trunk/src/libEGL/Surface.cpp
Modified : /trunk/src/libEGL/Surface.h
Modified : /trunk/src/libEGL/libEGL.cpp

Revision: 901
Author: daniel@transgaming.com
Date: 11:42:32 AM, Tuesday, November 29, 2011
Message:
Creates helper function for common subimage param checking

TRAC #18802
Signed-off-by: Nicolas Capens
Signed-off-by: Daniel Koch
Author: Shannon Woods
----
Modified : /trunk/src/common/version.h
Modified : /trunk/src/libGLESv2/libGLESv2.cpp

Revision: 900
Author: daniel@transgaming.com
Date: 11:42:28 AM, Tuesday, November 29, 2011
Message:
Adds missing parameter checks to texture functions

TRAC #18802
Signed-off-by: Nicolas Capens
Signed-off-by: Daniel Koch
Author: Shannon Woods
----
Modified : /trunk/src/common/version.h
Modified : /trunk/src/libGLESv2/libGLESv2.cpp

Revision: 899
Author: daniel@transgaming.com
Date: 11:42:23 AM, Tuesday, November 29, 2011
Message:
Adds a level parameter to texture getWidth and getHeight

TRAC #18802
Signed-off-by: Nicolas Capens
Signed-off-by: Daniel Koch
Author: Shannon Woods
----
Modified : /trunk/src/common/version.h
Modified : /trunk/src/libGLESv2/Renderbuffer.cpp
Modified : /trunk/src/libGLESv2/Texture.cpp
Modified : /trunk/src/libGLESv2/Texture.h
Modified : /trunk/src/libGLESv2/libGLESv2.cpp

Revision: 898
Author: daniel@transgaming.com
Date: 9:23:51 AM, Tuesday, November 29, 2011
Message:
Checks parameters of matrices for under-fullness in shader constructor check.

TRAC #18906
Issue=218
Signed-off-by: Nicolas Capens
Signed-off-by: Daniel Koch
----
Modified : /trunk/src/common/version.h
Modified : /trunk/src/compiler/ParseHelper.cpp

Revision: 897
Author: daniel@transgaming.com
Date: 9:21:42 AM, Tuesday, November 29, 2011
Message:
Fix post-build steps when spaces appear in directory names

TRAC #18901
Issue=245
Signed-off-by: Nicolas Capens
Signed-off-by: Daniel Koch
----
Modified : /trunk/samples/gles2_book/MultiTexture/MultiTexture.vcproj
Modified : /trunk/samples/gles2_book/ParticleSystem/ParticleSystem.vcproj
Modified : /trunk/src/common/version.h

Revision: 895
Author: daniel@transgaming.com
Date: 2:34:26 PM, Thursday, November 24, 2011
Message:
Update major version.
----
Modified : /trunk/src/common/version.h

Revision: 894
Author: daniel@transgaming.com
Date: 2:34:22 PM, Thursday, November 24, 2011
Message:
Add another contributor
----
Modified : /trunk/CONTRIBUTORS
Modified : /trunk/src/common/version.h

Revision: 893
Author: daniel@transgaming.com
Date: 2:34:18 PM, Thursday, November 24, 2011
Message:
Update contributors
----
Modified : /trunk/CONTRIBUTORS
Modified : /trunk/src/common/version.h

Revision: 892
Author: daniel@transgaming.com
Date: 2:34:14 PM, Thursday, November 24, 2011
Message:
Fix rendering for the closing line of line loops.

Trac #19035
Signed-off-by: Nicolas Capens

Line loops via DrawArrays were incorrect because the vertex buffer already
has the vertex offset factored in.
Line loops via DrawElements were incorrect because the vertex buffer was
offset by the minIndex. We need to use the same minIndex when rendering
the closing loop.
----
Modified : /trunk/src/common/version.h
Modified : /trunk/src/libGLESv2/Context.cpp
Modified : /trunk/src/libGLESv2/Context.h

Revision: 891
Author: daniel@transgaming.com
Date: 2:34:09 PM, Thursday, November 24, 2011
Message:
Avoid rendering the last pixel of lines.

Trac #19035
Issue=257
Author: Yuriy O'Donnell

Signed-off-by: Nicolas Capens
Signed-off-by: Daniel Koch
----
Modified : /trunk/src/common/version.h
Modified : /trunk/src/libEGL/Display.cpp

Revision: 890
Author: daniel@transgaming.com
Date: 2:34:04 PM, Thursday, November 24, 2011
Message:
Fix HLSL translation for mod(vec2,vec2)

ANGLEBUG=258
Signed-off-by: Daniel Koch
Signed-off-by: Nicolas Capens
Author: Sam Hocevar
----
Modified : /trunk/src/common/version.h
Modified : /trunk/src/compiler/OutputHLSL.cpp
Modified : /trunk/src/compiler/OutputHLSL.h


Review URL: http://codereview.chromium.org/8856011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113483 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8836001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113482 0039d316-1c4b-4281-b951-d872f2087c98

I had fixed it in r111201

R=dennisjeffrey@chromium.org
BUG=104886
TEST=

Review URL: http://codereview.chromium.org/8866001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113481 0039d316-1c4b-4281-b951-d872f2087c98

The old ProfileManagerObserver was hard to use since it required a new class or subclassing. Using callbacks is easier.

BUG=100461
TEST=

Review URL: http://codereview.chromium.org/8840003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113480 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit bd45bd25.

TEST=ran webkit tests in DRT and webgl tests in chrome
BUG=103989

Review URL: http://codereview.chromium.org/8758026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113479 0039d316-1c4b-4281-b951-d872f2087c98

I think that r113138 and r113167 combined made it too light

BUG=106669
TEST=manual

Review URL: http://codereview.chromium.org/8833006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113478 0039d316-1c4b-4281-b951-d872f2087c98

BUG=88782
TEST=none


Review URL: http://codereview.chromium.org/8834003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113477 0039d316-1c4b-4281-b951-d872f2087c98