1. 21 Sep, 2020 1 commit
    • Khushal's avatar
      Revert "PR_SET_DUMPABLE 1 briefly if opening pagemap fails" · 8581e363
      Khushal authored
      This reverts commit c63cb6f2.
      
      Reason for revert: crbug.com/1130358
      
      Original change's description:
      > PR_SET_DUMPABLE 1 briefly if opening pagemap fails
      > 
      > This is often necessary on Android to read /proc/self/pagemap. Without
      > prctl(PR_SET_DUMPABLE) opening this file fails in 94% of cases on
      > Canary. This potentially leads to bias in reporting
      > MappedAndResidentMemoryFootprint2.
      > 
      > Bug: 1070618
      > Change-Id: Ic7f965099c4b3ba822baf248eb80d33678996188
      > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416377
      > Commit-Queue: Egor Pasko <pasko@chromium.org>
      > Reviewed-by: Robert Sesek <rsesek@chromium.org>
      > Reviewed-by: ssid <ssid@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#808298}
      
      TBR=pasko@chromium.org,ssid@chromium.org,rsesek@chromium.org
      
      # Not skipping CQ checks because original CL landed > 1 day ago.
      
      Bug: 1070618
      Change-Id: Icae38145675e215c8ba1b685308d63b0a60b1d28
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420776Reviewed-by: default avatarKhushal <khushalsagar@chromium.org>
      Commit-Queue: Khushal <khushalsagar@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#808758}
      8581e363
  2. 20 Sep, 2020 38 commits
  3. 19 Sep, 2020 1 commit