GitLab

The folder image now consists of a white circle with a grey shadow,
rather than a simple grey circle.

Also slightly darkened the entire app list background from #fafafa to

BUG=425444

Review URL: https://codereview.chromium.org/686633003

Cr-Commit-Position: refs/heads/master@{#301597}

Since we may have more than one watcher, the previous naming didn't make sense.
This patch changes all naming related to observing entries into creating
watchers.

TEST=Refactoring only. All current tests should pass.
BUG=261491

Review URL: https://codereview.chromium.org/674413002

Cr-Commit-Position: refs/heads/master@{#301596}

Infrastructure for enabling V8's initial snapshot to be loaded from external files as opposed to being statically linked to the binary.

This is not currently supported on any architecture.

BUG=421063

Review URL: https://codereview.chromium.org/594603003

Cr-Commit-Position: refs/heads/master@{#301595}

This enables the serial custom bindings that forward to the mojo serial
service behind the --enable-mojo-serial-service flag. This adds service
factory overrides to ServiceRegistrationManager for testing and updates
the serial api browsertest to test both serial implementations.

BUG=389016

Review URL: https://codereview.chromium.org/652313002

Cr-Commit-Position: refs/heads/master@{#301594}

Prefix all CommandLine usage in the android_webview/ directory with
the base:: namespace.

BUG=422426

Review URL: https://codereview.chromium.org/661443003

Cr-Commit-Position: refs/heads/master@{#301593}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/33edc61..86bc9d5

TBR=leviw@chromium.org,yurys@chromium.org

Review URL: https://codereview.chromium.org/687453002

Cr-Commit-Position: refs/heads/master@{#301592}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=miu@chromium.org

Review URL: https://codereview.chromium.org/682763002

Cr-Commit-Position: refs/heads/master@{#301591}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/686463004

Cr-Commit-Position: refs/heads/master@{#301590}

BUG=426714
TEST=Open an inspector with Ctrl+Shift+J: Type fileManager.debugMe() in the console.

Sample Output:
Debug information.
1. fileManager.initializeQueue_.pendingTasks_
Length: 2
AsyncUtil.GroupTask
- name: (unnamed#8)
- dependencies:
AsyncUtil.GroupTask
- name: (unnamed#9)
- dependencies: UnexistTask1,UnexistTask2
2. VolumeManagerWrapper
VolumeManagerWrapper
- Initialized: true
- VolumeManager:
  VolumeManager
  - MountQueue_:
    AsyncUtil.ConcurrentQueue
    - WaitingTasksCount: 0
    - RunningTasksCount: 0
    - isCancelled: false
End of debug information.

Review URL: https://codereview.chromium.org/681693003

Cr-Commit-Position: refs/heads/master@{#301589}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=pkotwicz@chromium.org

Review URL: https://codereview.chromium.org/683593003

Cr-Commit-Position: refs/heads/master@{#301588}

"Address lookup" messes up the address parsing.
The card type <select> also fails for some reason.

TBR=isherman@chromium.org
BUG=427622

Review URL: https://codereview.chromium.org/685493002

Cr-Commit-Position: refs/heads/master@{#301587}

This patch allows to create multiple subscribers for observed entry change
notifications, up to one per origin for the same entry. Eg. multiple extensions
may want to observe the same directory.

Also, the persistent argument is introduced. Persistent subscriber mean, that the
origin is watching the entry persistently, despite reboots. It will be used by
cache only.

Extensions should never use persistent origins. Such subscribers will be removed
on reboot.

TEST=unit_tests: *FileSystemProvider*Registry*,
     *FileSystemProvider*ProvidedFileSystem*
BUG=248427

Review URL: https://codereview.chromium.org/642023003

Cr-Commit-Position: refs/heads/master@{#301586}

This is not being actively developed. We can bring it back from git's
history if and when we want to pick it up again.

Review URL: https://codereview.chromium.org/681203002

Cr-Commit-Position: refs/heads/master@{#301585}

This resolves a number of compile-time warnings about features that
are not available in versions prior to 10.5.

BUG=427654

Review URL: https://codereview.chromium.org/678763008

Cr-Commit-Position: refs/heads/master@{#301584}

These are being developed in the mojo repository. Prebuilt mojo_shell
binaries can be downloaded from chromium using the
mojo/public/tools/download_shell_binary.py script.

R=ben@chromium.org

Review URL: https://codereview.chromium.org/687433002

Cr-Commit-Position: refs/heads/master@{#301583}

Interprocess mojo data pipe is not ready yet. This converts the data
pipe wrappers to send the data via their control message pipes until
interprocess data pipe is ready.

BUG=389016

Review URL: https://codereview.chromium.org/646063003

Cr-Commit-Position: refs/heads/master@{#301582}

On low-end devices, if Chrome was upgraded from a previous version,
Chrome decides to use normal mode to keep user experience consistent.
This is done by force '--low-end-device-mode=0' on both browser and render
processes.

However, when crazy linker is used, Linker.isUsed() triggers
SysUtils.detectLowEndDevice() call which checks CommandLine first.
Existing code invokes Linker.isUsed() before initilizing CommandLine,
which causes the render process ignores '--low-end-device-mode=0'.

This results the browser in normal mode, but render is in low-end device mode.

BUG=424228

Review URL: https://codereview.chromium.org/665273003

Cr-Commit-Position: refs/heads/master@{#301581}

WebRTC has a throttling mechanism to ensure we don't push too much data into the system socket. The buffer size doesn't seem to be set correctly and it was experienced video freeze from time to time as the throttling mechanism kicks in too frequently and causes video packets dropped, even though system still has more capacity to handle it.

BUG=427555

Review URL: https://codereview.chromium.org/678103003

Cr-Commit-Position: refs/heads/master@{#301580}

BUG=159847

Review URL: https://codereview.chromium.org/652033004

Cr-Commit-Position: refs/heads/master@{#301579}

In this step, we move WPR down to platform without making
any changes to the lifecycle nor where the input comes from.
API and lifecycle cleanup to follow in a follow up patch.

BUG=404771

Review URL: https://codereview.chromium.org/656303003

Cr-Commit-Position: refs/heads/master@{#301578}

BUG=none
R=msw@chromium.org

Review URL: https://codereview.chromium.org/682843003

Cr-Commit-Position: refs/heads/master@{#301577}

BUG=None

Review URL: https://codereview.chromium.org/681193002

Cr-Commit-Position: refs/heads/master@{#301576}

There are currently 2 sources of EWOULDBLOCK. One is from the system which we don't have any monitoring in place. The other is generated by the socket implementation of WebRTC. This change adds UMA for both places. The UMAs added here are

1. max consecutive EWOULDBLOCK that we receive from the system. It's protocol dependent.
2. max consecutive EWOULDBLOCK that WebRTC socket generates. Protocol independent.
3. % of packet loss in WebRTC socket layer due to its own EWOULDBLOCK generation. Protocol independent.

Tested in a call and the dtor is invoked when a call is terminated. However, if a user just closes the renderer abruptly, the dtor is not invoked such that these UMA data points will be lost.

BUG=427555

Review URL: https://codereview.chromium.org/677473002

Cr-Commit-Position: refs/heads/master@{#301575}

BUG=424610

Review URL: https://codereview.chromium.org/672393004

Cr-Commit-Position: refs/heads/master@{#301574}

HTML Tag: input type reset button, samp, s, dt, progress
ARIA Role: button, dialog, radiogroup
ARIA state/property: aria-live

Following are already present:
HTML Tag input type in date and time state
ARIA state/property: aria-checked

Other changes incorporated in this CL:
1. There should be no STATE_SYSTEM_READONLY for ARIA role dialog.
2. ARIA role radiogroup is exposed correctly.

BUG=170578

Review URL: https://codereview.chromium.org/674873004

Cr-Commit-Position: refs/heads/master@{#301573}

With DestroyOnSequence, a Surface can live long after its SurfaceFactory dies, so every use of the SurfaceFactory needs to check whether it still exists.

Review URL: https://codereview.chromium.org/683623003

Cr-Commit-Position: refs/heads/master@{#301572}

Drawing in this case isn't productive and can cause DCHECKs to be hit.

Review URL: https://codereview.chromium.org/677983006

Cr-Commit-Position: refs/heads/master@{#301571}

BindToClient should return false so the compositor doesn't attempt to use the context.

Review URL: https://codereview.chromium.org/682963002

Cr-Commit-Position: refs/heads/master@{#301570}

BUG=None
TBR=dimich@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/683753002

Cr-Commit-Position: refs/heads/master@{#301569}

BUG=None
TBR=oshima@chromium.org, ygorshenin@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/683763002

Cr-Commit-Position: refs/heads/master@{#301568}

This adds several performance tests for Web Animations initiated in
various ways.

BUG=421733

Review URL: https://codereview.chromium.org/665893005

Cr-Commit-Position: refs/heads/master@{#301567}

The Continue Dialog (along with a few other dialogs) in Remote Assistance references
localized strings defined in rmeoting_strings.grd.  To make Remote Assistance work
on Chrome OS, we need to get those resources into Chrome.

This CL
1. Modifies repack_locales.py to merge the generated strings from remoting_strings.grd
into the merged resource packs (e.g. merge remoting/resource/en.pak -> en-US.pak).
2. Chrome currently supports more languages than remoting.  This CL adds the missing
languages into remoting_strings.grd.  This is required to avoid compilation failures.
The list of added locales are based-on on referencing other chrome grd files (e.g.
generated_resources.grd).
3. remoting_strings.grds currently uses an overlapping resource ID range with chrome.
To avoid conflicts, this CL reserves ids [29550-30000) for strings in remoting
(see the changes in remoting/resources/resource_ids and tools/gritsettings/resource_ids).

Review URL: https://codereview.chromium.org/682863002

Cr-Commit-Position: refs/heads/master@{#301566}

This patchset only separates the header definition for ime_keyboard_x11 to .h file. After that, I will create ime_keybord_ozone.h also.  So the file structure will be:

ime_keyboard.h
fake_ime_keyboard.h
fake_ime_keyboard.cc
ime_keyboard_x11.h
ime_keyboard_x11.cc
ime_keyboard_ozone.h
ime_keyboard_ozone.cc

BUG=342336

Review URL: https://codereview.chromium.org/666693010

Cr-Commit-Position: refs/heads/master@{#301565}

ContextMenuDelegate talks in RVCMBase. This is fine for
ContextMenuDelegate::BuildMenu, but while showing it through
ContextMenuDelegate::ShowMenu, each platform downcasts the
RVCMBase to its own variant (RVCMViews, RVCMMac, RVCMImpl),
this seems unnecessary since the showing functionality can be
moved to RVContextMenuBase.
This CL does that and adds a virtual Show() function on
RVCMBase.

BUG=397364
Test=No visible change should occur.
For reference, this CL is related to brining up right-click context menus
in chrome.

Review URL: https://codereview.chromium.org/678653003

Cr-Commit-Position: refs/heads/master@{#301564}

Use of aura::Env::AddPreTargetHandler won't compile on Mac, so we hide it
behind an interface and add a Mac implementation.

BUG=425229

Review URL: https://codereview.chromium.org/678823002

Cr-Commit-Position: refs/heads/master@{#301563}

Allow decltype.
Disallow long long, uniform initialization, raw string literals.

BUG=427584
NOTRY=true

Review URL: https://codereview.chromium.org/685663002

Cr-Commit-Position: refs/heads/master@{#301562}

This can be built by GN or from the mojo repo (by GN)

R=ben@chromium.org
TBR=deleting a dead target, sky@chromium.org for testing/buildbot/chromium_trybot.json change

Review URL: https://codereview.chromium.org/685533002

Cr-Commit-Position: refs/heads/master@{#301561}

BUG=427447

Review URL: https://codereview.chromium.org/683463002

Cr-Commit-Position: refs/heads/master@{#301560}

This ability was added for Android WebView to limit the number of
gralloc buffers, which has a low limit on the number of allocations.
Android WebView no longer uses gralloc buffers, so no need to keep this
ability.

Use memory limit to limit the staging resource pool for 1-copy
rasterizer.

BUG=426548

Review URL: https://codereview.chromium.org/643993005

Cr-Commit-Position: refs/heads/master@{#301559}

Modify json_output_formatter to include trace values in the result output.

This is a partial land of Ethan's patch in https://codereview.chromium.org/545523002/.

BUG=

Review URL: https://codereview.chromium.org/663023005

Cr-Commit-Position: refs/heads/master@{#301558}