GitLab

This reverts r403440 (commit c825d655),
as it caused a security regression.

BUG=626790
TBR=shanmuga.m@samsung.com

Review-Url: https://codereview.chromium.org/2147003002
Cr-Commit-Position: refs/heads/master@{#405264}

Now that cpplint.py doesn't trigger a false positive with
base::hash_map, we don't need the NOLINT tag anymore.

BUG=627202
TEST=git cl lint  # clean output

Review-Url: https://codereview.chromium.org/2146833003
Cr-Commit-Position: refs/heads/master@{#405263}

Implements migration of a QUIC connection to a different destination address if specified by the server in an ASAD tag in the Server Hello. Quietly falls back to original socket if creation and connecting a new socket fails.

R=rch@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2124753005
Cr-Commit-Position: refs/heads/master@{#405262}

Use the cursor theme that GTK tells us is the default,
instead of always using the default white cursor theme.

BUG=377525

Review-Url: https://codereview.chromium.org/2135353002
Cr-Commit-Position: refs/heads/master@{#405261}

All clients have transitioned to using the respective devil modules
directly, so these are no longer needed.

BUG=617761

Review-Url: https://codereview.chromium.org/2139133004
Cr-Commit-Position: refs/heads/master@{#405260}

Cleaning up auto-play-in-sandbox* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Review-Url: https://codereview.chromium.org/2146923002
Cr-Commit-Position: refs/heads/master@{#405259}

Make the empahsized "https:" scheme text match the connection state indicator
icon color. (In the new design, the color changed.) Also, per the new design,
don't emphasize (color) the scheme for Incognito or theme colors.

BUG=626646
TBR=tedchoc

Review-Url: https://codereview.chromium.org/2144443002
Cr-Commit-Position: refs/heads/master@{#405258}

Previously GN iterated through the deps and added the all_dependent followed by the public configs for each target.

But the ordering is documented to be all of the all_dependent_configs, followed by all of the public_configs. This patch brings the ordering in line with the documentation and adds a test.

BUG=474000

Review-Url: https://codereview.chromium.org/2140363002
Cr-Commit-Position: refs/heads/master@{#405257}

This fixes the deqp/data/gles3/shaders/linkage.html tests that were
checking that compilation fail if interface blocks have different
layouts.

BUG=621031
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2147663002
Cr-Commit-Position: refs/heads/master@{#405256}

... originally removed by https://codereview.chromium.org/1514483002

BUG=627875

Review-Url: https://codereview.chromium.org/2150653002
Cr-Commit-Position: refs/heads/master@{#405255}

Changes MojoBootstrap - the implementation of master endpoints for
IPC::ChannelMojo - to use custom message routing logic in lieu of
the Mojo public Binding and InterfacePtr primitives and the underlying
MultiplexRouter implementation.

This is part a series of CLs to support Channel-associated interfaces.

BUG=612500

Review-Url: https://codereview.chromium.org/2136193003
Cr-Commit-Position: refs/heads/master@{#405254}

It is necessary to restore the keyboard/touchscreen devices at the end
of the tests, so that subsequent tests are not affected.

BUG=545533

Review-Url: https://codereview.chromium.org/2151603002
Cr-Commit-Position: refs/heads/master@{#405253}

Minor change to ensure that paper-toggle-button is actionable.
Also removes an unnecessary paper-toggle-button include.

BUG=none
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2152503002
Cr-Commit-Position: refs/heads/master@{#405252}

When adding a new child to a ViewAndroid, it tries to remove the child
from the parent of the View to which the child is being added rather
than removing it from its existing parent. Fix that.

Review-Url: https://codereview.chromium.org/2147853002
Cr-Commit-Position: refs/heads/master@{#405251}

This patch removes the code which sets the application title from the launcher, since now the title is set from Android-side and we don't need to set it in Chrome-side.

BUG=621166

Review-Url: https://codereview.chromium.org/2113633002
Cr-Commit-Position: refs/heads/master@{#405250}

Currently, the user can unlock their device using one of three methods:
  - their password,
  - a PIN or password,
  - no authentication.

The setup pin screen is in a dependent CL.

The choose-method screen is available from the /quickUnlock/chooseMethod
endpoint.

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2097673002
Cr-Commit-Position: refs/heads/master@{#405249}

BUG=627578
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2141063003
Cr-Commit-Position: refs/heads/master@{#405248}

Mostly removing unneeded methods, reworked mute console.

BUG=none

Review-Url: https://codereview.chromium.org/2139363003
Cr-Commit-Position: refs/heads/master@{#405247}

Now that the shards are more evenly distributed, this is feasible.
Increase the number of shards to handle the additional ~15 minutes of
run time.

BUG=586033
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2133673003
Cr-Commit-Position: refs/heads/master@{#405246}

no_pch and disable_precompiled_headers do the same thing; drop one of them.

No behavior change.

BUG=none

Review-Url: https://codereview.chromium.org/2148953002
Cr-Commit-Position: refs/heads/master@{#405245}

Clean up compositor_model_bench code.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2145543002
Cr-Commit-Position: refs/heads/master@{#405244}

Got reverted due to breaking
WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.MANUAL_TestAcquiringAndReacquiringWebcam/0
in some WebRtc Mac bot, possibly because it has no real WebCam
or it has one without  AVCaptureStillImageOutputClass support.

This CL adds a guard  [captureSession_ canAddOutput:...]
before [captureSession_ addOutput:...]

Original description ----------------------------------------------
ImageCapture: Implement takePhoto() for Mac AVFoundation

By pulling the necessary symbols out of AVFoundation
and using them; most notably (Cr)AVCaptureStillImageOutput.

TakePhoto is already implemented for Android (both APIs).

Also adding VideoCaptureDeviceTest::MAYBE_TakePhoto
test case, enabled only for Mac.

BUG=518807
TEST=Run build with flag --enable-blink-features=ImageCapture,
navigate to [1] and push buttons
- Open Camera ...
- Create ImageCapturer
- takePhoto()  (N times!) --> profit

[1] https://rawgit.com/Miguelao/demos/master/imagecapture.html

TBR=rsesek@chromium.org since the change is trivial.

Review-Url: https://codereview.chromium.org/2146973002
Cr-Commit-Position: refs/heads/master@{#405243}

When file loading is finished ResourceMultiBufferDataProvider count
DataBuffer queue size twice, so GetSize returned incorrect value.

BUG=625515, 627525, 624853

patch from issue 2110853006 at patchset 1 (http://crrev.com/2110853006#ps1)

Review-Url: https://codereview.chromium.org/2133803004
Cr-Commit-Position: refs/heads/master@{#405242}

StopReason is passed to following observer methods:
- ArcBridgeBootstrap::Observer::OnStopped
- ArcBridgeService::Observer::OnBridgeStopped

Those callbacks can now tell the reason the bridge stopped.

I am planning to use this soon to show notifications on failures.
See the bug entry for more details.

BUG=chromium:625923
TEST=components_unittests --gtest_filter=ArcBridgeTest.*
TEST=Manually verified that ARC boots.

Review-Url: https://codereview.chromium.org/2133653002
Cr-Commit-Position: refs/heads/master@{#405241}

Revert of Enable PassiveDocumentEventListeners on waterfall. (patchset #2 id:20001 of https://codereview.chromium.org/2119403002/ )

Reason for revert:
Revert this for now. We are seeing cc:scheduler changes as a result of this and we need to understand them better and I'm not going to be in the office the next two days.

Original issue's description:
> Enable PassiveDocumentEventListeners on waterfall.
>
> Enable passive document event listeners finch experimentl on waterfall.
>
> BUG=625675
> R=rkaplow@chromium.org
>
> Committed: https://crrev.com/19233086ad7e2363e7e1d14582dc6a5428816169
> Cr-Commit-Position: refs/heads/master@{#404351}

TBR=rkaplow@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=625675

Review-Url: https://codereview.chromium.org/2149673002
Cr-Commit-Position: refs/heads/master@{#405240}

This reverts commit 198e264e.

The root cause of the crash has been fixed and we don't need this patch now.

BUG=625357
TBR=warx@chromium.org

Review-Url: https://codereview.chromium.org/2151613002
Cr-Commit-Position: refs/heads/master@{#405239}

This protocol allows the wayland server to notify the client of
connected gamepads and their state.
The protocol does not support axis mapping but assumes the use of the
'Standard Gamepad' as defined by the W3C gamepad API.

BUG=620977

Review-Url: https://codereview.chromium.org/2093803002
Cr-Commit-Position: refs/heads/master@{#405238}

Removes support for the old field-at-a-time autofill on iOS. Full-form
has been enabled for all iOS users for many months.

Corresponding internal change:
https://chromereviews.googleplex.com/470777015

BUG=504644,268279

Review-Url: https://codereview.chromium.org/2146523004
Cr-Commit-Position: refs/heads/master@{#405237}

BUG=none

Review-Url: https://codereview.chromium.org/2145873002
Cr-Commit-Position: refs/heads/master@{#405236}

BUG=610376

Review-Url: https://codereview.chromium.org/2130623002
Cr-Commit-Position: refs/heads/master@{#405235}

This CL does some minor changes to web_js_test.h based on eugenebut's
recommendations in https://codereview.chromium.org/2150513002/#msg21.

R=eugenebut@chromium.org
BUG=627775

Review-Url: https://codereview.chromium.org/2148723003
Cr-Commit-Position: refs/heads/master@{#405234}

Remove the last use case of texture-backed SkBitmaps in Chroimum.

Review-Url: https://codereview.chromium.org/2143183004
Cr-Commit-Position: refs/heads/master@{#405233}

 - Force render parts of the page that should be searched but
   are currently not rendered.
 - Ensuring that searching code yields often enough to the main
   thread to prevent UI freeze.

Specifically
 - Adding three types of tasks TopLevelSearchTask, SearchTask and
   RenderTask.
 - Adding a task manager class, which yields before executing a
   task by using window.requestIdleCallback().
 - Canceling obsolete tasks (happens when a new search is issued after the
   task was posted but before it made it to the front of the queue).

BUG=608535
TEST=Navigate to chrome://md-settings. Search for a term that exists in
an unrendered sub-page, for example "engine". Navigate to the subpage by
clicking "Manage search engines". Notice that matches are magically
highlighted even though this subpage was not rendered when the search was
initiated.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2103133007
Cr-Commit-Position: refs/heads/master@{#405232}

ash::PlaySystemSound* methods are used only from chrome. The code in ash
plays sounds through the AccessibilityDelegate interface. So remove these
methods from ash. This has two benefits: (1) ash no longer has dependency
on media, and (2) media::SoundsManager is initialized from chrome. So it
makes sense to move its usage into chrome as well.

BUG=none

Review-Url: https://codereview.chromium.org/2142463002
Cr-Commit-Position: refs/heads/master@{#405231}

Intent: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/kJMa2rpAYqI
Dashboard: https://www.chromestatus.com/feature/6687420359639040

R=foolip@chromium.org
BUG=496901

Review-Url: https://codereview.chromium.org/2023123002
Cr-Commit-Position: refs/heads/master@{#405230}

CronetEngine.createRequest has been deprecated. This
CL changes the test to use the new Builder API.
R=kapishnikov@chromium.org
BUG=547970

Review-Url: https://codereview.chromium.org/2142953002
Cr-Commit-Position: refs/heads/master@{#405229}

This patch updates the code to prevent auto deducing to a raw pointer.

R=nyquist, danakj, dcheng
BUG=554600

Review-Url: https://codereview.chromium.org/2102173003
Cr-Commit-Position: refs/heads/master@{#405228}

This is just code cleanup, IsSigninProfile does the same thing. This affects chromeos only.

BUG=
TBR=skuhne@chromium.org

Review-Url: https://codereview.chromium.org/2149603003
Cr-Commit-Position: refs/heads/master@{#405227}

A few https engagement tests used the test server resource at URL '/'.
It turns out that this resource gets served with mime type text/plain,
which we're planning to have page load metrics infrastructure ignore
in the future. This change switches those tests to use '/simple.html'
which is served with mime type text/html.

Additionally, this change adds a new test
Navigate_Both_NonHtmlMainResource, which we'll use to verify that we do
not track non-HTML resources.  The test currently asserts that we do
track these resources, with a comment explaining that we'll update it
to assert they are untracked as part of fixing bug 627536.

BUG=627536

Review-Url: https://codereview.chromium.org/2148473002
Cr-Commit-Position: refs/heads/master@{#405226}

According to the X11 doc: "The created window is placed on top in
the stacking order with respect to siblings."  Since all windows
that DWTHX11 creates are children of the root window, they are
all siblings, so new windows should instead be added to the front
of the stacking list.

BUG=556048

Review-Url: https://codereview.chromium.org/2148923002
Cr-Commit-Position: refs/heads/master@{#405225}