- 24 Aug, 2018 40 commits
-
-
Sylvain Defresne authored
Passing value by const-reference is unnecessary if the type passed can fit in a register and is copyable. Change method prototype to pass it by value. Bug: none Change-Id: I8fbbd25d79fcc6434ab95678bfc18292290f8694 Reviewed-on: https://chromium-review.googlesource.com/1188223Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#585807}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2a53275c38fb..60e5b43e85ec git log 2a53275c38fb..60e5b43e85ec --date=short --no-merges --format='%ad %ae %s' 2018-08-24 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 221fa26170ae..8ca60805916f (3 commits) Created with: gclient setdep -r src/third_party/skia@60e5b43e85ec The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I7fbb8412a20a9cc7de416c4710238142dd957cf4 Reviewed-on: https://chromium-review.googlesource.com/1188382Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585806}
-
Thomas Tangl authored
The title for the non-personalized services section is changed to "Other Google services". Bug: 872087 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic6953e95fa39a0b0ea5a5d950d15b63955098432 Reviewed-on: https://chromium-review.googlesource.com/1186624Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#585805}
-
Rohit Rao authored
BUG=855320 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4fb596298e417795877400a94fc7d80349c80673 Reviewed-on: https://chromium-review.googlesource.com/1186701Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#585804}
-
Xida Chen authored
Previously in order to prevent a crash, we add some temporary fix in touch_action_filter.cc. With some of the recent committed changes, there should be no more crashing. This CL removes the temporary code for suppressing the crash but keeps DumpWithoutCrashing so that we can get debugging info for the crash. Bug: 851644 Change-Id: I614ae6d20a24b402141563451c51b36d52302d70 Reviewed-on: https://chromium-review.googlesource.com/1185627 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#585803}
-
David Roger authored
Bug: 869938 Change-Id: I74b51073cf85bd167bbe15cef8f410e5c5300d2e Reviewed-on: https://chromium-review.googlesource.com/1184709 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585802}
-
Mike Klein authored
Lots of little tiny diffs from a little tiny gamut change. For https://skia-review.googlesource.com/c/skia/+/148990 Change-Id: Ieb91313059271b3acac97db571427563513fad37 Reviewed-on: https://chromium-review.googlesource.com/1187389Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#585801}
-
Kent Tamura authored
event.h is used in 840+ compilation units, and this CL reduces its pre-processed size by 3.54MB. Bug: 242216 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I85f8e58fbcb96c2056536a68ec4777bfa8521f31 Reviewed-on: https://chromium-review.googlesource.com/1188167Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#585800}
-
Jan Wilken Doerrie authored
This change fixes BluetoothDeviceWinrt::DiscoonectGatt. It does so by working around a quirk in the UWP APIs, that requires dropping all internal references to a given device. See this GitHub issue for further discussion: https://github.com/jasongin/noble-uwp/issues/20 Bug: 821766 Change-Id: I5bf0e4e0ce0e3b43d9cbb10e3b11e378de05e6b3 Reviewed-on: https://chromium-review.googlesource.com/1183234Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#585799}
-
Arthur Hemery authored
Following the direct passing of navigation timings information to the loader: https://chromium-review.googlesource.com/c/chromium/src/+/1127034, we move the remaining loading data down the same path and group them in a new unified structure. Background: Currently, we setup the DocumentLoader with browser provided loading data during the DidCreateDocumentLoader callback. This is modified in this patch, and relevant loading information is provided directly to the DocumentLoader at creation time. This reduces the reliance on the DidCreateDocumentLoader callback and further enables a complete removal of the PendingNavigationParams used to store browser provided informations while waiting for the callback. We do not include these informations in extra_data, to keep a clear separation between information relevant to the loader (ExternalLoadingData) and information that will eventually be stored by the FrameLoader and decoupled from the DocumentLoader (ExtraData). Bug: 789577 Change-Id: I4306c079a80260386547d4fb85ff8f398c811cc4 Reviewed-on: https://chromium-review.googlesource.com/1127783 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#585798}
-
Peter E Conn authored
Bug: 871266 Change-Id: Idb5ad9a435f8696eb5bb5f97de24ce05fbba5469 Reviewed-on: https://chromium-review.googlesource.com/1185007Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#585797}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 03168d86. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23218 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: If8345598e240e21411a867bc432e0df20c00ab80 Reviewed-on: https://chromium-review.googlesource.com/1188084 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#585796}
-
Ramin Halavati authored
Several profile and policy controlled preferences are removed from the persistent storage list for incognito mode. As these preferences are not written from inside an incognito window, the CL is not expected to make any behavioral change and is just cleanup. Bug: 861722 Change-Id: I28ec6eb98241656fe81bbbf81fbad0bc73eddc53 Reviewed-on: https://chromium-review.googlesource.com/1188123Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#585795}
-
Ben L. Titzer authored
This the Chromium side of adding usage counter for WASM language features. It depends on https://chromium-review.googlesource.com/c/v8/v8/+/1186721 R=ahaas@chromium.org, rmcilroy@chromium.org Bug: chromium:868844 Change-Id: I3e8ed00300a77e7d1f5a44a4ff30ad555051ca21 Reviewed-on: https://chromium-review.googlesource.com/1186726 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#585794}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/199b69092bef..12949bd7d3d6 git log 199b69092bef..12949bd7d3d6 --date=short --no-merges --format='%ad %ae %s' 2018-08-24 treehugger-gerrit@google.com Merge "Only start data sources on registration if the tracing session is enabled" 2018-08-24 primiano@google.com Merge "Update guard to use PERFETTO_BUILDFLAG" Created with: gclient setdep -r src/third_party/perfetto@12949bd7d3d6 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I7bfbac3f639655ef6b899d5cdc3f01d8ada70045 Reviewed-on: https://chromium-review.googlesource.com/1188362Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585793}
-
Giovanni Ortuño Urquidi authored
WebAppPolicyManager allows admins to not specify a launch container. When this is the case the installed app should launch in the default container: windows for PWAs and tabs for non-PWAs. Adds a new enum value to PendingAppManager::LaunchContainer to indicate that the default launch container should be used and changes WebAppPolicyManager to set that value when appropriate. Bug: 877398 Change-Id: I4c99d3b53bc7c29a50c6961da78d046bc7ef7819 Reviewed-on: https://chromium-review.googlesource.com/1188203 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#585792}
-
Tanja Gornak authored
The InsatnceId token can become invalid. This CL re-requests the token once a day and notifies the listener (FCMSyncInvalidationLIstener) in case token has become invalid. This CL only passes new token to the appropriate listener, but doesn't act on the change. Bug: 801985 Change-Id: I004983225e22326c6e06cc3b97098d7784d07754 Reviewed-on: https://chromium-review.googlesource.com/1166967 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#585791}
-
Giovanni Ortuño Urquidi authored
Changed BookmarkAppInstallationTask to set forced_launch_type on the BookmarkAppHelper used to install the app. Also adds set_forced_launch_type() to BookmarkAppHelper. When called, BookmarkAppHelper will ignore the default launch type (window for PWAs, tabs for non-PWAs) and also the user set launch type if any. Bug: 876169 Change-Id: I077570c35c00d3581b404daab7e054615ee7fc2a Reviewed-on: https://chromium-review.googlesource.com/1188176 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Ioana Pandele authored
This allows the TextView to expand beyond 48dp if the text needs to be displayed on multiple lines. Bug: 874257 Change-Id: I39a8bbd70bebf8421968e987b3df37ccc9684296 Reviewed-on: https://chromium-review.googlesource.com/1187147Reviewed-by:
-
Giovanni Ortuño Urquidi authored
WebAppPolicyManager would like to skip shortcut creation because there is a separate policy to create them. So we add that option to AppInfo and plumb it all the way down to BookmarkAppHelper Bug: 876175 Change-Id: I09f460efe7c3809856bde77ebe4570de6ae8845e Reviewed-on: https://chromium-review.googlesource.com/1186220 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Pavol Marko authored
Bug: none Change-Id: Iee909eb8c049aa69cb94d41b9170be0dc0272983 Reviewed-on: https://chromium-review.googlesource.com/1115223 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#585787}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b44922e7..8f582e98 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib6f6fc9d34bf7a057a52fce6e7d38602e0a99148 Reviewed-on: https://chromium-review.googlesource.com/1188032Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585786}
-
Giovanni Ortuño Urquidi authored
Changes TestBookmarkAppInstallationTask in pending_bookmark_app_manager_unittest.cc to notify the test that Install is called. Then the test saves a copy of the used AppInfo to compare to the app info originally passed to PendingAppManager. This helps make sure AppInfo is correctly plumbed from PendingAppManager up until BookmarkAppInstallationTask which will use it to install the app. Bug: 876173 Change-Id: Iac87fc6e941f1da239717b306f1be44b18704320 Reviewed-on: https://chromium-review.googlesource.com/1186213 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
Some actions (currently "New Incognito Tab" and "Recent Tabs") open as page in the current tab. Keyboards would be implicitly dismissed by Android but an open Accessory closes only when the page changes. This causes the activity to update its bounds too late and leave a patch on the newly renderd page. Therefore, this CL causes all accessory elements to be dismissed once any action is selected. Bug: 877029 Change-Id: I92a3174c7c7ffcb7e94e3b39b3a26b0eb7a4f1f3 Reviewed-on: https://chromium-review.googlesource.com/1188303Reviewed-by:
-
Hayato Ito authored
BUG=877361 TBR=bokan@chromium.org Change-Id: Id1bd59c7e430c0c65eeab1a4a9b25d39aa0de9ef Reviewed-on: https://chromium-review.googlesource.com/1188008Reviewed-by:
-
Robert Liao authored
This reverts commit 934c869c. Reason for revert: The Light variant will no longer be used in the Start Menu tile. Original change's description: > Include/use light variants of the Start Menu tile in the installer. > > BUG=722573 > > Change-Id: I117497dd31d6270e2284ee54c59a142d620128ab > Reviewed-on: https://chromium-review.googlesource.com/1016241 > Commit-Queue: Greg Thompson <grt@chromium.org> > Reviewed-by: Scott Graham <scottmg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551856} TBR=scottmg@chromium.org,grt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 722573 Change-Id: I57d96212235b86298ed06558074d0c6985d66ea8 Reviewed-on: https://chromium-review.googlesource.com/1187782Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#585782}
-
Hayato Ito authored
This reverts commit 42ad79bb. Reason for revert: [chromium sheriff] A culprit of test failures: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28724 single_process_mash_browser_tests Run on OS: 'Ubuntu-14.04' Max shard duration: 0:03:53.214620 (shard #3) Min shard duration: 0:01:18.857780 (shard #0) failures: LoginPromptBrowserTest.LoginPromptForXHRWithoutCredentialsCancelled LoginPromptBrowserTest.TestTwoAuths LoginPromptBrowserTest.ShowCorrectUrlForCrossOriginMainFrameRedirects LoginPromptBrowserTest.CancelRedundantAuths LoginPromptBrowserTest.CancelLoginInterstitialOnRedirect LoginPromptBrowserTest.ShouldReplaceExistingInterstitialWhenNavigated LoginUtilsTest.MashLogin LoginPromptBrowserTest.IncorrectConfirmation LoginPromptBrowserTest.TestBasicAuth LoginPromptBrowserTest.TestCancelAuth_Manual LoginPromptBrowserTest.NoLoginPromptForXHRWithBadCredentials LoginPromptBrowserTest.SupplyRedundantAuths LoginPromptBrowserTest.SupplyRedundantAuthsMultiProfile LoginPromptBrowserTest.LoginPromptForXHRWithoutCredentials LoginPromptBrowserTest.TestDigestAuth LoginPromptBrowserTest.AllowCrossdomainPromptForSubframes LoginPromptBrowserTest.ShouldNotProceedExistingInterstitial LoginPromptBrowserTest.TestCancelAuth_OnBack LoginPromptBrowserTest.TestCancelAuth_OnForward LoginPromptBrowserTest.BlockCrossdomainPromptForSubresources LoginPromptBrowserTest.TestCancelAuth_OnNavigation LoginPromptBrowserTest.ShowCorrectUrlForCrossOriginMainFrameRequests Original change's description: > Add tests for single process mash > > Moves plain Mash tests to FYI waterfall, while retaining a login test on the > main waterfall as a sanity check. > > Bug: 874090 > Change-Id: I86c60344610c2a4f99b35f9116c5366771a16c64 > Reviewed-on: https://chromium-review.googlesource.com/1175222 > Commit-Queue: Ryan Cui <rcui@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585665} TBR=jamescook@chromium.org,sky@chromium.org,rcui@chromium.org Change-Id: Ib9b9258b47e766d43ac7f3dc6b3c65aacf1230f4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874090 Reviewed-on: https://chromium-review.googlesource.com/1188165Reviewed-by:
-
Thomas Tangl authored
Screenshot before: https://drive.google.com/file/d/1docQTG83IMfNalyaJn8VOZ_bWIbMFq0J/view?usp=sharing Screenshot after: https://drive.google.com/file/d/1u6gCMPVEqsLy9fkuxhqGlrqpBYQzSmj_/view?usp=sharing Bug: 861649 Change-Id: Iecef069e5fe5007711c0b8b7191e9c3534c367f6 Reviewed-on: https://chromium-review.googlesource.com/1186723 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
-
Olivier Robin authored
Also clear frames on navigation as it is needed for the DCHECK to pass. Bug: 851636 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia154d52a338018b83967199ced25f9987d65242a Reviewed-on: https://chromium-review.googlesource.com/1184720 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#585779}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/de2476bcaacf..199b69092bef git log de2476bcaacf..199b69092bef --date=short --no-merges --format='%ad %ae %s' 2018-08-23 hjd@google.com traced_probes: Push cpu first in FtraceEventBundle Created with: gclient setdep -r src/third_party/perfetto@199b69092bef The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:113091178 TBR=perfetto-bugs@google.com Change-Id: Idb61e06fdac0514a4e41a23f3c03ac6afbdf3afa Reviewed-on: https://chromium-review.googlesource.com/1188103Reviewed-by:
-
Kouhei Ueno authored
and remove obsolete comments. Bug: 803774 Change-Id: Ifa7c7c287fa11f312d62a3f9b18e79be7f47c572 Reviewed-on: https://chromium-review.googlesource.com/1187858Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#585777}
-
Mirko Bonadei authored
Bug: webrtc:9453 Change-Id: Ibdf5ca427ba85d0d5f5a8890b50a9c1d0b502a2c No-Try: True Reviewed-on: https://chromium-review.googlesource.com/1188134 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#585776}
-
Jérôme Lebel authored
Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I31063198861ed9431a65aba872c688ef9a8ac58d Reviewed-on: https://chromium-review.googlesource.com/1186738Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#585775}
-
JunHo Seo authored
This reverts commit cf158e84. Reason for revert: A converted test snav-media-elements.html becomes flaky Original change's description: > Snav: Convert some legacy js-tests to testharness - 2 > > Convert list: > snav-display-contents-crash > snav-div-in-anchor > snav-fully-aligned-horizontally > snav-fully-aligned-vertically > snav-hidden-focusable-element > snav-imagemap-area-not-focusable > snav-imagemap-area-without-image > snav-imagemap-overlapped-areas > snav-imagemap-simple > snav-media-elements > > Bug: 803086 > > Change-Id: Iebe20bba5868fec1e1c38f2a188346432c42d568 > Reviewed-on: https://chromium-review.googlesource.com/1184945 > Reviewed-by: Hugo Holgersson <hugoh@vewd.com> > Commit-Queue: JunHo Seo <junho0924.seo@lge.com> > Cr-Commit-Position: refs/heads/master@{#585694} TBR=kochi@chromium.org,szager@chromium.org,junho0924.seo@lge.com,hugoh@vewd.com Change-Id: Id2448339f31a707ed9f6c769cd71dec0d500d11c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 803086 Reviewed-on: https://chromium-review.googlesource.com/1188262Reviewed-by:
Hugo Holgersson <hugoh@vewd.com> Commit-Queue: JunHo Seo <junho0924.seo@lge.com> Cr-Commit-Position: refs/heads/master@{#585774}
-
Kamila authored
In Guest mode, Site Settings link found in the Page info bubble, leads to chrome://settings/, not to the site content settings, as the content settings are not visible. Changes: -Removed the Site Settings button from guest mode. Note: Enabling just the Site Settings would require a complicated refactoring of privacy section. Bug: 823703 Change-Id: Ie3f6ecb3c7b11eeb7652808eefb8608222525830 Reviewed-on: https://chromium-review.googlesource.com/1185097 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
-
Hayato Ito authored
BUG=877104 TBR=yosin@chromium.org Change-Id: Id80de4171d13f32333d3ce93b330cf308a3c561a Reviewed-on: https://chromium-review.googlesource.com/1188059Reviewed-by:
-
Matt Falkenhagen authored
context_ may be null. It's not easy to cleanly abort in this case since the function returns a value. Since context_ is just used for some bookkeeping, just skip that when it's null. Bug: 877350 Change-Id: I696d08999fe6aa861be206381a4c162e3faa4758 Reviewed-on: https://chromium-review.googlesource.com/1188002Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#585771}
-
Kunihiko Sakamoto authored
and add a link to the mime-type definition. Bug: 874752,876968 Change-Id: I63be125a714e716fa83becc23e812db453fa1a9d Reviewed-on: https://chromium-review.googlesource.com/1188163Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
In WorkerThread::PerformShutdownOnWorkerThread(), DidTerminateWorkerThread() may induce the main thread to destroy the instance of WorkerThread, so accessing |this| after the function call is dangerous. This CL avoids it. Bug: 853520 Change-Id: If0b57ceb05fce97fa4d28d7ca9defb76e39d1c27 Reviewed-on: https://chromium-review.googlesource.com/1183005Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#585769}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cdcf168c. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23217 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I5ddd65d21249999e5a3a7f6155762cb72e3d71eb Reviewed-on: https://chromium-review.googlesource.com/1188034 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
