GitLab

Sheriffs: if WebRtcBrowserTest.CanSetupVideoCallAndDisableLocalVideo
flakes, revert this patch. It shouldn't flake after this fix.

Instead of looking at color values of individual pixels, see if we can
get more reliable results by looking at luma values instead. This way
we can detect black frames more reliably in the tests.

This is a partial re-land of codereview.chromium.org/1108803002.

This is essentially the black frame algorithm used in testrtc.

BUG=477498

Review URL: https://codereview.chromium.org/1132333006

Cr-Commit-Position: refs/heads/master@{#330539}

Review URL: https://codereview.chromium.org/1144713003

Cr-Commit-Position: refs/heads/master@{#330538}

These will be used in an upcoming CL implementing the iOS version of the card unmask prompt view.

BUG=484806

Review URL: https://codereview.chromium.org/1138653003

Cr-Commit-Position: refs/heads/master@{#330537}

In addition to simplifying the code, ScopedObserver ensures that the object is unregistered as an observer if and only if it has been registered.

BUG=488642

Review URL: https://codereview.chromium.org/1123283011

Cr-Commit-Position: refs/heads/master@{#330536}

TEST=Tested manually.
BUG=474146

Review URL: https://codereview.chromium.org/1149443002

Cr-Commit-Position: refs/heads/master@{#330535}

On a hotplug event we configure the displays regardless of the state.
However if we're in software mirror mode the configuration was skipped
if the previous configuration was extended mode.

We want to have a consistent approach to display configuration, so make
sure we configure the displays if the configuration was triggered by a
system event. Otherwise (if the configuration was requested by the user)
we'll just skip the configuration so we don't perform unnecessary
modesets.

BUG=488736

Review URL: https://codereview.chromium.org/1133743005

Cr-Commit-Position: refs/heads/master@{#330534}

Rather than converting everywhere from ScrollOffset to Vector2dF,
instead just store the scroll offset directly.

R=ajuma@chromium.org,vollick@chromium.org

Review URL: https://codereview.chromium.org/1142853003

Cr-Commit-Position: refs/heads/master@{#330533}

BUG=488666

Add spoken feedback but no visible text to button that leads to "Add supervised user"

Review URL: https://codereview.chromium.org/1125373004

Cr-Commit-Position: refs/heads/master@{#330532}

BUG=476410

Review URL: https://codereview.chromium.org/1126543009

Cr-Commit-Position: refs/heads/master@{#330531}

This component previously had no OWNERS file.

It makes sense to populate OWNERS from this component's counterpart in chrome/, i.e. chrome/browser/renderer_context_menu/OWNERS.

Review URL: https://codereview.chromium.org/1148543004

Cr-Commit-Position: refs/heads/master@{#330530}

See https://chromereviews.googleplex.com/193957013/ for the associated downstream changes.

BUG=484806

Review URL: https://codereview.chromium.org/1137403002

Cr-Commit-Position: refs/heads/master@{#330529}

In r237368, Clang started warning about mismatched operator new[] and delete
calls. This pacifies the warning by moving the operator new-call to a separate
function.

BUG=none

Review URL: https://codereview.chromium.org/1131513006

Cr-Commit-Position: refs/heads/master@{#330528}

This code is not used anymore.

BUG=486158

Review URL: https://codereview.chromium.org/1147773002

Cr-Commit-Position: refs/heads/master@{#330527}

They are not needed since Chromium has been moved to Git and no relpath needs to
be computed anymore.

R=akuegel@chromium.org
BUG=471767

Review URL: https://codereview.chromium.org/1141383003

Cr-Commit-Position: refs/heads/master@{#330526}

Now that change https://codereview.chromium.org/1137483003/ has landed
fix up change (https://codereview.chromium.org/1131093002/) by removing
the #if 0 and static casts.

This change doesn't provide an implementation of touch-action
because it has previously landed. But it activates
the code paths because now pan-left/pan-right/pan-up/pan-down
are passed transformed correctly between the blink and content
APIs.

BUG=476556
TEST=content_unittests

Review URL: https://codereview.chromium.org/1137153003

Cr-Commit-Position: refs/heads/master@{#330525}

Minimize the amount of differences vs. the PRUNE_PATH in licenses.py

BUG=350472,486158

Review URL: https://codereview.chromium.org/1139903004

Cr-Commit-Position: refs/heads/master@{#330524}

Testing:
- For GN, splits install and crash on start-up just like non-split version
- For GYP, tested with:
  - component=shared_library, component=static_library
  - gyp_managed_install=1, 0
  - load_library_from_zip_file=1, 0

BUG=484797

Review URL: https://codereview.chromium.org/1137313003

Cr-Commit-Position: refs/heads/master@{#330523}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7e8322c..55b88ca

TBR=hiroshige@chromium.org

Review URL: https://codereview.chromium.org/1136193004

Cr-Commit-Position: refs/heads/master@{#330522}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/2e5b4c5..9b4b91f5

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/1133523007

Cr-Commit-Position: refs/heads/master@{#330521}

Revert of content: Use NumberOfProcessors() / 2 raster threads. (patchset #2 id:20001 of https://codereview.chromium.org/1143473002/)

Reason for revert:
Incorrect logic for determining if async uploads is used

Original issue's description:
> content: Use NumberOfProcessors() / 2 raster threads.
>
> 4 raster threads improve performance on 8 core machines.
> 8 core machines might not be a priority but it seems
> like an unnecessary limitation to have.
>
> BUG=
>
> Committed: https://crrev.com/4a0177a1dba8197f61021ff3b4f9426e45faaa62
> Cr-Commit-Position: refs/heads/master@{#330427}

TBR=danakj@chromium.org,enne@chromium.org,piman@chromium.org,vmpstr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1136633006

Cr-Commit-Position: refs/heads/master@{#330520}

Revert of Add support for backgrounding processes on the Mac (patchset #22 id:420001 of https://codereview.chromium.org/989703002/)

Reason for revert:
This CL seems to be the cause of ExtensionApiNewTabTest.Tabs failures on Mac.

Original issue's description:
> Add support for backgrounding processes on the Mac
>
> Added process_mac.cc with implementations of IsProcessBackgrounded() and
> SetProcessBackgrounded().
>
> BUG=460102
>
> Originally Committed: https://crrev.com/e3bb10f7860a1d553c85293bd7d7615c0e7f0fd9
> Reverted: https://crrev.com/ce6226a7ffe2c1cb7ac5f6cf34b56b8d217686b9
>
> Committed: https://crrev.com/0160d130f8a4462fa7bfb8a9924e476d31ba9a48
> Cr-Commit-Position: refs/heads/master@{#330464}

TBR=rsesek@chromium.org,gab@chromium.org,thakis@chromium.org,asvitkine@chromium.org,avi@chromium.org,kbr@chromium.org,shrike@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=460102

Review URL: https://codereview.chromium.org/1142913004

Cr-Commit-Position: refs/heads/master@{#330519}

Sometimes the find in page js returns a text position that is too far down.
Correct all |points| sent to -setContentOffset for overscroll.

BUG=472091

Review URL: https://codereview.chromium.org/1071723002

Cr-Commit-Position: refs/heads/master@{#330518}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/15081cc..7e8322c

TBR=hiroshige@chromium.org

Review URL: https://codereview.chromium.org/1145473007

Cr-Commit-Position: refs/heads/master@{#330517}

and convert existing clients to the public API.

R=reed@google.com
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/1142113002

Cr-Commit-Position: refs/heads/master@{#330516}

BUG=None

Review URL: https://codereview.chromium.org/1128843008

Cr-Commit-Position: refs/heads/master@{#330515}

When we cross-compile, we do not want any /usr/include paths as that will
conflict with our own system headers.  Disable the hardcoded path when we
have an active sysroot.

BUG=chromium:488360

Review URL: https://codereview.chromium.org/1132853010

Cr-Commit-Position: refs/heads/master@{#330514}

Revert of Move content:: scheme registrations from chrome/ to content/. (patchset #1 id:1 of https://codereview.chromium.org/1137103003/)

Reason for revert:
Breaks some layout tests

BUG=489672

Original issue's description:
> Move content:: scheme registrations from chrome/ to content/.
>
> Both 'chrome:' and 'chrome-devtools:' are content-level schemes; we
> should do their various renderer-side scheme registrations in content
> (RenderThreadImpl::RegisterSchemes) rather than in chrome
> (ChromeContentRendererClient::RenderThreadStarted).
>
> R=jochen@chromium.org
>
> Committed: https://crrev.com/dcd7aad11d33ffd6dffe440ce32a0228c0843a67
> Cr-Commit-Position: refs/heads/master@{#330506}

TBR=jochen@chromium.org,philipj@opera.com,sofbjornf@opera.com,mkwst@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1142213002

Cr-Commit-Position: refs/heads/master@{#330513}

BUG=451035

Review URL: https://codereview.chromium.org/1135693008

Cr-Commit-Position: refs/heads/master@{#330512}

R=dconnelly@chromium.org

BUG=486739

Review URL: https://codereview.chromium.org/1142713008

Cr-Commit-Position: refs/heads/master@{#330511}

WebRTC 9205:9217
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/3c9a06a..5deb53c

Libjingle 9198:9216
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/87e6b84..44d6a85

TBR=
BUG=

Review URL: https://codereview.chromium.org/1145783002

Cr-Commit-Position: refs/heads/master@{#330510}

The presubmit is already robust to handle Objective-C .h files. Not
checking .mm files just adds extra review burden. Plus I can't just
press F5 in Sublime to sort lines in .mm files due to import vs include,
so it actually needs some brainpower when adding something and I keep
forgetting to do that.

This adds .mm to the list of file extensions the header sorting
presubmit checks for, and fixes the current mistakes to avoid annoying
people on presubmit with this change.

BUG=None
TBR=keybuk@chromium.org,jamescook@chromium.org,stuartmorgan@chromium.org,xhwang@chromium.org,rsesek@chromium.org,zea@chromium.org
R=thakis@chromium.org,jochen@chromium.org

Review URL: https://codereview.chromium.org/1133713009

Cr-Commit-Position: refs/heads/master@{#330509}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/50b58e6..2e5b4c5

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/1133693005

Cr-Commit-Position: refs/heads/master@{#330508}

A recent update
https://codereview.chromium.org/1022993002
broke the loading of javascript URLs. This patch reverts only the part
of the update which is broken.

BUG=489259

Review URL: https://codereview.chromium.org/1131083004

Cr-Commit-Position: refs/heads/master@{#330507}

Both 'chrome:' and 'chrome-devtools:' are content-level schemes; we
should do their various renderer-side scheme registrations in content
(RenderThreadImpl::RegisterSchemes) rather than in chrome
(ChromeContentRendererClient::RenderThreadStarted).

R=jochen@chromium.org

Review URL: https://codereview.chromium.org/1137103003

Cr-Commit-Position: refs/heads/master@{#330506}

Revert of ServiceWorker: Use SimpleCache for the script cache (patchset #7 id:230001 of https://codereview.chromium.org/1140853002/)

Reason for revert:
We'll reland this CL with DiskCache migration code.

Original issue's description:
> ServiceWorker: Use SimpleCache for the script cache
>
> This CL migrates the backend of ServiceWorkerDiskCache from Default to
> SimpleCache on all platforms.
>
> If old DiskCache images exist,
> (1) DiskCache backend fails to open an pre-existing data due to incompatible
> format (in both Default->SimpleCache and SimpleCache->Default cases),
> (2) ServiceWorkerStorage wipes out all cached scripts and registrations via
> DeleteAndStartOver, and
> (3) navigation falls back to network.
>
> BUG=487482
> TEST=manual (use DiskCache and SimpleCache alternately and make sure the system can recover)
>
> Committed: https://crrev.com/a00e5be5a06e626de1b62cbfc7c350bef08647ea
> Cr-Commit-Position: refs/heads/master@{#330274}

TBR=michaeln@chromium.org
BUG=487482

Review URL: https://codereview.chromium.org/1142193002

Cr-Commit-Position: refs/heads/master@{#330505}

Revert of cc: Aggressively expire retro frames. (patchset #1 id:1 of https://codereview.chromium.org/1055113004/)

Reason for revert:
This seems to be causing DesktopNativeWidgetNoPaintAfterCloseTest failures.

Original issue's description:
> cc: Aggressively expire retro frames.
>
> If we're not aggressive about expiring a retro frame (e.g. MISSED frames)
> then it's possible to enter a high latency mode often.
>
> BUG=469953
>
> Committed: https://crrev.com/bb5a390066a1baf27ec44228fd3ba4173f93cfbf
> Cr-Commit-Position: refs/heads/master@{#330465}

TBR=brianderson@chromium.org,sunnyps@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=469953

Review URL: https://codereview.chromium.org/1135003006

Cr-Commit-Position: refs/heads/master@{#330504}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f421a993..26d7fad7

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1147833002

Cr-Commit-Position: refs/heads/master@{#330503}

Fixes buzzfeed by introducing password_not_auto parameter.

BUG=369521
R=vabr@chromium.org

Review URL: https://codereview.chromium.org/1138353003

Cr-Commit-Position: refs/heads/master@{#330502}

Fix error introduced while adressing comments in
https://codereview.chromium.org/1089383002/

BUG=369521
R=vabr@chromium.org

Review URL: https://codereview.chromium.org/1134843005

Cr-Commit-Position: refs/heads/master@{#330501}

Use a different path for template URL for yandex search on mobile to avoid an
extra redirection. Mobile should use http://yandex.ru/touchsearch?text=${query}
or http://yandex.ru/padsearch?text=${query} depending on the device form factor
instead of http://yandex.ru/yandsearch?text=${query}.

The issue was reported by yandex and fixed in downstream iOS fork. Upstream
it now that the code is componentized.

TEST=Set your locale to Russian, launch Chrome for iOS, select Yandex as the
search engine, type a query in the omnibox to do a search, check that you're
sent to /touchsearch directly, not via /yandsearch first.

BUG=b/7024148

Review URL: https://codereview.chromium.org/1141743003

Cr-Commit-Position: refs/heads/master@{#330500}