GitLab

This reverts commit 919dce44.

BUG=None
TBR=akuegel

Review URL: https://codereview.chromium.org/1094553002

Cr-Commit-Position: refs/heads/master@{#325412}

I am reverting all CLs that could have caused this failure:

http://build.chromium.org/p/chromium.linux/builders/
    Android%20Tests%20%28dbg%29/builds/27276

I will start re-landing vindicated CLs shortly.

Revert "Convert a11y_page.css to a11y_page_style.html. See http://goo.gl/vIGSCO for more information."

This reverts commit eb48d657.

Revert "Supply build properties to run-bisect-perf regression for android bisects."

This reverts commit 9d70bb94.

Revert "[cros New-GAIA] Webview login and new GAIA endpoint enabled by default"

This reverts commit 29061783.

Revert "Prime the landing pad for the new video rendering pipeline."

This reverts commit 45a3c93f.

Revert "Implement separate error dialog for cws widget container"

This reverts commit 7ed1f876.

Revert "Create device_bluetooth watchlist; add scheib."

This reverts commit 40514c99.

Revert "Convert checkbox.css to checkbox_style.html. See http://goo.gl/vIGSCO for more information."

This reverts commit a687f31a.

Revert "Created new URLRequestContext for secure proxy check."

This reverts commit 652eabf1.

Revert "Revert of Fix scroll regression when specifying an extension id. (patchset #4 id:60001 of https://codereview.chromium.org/1064573003/)"

This reverts commit 488846cd.

Revert "Sync: Add Android test for downloading a bookmark"

This reverts commit 9c052713.

Revert "ScreenOrientationController to start observing even without an internal display."

This reverts commit 31fed68a.

Revert "Fix MB configurations for Mac and Win GN bots."

This reverts commit 31a66f3e.

Revert "Add tool/perf/measurements path to check for CQ jobs."

This reverts commit 99e1ac1d.

Revert "Implement Notification.data for persistent notifications."

This reverts commit 539f51d6.

Revert "Fix playback rate calculations for WallClockTimeSource."

This reverts commit 3ec02d64.

Revert "Roll src/third_party/pdfium eddab44:b330016"

This reverts commit 81d51e25.

Revert "cc: Make DisplayItemList::Append replay into an SkPicture"

This reverts commit ec7c07e5.

Revert "Clean up URLFetcher unit tests, part 5."

This reverts commit 8eeb3bf4.

BUG=None
TBR=akuegel

Review URL: https://codereview.chromium.org/1083683003

Cr-Commit-Position: refs/heads/master@{#325411}

This CL does what I should have done long ago -- adding me to the password manager watchlist. Also, adding the +watchlist tag for easier filtering.

R=mkwst@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/1089803002

Cr-Commit-Position: refs/heads/master@{#325410}

This CL updates the window in which SAML IdP pages are shown to match
the new GAIA style:
* The window expands to the size requested in the mocks.
* The header text is updated to match the mocks.
* An "X" button is shown, as requested in the mocks.

The CL updates the windows shown during login and enrollment. Both are
bit-for-bit identical now. See the bug for screen shots.

BUG=467167
TEST=Manual

Review URL: https://codereview.chromium.org/1052103003

Cr-Commit-Position: refs/heads/master@{#325409}

- Exporting of ETW events can be turned on using --trace-export-events-to-etw.

BUG=

Committed: https://crrev.com/1cc86c4f686869f32dfede093a07828c73563892
Cr-Commit-Position: refs/heads/master@{#324982}

Review URL: https://codereview.chromium.org/1038453002

Cr-Commit-Position: refs/heads/master@{#325408}

Ensure geolocation permission is only automatically given to search engines that are accessed over https.

BUG=474476, 467798

Review URL: https://codereview.chromium.org/1089543004

Cr-Commit-Position: refs/heads/master@{#325407}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/6983f66..0b71278

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/1067713004

Cr-Commit-Position: refs/heads/master@{#325406}

Review URL: https://codereview.chromium.org/1086073002

Cr-Commit-Position: refs/heads/master@{#325405}

Direct use of message_center::MessageCenter may cause some problems (eg. crbug.com/469622) because it is not aware of profie.

This patch changes the code to use NotificationUIManager, which is a higher layer wrapper and is aware of profile, instead of message_center::MessageCenter, which is on lower layer and isn't aware of profile.

BUG=469622
TEST=manually tested

Review URL: https://codereview.chromium.org/1005393003

Cr-Commit-Position: refs/heads/master@{#325404}

Review URL: https://codereview.chromium.org/1092583002

Cr-Commit-Position: refs/heads/master@{#325403}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/86a890b..30421b4

TBR=mlamouri@chromium.org,dcheng@chromium.org

Review URL: https://codereview.chromium.org/1092543002

Cr-Commit-Position: refs/heads/master@{#325402}

As part of this CL, the dependency of //components/user_prefs
on //content is removed.

TBR=rlp, estade

Review URL: https://codereview.chromium.org/1062083003

Cr-Commit-Position: refs/heads/master@{#325401}

BUG=37273
TEST=manual test

Review URL: https://codereview.chromium.org/1089683003

Cr-Commit-Position: refs/heads/master@{#325400}

Previously we haven't generated thumbnails if an error had happened to avoid showing (and caching) wrongly rotated thubmanil (crbug.com/463384).
This CL changes to generate thumbnail even an error had happend.
However, IO error is an exception since IO error may not happen in the next try.

BUG=475251
TEST=manually tested.

Review URL: https://codereview.chromium.org/1093433003

Cr-Commit-Position: refs/heads/master@{#325399}

Cr-Commit-Position: refs/heads/master@{#325398}

BUG=469061
TEST=run newly added test

Review URL: https://codereview.chromium.org/1089543005

Cr-Commit-Position: refs/heads/master@{#325397}

BUG=477180
TEST=manual test

Review URL: https://codereview.chromium.org/1088413002

Cr-Commit-Position: refs/heads/master@{#325396}

This method returns a list of installed providing extensions with extra flags
saying whether the extension handles configuring or adding new mount points
via an event.

TEST=Not yet, they will be added in a follow up CL once all is wired up.
BUG=474146

Review URL: https://codereview.chromium.org/1089193002

Cr-Commit-Position: refs/heads/master@{#325395}

BUG=460638

Review URL: https://codereview.chromium.org/1082393003

Cr-Commit-Position: refs/heads/master@{#325394}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/639a828..6983f66

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/1076963003

Cr-Commit-Position: refs/heads/master@{#325393}

This patch contains some style cleanups I found recently.

Review URL: https://codereview.chromium.org/1053203006

Cr-Commit-Position: refs/heads/master@{#325392}

BUG=475994

Review URL: https://codereview.chromium.org/1091603003

Cr-Commit-Position: refs/heads/master@{#325391}

BUG=394135

Review URL: https://codereview.chromium.org/1068123002

Cr-Commit-Position: refs/heads/master@{#325390}

setWindowShape now checks that the window is frameless, which it isn't on Mac.
Ideally, we would tie this check to the frameless state directly, rather than
duplicating the platformIsMac check, but there's no API for that.

BUG=b/20270661

Review URL: https://codereview.chromium.org/1086223003

Cr-Commit-Position: refs/heads/master@{#325389}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/dceaf644..67b98f43

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1088403002

Cr-Commit-Position: refs/heads/master@{#325388}

Code Cleanup for extension_prefs, as AddDisableReasons() is not required same behavior can be achieved by AddDisableReason().

BUG=475911

Review URL: https://codereview.chromium.org/1073153002

Cr-Commit-Position: refs/heads/master@{#325387}

This applies to situations where we are opening a new window or failing
to draw content in time during tab-switch.

Make the RenderWidgetHostViewMac and its layers be transparent, instead
of being the view's background color and white, respectively.

For the RenderWidgetHostViewMac it was in error to set the layer's color
to be the color specified by SetBackgroundColor -- the color specified
by that method will go down to the renderer, and the renderer will
produce frames with the appropriate background color.

The theme color will come from the TabContentsContainerView. Update the
computation of the resulting color to use mostly SkColor operations.

BUG=470669

Review URL: https://codereview.chromium.org/1082143002

Cr-Commit-Position: refs/heads/master@{#325386}

Instead of TestSimpleTaskRunner, which DCHECKs when posting message
from worker thread, use MessageLoop and set a timeout that is
equivalent to CompositorLock's timemout.

BUG=473507
TEST=run w/ --ui-enable-impl-side-painting

Review URL: https://codereview.chromium.org/1081223002

Cr-Commit-Position: refs/heads/master@{#325385}

Review URL: https://codereview.chromium.org/1091683003

Cr-Commit-Position: refs/heads/master@{#325384}

This adds browser tests that verify console message logged when a
promise passed to waitUntil() or respondWith() is rejected.

These tests are here because console outputs from SWs aren't testable
with layout tests (crbug.com/456708).

BUG=359423

Review URL: https://codereview.chromium.org/1081953004

Cr-Commit-Position: refs/heads/master@{#325383}

BUG=431057,442173

Review URL: https://codereview.chromium.org/1008473006

Cr-Commit-Position: refs/heads/master@{#325382}

Please take a look at first part of this review

and also at this conversation

https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/xiuyMB5AiNY

BUG=

Review URL: https://codereview.chromium.org/1087883005

Cr-Commit-Position: refs/heads/master@{#325381}

Currently if the form changes in any way between parsing and form submission
any server overrides for the form will be ignored. Relax the matching to only
take into account name and action for the form and name for the field. This
is similar to how Autofill matches.

BUG=476092

Review URL: https://codereview.chromium.org/1088973003

Cr-Commit-Position: refs/heads/master@{#325380}

According to the newest mocks, the file systems will be managable from Files
app. In order to do that, both of the events are required.

TEST=None.
BUG=474146
R=benwells@chromium.org

Review URL: https://codereview.chromium.org/1088883002

Cr-Commit-Position: refs/heads/master@{#325379}

Add some new owners to make sure it gets some security attention

BUG=none
TBR=cbentzel (already reviewed)

Review URL: https://codereview.chromium.org/1090643003

Cr-Commit-Position: refs/heads/master@{#325378}

TBR=phajdan.jr@chromium.org
BUG=454413

Review URL: https://codereview.chromium.org/1082323004

Cr-Commit-Position: refs/heads/master@{#325377}

If one of the tools/mb files changes, mb analyze may not produce
correct results (since the configs might change), so we should
just build everything.

Also, fix a dangling target for the android_gn trybot.

TBR=phajdan.jr@chromium.org
BUG=454413

Review URL: https://codereview.chromium.org/1092523002

Cr-Commit-Position: refs/heads/master@{#325376}

This flag causes unused argument errors when using LTO (or Clang's integrated
assembler), and is not needed to disable executable stacks, as we are already
passing -Wl,-z,noexecstack at link time, which is how executable stacks are
already getting disabled on other platforms.

BUG=407544
R=thakis@chromium.org
TEST=Built libchromeshell.so with default GYP_DEFINES with and without this change, verified that binaries are equivalent

Review URL: https://codereview.chromium.org/1091463002

Cr-Commit-Position: refs/heads/master@{#325375}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4127337..86a890b

TBR=mlamouri@chromium.org,dcheng@chromium.org

Review URL: https://codereview.chromium.org/1089323002

Cr-Commit-Position: refs/heads/master@{#325374}

This also includes several fixes for the plugin logic on Windows:
- The banned directory check normalizes path separators.
- The banned directory check now returns true for files that are
  considered system headers.
- Diagnostics from the plugin are always reported as warnings.

BUG=467287
R=thakis@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/26ba172e8543b9029f320600f3aeced40028ff20

Committed: https://chromium.googlesource.com/chromium/src/+/5b5d1269ade9eeb50875b20570ef3e0d8c5d95fb

Review URL: https://codereview.chromium.org/1072203002

Cr-Commit-Position: refs/heads/master@{#325373}