- 02 Jan, 2019 40 commits
-
-
Christopher Cameron authored
Add a mojo method to query the sheet's vertical offset. In practice this offset is off of the widget's NSWindow's contentView, so perform the computations to make that adjustment in the app shim process. Bug: 912815 Change-Id: I7c224a87769705cab94606c0bb24ab5f7b5e7d6d Reviewed-on: https://chromium-review.googlesource.com/c/1389962Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#619462}
-
Peter Kasting authored
Bug: none Change-Id: I65e12280b8e9763fb9bead3ae66d9c9767dd8342 Reviewed-on: https://chromium-review.googlesource.com/c/1391418Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#619461}
-
Avi Drissman authored
BUG=916749 Change-Id: Ideb4f53009923138676063e2186332c0b4d147a2 Reviewed-on: https://chromium-review.googlesource.com/c/1393021Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#619460}
-
Avery Musbach authored
If the active window is snapped when the user switches from laptop mode to tablet mode, then split view shall be activated with the active window on the side to which it was snapped. On the other side shall be the previous window if it was snapped to that side, and overview otherwise. Bug: 819798 Change-Id: I22830563e0fea71977cd5b6c0b78f9d4f3a66e71 Reviewed-on: https://chromium-review.googlesource.com/c/1391470 Commit-Queue: Avery Musbach <amusbach@google.com> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#619459}
-
James Cook authored
Instead define an explicit Show() method to start the UI. See bug for details. TBR=sky@chromium.org Bug: 904148 Test: Run chrome --show-taps, see touch point circles Change-Id: I9d718097be9bb685e1e218780489fffce386a622 Reviewed-on: https://chromium-review.googlesource.com/c/1385013Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#619458}
-
Theresa authored
If the tab count has changed since the last toolbar texture capture, force a texture capture the next time #setForceTextureCapture is called. Prior to splitting the tab switcher and browsing mode toolbar views this wasn't necessary because changing the tab count caused an invalidation to propogate to the ViewResourceFrameLayout. After the split, however, the invalidation doesn't get propogated becaused the browsing mode view is invisible while in the tab switcher. BUG=917805 Change-Id: I451767a6d24bf570a60eac22ef1c2d76decf9740 Reviewed-on: https://chromium-review.googlesource.com/c/1391677Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#619457}
-
Paul Miller authored
This study doesn't do anything except exercise permanent-consistency. Query it once to "activate" it, so it shows up in the logs when WebViewLogVerbosifier.apk is installed, so QA can verify permanent-consistency. BUG=866722 Change-Id: I2b2c6812b735a7bd0cee8c116161d2e18c5a27f3 Reviewed-on: https://chromium-review.googlesource.com/c/1389437Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#619456}
-
khmel@chromium.org authored
TEST=Manually BUG=896221 Change-Id: I4be49faac0574372b52a009f912dabeb85ec7283 Reviewed-on: https://chromium-review.googlesource.com/c/1392110Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#619455}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9356393f5b48..279b65ddb5a3 git log 9356393f5b48..279b65ddb5a3 --date=short --no-merges --format='%ad %ae %s' 2019-01-02 halcanary@google.com SkPDF: clean up public header 2019-01-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 0c6672158c77..04ea03e4e1e1 (2 commits) 2019-01-02 kjlubick@google.com Add docker caches in more places Created with: gclient setdep -r src/third_party/skia@279b65ddb5a3 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I37dd481b921970bfa138568370013fb54719e86a Reviewed-on: https://chromium-review.googlesource.com/c/1393345Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619454}
-
Vladimir Levin authored
This patch adds a yielding budget which tries to do as much work as possible within the budget. If the budget expires, it yields between lifecycles. This patch also makes this the default budget, since it's the best behavior currently implemented. See YieldingDisplayLockBudget::GetCurrentBudgetMs() for the time budgets. These were picked arbitrarily, but I think they seem reasonable. R=chrishtr@chromium.org Bug: 907619, 882663 Change-Id: If8b3680df6b52690c238f23a319591dd8e181add Reviewed-on: https://chromium-review.googlesource.com/c/1388159Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619453}
-
Vlad Tsyrklevich authored
This inconsistency appears to have been introduced in error during an update. This constant is not present in the upstream code and is unused. Bug: crashpad:271 Change-Id: Ic1d72fe353da9076b4adf111e855347b04df3f94 Reviewed-on: https://chromium-review.googlesource.com/c/1389161Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#619452}
-
James Cook authored
This allows test-only APIs to be added without SECURITY_OWNERS review. TBR=bartfab@chromium.org Bug: 915912 Test: compiles Change-Id: I9f8fb2e30b15f71aeddc778da571560b0a60d2a9 Reviewed-on: https://chromium-review.googlesource.com/c/1384926Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#619451}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6d2bcf3c2f33..dae815456c77 Created with: gclient setdep -r src-internal@dae815456c77 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3b7473ef942fd522d8ebd18e1ae6b0337614a635 Reviewed-on: https://chromium-review.googlesource.com/c/1393348Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619450}
-
Becca Hughes authored
This updates the media notification to only show action buttons for actions that are supported by the media session. BUG=897836 Change-Id: I0809167fb108e803a44f9e4f5220259555550fe9 Reviewed-on: https://chromium-review.googlesource.com/c/1386646Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#619449}
-
Peter Kasting authored
These pass on Windows. Bug: 11761, 40948, 43070, 43072, 367701, 369169, 733286, 825341 Change-Id: Ic6ebbddbdd306ff09867a1ea2c97cbf701ee526e Reviewed-on: https://chromium-review.googlesource.com/c/1351785Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#619448}
-
Thomas Anderson authored
This reverts commit 8a5a16af. Reason for revert: Suspected cause of breakage on android-rel: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel/6359 Original change's description: > Android: Replace desugar with d8 and r8 for debug > > For release builds, desugar.jar still runs first, before d8 or r8, so > nothing is changing for them as by the time d8 or r8 runs, the code has > already been desugared. > > When r8 is enabled, it can desugar all targets that enable proguard, and > d8 can desugar all targets that do not enable proguard. > > This can only be turned on once r8 replaces proguard since proguard does > not understand java 8 code that has not been desugared already. > > Bug: 906803, 913679, 916733 > Change-Id: I3fcc5a20b38e7fdc78cdeed1533583675d58346b > Reviewed-on: https://chromium-review.googlesource.com/c/1384945 > Reviewed-by: Sam Maier <smaier@chromium.org> > Commit-Queue: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619434} TBR=wnwen@chromium.org,smaier@chromium.org Change-Id: I5591321bd6369f4fb9de3f1519b2c823775c048b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 906803, 913679, 916733 Reviewed-on: https://chromium-review.googlesource.com/c/1393425Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#619447}
-
Theresa authored
BUG=524215 Change-Id: If163f88332e28bf769c4f4c80e6a2a00efc16f39 Reviewed-on: https://chromium-review.googlesource.com/c/1392249Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#619446}
-
Troy Hildebrandt authored
Since the WeakPtrFactory is used on |task_runner_|, we need to also destroy it on |task_runner_| as well. This change wraps the WeakPtrFactory in a unique_ptr and calls DeleteSoon on |task_runner_| with the factory in the destructor. Bug: 918532 Change-Id: I5a5eed43966b81f0cbb28c978c0f50f133b16169 Reviewed-on: https://chromium-review.googlesource.com/c/1392595Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619445}
-
Doug Arnett authored
The PreviewsLitePageDecider implements a 4th type of blacklist just for LitePageRedirect Previews that is populated from a server bypass response. This CL renames a couple methods and a member variable to aid in clarity about the nature of this blacklist to avoid confusion with other blacklists. This CL has no functional changes. Change-Id: I20d721b8926492c984efba82e228a3571f03d8ce Reviewed-on: https://chromium-review.googlesource.com/c/1392591Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#619444}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/abd39667..46d76765 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib3eb7dad37e014bf4fdc8e3b6f4bb6f1a4afbdc2 Reviewed-on: https://chromium-review.googlesource.com/c/1393269Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619443}
-
Manu Cornet authored
Performance improvements, one small step at a time :-) The current tooltip logic has at least two issues that this CL addresses: * When computing the contiguous area over which to show a tooltip continuously, all children of the ShelfView were considered (including overflow items for a non-overflow shelf for instance). * Said contiguous area was recomputed on *every single mouse event* over the shelf, thus performing a O(n) (n = # of shelf items) operation every mouse move. These are cheap but completely gratuitous operations. Note that this CL will not yet by itself fix the linked bug. Bug: 896524 Change-Id: I801bf727232bd588b25dd797fdd20a6a5f675ac3 Reviewed-on: https://chromium-review.googlesource.com/c/1391360Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#619442}
-
Peter Kasting authored
TBR=oshima, dbeam Bug: none Change-Id: Idf7858096414e43b9d067b55627bb6af97839ab1 Reviewed-on: https://chromium-review.googlesource.com/c/1351796Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#619441}
-
Theresa authored
Request an update to the toolbar texture after exiting the tab switcher to ensure a new texture is captured before the user re-enters the tab switcher. This used to be handled in ToolbarPhone#updateVisualsForLocationBarState due to the visual state for the toolbar changing from TAB_SWITCHER_* to one of the other states. Also update the location bar bounds logic and shadow drawing logic to ensure that the location bar is properly clipped and the shadow has the proper visibility when capturing textures. BUG=916561 Change-Id: I8ab5116d087866c7aa6e56865dc160c7a5f729c3 Reviewed-on: https://chromium-review.googlesource.com/c/1384374Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#619440}
-
Caleb Raitto authored
Bug: 879208 Change-Id: If2934a611d583d6725b7a9cd170e3c0fcd63bf34 Reviewed-on: https://chromium-review.googlesource.com/c/1374158 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#619439}
-
Laís Minchillo authored
Bug: 918350 Change-Id: Ieac9c9e1590c4cfe8f39d9f9bdfd510b41be616e Reviewed-on: https://chromium-review.googlesource.com/c/1392719Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Cr-Commit-Position: refs/heads/master@{#619438}
-
Majid Valipour authored
Existing pause time application in cc::KeyframeModel is incorrect. To convert the client pause time to monotonic time, we used to add the |time_offset_| (1) but not add |total_pause_duration_| (2). The new logic now excludes (1) and adds (2). This ensures pause time and monotonic time have the same base clock. The original conversion was incorrect because: a. Pause time should have the same base clock as monotonic time since we compute total_paused_duration_ as difference between the two. b. Blink provides its animation's current time as pause offset which maps to the concept of local time in cc. So to convert it to monotonic time we don't need to include time_offset_. Without this correction animations with start-delay or multiple pause/unpause cycles would lead to incorrect pause time calculation. I suspect these issues flew under the radar mainly because pausing is only ever used for simple test cases not involving either of these conditions. Bug: 840364 TEST: cc/animation/keyframe_model_unittest.cc Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Id52ca7a3f3d63899864b7153470c7ef64c582d29 Reviewed-on: https://chromium-review.googlesource.com/c/1045126 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#619437}
-
John Delaney authored
This CL is strictly a refactor that switches the Ads PLMO to count frame data using ResourceDataUseUpdate instead of OnLoadedResource. This will allow us to include incomplete resources and header bytes in future per-frame metrics. This will not change behavior of existing histograms at all. Bug: 878393 Change-Id: Ibb235c11bbaa168a40be51bc99c03a0ba999c251 Reviewed-on: https://chromium-review.googlesource.com/c/1372428 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#619436}
-
Tomasz Wiszkowski authored
Navigation icon is changed only in tablet mode. Bug: 871798 Change-Id: Iab19f02b93566f35a0a65362e035bf82851cad73 Reviewed-on: https://chromium-review.googlesource.com/c/1391995 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#619435}
-
Peter Wen authored
For release builds, desugar.jar still runs first, before d8 or r8, so nothing is changing for them as by the time d8 or r8 runs, the code has already been desugared. When r8 is enabled, it can desugar all targets that enable proguard, and d8 can desugar all targets that do not enable proguard. This can only be turned on once r8 replaces proguard since proguard does not understand java 8 code that has not been desugared already. Bug: 906803, 913679, 916733 Change-Id: I3fcc5a20b38e7fdc78cdeed1533583675d58346b Reviewed-on: https://chromium-review.googlesource.com/c/1384945Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#619434}
-
Pavel Golikov authored
Change-Id: I8d452ba40f6224b3d33e651e2ad3bd5319d65ea2 Reviewed-on: https://chromium-review.googlesource.com/c/1391670Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#619433}
-
Theresa authored
Set the CompositorViewHolder to unfocusable when the accessibility tab switcher is showing. This fixes an issue where tapping on the disabled tab switcher button (when no tabs are open) jumped focus to the CompositorViewHolder. BUG=584423 Change-Id: I9d637e37514aa4ad4f7621c75240428aba16bfd0 Reviewed-on: https://chromium-review.googlesource.com/c/1392149 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#619432}
-
Tomasz Wiszkowski authored
Bug: 918342 Change-Id: I9f0a7e24dddb6b612378388c880c501dda4ff6c5 Reviewed-on: https://chromium-review.googlesource.com/c/1392593 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#619431}
-
Katie D authored
This does not yet do anything. See more background in the bug. Bug: 905419 Change-Id: I67cea842e5e83804ebe7618855e0712d74cbf76a Reviewed-on: https://chromium-review.googlesource.com/c/1387831Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#619430}
-
Caleb Raitto authored
This adds support needed by crrev.com/c/1374158. Bug: 879208 Change-Id: I80894a166cf4233087b81a455cfc22a106f724e6 Reviewed-on: https://chromium-review.googlesource.com/c/1382694Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#619429}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8a5b9a8ad6fa..a6ba1795b7bc git log 8a5b9a8ad6fa..a6ba1795b7bc --date=short --no-merges --format='%ad %ae %s' 2019-01-02 eseckler@google.com build: Use test() template for test executables Created with: gclient setdep -r src/third_party/perfetto@a6ba1795b7bc The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Iae7acc33591869390b669433d951978e1bfcf387 Reviewed-on: https://chromium-review.googlesource.com/c/1393256Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619428}
-
manuk authored
Added favicons to the 'URL' column. Favicons are displayed to the left of the url, similar to how they're displayed in the omnibox. Added answer entities to the 'Contents & Description & Answer' column. Answer images are displayed to the left of the contents and description, similar to how they're displayed in the omniobx. For answers which have text associated with them (e.g. 'weathe<b>r</b> / 76°F Thu / answer type weather'), it will be displayed in orange after the contents and description. Bug: 891303 Change-Id: I46d50fcce39f93b57a70aae5d2f439333d203dbf Reviewed-on: https://chromium-review.googlesource.com/c/1376661Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#619427}
-
Lukasz Anforowicz authored
The factory requested by the renderer via RendererBlinkPlatformImpl::CreateNetworkURLLoaderFactory cannot be associated with a specific origin, but it can still be locked down to the site URL used that the process might have been locked to. This lessens the impact of https://crbug.com/891872 - before this CL a compromised renderer could abuse the process-wide factory to start requests with an arbitrary request_initiator. After this CL, request_initiator_site_lock will lock down |request_initiator| to a particular site. Bug: 914130 Change-Id: Ibca31d349e3c090755679a30c87ab85469ad30a4 Reviewed-on: https://chromium-review.googlesource.com/c/1374053 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#619426}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/96eb27a4c496..6d2bcf3c2f33 Created with: gclient setdep -r src-internal@6d2bcf3c2f33 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibdbb84ad363f31ac37e1a50b2bf0dedbbbc54d3b Reviewed-on: https://chromium-review.googlesource.com/c/1393344Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619425}
-
Gauthier Ambard authored
The cell wasn't converted to UITableViewCell. Bug: 894791 Change-Id: I44fdd29f4d3179eefa0d4515c4b8655bb77cd6c0 Reviewed-on: https://chromium-review.googlesource.com/c/1392960 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#619424}
-
Dominik Röttsches authored
Change-Id: I873ee094a9a390a92a09b33ef924c84e93d4b850 Reviewed-on: https://chromium-review.googlesource.com/c/1392331Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#619423}
-