GitLab

This CL plumbs the network error code through to show it in the
chrome://sync-internals pages in case of NETWORK_CONNECTION_UNAVAILABLE.

This should allow for easier debugging for some user reported bugs.

Bug: 897049
Change-Id: Id0fc5455eb4d64b1a022898d8a898e7efa4a255c
Reviewed-on: https://chromium-review.googlesource.com/c/1346460
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611113}

Push some functionality down from AXTreeSourceAura and AXTreeSourceMus
into AXTreeSourceViews.

This allows AXTreeSourceViews to completely implement the AXTreeSource
interface, eliminating the weird "subclasses must implement GetRoot"
condition.

Just cleanup, no functional changes.

Bug: 888145
Test: views_unittests, views_mus_unittests
Change-Id: I1c1b2cfa856fe6f5e5bcf8dfff172a7ffb6e5339
Reviewed-on: https://chromium-review.googlesource.com/c/1351776Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611112}

Add setFormValue() implementation to blink::ElementInternals, and it
also overrides ListElement::AppendToFormData().

Tests:
- custom-elements/form-submission-file.html
  This won't be merged to WPT because this test uses a Mojo interface mock.
- custom-elements/tentative/form-submission.html
  This will be merged to WPT.

Bug: 905922
Bug: https://github.com/w3c/webcomponents/issues/187
Change-Id: I1d28d1d5e8c2c412e7db18a0b39eb9d517054c04
Reviewed-on: https://chromium-review.googlesource.com/c/1350418
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611111}

BUG=903885

Bots are true but mac_chromium_rel_gn, which is sick. Adding "notry".

NOTRY=true

Change-Id: I6907a8c978a4adbbbca2f5e12122c90564607b1c
Reviewed-on: https://chromium-review.googlesource.com/c/1351153
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611110}

Looks like https://chromium-review.googlesource.com/c/chromium/src/+/1349854
fixed these too.

Bug: 897970,897969
Change-Id: I09dac10a533511fbab3d49e9c0055ebc7b507f2d
Reviewed-on: https://chromium-review.googlesource.com/c/1350190
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611109}

No need to zip up the generated source just to unzip it again :P

This reverts commit f4e7bed3.

Reason for reland: Fixed missing deps in __final_jni template

TBR=pauljensen@chromium.org,agrieve@chromium.org

Bug: 908479
Change-Id: I1177d550eb33737f47192bd70db5358c6392598c
Reviewed-on: https://chromium-review.googlesource.com/c/1351930
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611108}

When the tab is brought to the foreground, preconnect to the
origin of the main frame request. This preconnection is done
at most once, and is helpful in case user clicks on a link.

Change-Id: I6786c14ad7be0921bb309aabac5a75cff9819db8
Bug: 908725
Reviewed-on: https://chromium-review.googlesource.com/c/1350209Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611107}

Ideally, it should be possible to use the IdentityTestEnvironment
ctor that takes only the boolean paramater, and constructs the
signin and token handler objects internally. But some tests
tweak the PrefService instance, which is not exposed by
IdentityTestEnvironment APIs.

Bots are true but mac_chromium_rel_gn, which is sick. Adding "notry".

NOTRY=true

BUG=908519

Change-Id: I6b4c9076c61079b45da76960c5269fd5ca8397a8
Reviewed-on: https://chromium-review.googlesource.com/c/1351152
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611106}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/2135b68548af..115df409efa1


git log 2135b68548af..115df409efa1 --date=short --no-merges --format='%ad %ae %s'
2018-11-27 dgarrett@google.com repo_sync_manifest: Add -g cherry-pick support.
2018-11-27 dgarrett@google.com config_lib: Remove REPO_URL from site_config.
2018-11-27 mikenichols@chromium.org cidb: Working around some SSL options from new packages.
2018-11-26 bhthompson@google.com Move eve-arcnext P Android PFQ to eve
2018-11-26 cjmcdonald@chromium.org chromeos_config: Add template for unit test only buildbot


Created with:
  gclient setdep -r src/third_party/chromite@115df409efa1

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ib6e71f049b8388eeb2856cc9fb53e9b1ce8e309c
Reviewed-on: https://chromium-review.googlesource.com/c/1351298Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611105}

webViewScrollViewDidResetContentSize interprets the scroll view's content size's
width being narrower than the frame's width as a sign that WebKit hasn't
properly resized the content, so resets zoom scale to force WebKit to
re-render. However, the zoom scale that makes the content fit exactly within
the width of the frame may not be exactly representable as a float. In this
case, the content size's width can be up to a pixel narrower than the frame
width. There's no benefit to forcing a re-render in this case, and furthermore,
resetting the zoom scale causes the page to scroll, which may trigger the page's
content to spuriously change. In the worst case, this can lead to a never-ending
cycle of resetting the zoom scale, the page scrolling, the page changing,
resetting the zoom scale again, and so on.

This CL makes webViewScrollViewDidResetContentSize ignore cases where the
contentSize's width is up to a pixel narrower than the frame.

Bug: 822697
Change-Id: I93e3e7efb33a6ea3b931c0d7f2b404bf93e80e12
Reviewed-on: https://chromium-review.googlesource.com/c/1348955Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611104}

Tbr: sergeyberezin@chromium.org,bradhall@chromium.org
No-Try: true
Bug: 908551
Change-Id: I5f003793bc94930fa685fff74ae1217e208b0dc6
Reviewed-on: https://chromium-review.googlesource.com/c/1351936Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611103}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6c18a1afa1a7..44d4b29082f0


git log 6c18a1afa1a7..44d4b29082f0 --date=short --no-merges --format='%ad %ae %s'
2018-11-26 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-11-26 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-11-26 ehmaldonado@chromium.org roll-dep: Use gclient setdep/getdep.


Created with:
  gclient setdep -r src/third_party/depot_tools@44d4b29082f0

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:906114
TBR=agable@chromium.org

Change-Id: I4c4668c3e3c3a02b47454b536f915980dab760c0
Reviewed-on: https://chromium-review.googlesource.com/c/1351472Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611102}

This CL introduces a new UKM for measuring success of finding
corresponding password form managers during the stages of saving a
password form.

There are three stages during which one of four values is reported.
The reporting only takes place if the page has at least one password
form, and only one value per page load is reported.

Privacy review of this metric:
The whole UKM event "PageWithPassword" has been reviewed in
crbug.com/728707 and go/gkmnc, where the privacy TL agreed that adding
new metrics for this event is OK under certain conditions (see the
linked doc). The new metric satisfies such conditions, in the opinion
of the CL author, and hence are covered by that review. The new
metrics have been added to the requested spreadsheet listing all
passwords-related metrics.

Bug: 907794
Change-Id: I3cdcffeea9546474acd71ee85f74f4d2e60a6a2e
Reviewed-on: https://chromium-review.googlesource.com/c/1348043
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611101}

These tests rely on assumptions on Chrome's old user gesture model.
This CL fixes the assumptions for the new model (UAv2).

Bug: 908531
Change-Id: I3d290489075f81f5c8fd414c050d1beabab48488
Reviewed-on: https://chromium-review.googlesource.com/c/1351570Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611100}

This CL does most of the changes needed to move EventTiming tests to WPT. The CL
attempts to make the tests less flaky by ensuring the event handlers themselves
take a long time to execute.

Bug: 908187, 907948, 907949
Change-Id: Iced25d635cb05c9903a209d43988ba4e71681195
Reviewed-on: https://chromium-review.googlesource.com/c/1351600Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611099}

Bug: 736037
Change-Id: I4b4b0e221ac987f0c2de81cbc2709c7711d0d1df
Reviewed-on: https://chromium-review.googlesource.com/c/1351450Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611098}

LayoutNG creates an anonymous inline wrapper when
::first-line has background, so that paint code can handle it
the same way as other boxes.

Because of that, when ::first-line was applied after the box
was once laid out, such block needs to reattach to insert the
anonymous inline wrapper.

This patch should have been needed, but all tests used to
pass without this, probably we didn't have such tests.
Recently 3 tests started to fail. This patch fixes them.

DCHECKs to avoid splitting anonymous inlines added in r521673
(CL:806158) are adjusted to allow splitting anonymous wrapper
for ::first-line.

Bug: 636993
Change-Id: Ib1e51f0f77c759761b31abe8cc0e2973caa77d92
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/c/1345676
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611097}

Change-Id: I4c1979c82b96bbba5e2ac923d549faa87e5f28cf
Reviewed-on: https://chromium-review.googlesource.com/c/1350024Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611096}

BUG=903381

Change-Id: Ic99dc1e7d52e434a5f2b38b0fa561921aab26065
Reviewed-on: https://chromium-review.googlesource.com/c/1328821Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611095}

Filter android passwords from the manual fallback options.

Bug: 905659, 878388, 845472
Change-Id: Id7f120f0747f3ff01d5239568a427dea97a965a9
Reviewed-on: https://chromium-review.googlesource.com/c/1352149
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611094}

The parameter is no longer needed, so this CL removes it.

Bug: 875153
Change-Id: I985eb2a90c25652d2daf6bbef1aa3e2e7cdd549f
Reviewed-on: https://chromium-review.googlesource.com/c/1275469Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611093}

When the kCompositorTouchAction flag is enabled, and browser receives
the touch start ack from the compositor, if there is no white listed
touch action, then the touch start must be non-blocking, thus setting
the touch action to Auto.

Unit tests are modified to account for this change.

Bug: 907959
Change-Id: Ife589533a959ccce1376926e14935639341f32ea
Reviewed-on: https://chromium-review.googlesource.com/c/1349673Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611092}

Also gray out "No Username" label.

Bug: 905663
Change-Id: Iabbbf1ce7d20f62e72896ad08b5a239d0fbd14dc
Reviewed-on: https://chromium-review.googlesource.com/c/1350616
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611091}

SigninClient implementations should not depend on SigninErrorController.
The dependency should be the other way around.
This CL fixes the WebView implementation of SigninClient.

NOTRY=true

Change-Id: I0592028bd988036bc01a2a48d375337f077bfbd7
Bug: 836212
Reviewed-on: https://chromium-review.googlesource.com/c/1348035
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611090}

This fixes the issue where Chrome would hang if the user had a lot (tested with 5000) profiles.

After debugging, the following bottlenecks were identified (listed in order of execution):
- Finding matching profiles (impact small),
- Deduping matching profiles to create a unique set (impact medium),
- Calculating width of every rows (impact high),
- Eliding strings (impact high)

The approach this CL is taking to solving the issue is to limit the number of profiles that are shown to the user. This is done gradually to optimize perf while keeping the same precision.
Effectively, in the worst case, we are limiting our search to:
- Find the first 50 matching profiles,
- Dedupe matching profiles until you have 10 unique to show.

This way we are optimizing where perf cost is high, while keeping our results relevant since users will get other results not shown by default as they keep typing.

Metrics considered for choosing the numbers:
50 matching profiles:
- Very few users have more than 3 profiles, but recorded extreme cases go up to 53 (see UMA chart link),
- Since perf cost for this part of the code is not high, we can accommodate these extreme cases.

10 suggestions:
- Over 99% of our users will choose a suggestion that is within the first 10 suggestions.

Fixes: 753481
Change-Id: I59a9529f9ba4cf6da56a1c1167aa6bb7562d0f81
Reviewed-on: https://chromium-review.googlesource.com/c/1343609Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611089}

This makes the RTCPeerConnection aware, through the help of the tracker,
what its call setup state is. This is confirmed by unittests.

UMA metrics and trigger point for collecting this will be added in a
follow-up CL.

Bug: 906029
Change-Id: Ib71ec03d7560c5ee9ac65fd5427b297808e8c4fa
Reviewed-on: https://chromium-review.googlesource.com/c/1349340Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611088}

Test case: TwoClientBookmarksSyncTestIncludingUssTests.MC_MergeDifferentBMModelsModeratelyComplex

Bug: 908771
Change-Id: Ibf0166436b5639caaeb5583a3a6b7ab541e3cd9c
Reviewed-on: https://chromium-review.googlesource.com/c/1352129Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611087}

Change-Id: Ib142a395db29f8ed48c35b5f7c8ffc13cbce1fca
Bug: 830624, 826664
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/c/1346455
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611086}

Relax the restriction on parallel requests.
Most of the changes are in tests:
- Don't always initialize the browser in tests
- Detached requests are tried before and after native is loaded.

Bug: 901835
Change-Id: Iecd16e976eb3bdea44871097528ef799b9678051
Reviewed-on: https://chromium-review.googlesource.com/c/1350891Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611085}

To make browser-side loader classes for PlzSharedWorker reusable for
PlzDedicatedWorker, this CL renames the classes as follows:

- SharedWorkerScriptFetcher => WorkerScriptFetcher
- SharedWorkerScriptLoader => WorkerScriptLoader
- SharedWorkerScriptLoaderFactory => WorkerScriptLoaderFactory
- SharedWorkerMainScriptLoadParams => WorkerMainScriptLoadParams

This doesn't change functional behavior.

See the design doc for details:
https://docs.google.com/document/d/1fWsD0oIa5sNDfUFWGJZ41pDo3zzsbFGyQSNdV8nOG4I/edit?usp=sharing

Bug: 906991
Change-Id: If25f463655f2f53a533a6c1504f57f05937860a1
Reviewed-on: https://chromium-review.googlesource.com/c/1350018Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611084}

The previous logic failed to handle various edge cases, such as when
Sync as a whole is disabled or fails to start up.
The new logic checks whether the user has chosen to sync themes,
independent of the current runtime state of Sync.

Bug: 907027
Change-Id: If9974c0cfd99ad66c28726e319b6f3c565073d5d
Reviewed-on: https://chromium-review.googlesource.com/c/1346391
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611083}

This CL uses the callbacks used when the user tab an omnibox result
to switch to an open tab. It allows to record the same metrics as
desktop.

Bug: 906598
Change-Id: I12d848915b1a8a266d887d1eec11f71d2daef1a8
Reviewed-on: https://chromium-review.googlesource.com/c/1341538
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611082}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/483d8219..62e154db

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

Passing a NOTRY because the mac_chromium_rel_ng and mac_optional_gpu_tests_rel
bots experience an infra failure, see https://crbug.com/908729.
All the others are green.

NOTRY=true

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I6369c6500454aec9f21c08e78b9a14b65b2a54a4
Reviewed-on: https://chromium-review.googlesource.com/c/1351463
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611081}

This CL adds callbacks to the AccessorySheetData java class. They are
needed for the rework of the UI.

Bug: 902425
Change-Id: Idaa321a21268b9b071d244633553a86a9733408c
Reviewed-on: https://chromium-review.googlesource.com/c/1348331Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611080}

Instead of relying on an implementation of IdentityManager::Observer and
a private flag to know when a RefreshToken is available before requesting
using PrimaryAccountAccessTokenFetcher, use PAATF's mode to wait until the
primary account has a refresh token available (i.e. kWaitUntilAvailable)
whenever needed when TokenHandleFetcher::BackfillToken() is invoked, or
simply using kImmediate if such refresh token is already available.

Bug: 905689
Change-Id: Idf8e8b58a9bda518f2bd11d140b4e8776194a8f4
Reviewed-on: https://chromium-review.googlesource.com/c/1343264
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611079}

Remove passing tests from the filter.

Passing tests:
-ClientOnPageStartedTest.testBrowserInitiatedHangingNavigation
-ClientOnPageStartedTest.testRendererInitiatedHangingNavigation

passing due to:
https://chromium-review.googlesource.com/c/chromium/src/+/1345029

The above tests rely on onLoadResource call, which is implemented
via shouldInterceptRequest.

BUG=893572,841556
Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo

TBR=cduvall@chromium.org,jam@chromium.org

Change-Id: I0062fd921ac0ce8f859a335674fd25b82fd07e9b
Reviewed-on: https://chromium-review.googlesource.com/c/1350919Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611078}

This CL let the toolbar be contracted even if it is animating.
This is needed, because calling twice the same method could yield
different results based on the state of the device (portrait vs
landscape for example).

Bug: 900761
Change-Id: Ie3f44e871e411162bc63467d6cf5e7df3d02cc22
Reviewed-on: https://chromium-review.googlesource.com/c/1349347Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611077}

This histogram hasn't been used in a long time.

The last collected value of these histograms was:
Settings.JsonDataWriteCount.Local_State
-Most values close to 0 writes
-99.31st percentile: 1 write
-99.9th percentile: 11 writes

Settings.JsonDataWriteCount.Preferences
-99.05th percentile: 0 write
-99.9th percentile: 12 writes

Settings.JsonDataWriteCount.Secure_Preferences
-99.7th percentile: 0 writes
-99.86th percentile: 2 writes

Bug: 902187
Change-Id: I17cf198066fe400e29df156207222e444a8da9dc
Reviewed-on: https://chromium-review.googlesource.com/c/1329708Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611076}

This reverts commit 409ceb85.

Reason for revert: Introduced flaky tests (http://crbug.com/908804)

Original change's description:
> GWP-ASan: Add crash handler hook.
> 
> After a GWP-ASan exception occurs, a crash handler hook (e.g. a crashpad
> UserStreamDataSource) is responsible for looking at the crash and
> 1) determining if the exception was related to GWP-ASan, and 2) adding
> additional debug information to the minidump if so.
> 
> The crash handler hook determines if the exception was related to
> GWP-ASan by finding the AllocatorState address (using a crash key),
> reading the allocator state and seeing if the exception occurred in the
> bounds of the allocator region. If it did, we extract debug information
> about that allocation and report it in the minidump.
> 
> CQ-DEPEND=CL:1339246
> 
> Bug: 896019
> Change-Id: I63d12b5137098b20ec946e3bddbdcabaf20e430a
> Reviewed-on: https://chromium-review.googlesource.com/c/1330283
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Reviewed-by: Brian White <bcwhite@chromium.org>
> Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611033}

TBR=ajwong@chromium.org,bcwhite@chromium.org,mark@chromium.org,vtsyrklevich@chromium.org,vitalybuka@chromium.org

Change-Id: If79e66f0852b0bb5ff6ea5d97e0197f0c5924ab8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 896019
Reviewed-on: https://chromium-review.googlesource.com/c/1352173Reviewed-by: Tim Schumann <tschumann@chromium.org>
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611075}

Make this method match in Chromium style guide.
This CL has no behavior changes.

Bug: 761242
Change-Id: Ie2fda83b51525812a20472cb157e855ee57a561c
Reviewed-on: https://chromium-review.googlesource.com/c/1351345Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611074}