- 16 Mar, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/22594b8b0acd..496706c9672e git log 22594b8b0acd..496706c9672e --date=short --first-parent --format='%ad %ae %s' 2020-03-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-03-16 sigurds@chromium.org Only display 100 inline breakpoints 2020-03-16 szuend@chromium.org Initialize Linkifier link texts with 'zero width space' 2020-03-16 tvanderlippe@chromium.org Extract tsconfig.base.json to obtain VSCode compatible tsconfig.json 2020-03-16 jacktfranklin@chromium.org TypeScriptify `sdk/CookieParser` Created with: gclient setdep -r src/third_party/devtools-frontend/src@496706c9672e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1032016,chromium:1057021,chromium:1060105 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I79d993f3bdc484a7f69af59056b8535cfa57fa5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105193Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750539}
-
Kei Nakashima authored
Implemented |erase|, |RemoveFirst|, |pop_back|, |clear| in NewLinkedHashSet. Also added tests for those functions. Change-Id: I434409a3f1ad0a6bffd60ddfbd79f4cdeaf22d94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103994Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Kei Nakashima <keinakashima@google.com> Cr-Commit-Position: refs/heads/master@{#750538}
-
Nohemi Fernandez authored
When the flag kClearSyncedData is enabled, the current code attempts to add the new dialog option to the managed account alert. We only expect the change to affect non-managed accounts, and so the app crashes. Adds regression test for the case where a managed user signs out from Chrome. Bug: 1058662 Change-Id: Iaad9a13655a45653aa2e09e1428c03a37e412325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101008 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#750537}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f4a3e7498a60..18f1a2797005 Created with: gclient setdep -r src-internal@18f1a2797005 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:974751 Tbr: jbudorick@google.com Change-Id: I8d7da36e2abeb7dfbab2c218e496c2a6a81a7bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104949Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750536}
-
François Beaufort authored
Bug: 346399 Change-Id: I038233ae521749c4168f08bb9450309da4a04e4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102492Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#750535}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3a50a43df988..440fc9959f06 git log 3a50a43df988..440fc9959f06 --date=short --first-parent --format='%ad %ae %s' 2020-03-16 swiftshader.regress@gmail.com Regres: Update test lists @ 3a50a43d Created with: gclient setdep -r src/third_party/swiftshader@440fc9959f06 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ia77d4e0d7d0fd5513a005e4bcf1cd7c8db18e29b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104951Reviewed-by:
-
David Roger authored
Bug: 1041472 Change-Id: I6435d239ddb90b0b5ffed600d0e5d2e51d4b8270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096962Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#750533}
-
Maxim Novikov authored
Test: N/A Bug: internal b/151449774 Change-Id: I9e66ebef8c96e9d3cf2708efdfdf95139d9d2b61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104663 Auto-Submit: Maxim Novikov <csbubbles@chromium.org> Commit-Queue: Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#750532}
-
Olivier Robin authored
Metric is still use to reduce the crash report unfinished report upload. Change-Id: Ia3e4b4a5de2a5a86ddb7e172a47e2a7599949ea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093605 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#750531}
-
Omer Katz authored
Tracing on-heap objects should treat everything as const and not change anything. This CL makes all visitor tracing/visitation methods and TraceTraits expect const objects. The guideline this CL tries to establish is that from the perspective of tracing everything is const, including data that will later be used for compaction. Everything the visitors records is const. If and when needed, const_cast is used to get mutable versions (e.g. in weak callbacks and compaction). This CL also updates the collection Trace methods to const as these are highly intertwined with the TraceTraits. Bug: 1058387 Change-Id: Icd26693e029d5c1d03ba50e54390b1d9aa350620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095720Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#750530}
-
Rakina Zata Amni authored
We added some new histograms for find-in-page in https://chromium-review.googlesource.com/c/chromium/src/+/2096795, and three of them should be marked as base histograms as we are only tracking their subhistograms. The base histograms are: - WebCore.FindInPage.NumberOfTasksPerRequest - WebCore.FindInPage.RequestDuration - WebCore.FindInPage.TotalTaskDuration Bug: 1057917 Change-Id: Ifcf79e1d93334a9ac062f1d9cab79349e2d35e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104810Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#750529}
-
Peter Marshall authored
Clicking on the inspect/close button too quickly in succession or right- clicking the button would cause the whole div containing both buttons to be highlighted which was annoying. Before: https://imgur.com/a/OgdmeE7 After: https://imgur.com/a/nfjOrb4 Bug: chromium:1036789 Change-Id: I51328de5d1fa2ab232913770cc1cf594b019d660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102581Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#750528}
-
David Jean authored
New simpler two-step api. Bug: 1049638 Change-Id: I8490144f181e140a909d3a740be9035ef0be1465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095056 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#750527}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/80ed7ca9c63c..22594b8b0acd git log 80ed7ca9c63c..22594b8b0acd --date=short --first-parent --format='%ad %ae %s' 2020-03-16 tvanderlippe@chromium.org Fix typeRoots inclusion for non-testonly ts_libraries 2020-03-16 tmathmeyer@chromium.org Add SDK import that broke the media tab. 2020-03-16 petermarshall@chromium.org [ui] Add spacing to checkboxes in lighthouse start page 2020-03-16 tvanderlippe@chromium.org Add missing inputs to ts_library definitions Created with: gclient setdep -r src/third_party/devtools-frontend/src@22594b8b0acd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1054925,chromium:1058320,chromium:1061362 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifc1e1d65ccaabf84712388a2f2b53754d2713b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104950Reviewed-by:
-
Andrew Grieve authored
These were the only sources that caused "gn gen" to fail when setting the global sources_assignment_filters to []. Bug: 1018739 Change-Id: I95a1b3a1386c176689a184a464275907d0b7a414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102786 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/463c39490599..1a56ce54e070 git log 463c39490599..1a56ce54e070 --date=short --first-parent --format='%ad %ae %s' 2020-03-16 jiawei.shao@intel.com Validate creating bind group layout with storage textures Created with: gclient setdep -r src/third_party/dawn@1a56ce54e070 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1061156 Tbr: cwallez@google.com Change-Id: I0fa371e8ca5b1e66807ad02c645367cd640da0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104947Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/506142ad..717aa4d9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8ec943c035153e9a4020d680473cbdf4b6eda8d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104613Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750523}
-
Oleg Davydov authored
Before this CL if extension had any problem with computed_hashes.json file, content verification will fail with MISSING_ALL_HASHES failure. Previously it was not an issue, since: * With mode equals to ENFORCE_SCRICT, as in ChromeContentVerifierDelegate, this failure reason makes no difference. We still consider extension as corrupted. * For extensions from Chrome Web Store this is unusual situation: we can recompute hashes and verify them using hashes signed by Chrome Web Store. But after work in https://crbug.com/958794 there is a strong difference between cases "no computed_hashes.json file at all" and "there is the file, but it is damaged and unreadable itself". In the first one we should ignore the failure. In the future we will reinstall such an extensions, but without disabling them before. But in the second case damaged file with hashes may mean that other files are damaged too, so we have to disable extension and reinstall it immediately. This commit reflects mentioned difference, adding a new type of failure and passing it from ComputedHashes::CreateFromFile to the VerifyFailed callback in content verifier delegate. Bug: 958794 Change-Id: Ibb2ef46f00b97e09aec593c44fceed93ad73e81f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062276 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#750522}
-
Benoit Lize authored
The hooks' spinlock in PartitionAlloc is not performance-sensitive, and is likely used as PartitionAlloc used not to rely on base/. Removing it to reduce the use of custom locking (see the attached bug for motivations). Bug: 1061437 Change-Id: Id1d74ac9f108bdc462fd0d5586e89b0be056b67a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102532 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
-
Yoav Weiss authored
This fixes a regression from [1], which accidentally modified CrOS' User-Agent string. Bug: 1061132 Change-Id: Ib42fe7eb840ceab38dba9a29d498b5c9ed041fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102554Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#750520}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cb9a86a9d867..d1d96d73bff7 git log cb9a86a9d867..d1d96d73bff7 --date=short --first-parent --format='%ad %ae %s' 2020-03-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 18daa81e3d3d..3a50a43df988 (14 commits) Created with: gclient setdep -r src/third_party/angle@d1d96d73bff7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ynovikov@chromium.org Change-Id: Ic72e9c810a5fd501931e5f2d6c78a7353807bc63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104704Reviewed-by:
-
Vasilii Sukhanov authored
Mock: https://docs.google.com/presentation/d/1yWuZO-fjXhdRp64nWRbnHEyzpFd1KOMS3u1_1XMdGuA/edit#slide=id.g76725620de_2_176 Bug: 1047726, 1061087 Change-Id: If49570dfefec51614814f314d0fe1cce4a64aaf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095731Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#750518}
-
Colin Blundell authored
WebLayer will shortly be incorporating //components/navigation_interception, following the model set by //chrome. As a precursor, this CL moves the functionality that is in the //chrome subclass of InterceptNavigationDelegate to be available to all embedders via a construction parameter of InterceptNavigationDelegate. WebLayer will reuse this functionality. TBR=eroman@chromium.org Bug: 1031465 Change-Id: I0dae07c117e071d9bc16e937cc5dc5cd64960ced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102730 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#750517}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7146ea83c0c4..29de50e4d8ee git log 7146ea83c0c4..29de50e4d8ee --date=short --first-parent --format='%ad %ae %s' 2020-03-16 hjd@google.com ui: Fix thread state Created with: gclient setdep -r src/third_party/perfetto@29de50e4d8ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:151569976 Tbr: perfetto-bugs@google.com Change-Id: I9c61478b50d8f35f60f560baaae0cfc9cd3cae12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104706Reviewed-by:
-
Wolfgang Beyer authored
A DevTools CL (see below) changes the expected output for this test. This patch temporarily allows the relevant Blink Web Test to fail, so that we can land the devtools-frontend patch. We can re-enable and update the test once that happens. [1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2078851 Bug: chromium:1041830 Change-Id: I38bfd1bcb14da3382ced9fd145aa60a9d22cb8b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095591 Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This reverts commit 9e64c392. Reason for revert: Failing on iOS device. See crbug.com/1061863 Original change's description: > Set a limit on how shared memory can be mapped in one process. > > Allowing arbitrary amounts of shared memory to be mapped can make it > easier for an attacker to bypass ASLR as documented in > https://googleprojectzero.blogspot.com/2019/04/virtually-unlimited-memory-escaping.html > > Bug: 1056572 > Change-Id: I812542e2b3d9e7842a7ae54bdd837fa956a99177 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083447 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Auto-Submit: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750211} TBR=dcheng@chromium.org,rkaplow@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1056572 Change-Id: I78af6cfd9737a96cbb120c6e3db769145c244f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104050Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#750514}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cb66c20c2371..80ed7ca9c63c git log cb66c20c2371..80ed7ca9c63c --date=short --first-parent --format='%ad %ae %s' 2020-03-16 szuend@chromium.org Use Ninja to build ArrayUtilities unit test Created with: gclient setdep -r src/third_party/devtools-frontend/src@80ed7ca9c63c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9fa271ac22f4aec0d9e6a5510d68f2553450e32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104705Reviewed-by:
-
Fredrik Söderqvist authored
This starts dismantling SVGFilterPainter by moving some of the logic into the FilterData class. Various methods are added to FilterData to handle manipulation of its state. Member fields are made private. The kPaintingFilter* states are renamed to kGeneratingFilter* because that more closely describes what they are there for (which is made more obvious by the new structure). Bug: 109224 Change-Id: Idfa1d584b4d37c8e4d6733f8729e8e942313533c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102573 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#750512}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/567ffda407c9..f4a3e7498a60 Created with: gclient setdep -r src-internal@f4a3e7498a60 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I20e12914a9b39e6809c3d3b8fa54bd322e33c97d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104703Reviewed-by:
-
Dominik Röttsches authored
Address gab's additional review comments from https://chromium-review.googlesource.com/c/chromium/src/+/2032119/6#message-3d833beea111694a8a8920ede2468ac775ca310a Make DWriteFontLookupTableBuilder use a DeferredSequencedTaskRunner instead of manually maintaining the pending callbacks vector.Replace WaitableEvent with AtomicFlag.AtomicFlag makes things simpler in comparison to introducing our own sequence guarded boolean, as its used synchronously in tests. Bug: 1047054 Change-Id: I8a07c3eadec6f45784be013d062a467ab496dfb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083143 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#750510}
-
Will Cassella authored
The reference pages for the 'embedded_style_media_queries*' tests previously didn't wait to take a screenshot (as opposed to their counterparts which wait 100ms to take a screenshot), causing them to be a bit flaky. This CL fixes that. Change-Id: Ie8dd12b3b4dd7f810d72b3ba94ae2e5cb3644fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103142 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#750509}
-
Gauthier Ambard authored
This reverts commit 092dd8d9. Reason for revert: Failing on device bots. See crbug.com/1061867 Original change's description: > [AppLauncher] Look at core page transition type rather than explicit. > > This allows page to open app URLs via JavaScript. > > Bug: 1058388 > Change-Id: I3aabfab102c89156c342cf8f4fec72e69d69e2fc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087905 > Reviewed-by: Peter Lee <pkl@chromium.org> > Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750317} TBR=pkl@chromium.org,seblalancette@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1058388 Change-Id: I202ca98be0ab43a77dabd03d3e6e13a09c5f61a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102542Reviewed-by:
-
Kei Nakashima authored
Implemented |NewLinkedHashSet::front|, |NewLinkedHashSet::back|, |NewLinkedHashSet::size|, |NewLinkedHashSet::IsEmpty|. Also added tests for those functions. Along with this change, added DCHECK to |VectorBackedLinkedList::front| and |VectorBackedLinkedList::back|. Change-Id: I8f90dd8b744b85dd4ceb8366a64398d5f88c34bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103595Reviewed-by:
-
James Cook authored
A couple of tests verify that no notifications are shown if the sync system is disabled. They need to be updated to turn off OS sync on Chrome OS, because we still show the notifications if OS sync is enabled. These manifest as unit_tests failures when I run: unit_tests --enable-features=SplitSettingsSync This CL is preparation for turning SplitSettingsSync on by default. Bug: 1060289 Change-Id: Ia3e8d9d3b5be0879b1c929faed0f988338b730bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103439 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#750506}
-
Rob Buis authored
Implement the CSS property math-style as specified in [1]. The property is still a proposal [2] so it is toggled using the runtime flag CSSMathStyleEnabled. It a CSS property rather than an extra field of ComputedStyle because it will be used (amongst other things) in the MathML UA sheet to implement complex inheritance of scriptlevel/displaystyle and in the resolution of font-size (in particular they should have high priority). Additionally, we believe it makes sense to expose these properties for users (other than just MathML attributes) so that people can understand the magic behind the scriptlevel and displaystyle changes. However, we probably don't want to expose these properties yet, until details are agreed with the CSSWG. [1] https://mathml-refresh.github.io/mathml-core/#the-math-style-property [2] https://mathml-refresh.github.io/mathml-css-proposals/math-script-level-and-math-style-explainer.html Bug: 6606 Change-Id: I0d854c0829f5b7453901651a97efd5a7e5cea39d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100787 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#750505}
-
Shik Chen authored
When the system is extremely slow, the buffer allocation of the output buffer can fail and upper layer would get the raw un-rotated buffer. This CL mitigates the issue by increasing the pool size. Bug: 1061346 Test: Run Hangouts Meet and `stressapptest -M 32 -m 0 -i 0 -c 2 -s 30` concurrently, the flipped frame count in 30s dropped from 85 to 0 on Nocturne. Change-Id: I16a5cd260adc2799d8109bf323eae413ef7ac612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102268 Auto-Submit: Shik Chen <shik@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#750504}
-
Kunihiko Sakamoto authored
TBR=gyuyoung@igalia.com No-try: true Bug: 1061180 Change-Id: Iacddc75a342283f5be7bf27ff67854f0ef7f24ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104850Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#750503}
-
Yuki Shiino authored
Bug: 839389 Change-Id: Ibe92a15c48d11ea70391663a780bb846d90ccb5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102934Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#750502}
-
Ewann authored
Only failure for EG1 were seen. Enables testEmptyOmnibox for iPhone 13.3 and later, EG2 only. Bug: 1046787 Change-Id: I2aec75146a8a6a32ba28f14438cc092956ee09d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094988 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
-
Andreas Haas authored
This CL removes the list of ArrayBufferViews held by the ArrayBuffer. This list was originally introduced to handle a bug use-after-free issue in audio buffers, but this issue has been dealt with otherwise in the meantime, see https://docs.google.com/document/d/1h0bfIeGIqNCFi7iKyKKYDbQKpflSvA1kMNh74MCgHZM/edit?usp=sharing. Additionally I removed dead code: * ArrayBufferViews are never detached anymore. * ArrayBufferViews cannot be marked as detachable. R=ulan@chromium.org, haraken@chromium.org CC=hongchan@chromium.org, rtoy@chromium.org Bug: chromium:1008840 Change-Id: I5ee1093a94882e7e2260157cbb88c618bf052a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102530Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
