- 08 Jul, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/847ded3ada37..973c321add1b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jam@google.com,mohsen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jam@google.com,mohsen@google.com Change-Id: Ia46afad1d5052954b59fff4b20c50160577f43a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288138Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786477}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c49c88ac82fb..e64cd3aeff71 2020-07-08 thakis@chromium.org mac: Add an arm64 slice to ninja-mac. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1103315,chromium:762354 Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: I5b328dd2eb93cd1562224d76b20942ec49f057f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288589Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786476}
-
Mirko Bonadei authored
This CL adds the parts of absl that are needed by both Nearby and //third_party/shell-encrpyption. Bug: 1046390 Change-Id: Idaf0b92b764565b8f08b25f2ca9e13a6c0f2ef99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260632Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#786475}
-
Ghazale Hosseinabadi authored
This CL reverts commit 20204dee. The revert in commit 20204d was done due to a failing test, i.e., ToolbarActionsBarUnitTest.ReuploadExtensionFailed. This CL also fixes ToolbarActionsBarUnitTest.ReuploadExtensionFailed. Bug: 1101189 Change-Id: I996b2fd17923162c89161ce154dcd1046c47b814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285334Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Cr-Commit-Position: refs/heads/master@{#786474}
-
Tibor Goldschwendt authored
Deprecates the histograms - Tab.NewTabDOMContentLoaded - Tab.NewTabScriptStart - Tab.NewTabOnload* (on desktop) and logging code. The histograms are no longer used for analysis. Fixed: 1089552, 1089553 Change-Id: Ieb129e80825c1004a854df48894f580776953247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284375Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#786473}
-
Sreeja Kamishetty authored
-virtual/webrtc-wpt-plan-b/external/wpt/webrtc/simulcast/h264.https.html -external/wpt/webrtc/protocol/video-codecs.https.html -virtual/webrtc-wpt-plan-b/external/wpt/webrtc/protocol/video-codecs.https.html -external/wpt/webrtc/simulcast/h264.https.html Also, rename third_party/blink/web_tests/FlagExpectations/back-forward-cache to third_party/blink/web_tests/FlagExpectations/enable-features=BackForwardCache to match the name in test_suite_exceptions.pyl Bug: 1103214 Change-Id: Ie6e65711c83c873d3ca5280c8a6d5b72e6daf796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287381Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#786472}
-
Guido Urdaneta authored
This class has been mojified and the ThreadSafeSender appears to be dead code. Bug: 1102895 Change-Id: I2fe859b842e085e595fd82e5f0a3a80e0a2f4961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285007Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#786471}
-
shrekshao authored
Suppress deqp/functional/gles3/fborender/recreate_color_03.html on Android FYI Release (Pixel 2) as RetryOnFailure Tbr: kbr@chromium.org No-Try: true Bug: 1103370 Change-Id: Idc004171e10c2b112e746a3c8092ede33436e405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288749Reviewed-by:
Shrek Shao <shrekshao@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#786470}
-
Kevin Schoedel authored
Focus did not work due to two distinct problems, both of which caused page-level focus to be absent, which in turn meant that blink-level focus was suppressed. - The aura::Window on which focus was attempted does not have an OnWindowFocused observer. This change focuses the Window that does. - Wayland app's aura::Windows are not visible. This change adds a check for an ancestor that is an exo window. Bug: b/156123509 Test: manual on device Change-Id: Ib4e8a5101bbc28d2b7a0448aff8142c8cffa2a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274201Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Albert Chaulk <achaulk@chromium.org> Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#786469}
-
Brian Geffon authored
To keep CLs small on userspace swap this CL only adds the configuration tunables which will be available to userspace swap. Additionally, it adds a helper to determine if the kernel supports the necessary features for userspace swap. BUG=chromium:1067833 Change-Id: Id674abede3d503218189cd3b4bef130c4297b5c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288492 Commit-Queue: Brian Geffon <bgeffon@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#786468}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/414418d55f49..babba97ae63a 2020-07-08 zepenghu@google.com Use test font manager for SVG fuzzer 2020-07-08 herb@google.com don't produce empty SubRuns 2020-07-08 jlavrova@google.com Placeholders coming from flutter can have Inf sizes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: mtklein@google.com Change-Id: Iac39dc61175c418942267aadc39e22522f0d2f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288426Reviewed-by:
-
Oleh Lamzin authored
Use auto in tests when possible. Bug: b:158658869 Change-Id: Ib91a9ec07bfcac503b31811166361cb5e9033c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277992 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Roland Bock <rbock@google.com> Cr-Commit-Position: refs/heads/master@{#786466}
-
Jesse McKenna authored
This change moves the code to emit histogram "Windows.ChromeDllPrefetchResult" histogram into ChromeMain(). This fixes an issue where the histogram was created in chrome.exe and thus failed to be emitted by chrome.dll on non-components builds. Currently, the histogram is created before chrome.dll is entered, in chrome.exe. On non-component (release) builds, chrome.exe and chrome.dll each have separate copies of base, because base is statically linked ('baked in') into each portable executable file. Creating the histogram in chrome.exe's base means that chrome.dll's base, the one that actually emits the histograms to UMA, does not see the histogram. This change addresses this by passing the histogram value into ChromeMain() and emitting the histogram there. Bug: 1096609 Change-Id: I918144dff4fc0d5189d5882462ffadd88f27b9b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280242 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#786465}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/49a334846e76..76cae97fc14c 2020-07-08 amaiorano@google.com Update llvm 10 Darwin config 2020-07-08 amaiorano@google.com Update llvm 10 Linux config If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I01e0d277fbea13a8b294334fc11e8864666bc700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288139Reviewed-by:
-
Bettina authored
Instead of controlling it from Finch params, it will now be controlled in Client code. Also refactored the code to be in a central place to not duplicate it.Removed checks from compromised_credentials_* file as the saved password protection will be enabled by default. The signed-in non-sync and saved passwords will be ENABLED_BY_DEFAULT. This CL also does the clean up for both experiments. Bug: 1099908 Change-Id: I93dfb04ead935752658b24c7454786907e1f6141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269756 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#786463}
-
Oleh Lamzin authored
Fill disk infos in a separate logical block. It helps to avoid name collisions and looks simpler. Bug: b:158658869 Change-Id: I82a27cff9660e5540a3dfee90aae5f530c72a5dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277991 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
-
Peter Kasting authored
These uses of std:: functions should use the base:: versions since they want an integral type. Bug: 1088346 Change-Id: I32c96ddd31b27676dd2d1fb0d1467e8b0263980e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275346 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#786461}
-
Daniel Murphy authored
This should never happen, but it seems to be occurring for some users (see bug). Until the root cause is found, do a manual check to make sure WebApp is not a nullptr. R=loyso@chromium.org Bug: 1101668 Change-Id: Ia6148a0335aaa4394d9e335763791280001a7dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284004 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#786460}
-
Mitsuru Oshima authored
Removed WMHelper::SetInstance and simplified the code a bit. Bug: None AX-Relnotes: n/a. Change-Id: I2c09d7aad7e8dce20d11cd3618da7c5d6f22a07a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285345Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
-
Karandeep Bhatia authored
DOMWrapperWorld. Change one of the constructors of FetchParameters to accept DOMWrapperWorld as an argument to ensure that the DOMWrapperWorld is correctly set for requests using this constructor. Eventually we'll ensure that the ResourceLoaderOptions constructor takes DOMWrapperWorld as an argument. This also ensures that the isolated world CSP is correctly enforced for any beacon requests originating in isolated worlds. Currently, on redirects, such requests may not correctly bypass the main world CSP. BUG=1099975 Change-Id: I36799b11f9c47038051c31c8296c892d84fb0e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284362Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#786458}
-
Austin Eng authored
Bug: none, dawn:449 Change-Id: I00b81214a1c6d27340a610b33a4503ed75fd185c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288476Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Auto-Submit: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#786457}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a9e1b49704b2..a376518817f9 2020-07-08 handellm@webrtc.org Migrate video/ except video/end_to_end_tests and video/adaptation to webrtc::Mutex. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I98cf15e91ed4a733ab4f9886a999c41a0594b248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288137Reviewed-by:
-
Oleh Lamzin authored
Rename ptr to output in probe tests. Bug: b:158658869 Change-Id: I20613c04af413238c59a23a8f0ed2c7db91be60e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277990 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
-
Alexander Cooper authored
All XRSpaces, except for XRReferenceSpaces, implement MojoFromNative and their NativeFromMojo method is simply a wrapper to invert the other method. Because the StageParameters's standing_transform property was floor_from_mojo instead of mojo_from_floor, XRReferenceSpaces used NativeFromMojo and MojoFromNative was the inverter. This change renames (and inverts) StageParameters's standing_transform to mojo_from_floor. This removes the need for child classes of XRSpace to implement NativeFromMojo. XRSpace still implements this as a (non-virtual) helper method, because some math operations require it, and this provides a convenience wrapper around the inversion. As noted, this does invert the existing meaning of standing transform, so the runtimes needed to be updated. Fixed: 1031598 Change-Id: Ia36fe21ea2c179acb4a0d1a7096c7e5271d7a3a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278317 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#786454}
-
Peng Huang authored
1. For the first time GL access, the backing's queue family could be not VK_QUEUE_FAMILY_EXTERNAL. We need to transfer it to external for GL access. 2. SkiaOutputDeviceBufferQueue doesn't set backing's layout and queue family after Skia write access. Fix it by override PreGrContextSubmitz() to set the backing's layout and queue family. Bug: 1101167 Change-Id: I2f2f527ffb6f4b56e0042c8762cdb93eea4b6942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286052Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#786453}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594219033-e737395f4059a2d181f502d2cd1e2e733e308ff9.profdata to chrome-mac-master-1594231179-c7594468dab38d8e431c4fcba79f22d1baa4fc31.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I45ed3e29e540cc170c4e3ca0588ece4c4fba650c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288210Reviewed-by:
-
Dominique Fauteux-Chapleau authored
This dialog can appear during a long scan, or if the user waits for too long to close the scan dialog indicating the scanning verdict. It is misleading as the page seems unresponsive because of the scanning, so this CL prevents that dialog from appearing at the same time as the scanning dialog. The dialog is prevented from being shown by having ShouldIgnoreUnresponsiveRenderer return true until the paste callback has been ran. Bug: 1028750 Change-Id: If34f8184f254074c9ce30b49337a14531e24a8c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283397Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#786451}
-
Curt Clemens authored
This is a reland of 341bb752 Original change's description: > [Nearby Share] Add ToDictionary, FromDictionary to PrivateCertificate > > ToDictionary and FromDictionary methods convert to/from a Value > dictionary to facilitate storing PrivateCertificates in Prefs. > > Change-Id: I92117836af94cd224eeea34edc7dd55dd3eb7484 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284043 > Reviewed-by: Josh Nohle <nohle@chromium.org> > Commit-Queue: Curt Clemens <cclem@google.com> > Cr-Commit-Position: refs/heads/master@{#786027} Change-Id: I223a97fa67c1ecc821971ce89302f0064fd4abb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287989Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#786450}
-
Sreeja Kamishetty authored
- RenderDocumentHostUserDataTest.CheckWithFrameCrashDuringNavigation - All/RenderFrameHostManagerTest.DontSwapProcessWithOnlyRelNoreferrer/2 - All/RenderFrameHostManagerTest.DontSwapProcessWithOnlyRelNoreferrer/0 - All/RenderFrameHostManagerTest.DontSwapProcessWithOnlyRelNoreferrer/1 Bug: 1102629 Change-Id: Ibf928450dd7affeca9a78842460c364210308de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287810Reviewed-by:
-
Henrique Nakashima authored
Old wording implies only one JAR is analyzed. Bug: 1081840 Change-Id: Id98d2ce6e59d6b0d9e9dde863932f47d14920a21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288629 Auto-Submit: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#786448}
-
Stephen Sigwart authored
Fixes visible selection change when you left click or hold down the left mouse button. Bug: 1101679 Change-Id: Id08534eeabfc9a9a58744d7fa6cb4e7a2ba1a372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285873Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#786447}
-
Matt Reynolds authored
WebMediaPlayerImpl uses a base::CancelableCallback to hold the callback that will receive a routing token for the Android overlay. The callback is canceled if DisableOverlay is called before the token is received. The type of this callback should be media::RoutingTokenCallback which is a base::OnceCallback, so we'll switch to base::CancelableOnceCallback. BUG=1102651 Change-Id: I50845dba9be97f30b86f8ebb71a152457ff3df7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284208Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#786446}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594216727-af10bce0f9b1296f4a0f692869feeccf20c7185e.profdata to chrome-win32-master-1594220267-9b42ec61f1a87a14500dff1ab9da4a37b8c79053.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ib0fcd2365e0e5232a08da3e5c9b356607f10ef9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288469Reviewed-by:
-
Edward Lesmes authored
Bug: 1098927 Change-Id: Ibc9b2571750e5ac9dbb7fbb737790c7584af88f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284370Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#786444}
-
Natalie Chouinard authored
This reverts commit 53f0457f. Reason for revert: Suspected cause of multiple weblayer_instrumentation_test_apk failures on Lollipop Phone Tester https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester Original change's description: > [WebLayer] InstrumentationShellActivity uses UrlBarController. > > This change gets rid of the EditText we were using in > InstrumentationTestActivity for weblayer instrumentation tests and > replaces it with a UrlBarView returned by UrlBarViewController. > > All relevant methods have been updated, and a small UrlBarControllerTest > added to verify expected behavior. > > Bug: None > Test: ./out/<build_dir>/bin/run_weblayer_instrumentation_test_apk > Change-Id: I7b8a54cec34f4b53df2e410ebb9526c943f4edf0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270442 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Mugdha Lakhani <nator@chromium.org> > Cr-Commit-Position: refs/heads/master@{#785731} TBR=jam@chromium.org,boliu@chromium.org,nator@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1103342 Change-Id: I46ff0442bebc4ff50b6ae6ed8a7708ced5678568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288103 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#786443}
-
Steve Kobes authored
Bug: 1007815 Change-Id: I858d9d2cd1b28d213d028350d39c064d2972bdf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285519 Auto-Submit: Steve Kobes <skobes@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#786442}
-
Steve Kobes authored
Bug: 1007815 Change-Id: Idfa01b46b4ada3e968843277124841e70932bc7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285512 Commit-Queue: Eric Roman <eroman@chromium.org> Auto-Submit: Steve Kobes <skobes@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
If we already know the inline-size of the float before placing it, we don't need to make a guess at its position before laying it out. We can just set it right away. This is just an optimization. No behavior changes intended. Bug: 915929 Change-Id: I72ce406ef6b32ff5755522e3375dd93c407ee834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278050Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#786440}
-
Yuheng Huang authored
- Create enable_tab_search build flag - Setup WebUIDataSource for TabSearchUI - Setup resource grid file Bug: 1099917 Change-Id: Ifef42c65d2e485a9f9cb24f6634af41cd7afb48c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268199 Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#786439}
-
Henrique Nakashima authored
Use multiprocess.Pool to spawn CPU# / 2 processes and accelerate generate_json_dependency_graph.py when possible. Based on a single run: Before: real 5m38.769s user 29m9.770s sys 1m38.073s After: real 1m11.504s user 23m35.792s sys 1m5.959s Bug: 1081840 Change-Id: Ib5d1e24c37d1fadeae5df0536c7fd1b20e7a1b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285379 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
-
