- 01 Jul, 2020 40 commits
-
-
Tao Bai authored
Change-Id: Iaa88235408b6dee758ca88d638db40a25f74e2fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276751Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#784457}
-
Dominic Mazzoni authored
Previously we used an enum to select the structure element node type when building a tagged PDF. Update this to set the node type by name (as a string), so that Skia doesn't need to maintain the set of all possible node types. Also, export the appropriate specific type for headings with heading levels where possible, just like in HTML (H1 through H6). This requires plumbing through one additional accessibility attribute from blink_ax_tree_source.cc. Bug: 1100698, 1039816 Change-Id: I8189d6dac41c29cbe8662076b752a9b44901e5c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276580 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#784456}
-
Andreea Bacanu authored
ClosedTabCache aims to make the "Reopen closed tab" button instant for recently closed tabs. Design doc: https://docs.google.com/document/d/1SF230MYWgroe4WikDMn82ETd3-HFRzylKtIk0HZRaOU BUG=1100946 Change-Id: I43934b0fe8b60ca9bbc09f27bbb62b38e33891d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274509Reviewed-by:
Carlos Caballero <carlscab@google.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Commit-Queue: Andreea Bacanu <aebacanu@chromium.org> Cr-Commit-Position: refs/heads/master@{#784455}
-
Jan Wilken Dörrie authored
This change implements the ranges algorithms in alg.move and alg.swap and the unary version of alg.transform. Bug: 1071094 Change-Id: Ia98681bd73702b8800dc6bdc5e37873373e7311d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267080 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#784454}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5638f489af56..ba7cbf76d498 2020-07-01 zepenghu@google.com Add SkSVGCanvas api Fuzzer 2020-07-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 277fb4f3 to 13ebce23 (489 revisions) 2020-07-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 06462adde69b to 2761f01d68a7 (13 revisions) 2020-07-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b3240d0c355a to 2d6b37bbda59 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1091259,chromium:1100613 Tbr: ethannicholas@google.com Test: Test: Test: CQTest: Test: Test: angle_end2end_tests --gtest_filter=*CopyTexImageTestES3.2DArraySubImage*Vulkan*Test: Test: Test: angle_end2end_tests --gtest_filter=*WebGLReadOutsideFramebufferTest.CopyTexSubImage2D*Vulkan* Change-Id: Ic270cc7996ad34bf04a570b23ed80df4a767970d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278002Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784453}
-
Tao Bai authored
The test actually waited for the less events than it should. Autofilling the select control will move the focus on it and trigger additional value change event. Bug: 1069888 Change-Id: Id886e4ae3a6b665d72861ac2b6844db32d3d6451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277179Reviewed-by:
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I80e421a98f13416626d2e92dc13bd8727b422a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277967 Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#784451}
-
Robert Phillips authored
Due to GrContext refactoring on the Skia-side, this call site of SkSurface::MakeRenderTarget (on line 2674) will need to know that GrContext is derived from GrRecordingContext to permit an upcoming Skia roll. Here is the responsible Skia-side CL: https://skia-review.googlesource.com/c/skia/+/299867 (Make SkGpuDevice hold a GrRecordingContext) Change-Id: Ib425d1572f6dc4c8902ff2eb5a4f55c64e7096a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277964Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#784450}
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: Ida29dc452a4add2a8a7eedc7269022769a58a234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277970 Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
Omar Morsi authored
This CL changes how platform keys service expects token IDs from the service consumers and makes it clear what to expect in special cases like empty/unprovided token IDs. Before this CL, platform keys service was accepting token IDs as strings which is not as clear as enums especially for the cases of empty strings. Bug: 1073512 Change-Id: I4cbdfdc8f22b23ce0297314915e52804b2e495f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270069 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#784448}
-
Haiyang Pan authored
This reverts commit 5a04dad7. Reason for revert: Tests crash consistently since the builds https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/1294 https://ci.chromium.org/p/chromium/builders/ci/android-arm64-proguard-rel/2083 And flakily since https://ci.chromium.org/p/chromium/builders/ci/android-pie-arm64-rel/5696 Original change's description: > Download later: Implements lots of things in download later dialog. > > This CL does the following: > > 1. Implements the checkbox. > 2. Implements the edit location text, which triggers location dialog. > 3. Make download later dialog owns a date time picker, so other callers > can share the glue code between later dialog and date time picker. > 4. Lots of tests added, lots of code refactored. > > TBR=dtrainor@chromium.org > > Bug: 1099989,1078454 > Change-Id: I3dd53c0a0694c91789398382c6deb11fbfe8006d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268467 > Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: Hesen Zhang <hesen@chromium.org> > Commit-Queue: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784260} TBR=dtrainor@chromium.org,qinmin@chromium.org,shaktisahu@chromium.org,xingliu@chromium.org,hesen@chromium.org Change-Id: Idd5217d490c209c38a2fc1174d771daa9c877c62 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1099989, 1078454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278124Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#784447}
-
Haiyang Pan authored
This reverts commit b0e78262. Reason for revert: Tests crash consistently since the builds https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/1294 https://ci.chromium.org/p/chromium/builders/ci/android-arm64-proguard-rel/2083 And flakily since https://ci.chromium.org/p/chromium/builders/ci/android-pie-arm64-rel/5696 Original change's description: > Download later: Change the title of the location dialog. > > The location dialog title is changed to "Choose where to download" to > match the download later dialog's "Choose when to download". > > The file size is kept, the text could be "Choose where to download 15Kb" > when the file size is available. > > Also does layout polish to make the title and subtitle to match the > new download later dialog. > > Bug: 1101010,1078454 > Change-Id: I08c4965ca007afa74b5c23e019d615fbb8fcbc81 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276347 > Commit-Queue: Xing Liu <xingliu@chromium.org> > Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Hesen Zhang <hesen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784266} TBR=dtrainor@chromium.org,qinmin@chromium.org,shaktisahu@chromium.org,xingliu@chromium.org,hesen@chromium.org Change-Id: Ic5a474e211c12fe6351a2531e5e647f553532779 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1101010, 1078454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278087Reviewed-by:
-
Sangwoo Ko authored
This is cleanups to make access control of ToolbarButton's subclasses match the superclass. in order to do this, reorder some functions and modify comments. There's no intended behavior change. Bug: 1048901 Change-Id: I2f956cb40042ab9385d1b7e9203988d7c9a377e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275165Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#784445}
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: Ie1c070801057c642961397f02dd31bad2945abdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277969 Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#784444}
-
Saurabh Nijhara authored
As we use std::lround(...) for calculating the number of remaining days from time remaining to reach the deadline, it can result in return value of zero if we are very close to the deadline. In this case, we need to use the last day notification strings (days_remaining = 1). The plural string IDS_UPDATE_REQUIRED_NETWORK_LIMITATION_TITLE_DAYS only has two options i.e. 1 and Other. Bug: 1048607 Change-Id: I60de9aac659503557ccc4ead60a434ae6d5184d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270186Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Maksim Sisov authored
Add a factory method for linux that chooses between the ozone and non-ozone/X11 keyboard hook based on the IsUsingOzonePlatform condition. PS: Ozone misses platform kbd hook implementation. This will be addressed in https://crbug.com/1099225 Bug: 1085700 Change-Id: I0c4845d24c99eb5d4c414acec61515fecac9871d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266474 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#784442}
-
David Roger authored
This is necessary because part of the implementation will use the views system to create a bubble. Bug: 1076880 Change-Id: I801a6d916a9421eaac49a98633723f033d3d999e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274600 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#784441}
-
Yuichiro Hanada authored
When ARC apps receive a key event before IME, a key event which is not consumed by the apps has to be sent to the IME. The new mojo method is added to let the proxy IME ask ArcImeService whether it should send back a key event. Bug: b:148193316 Change-Id: I6bbb83b9b3ab58a11ab5e9c01ce626255871818f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269386Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#784440}
-
Himanshu Jaju authored
Implements mojo interactions b/w utility process and browser process for signaling messenger. IceConfigFetcher will be implemented along with webrtc medium in upcoming CLs. Design doc - go/nearby-chrome-webrtc Master design doc - go/nearby-chrome Bug: 1082305 Change-Id: Ia8cb9f3746f781e1ec941925ddbb46d4d9f6300a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270092 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#784439}
-
Nektarios Paisios authored
In https://crrev.com/c/2237930/ the Blink web test for accessibility word boundaries was removed due to an issue with some, but not all, of the try bots. TBR=dmazzoni@chromium.org, aleventhal@chromium.org AX-Relnotes: n/a. Bug: 1028830 Change-Id: Ib5b05c68203a627f52081a6d423ed50a890f3566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275885Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#784438}
-
Anqing Zhao authored
According to the design spec of the new policy 'Virtual Keyboard Features' (go/pwa-api-key-dd), the keyboard features will be disabled by default in the Web Kiosk session. This is an intended behavior change. For other sessions, the original behaviors will still remain (i.e., enabled by default). In this cl, some browser tests are added to ensure the following sessions are correctly impacted (or not impacted) by the new policy. - Guest session. - Regular session. - Chrome App Kiosk session. - Web Kiosk session. Bug: 1083893 Change-Id: If627ba3126f47a503f7793d1e7f9211b4f471079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276278Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Anqing Zhao <anqing@chromium.org> Cr-Commit-Position: refs/heads/master@{#784437}
-
Lorne Mitchell authored
Reworked system_web_app_manager_unittest.cc tests using the TestWebAppRegistryController. Bug: 1082880,1088399 Change-Id: Ibe566c76b520f0b7d5177059bc0aa847fc20215f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223978Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Lorne Mitchell <lomitch@microsoft.com> Cr-Commit-Position: refs/heads/master@{#784436}
-
Matthias Körber authored
This CL adds heuristic parsing support for two last names as they are often used in Hispanic/Latinx names, and support for a honorific prefixes. Change-Id: I54590dde88886765aba438ceef6a0c9b24519db9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264440 Commit-Queue: Matthias Körber <koerber@google.com> Auto-Submit: Matthias Körber <koerber@google.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#784435}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/8d3f3b7dac48..b112fac0033c 2020-07-01 cepheus@frii.com HLSL: Catch error cases earlier, preventing a later assert. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: I78664361bfb093b1d3569f74ad9e993ee60ebc50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277615Reviewed-by:
-
Oriol Brufau authored
The list-style-type and list-style-image properties can affect the kind of list marker that we have, including its margin. However, what matters are the values on the originating list item, not on the ::marker itself. Right now the difference doesn't matter, since ::marker doesn't accept these properties, and thus must be inherited. But in the future we might remove the restrictions and accept arbitrary properties in ::marker. This patch uses the proper ComputedStyle when resolving margins. Bug: 457718 Change-Id: I41aafb4b0b5778f637af6d74c0f50146a3698be8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263834Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#784433}
-
Robert Sesek authored
Without this, reset()ing a ScopedTypeRef with a temporary ScopedTypeRef results in the receiver storing a dead pointer. This is because the reset(element_type) method causes implicit conversion of argument ScopedTypeRef via |operator element_type()|, with the receiver assuming ownership rather than retaining. As an example, prior to this change, the following snippet would leave |member_| holding a dead pointer: member_.reset(base::ScopedCFTypeRef<CFStringRef>( CFStringCreateCopy(NULL, CFSTR("Use-after-free")))); Bug: 1100258 Change-Id: I528b6b32d0bd4ac1f91978dde39e818bef41cdd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277000 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#784432}
-
Antonio Gomes authored
This is part of the effort to move as much public headers out of the Blink platform topmost public directory (//third_party/blink/public/platform/). CL also removes web_media_stream.h inclusions there were needless (ie the class was not being referenced directly in the file anymore). BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: Icbb15378bf1763b594f001b0604dbf4a5852f176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276215 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#784431}
-
Sophie Chang authored
Bug: 1087123 Change-Id: I7d29b30f7293df52ea5f2690f8daa1bc3f8bbb6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277087Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#784430}
-
Julian Kranz authored
This CL replaces commented fields by explicit field reservations in the NigoriSpecifics message. Change-Id: If7e32c7764c46acba555ecd931989a59691f347a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274630 Commit-Queue: Julian Kranz <kranzj@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#784429}
-
Greg Thompson authored
During startup, the mini_installer attempts to free up disk space left occupied by previous runs of the installer that may have failed to perform their own cleanup. Such freeing shouldn't cross junction points or links or other similar filesystem constructs, since such would not have been created by a previous run. This CL simply skips over any directories that have reparse points -- directories created by the installer should not have any. BUG=1100280 R=waffles@chromium.org Change-Id: I20d874db50bd11faeac8e03522d162abcae095b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276207 Commit-Queue: Greg Thompson <grt@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
-
Mirko Bonadei authored
For some reason the regex was only selecting symbols starting with one ? while there are some Abseil symbols that start with ??. This was discovered by crrev.com/c/2245897. Bug: 1046390 Change-Id: I79e453ef6d30017eb9c078a95aa16e3e949186fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275887 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#784427}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I1c69b0d303b6a87614072c4ca086fb5880c5a285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277614Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/43c639f0906a..f4025c1cd5c2 2020-07-01 xinghua.cao@intel.com Add interface for enabling 16-bit types (#1091) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: If4054f487413d792e96807d1fbe531b83ef347d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277620Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1593582825-995d8e78b6c8ff09ef0a8c1c9fd4830db0669287.profdata to chrome-mac-master-1593604378-7ad12f7ebd4d045f1c25dd8b02b7f9ffca2fcf89.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,jeffyoon@google.com Change-Id: Ie39bb5f5fba4894c3eb2607069a1ad87072ef32a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278004Reviewed-by:
-
François Beaufort authored
This CL removes a comment that is not necessary anymore with https://chromium-review.googlesource.com/c/chromium/src/+/2247820 Bug: 934063 Change-Id: I7aa733f18f399ab7036f083b37134a99b47a8107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274622 Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
-
Michael Ershov authored
Ignore certificates that return error when asked for certificate provisioning specific attribute. The error most likely just means that the certificate doesn't have a value for the attribute. This will be changed later when there is a way to distinguish unset attribute case and other errors. Bug: 1045895 Test: CertProvisioning* Change-Id: Ib4960916f53e50ed6d374085cbd165b8fdcd4c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275879 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:
-
Jeremie Boulic authored
When the files-zip-no-nacl flag is enabled, the cros-disks zip handling is called via mountArchivesInternal_. Zip integration tests still work: browser_tests --gtest_filter=*zipFile* Test: Manually tested on DUT Bug: 912236 Change-Id: I4a5732161f19edd8a10ac5fc4ec280694a1c8415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239775Reviewed-by:
François Degros <fdegros@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#784421}
-
Eugene But authored
Please see crbug.com/1029907 for details. Bug: 1029907 Change-Id: I2dab884278ada0d2532bbb0adb4cf3d71fd7850e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277069 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#784420}
-
Sylvain Defresne authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I8060c8baea8424c9ee999a4db99159320268f0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277726 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#784419}
-
Sylvain Defresne authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: Ic845c9310296d8e6527df7d9d0afa104f526ef61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276262 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
