- 04 Jun, 2019 40 commits
-
-
Etienne Pierre-doray authored
This CL replaces ScopedNestableTaskAllower with kNestableTasksAllowed passed as argument to the RunLoop involved if any. Only native nested loops should use ScopedNestableTaskAllower (soon to be deprecated). For more details, see: https://cs.chromium.org/chromium/src/base/message_loop/message_loop_current.h?sq=package:chromium&dr=CSs&g=0&l=159 A small step towards deleting MessageLoop. This CL was generated with git cl split. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1635819 Please CQ if LGTY! This CL was uploaded by git cl split. R=jam@chromium.org Bug: 766678 Change-Id: Ia1cd4759cde35f80b6ea0a6e5de78f1c91e3744f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635826 Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#665870}
-
Rune Lillesveen authored
Remove the methods from Node and ContainerNode to avoid confusion. This is not fixing 967548, but a part of trying to make sense of the active/hover code to make sure a fix will be sound. Bug: 967548 Change-Id: Ia60a3cda7ec66db63dec2acc939c91ecbfdf24ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641842Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#665869}
-
Kush Sinha authored
Please check the attached bug for context. The screen needs to be: - Frameless (no title bar or 'X' button). - Non-draggable. to conform to other current Chrome OS welcome dialogs. Bug: 968143 Change-Id: Idcd85d37aa1985dd02002674d47996b76f96cc68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642067Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#665868}
-
Yoichi Osato authored
This patch adds the flag that overrides default read buffer size (32k Bytes) for WebSocket. The buffer is the first pool to receive date from network socket. This flag will be used to investigate the performance issue. You can use this flag both on chrome and content_shell: $ ./chrome.exe --websocket-read-buffer-size=3000000 This flag sets the buffer size 300k Bytes. Bug: 865001 Change-Id: I57aeb9e2feb9b249f1265596d6da5524a63f801a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635079Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#665867}
-
Etienne Pierre-doray authored
MessageLoopCurrent::task_runner() is depecated. This CL replaces it with with ThreadTaskRunnerHandle::Get(). A small step towards deleting MessageLoop. This CL was generated with git cl split. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1631693 Please CQ if LGTY! This CL was uploaded by git cl split. R=jam@chromium.org Bug: 616447 Change-Id: Ib72f68278cfd05901c1a69c612feb5415485dae8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636059 Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4b1386c027fe..4976a2236cd3 Created with: gclient setdep -r src-internal@4976a2236cd3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=harringtond@google.com,orphis@google.com,shend@google.com Change-Id: I0dad24532c7de77b9b151880cf0bf13094cc9763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643149Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665865}
-
Yi Su authored
This CL moves CRWWebController.pageTransitionFromNavigationType into CRWWKNavigationHandler. Bug: 956511 Change-Id: I7b9a9d906af0827569190aa4c7e3a391c3aac963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639381Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#665864}
-
Sylvain Defresne authored
Uses of base::Callback<...> is deprecated in favor of either base::OnceCallback<...> or base::RepeatingCallback<...> (the former is preferred if possible). This is part 6 of a multi-CL refactoring and does: - use PostTaskAndReplyWithResult in HistoryService::GetVisibleVisitCountToHost thus removing a naked "new" and the use of base::Unretained and base::Owned to pass the value to both callbacks - change GetVisibleVisitCountToHostCallback callback to be invoked with VisibleVisitCountToHostResult passed by value instead as a const pointer thus allowing to remove an helper function - change GetVisibleVisitCountToHostCallback to a base::OnceCallback<...> - change HistoryBackend::GetVisibleVisitCountToHost to return the result by value instead of via an out parameter Bug: 812523, 714018 Change-Id: Ib6906436103d0014d523b5e4e6dc86fcb8e34d08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632152 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#665863}
-
Vasilii Sukhanov authored
PasswordManagerDriver::GeneratedPasswordAccepted is called directly by the pop- up. The CL changes the call to go through PasswordGenerationState. In the next CLs the class will perform disambiguation step before telling the renderer to fill the generated password. Bug: 936011 Change-Id: I5e38476dcd22384440feafe69b47179ef3a67628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631281 Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#665862}
-
Ian Kilpatrick authored
This makes style_ member within LayoutObject const! There is one const_cast added within: Node::MutableComputedStyleForEditingDeprecated This method is used within the editing codebase which is non-trivial to remove at the moment. Bug: 813068 Change-Id: Ia248932c8789d7405ec64a5fd2c86b701cb37d35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636554 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#665861}
-
arthursonzogni authored
Navigation to MHTML document needs to be tested. There are some blink web tests, but no real browser tests. This adds the NavigationMhtmlBrowserTest set of tests. It contains an helper class to quickly build and use MHTML archives easily in tests. New tests: + NavigationMhtmlBrowserTest.IframeFound + NavigationMhtmlBrowserTest.IframeNotFound + NavigationMhtmlBrowserTest.IframeDataUrlNotFound + NavigationMhtmlBrowserTest.IframeDataUrlFound + NavigationMhtmlBrowserTest.IframeAboutSrcDocFound + NavigationMhtmlBrowserTest.IframeAboutSrcDocNotFound + NavigationMhtmlBrowserTest.IframeAboutBlankFound + NavigationMhtmlBrowserTest.IframeAboutBlankNotFound + NavigationMhtmlBrowserTest.IframeJavascriptUrlFound + NavigationMhtmlBrowserTest.IframeJavascriptUrlNotFound + NavigationMhtmlBrowserTest.IframeContentIdUrlFound + NavigationMhtmlBrowserTest.IframeContentIdUrlNotFound Some weird expectations have been found, but not investigated yet. The test NavigationMhtmlBrowserTest.IframeDataUrl is not enabled, because it reaches a DCHECK. See https://crbug.com/967307. It needs to be fixed in a follow up. The main goal for this CL is to prepare for: https://chromium-review.googlesource.com/c/chromium/src/+/1547521 New tests will make us a bit more confident. Bug: 967307, 936696 Change-Id: I71cee7a4377467126f10b22b9d828f539045e102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631399 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#665860}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cd6e781b..d7092831 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie1b22f6d30b8e2d2a73669327787b21083669fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643288Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665859}
-
Henrique Ferreiro authored
This was missing from https://codereview.chromium.org/964553002. Bug: 260022, 350202 Change-Id: I4198ddb70195d70f9307638d6def291022a1b2ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636198Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#665858}
-
Yannic Bonenberger authored
There seems to be only one use of base::LazyInstance in service worker code. This CL replace this usage with base::NoDestructor. i.e. No intended behaviour change from this CL. Bug: 925323 Change-Id: I9fde0fb162b61758cb03305f03c62f8b781361ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640097 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Yannic Bonenberger <contact@yannic-bonenberger.com> Reviewed-by:
-
Tsuyoshi Horo authored
Bug: 935267 Change-Id: I7cbd3a0a6beb08fa4896aee1fba6b648c8d72c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640744Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
-
A Olsen authored
Change-Id: Ieb0a28cfd4aaa4cb9f3652e03aca89f4004837b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624336Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#665855}
-
Victor Hugo Vianna Silva authored
An icon found during the first local lookup in FaviconRequestHandler may originally come from the favicon server, so we need to update its timestamp in the database, for eviction purposes. Change-Id: I1fbeff5e9d1e0e5da45cac289d1e1bb7c5d6b2ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640647 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#665854}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=chfremer@chromium.org Change-Id: I01fd29d9d4152fd6f993d5071f16d167b5107d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635813Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#665853}
-
Florent Castelli authored
This reverts commit 12cce4ec. Reason for revert: browser_tests failing on chromium.memory/Linux CFI Bug: 970158 Original change's description: > Disable install event.prompt() after user has already installed the site > > Before this CL we would only disable prompt() if the user installs the site > via the menu or the web app banner. This updates the web app omnibox install > button to also disable prompt() from being called. > Without disabling prompt() the site can re-prompt the user to install > which results in the browser crashing. > > Note: This CL is a "quick fix" to resolve the browser crash in a mergeable > CL. A set of follow up CLs will change AppBannerManager to listen to web app > install events and clear the prompt() handle that way instead. > > Bug: 956810 > Change-Id: I2e731f35346b3b77bcac2a1018b8ddab5310847b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640742 > Auto-Submit: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665762} TBR=msw@chromium.org,alancutter@chromium.org,dominickn@chromium.org Change-Id: Ib27616b14d6b669f0998f531b59f2dcff42cb612 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 956810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642633Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#665852}
-
jdoerrie authored
This change implements C++17's std::map::insert_or_assign and std::map::try_emplace as free standing functions. Bug: 752720 Change-Id: Ic74997465503b589cdf10f346289ee4f312140f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631650 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#665851}
-
Julie Jeongeun Kim authored
This CL is a precursor CL to moving WebApplicationCacheHostImpl to loader. It renames RendererWebApplicationCacheHostImpl to ApplicationCacheHostForFrame in order to mirror ApplicationCacheHostForSharedWorker and prepare merging WebApplicationCacheHost into ApplicationCacheHost. Bug: 950159 Change-Id: I31928152f6a58de93d5b6264676cbfc64b1b3de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642848Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#665850}
-
Henrique Ferreiro authored
These were missing from https://crrev.com/c/1486337. Bug: 796544 Change-Id: Ib9fcf8a49a88f3351c49fe67a922dac0c7b9d8f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635521Reviewed-by:
-
Kamila authored
Change-Id: I413da11c398066f6be545660afe5512abde16fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639386Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@google.com> Cr-Commit-Position: refs/heads/master@{#665848}
-
Edward Jung authored
Allows these Web UI interstitials to respond to OS level theme preferences. Bug: 934901,947840 Change-Id: Ibb6f6c58ca9938cd2539900458007eb7b0e25cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634883Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#665847}
-
Victor Hugo Vianna Silva authored
Bug: 955475 Change-Id: I8a393c33dabe8a974acee4cf27acdc7f8a08c4d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634695Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Auto-Submit: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#665846}
-
Hugo Holgersson authored
When two candidates are equally close to our current focus F, SpatNav now prioritizes the candidate that can "absorb" most of F's horizontal or vertical projection. The spec calls this "projected overlap" [1]. When a document is focused (or when activeElement is null), SpatNav projects the document's edge onto each candidate. More generally, when looking inside (and outside) any focused box, we project the box's _edge_ onto each candidate. Note: The current spec [1] suggests us to remove |navigation_axis_distance| from the formula but if we do, snav-symmetrically-positioned.html will fail. So let's keep it until we find a simpler/more robust formula that can handle this pattern. [1] https://drafts.csswg.org/css-nav-1/ Bug: 958845 Change-Id: Id90bce78c9e9d985e6936716b8dafce883b07540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594724Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Hugo Holgersson <hholgersson@fb.com> Cr-Commit-Position: refs/heads/master@{#665845}
-
Alexander Hendrich authored
This CL adds a new device policy to whitelist certain USB devices for certain urls in order to be used by the WebUSB API. We already have a user policy for that, so this device policy reuses the existing user policy's infrastructure. Bug: 968373, 854329 Change-Id: I21a80f0b6557a1270a8fd6243f07e2fc8682004a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636350 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#665844}
-
Maksim Sisov authored
Previously, unittests for the buffer manager exercised only the host part. Now, they are also exercising the buffer manager gpu part and reinitialization of the mojo connection between the gpu and host. Bug: 969608 Change-Id: I07af295d5a75ba6cf3f73caa7a74e3e6ec24f180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640538 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#665843}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/7b275a5af161..e13c1f46dc1a git log 7b275a5af161..e13c1f46dc1a --date=short --no-merges --format='%ad %ae %s' 2019-06-01 apodtele@gmail.com Solidify VC2005 builds. Created with: gclient setdep -r src/third_party/freetype/src@e13c1f46dc1a The AutoRoll server is located here: https://autoroll.skia.org/r/freetype-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com Change-Id: I514a69db3efb9c1462a5d9afa4bece25205eb72f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641212Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#665842}
-
Mathias Carlen authored
Before this patch the terms section was always shown. There are occasions where that section does not make sense. This patch introduces a new flag to hide the T&C section altogether. Bug: b/134096141 Change-Id: I83dd88f35151934ad4c8c4b8e276582024294441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640991 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#665841}
-
Carlos IL authored
Bug: 967750 Change-Id: Ic02e70a59aec016fe204deb09fac8d95daf2858c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631672 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#665840}
-
David Jean authored
Bug: 968114, 968115 Change-Id: Id7911c21f1609839994b742f38bac0eb6cea0864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640540Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#665839}
-
Max Morin authored
Bug: 965235 Change-Id: I9a172d2d549ed459f85b23133d7e046e01cefdec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630158 Auto-Submit: Max Morin <maxmorin@chromium.org> Reviewed-by:
-
David Tseng authored
1. the <input> for this preference was actually missing. 2. when enabled, we should also dump the output log to the console Change-Id: I7852dc3dcc6ef8b8164d4e74e1483e1664bd049d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639326Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Auto-Submit: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#665837}
-
Maksim Sisov authored
Previously, the manager had been rerouting calls to GpuMainThread to make mojo calls. That thread is not really meant for IPC. Instead, make calls on IOChildThread for consistency. Bug: 969603 Change-Id: I351768c4a36973bd791c02c1f65080c65b9a0a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640398 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#665836}
-
François Degros authored
Bug: 778674 Change-Id: If24284710325335dc9a33d61773fbf69a9167cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642435 Auto-Submit: François Degros <fdegros@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#665835}
-
Alexey Baskakov authored
Fix error handling if WebContents gets closed/destroyed or a blink renderer process dies. Drive-by: Avoid posting caller's callback to ThreadTaskRunnerHandle, let's PostTask with weak |this| and call the callback via std::move(calback) instead. Typically, an owner owns WebAppDataRetriever and posts Unretained |this| pointer for data retrieval completion. Bug: 901226 Change-Id: I3ed1928ae3acb0f5c89f62b7bfbe3772689ff7a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637016Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#665834}
-
Maksim Sisov authored
Currently, WaylandWindow may attach a null buffer to a surface, which makes the Wayland compositor skip the buffer release call even though there was a buffer attached. The skipped buffer release call results in a missed submission callback, and the Chromium display compositor starts to lag behind one frame. What is more, we no longer trigger a buffer swap completion callback before presention feedback is provided, which also results in DCHECK when checking the order of the callbacks. Bug: 968497 Change-Id: I12494e78fa376d6c421b7366d0bddb52ae59a5af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636354 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
-
Darren Shen authored
Causing failures on mac. TBR=hayato@chromium.org Bug: 970135 Change-Id: Ib8b96084ad5bfee19cabbe011524c7fa8419bf46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642611Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#665832}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8893ef1b..cd6e781b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia67adbc2d4e83d086c129a8eecc5237dde7eeee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643048Reviewed-by:
-
