GitLab

This fixes the component=shared_library build on Chrome OS.

BUG=none
TEST=cros chrome-sdk --board=link
  GYP_DEFINES="$GYP_DEFINES component=shared_library" gclient runhooks
  ninja -C out_link/Release chrome chrome_sandbox

Review URL: https://codereview.chromium.org/1136123004

Cr-Commit-Position: refs/heads/master@{#329354}

It wasn't quite wide enough.

TBR=jyasskin@chromium.org
BUG=480750

Review URL: https://codereview.chromium.org/1135563006

Cr-Commit-Position: refs/heads/master@{#329353}

Revert of Be explicit about forcing TouchSelectionController updates (patchset #2 id:20001 of https://codereview.chromium.org/1127383007/)

Reason for revert:
This has caused failures on the memory bots. e.g.:http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/6179

Sample test output:
[ RUN      ] TouchSelectionControllerTest.AllowShowingFromCurrentSelection
==6485== WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x7f5bc93bb605 in ui::TouchSelectionController::OnSelectionBoundsChanged(ui::SelectionBound const&, ui::SelectionBound const&) ui/touch_selection/touch_selection_controller.cc:71:27
    #1 0x7f5bc922803a in ui::TouchSelectionControllerTest::ChangeSelection(gfx::RectF const&, bool, gfx::RectF const&, bool) ui/touch_selection/touch_selection_controller_unittest.cc:147:5
    #2 0x7f5bc9278c8d in ui::TouchSelectionControllerTest_AllowShowingFromCurrentSelection_Test::TestBody() ui/touch_selection/touch_selection_controller_unittest.cc:946:3
    #3 0x7f5bc93631dc in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2420:12
    #4 0x7f5bc93631dc in testing::Test::Run() testing/gtest/src/gtest.cc:2436:0
    #5 0x7f5bc9365a4c in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2612:5
    #6 0x7f5bc93673f6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2730:5
    #7 0x7f5bc9384d03 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4602:11
    #8 0x7f5bc9383ce2 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2420:12
    #9 0x7f5bc9383ce2 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4220:0
    #10 0x7f5bc93078a3 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2326:10
    #11 0x7f5bc93078a3 in base::TestSuite::Run() base/test/test_suite.cc:228:0
    #12 0x7f5bc92f7b2d in (anonymous namespace)::RunTestSuite(int, char**) base/test/run_all_unittests.cc:25:10
    #13 0x7f5bc92f85ee in Run base/callback.h:396:12
    #14 0x7f5bc92f85ee in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:184:0
    #15 0x7f5bc92f7f5b in base::LaunchUnitTests(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:423:10
    #16 0x7f5bc92f792d in main base/test/run_all_unittests.cc:37:10
    #17 0x7f5bc206a76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226:0
    #18 0x7f5bc9188f38 in _start ??:0:0

  Uninitialized value was created by a heap allocation
    #0 0x7f5bc91da0e2 in operator new(unsigned long) ??:0:0
    #1 0x7f5bc927c95c in ui::TouchSelectionControllerTest::SetUp() ui/touch_selection/touch_selection_controller_unittest.cc:65:23
    #2 0x7f5bc9362f57 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2420:12
    #3 0x7f5bc9362f57 in testing::Test::Run() testing/gtest/src/gtest.cc:2432:0
    #4 0x7f5bc9365a4c in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2612:5
    #5 0x7f5bc93673f6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2730:5
    #6 0x7f5bc9384d03 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4602:11
    #7 0x7f5bc9383ce2 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2420:12
    #8 0x7f5bc9383ce2 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4220:0
    #9 0x7f5bc93078a3 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2326:10
    #10 0x7f5bc93078a3 in base::TestSuite::Run() base/test/test_suite.cc:228:0
    #11 0x7f5bc92f7b2d in (anonymous namespace)::RunTestSuite(int, char**) base/test/run_all_unittests.cc:25:10
    #12 0x7f5bc92f85ee in Run base/callback.h:396:12
    #13 0x7f5bc92f85ee in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:184:0
    #14 0x7f5bc92f7f5b in base::LaunchUnitTests(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:423:10
    #15 0x7f5bc92f792d in main base/test/run_all_unittests.cc:37:10
    #16 0x7f5bc206a76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226:0

SUMMARY: MemorySanitizer: use-of-uninitialized-value (/mnt/data/b/build/slave/Linux_MSan_Tests/build/src/out/Release/ui_touch_selection_unittests+0x285605)
Exiting

Original issue's description:
> Be explicit about forcing TouchSelectionController updates
>
> Previously, cached values in the TouchSelectionController would be reset
> to force future selection updates. However, these cached values can
> actually be used outside of selection update calls, e.g., when force
> showing the selection from the current cached values. Instead of
> resetting the cached values, simply set a dirty bit that forces an
> update, avoiding issues when dealing with the reset values.
>
> BUG=393025
>
> Committed: https://crrev.com/fdcf817da49ee92fe191981f7525503444f75f83
> Cr-Commit-Position: refs/heads/master@{#329325}

TBR=mohsen@chromium.org,jdduke@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=393025

Review URL: https://codereview.chromium.org/1139533006

Cr-Commit-Position: refs/heads/master@{#329352}

BUG=451917
TEST=DriveApiRequestsTest.BatchUploadRequestProgress

Review URL: https://codereview.chromium.org/1130183003

Cr-Commit-Position: refs/heads/master@{#329351}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0c327f6..bedb2c7

TBR=yosin@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/1131413005

Cr-Commit-Position: refs/heads/master@{#329350}

This change prevents any *.googlezip.net Data Reduction Proxy from being
configured as part of the ProxyService's ProxyConfig via the
proxy pref.

Specifying a DRP in the proxy rules is not a supported means of
activating the DRP, and could cause requests to be sent to the DRP
without the appropriate authentication headers and without using any of
the DRP bypass logic.

This is a fix for http://crbug.com/476610, to be merged into M43.

BUG=476610

Review URL: https://codereview.chromium.org/1126413006

Cr-Commit-Position: refs/heads/master@{#329349}

Revert of [Chromecast] Ignore interfaces not used to connect to internet. (patchset #1 id:1 of https://codereview.chromium.org/1137483004/)

Reason for revert:
broke the Android builds. Not sure how "cast_shell_android" passed, actually.

Original issue's description:
> [Chromecast] Ignore interfaces not used to connect to internet.
>
> Add NetworkChangeNotifierFactoryCast to create instance of
> NetworkChangeNotifierLinux that ignores interfaces that will not be
> used to connect to internet.
>
> BUG=469863
> R=gunsch@chromium.org,byungchul@chromium.org,wzhong@chromium.org
>
> Committed: https://crrev.com/561d7adb5ec842c5e56ece4524d0e486691ca614
> Cr-Commit-Position: refs/heads/master@{#329319}

TBR=byungchul@chromium.org,wzhong@chromium.org,derekjchow@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=469863

Review URL: https://codereview.chromium.org/1141503002

Cr-Commit-Position: refs/heads/master@{#329348}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/1107e90..06f3647

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/1127353003

Cr-Commit-Position: refs/heads/master@{#329347}

BUG=483716
TEST=manually

Review URL: https://codereview.chromium.org/1140653003

Cr-Commit-Position: refs/heads/master@{#329346}

BUG=486194

Review URL: https://codereview.chromium.org/1137993002

Cr-Commit-Position: refs/heads/master@{#329345}

We recently introduced SchemeIsCryptographic() and IsOriginSecure(),
which are meant to replace SchemeIsSecure().

IsOriginSecure() roughly means "do we trust this content not to be
tampered with before it reaches the user?" [1] This is a higher-level
definition that corresponds to the new "privileged contexts" spec. [2]

SchemeIsCryptographic() [3] is close to the old definition of
SchemeIsSecure(), and literally just checks if the scheme is a
cryptographic scheme (HTTPS or WSS as of right now). The difference is
that SchemeIsCryptographic() will not consider filesystem URLs secure.

[1] https://code.google.com/p/chromium/codesearch#chromium/src/content/public/common/origin_util.h&sq=package:chromium&type=cs&l=19&rcl=143099866
[2] https://www.chromium.org/Home/chromium-security/prefer-secure-origins-for-powerful-new-features and https://w3c.github.io/webappsec/specs/powerfulfeatures/
[3] https://code.google.com/p/chromium/codesearch#chromium/src/url/gurl.h&sq=package:chromium&type=cs&l=250&rcl=1430998666

BUG=362214

Review URL: https://codereview.chromium.org/1131993005

Cr-Commit-Position: refs/heads/master@{#329344}

Previously, all Webstore results had an internal relevance score of 0.0.
Now they are scored based on the query matched against the app's title,
and scores of 0.0 are discarded. This fixes app results showing up
because the word you typed appears in the app's web store description,
but not its title.

BUG=481837

Review URL: https://codereview.chromium.org/1110903002

Cr-Commit-Position: refs/heads/master@{#329343}

- Use core-toolbar for header.
- Change close button div to a paper-icon-button.
- Remove close-gray.png and close-gray2x.png.
- Remove unneeded CSS, modifies some positioning.

Review URL: https://codereview.chromium.org/1134463008

Cr-Commit-Position: refs/heads/master@{#329342}

TBR=kpschoedel@chromium.org
BUG=487056

Review URL: https://codereview.chromium.org/1128253007

Cr-Commit-Position: refs/heads/master@{#329341}

Tested on Linux with the following command lines:

$ gn gen out-gn/Debug
$ ninja -C out-gn/Debug :blink_tests

Tested on Android with the following command lines:

$ gn gen out-gn-android/Debug --args='symbol_level=1 is_debug=true target_os="android" target_cpu="arm"'
$ ninja -C out-gn-android/Debug :blink_tests

BUG=483171
TEST=see above
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1118863002

Cr-Commit-Position: refs/heads/master@{#329340}

Due to Issue 398271 , we are disabling OOBE demo on test image, which makes it
hard to test OOBE demo. We can relax the condition, so that it does not skip
when derelict related switches are specified.

BUG=485471
TEST=None

Review URL: https://codereview.chromium.org/1130173002

Cr-Commit-Position: refs/heads/master@{#329339}

The reasons for adding such interfaces:
- There'll be code in src/mandoline that creates an http server which enables
communication between html_viewer/mandoline ui and external applications. One
use case is to support telemetry.

- We would like to use the C++ http server and websocket impl in net/, and don't
want to link net/ into anything other than the network service.

BUG=478249
TEST=None

Review URL: https://codereview.chromium.org/1136773002

Cr-Commit-Position: refs/heads/master@{#329338}

The main RenderFrame object for a page is currently owned directly
through a scoped_ptr by RenderViewImpl. Since we want the main
RenderFrame to be deleted when we do a cross-process navigation,
it needs to be cleaned by as part of the regular callbacks from
Blink - WebFrameClient::frameDetached. This requires the frame to not
be owned by RenderViewImpl, so this CL changes it from scoped_ptr
to raw pointer.

The only change in behavior after this CL is that the RenderFrame
will be destroyed prior to RenderView being destroyed as part of
WebView::close(). The destruction of both objects still stays in
the same task on the event loop, though.

BUG=357747

Review URL: https://codereview.chromium.org/1130233002

Cr-Commit-Position: refs/heads/master@{#329337}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/8e5c177..1107e90

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/1129023004

Cr-Commit-Position: refs/heads/master@{#329336}

Cr-Commit-Position: refs/heads/master@{#329335}

Start tracking libvpx master again:
https://codereview.chromium.org/1124333011

R=tomfinegan@chromium.org

Review URL: https://codereview.chromium.org/1129893007

Cr-Commit-Position: refs/heads/master@{#329334}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/60d9c66..0c327f6

TBR=yosin@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/1135083003

Cr-Commit-Position: refs/heads/master@{#329333}

This video is 10 seconds of SMPTE color bars.
The load on the vp9 decoder is relatively low, in this way we can better
measure the load on the compositor.

The video has been generated using libavfilter.
BUG=

Review URL: https://codereview.chromium.org/1083073003

Cr-Commit-Position: refs/heads/master@{#329332}

This updates to the following revision: 45547d19c355
(2015-05-07 05:08 -0700)

It includes changes from revision 4f90008545e0
(2015-04-02 03:34 -0400) to revision 45547d19c355
(2015-05-07 05:08 -0700), listed at
http://hg.mozilla.org/mozilla-central/log/45547d19c355/netwerk/dns/effective_tld_names.dat

R=pkasting@chromium.org
BUG=37436

Review URL: https://codereview.chromium.org/1133773006

Cr-Commit-Position: refs/heads/master@{#329331}

We need to use quotaBytesUsedAggregate to know the actual available space, because the current quotaBytesUsed returns usage in only Google Drive (doesn't include Gmail, G+ Photos, etc...).
https://developers.google.com/drive/v2/reference/about#resource

BUG=483058
TEST=run unit_tests

Review URL: https://codereview.chromium.org/1125123008

Cr-Commit-Position: refs/heads/master@{#329330}

This passes the value of |use_video_overlay_for_embedded_encrypted_video| from RendererPreferences to requestMediaKeySystemAccess() so that it can correctly block either non-hardware-secure codecs or hardware-secure codecs.

BUG=467779

Review URL: https://codereview.chromium.org/1124863005

Cr-Commit-Position: refs/heads/master@{#329329}

This picks up the following change:

  22d6ca18 GN: Don't generate phony rules called "all".

TBR=brettw@chromium.org
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel;tryserver.chromium.win:win8_chromium_gn_rel

Review URL: https://codereview.chromium.org/1141483002

Cr-Commit-Position: refs/heads/master@{#329328}

Record whether a query is pending and use it to decide when to wait
(previously, it would wait if ANY previous query was ever pending, which
"just happened" to work for the specific test cases).

Changed some ASSERT into EXPECT.

Use more descriptive special strings for HTTP errors, rather than the
exact same string as the query, which is confusing.

Document the test cases properly.

Reformat the source according to ClangFormat.

BUG=481837

Review URL: https://codereview.chromium.org/1133543003

Cr-Commit-Position: refs/heads/master@{#329327}

Review URL: https://codereview.chromium.org/1129153003

Cr-Commit-Position: refs/heads/master@{#329326}

Previously, cached values in the TouchSelectionController would be reset
to force future selection updates. However, these cached values can
actually be used outside of selection update calls, e.g., when force
showing the selection from the current cached values. Instead of
resetting the cached values, simply set a dirty bit that forces an
update, avoiding issues when dealing with the reset values.

BUG=393025

Review URL: https://codereview.chromium.org/1127383007

Cr-Commit-Position: refs/heads/master@{#329325}

We want to use the same color between Chrome and an external activity in
GMS core, and we can launch this activity with a custom color, so this change
makes the color accessible in both places.

BUG=480598

Review URL: https://codereview.chromium.org/1136953008

Cr-Commit-Position: refs/heads/master@{#329324}

TBR=mgiuca@chromium.org
BUG=396499, 483615

Review URL: https://codereview.chromium.org/1137073004

Cr-Commit-Position: refs/heads/master@{#329323}

The current threadtime timeline measurement only supports per-frame
metrics. Generalize this to support total and per-second  metrics for
threadtimes and tasks.

BUG=466213
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Review URL: https://codereview.chromium.org/1084533005

Cr-Commit-Position: refs/heads/master@{#329322}

$ git log f222001cc..b39a448d8 --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//'
2015-05-11 maruel Fix crash when exit_code=='N/A'.
2015-05-04 maruel Handle SIGTERM while uploading results back.
2015-04-27 phajdan.jr Don't use parent of root_dir as temp directory
2015-04-22 maruel Trap TypeError in collect when trigger had failed.

R=vadimsh@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1131013003

Cr-Commit-Position: refs/heads/master@{#329321}

This patch includes the correct GN changes.

This CL does the following:
* Fixes the component build
* Limits the length of LogEntry strings
* Cleans up the code a little to help with crash debugging

BUG=479095
For device_event_log gypi:
TBR=reillyg@chromium.org

Review URL: https://codereview.chromium.org/1140643002

Cr-Commit-Position: refs/heads/master@{#329320}

Add NetworkChangeNotifierFactoryCast to create instance of
NetworkChangeNotifierLinux that ignores interfaces that will not be
used to connect to internet.

BUG=469863
R=gunsch@chromium.org,byungchul@chromium.org,wzhong@chromium.org

Review URL: https://codereview.chromium.org/1137483004

Cr-Commit-Position: refs/heads/master@{#329319}

Move priority and is_occluded from Tile to new PrioritizedTile class.

Logged https://code.google.com/p/chromium/issues/detail?id=485705 for the traceviewer change

BUG=483293

Review URL: https://codereview.chromium.org/1130123003

Cr-Commit-Position: refs/heads/master@{#329318}

The following TODO existed in mime_sniffer.cc since 2008:

// TODO(abarth): we don't handle partial byte matches yet
// MAGIC_NUMBER("video/mpeg", "\x00\x00\x01\xB")
// MAGIC_NUMBER("audio/mpeg", "\xFF\xE")
// MAGIC_NUMBER("audio/mpeg", "\xFF\xF")

video/mpeg is not sniffed by Firefox or IE, and is not required to be sniffed by the spec at https://mimesniff.spec.whatwg.org/.

audio/mpeg is already sniffed for the common case where the file starts with an ID3 tag. The uncommon case where it starts with "\xFF\xF." is too broad (it matches the little-endian UTF-16 byte-order-mark), and is not required by the spec.

Remove the TODO.

TEST=net_unittests
BUG=

Review URL: https://codereview.chromium.org/1138483004

Cr-Commit-Position: refs/heads/master@{#329317}

This CL renames the section in the manifest, so it's more meaningful.

TEST=Refactoring only.
BUG=474146

Review URL: https://codereview.chromium.org/1137813003

Cr-Commit-Position: refs/heads/master@{#329316}

PaintRecorder needs to present a gfx::Canvas instead of an SkCanvas.
Currently it does so via CreateCanvasWithoutScaling which returns
a new Canvas allocated on the heap. But mallocs are terrible, so
instead make it a constructor and have the canvas allocated as part
of ui::PaintRecorder on the stack.

This changes the time to record a single tab loading spinner from
0.138818 ms to 0.124487 ms per frame for a 10% reduction in time.

R=sky
BUG=466426

Review URL: https://codereview.chromium.org/1124223010

Cr-Commit-Position: refs/heads/master@{#329315}