Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 05 Mar, 2020 4 commits
    • Pavol Marko's avatar
      Bump expiry of auto-enrollment histograms · 85d0fd9f
      Pavol Marko authored 
      The feature is being used for packaged licenses and maybe also for
initial enrollment soon, so the histograms are still interesting.

Bug: 1053198, 1053197, 1053196, 1053195, 1053194
Change-Id: I6a1857c08e0150491b3511b7740d04f5174a662b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078912
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747013}
      85d0fd9f
    • Daniel Clark's avatar
      Reland "Fix null check preventing AXObjectCacheImpl from registering as popup... · 1b445276
      Daniel Clark authored 
      Reland "Fix null check preventing AXObjectCacheImpl from registering as popup document lifecycle observer"

The change was reverted because a couple of the updated tests were failing
on older mac platforms.  Apparently opening the date/week popops fires
different numbers of events on these platforms.  Since the point of
the tests is to observe events fired from focus changes in an opened
popup, I changed the tests to start logging events only after opening
the popup.  I've also modified them to provide some logging in the event
of a failure instead of just timing out opaquely.

Initial change description follows:

Fix the polarity on a couple of null checks that were preventing
AXObjectCacheImpl from registering as a lifecycle notification observer
for popup documents.  This failure to register was preventing AX focus
events from being fired when focus changed inside of a popup.

The week-picker-ax.html test was passing prematurely because of focus
events received when opening the popup, without validating that
additional events were fired when changing focus in the popup.  Update
that test to confirm that events are also fired for a focus change in
the popup itself.

There were a couple of analogous tests (date-picker-ax.html,
month-picker.html) that were deleted when we purged old date popup tests
in favor of new tests written for the new popup implementation
(crrev.com/c/1967608).  I don't see replacements for these in the new
tests, so this change also restores those tests, updates them for
the structure of the new form controls, and ensures that they are
checking that focus events are fired due to changes in the popups and
not just from events fired when the popups open.

TBR=aboxhall@chromium.org

Bug: 1022920, 1057036, 1057044
Change-Id: I8792ea074e89967c7ff68e21dfda8e0f6ba6f9a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080459
Commit-Queue: Dan Clark <daniec@microsoft.com>
Reviewed-by: default avatarMason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747012}
      1b445276
    • Jae Hoon Kim's avatar
      DlcserviceClient handles busy dlcservice · 3d2082c2
      Jae Hoon Kim authored 
      DlcserviceClient should make the life of callers as easy as possible.
Since dlcservice returns a busy status:
 - when a platform side dlcservice client starts an installation.
 - when update_engine is busy performing actions.

This change allows callers in Chrome to not worry about the busy status.

BUG=chromium:1053745
TEST=out/Default/unit_tests --gtest_filter=Dlcservice*

Change-Id: Iae6a75567345c3615662dddde2479141ab80098a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079213Reviewed-by: default avatarSteven Bennetts <stevenjb@chromium.org>
Commit-Queue: Jae Hoon Kim <kimjae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747011}
      3d2082c2
    • Richard Townsend's avatar
      build: add support for armasm64.exe · 548858d9
      Richard Townsend authored 
      armasm64.exe is Microsoft's reference compiler for 64-bit Arm assembly code.
This is needed to make sure that V8 can be tested and cross-compiled
under MSVC for Windows on Arm systems.

Bug: v8:10012
Change-Id: Id1b9ab7bb0cc96179a707e9746f9e78e8da30de9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071941
Commit-Queue: Richard Townsend <richard.townsend@arm.com>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Auto-Submit: Richard Townsend <richard.townsend@arm.com>
Reviewed-by: default avatarBruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747010}
      548858d9
  3. 04 Mar, 2020 36 commits