- 17 Sep, 2019 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c1c6284cd11f..4a822f4b3c64 git log c1c6284cd11f..4a822f4b3c64 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2e4ccff8..dbd15694 (696956:697157) 2019-09-17 danilchap@webrtc.org In TaskQueueTest::PostDelayedAfterDesctruct increase timeout Created with: gclient setdep -r src/third_party/webrtc@4a822f4b3c64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:1000531 Change-Id: I8734d8e8efbb8ef949237b8ac94c1bff0bfdff27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809240Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697191}
-
Denis Solonkov authored
We can't expect that the test array would be put in the same place in memory between test runs and since [l, r) is being rounded to the page size. Due to that we can't make any assumptions about the elements inside of the final range and can't calculate the resulting sum, since all elements inside of the range are zeroed. The tests were modified the following way: 1) All zeroes in the test array were replaced by one to be able to locate all zeroed elements in it. 2) GetSum method was replaced by GetZeroes method which is expected to return 4096. 3) The size of the array was set to 2*4096 - 1 to prevent unlikely case of array aligning perfectly on memory and having 2 pages cut out of it. Bug: 998082 Change-Id: Idde87569decd3a52ecd1a0c034ab638833d8e0b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795791 Commit-Queue: Denis Solonkov <solonkovda@google.com> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#697190}
-
Jan Wilken Dörrie authored
The checked iterators model the RandomAccessIterator concept, however they did not implement operator>, operator>= and operator[], which are part of the concept requirements [1]. This change adds implementations of these operators and adds appropriate tests. [1] https://en.cppreference.com/w/cpp/named_req/RandomAccessIterator#Requirements Bug: 817982, 828324 Change-Id: I14d80a412a9071c5ba50c57114ffec794cde9f07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807195Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#697189}
-
Thomas Tangl authored
Screenshot before: https://drive.google.com/file/d/1vuvx8gWWX-f2Tb01QmorWg3EGJpP9VU6/view?usp=sharing Screenshot after: https://drive.google.com/file/d/12i0Dw3h82IjPTU4VP-LmCsHobZE38pU4/view?usp=sharing Bug: 995720 Change-Id: I86ddfd04ad59e16abc546fa97fcebbdd715616bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807314Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#697188}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/41079d70e469..65a5036eb041 git log 41079d70e469..65a5036eb041 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 1e146e8a3485..99793fa67d78 (2 commits) Created with: gclient setdep -r src/third_party/angle@65a5036eb041 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: chromium:None Change-Id: I6c0ecf18ef577f28e32c47009c53beec06137e16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809237Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/df432d5efb70..d545bfbb94ca git log df432d5efb70..d545bfbb94ca --date=short --no-merges --format='%ad %ae %s' 2019-09-17 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps Created with: gclient setdep -r src/third_party/skia@d545bfbb94ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: I9dec96d1d33ad47325b049d342d106fc1e81f054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809239Reviewed-by:
-
Robbie Gibson authored
The root cause looks like the BVC view will show up momentarily when closing the last tab. I assume that all the actual tab views are removed, which lets the BVC shine through. Bug: 1003485 Change-Id: I4760cd2031abdcb5d04572efd5c1fbb637dae6db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807221Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#697185}
-
Nikita Podguzov authored
This is required to clean several expired print jobs at once. Bug: 992889 Change-Id: Iecfedcd1282fe610c6bcc60c7f42746916dc9497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804486 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#697184}
-
Robbie Gibson authored
Here, the root case is that the accessibleElements array keeps growing and eventually has many many copies of self.trailingButton (once on each page load). This causes voice control to think there are many buttons named share, so it asks which one to choose. This also seems to fix a bug where you can't swipe past the share button when using voiceover. I assume it's a similar issue coming from -indexOfAccessibilityElement:. Bug: 1004331 Change-Id: Iaed748b8488451704d8d338c50b5d12cfce61986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807114Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#697183}
-
Tanmoy Mollik authored
To enable the feature flag that will make android manual start it is necessary to change the tests that assume android is auto start. This signIn method is used by some sync autofill and bookmark tests that needs to manually set setFirstSetUpComplete to start the sync process. Bug: 1004264 Change-Id: Ie33ae3b69478794b32530dd5596af66d813ee84c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798323 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
-
Christoph Schwering authored
Blacklist some social titles from being autofilled for company name: - English: Mr, Mr., Mrs, Mrs., Ms, Ms., Miss, Mistress, Mister, Miss; - German: Frau, Herr, - Mme, Mlle, Mlles, M. - Academic: Prof, Prof., Dr, Dr. Bug: 999952 Change-Id: I9cfe9f00263148b7821d8b7069651a7835fb6e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807316Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#697181}
-
Paul Lewis authored
We currently use the mime-type determine into which mode to put CodeMirror. For the most part this is fine, save for JSX/TSX projects where the files are saved with .js/.ts files suffixes. Typically this causes the non-x mime-type to be chosen, which in turn puts CodeMirror into the wrong mode. Since JSX/TSX are supersets of the non-x versions this CL simply pushes the mode over to the respective superset. Bug: 659515 Change-Id: I186d976a6a1ac991a296f92a22c8a0b3e83743c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800748 Commit-Queue: Paul Lewis <aerotwist@chromium.org> Reviewed-by:
Jeff Fisher <jeffish@microsoft.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#697180}
-
Nikita Podguzov authored
This will be used in follow-up CLs. This involves splitting PrintJobHistoryService into interface and implementation. Bug: 992889 Change-Id: I52909c73a52d834cb9147d1e09e2cf9af83ba3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798662Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#697179}
-
Nikita Podguzov authored
This will allow to resolve possible race conditions when the client tries to access database before it's fully initialized. Bug: 992889 Change-Id: Ie890e1c83add83f7be0892ad8a4a990730a38a90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798603Reviewed-by:
-
Alexander Timin authored
At the moment cr tool sets is_component_build=true by default, overriding the existing value of the flag, which is not particularly helpful when trying to use is_official_build=true. This patch disables this functionality and removes all smartness associated with trying to guess the correct is_component_build, leaving the user free to choose whatever they please. R=skyostil@chromium.org Change-Id: I8953e0e3e8fea676b044d04460b418f310b9656c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807829Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#697177}
-
Wanming Lin authored
Following tests are still flaky on Mac10.13 builders: - external/wpt/gyroscope/Gyroscope.https.html - external/wpt/accelerometer/Accelerometer.https.html - external/wpt/orientation-sensor/AbsoluteOrientationSensor.https.html - external/wpt/orientation-sensor/RelativeOrientationSensor.https.html And remove external/wpt/accelerometer/LinearAccelerationSensor-shake-threshold-manual.https-expected.txt which is unnecessary as it has already been in web_tests/NeverFixTests file. Bug: 731018 Change-Id: I7cdd26682981e07695d9928536be3cbc0fca7890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808390Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#697176}
-
Javier Ernesto Flores Robles authored
It looks like changes in the interface style are delayed until the app comes back to the foreground. Because of this, it feels that "Currently Used" is more appropriate. Bug: 1001192 Change-Id: Ie437609564cd38f4a79b6684a418b963003803c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800991Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#697175}
-
Yannic Bonenberger authored
Change-Id: I2c4154d1fc58185155fcfcba758dbd33a2fe8b6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803918 Commit-Queue: Yannic Bonenberger <yannic.bonenberger@gmail.com> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#697174}
-
Dominic Battre authored
This CL resolves an older TODO. With the LogBuffer now living in common/ instead of browser/, it is possible to do the serialization of these two enums in common/ as well. TBR=ftirelo@chromium.org Bug: 928595 Change-Id: Ie9a0f8352b38202b1b87a269256ecf4e6e4421ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803925 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#697173}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3d1647412c08..c1c6284cd11f git log 3d1647412c08..c1c6284cd11f --date=short --no-merges --format='%ad %ae %s' 2019-09-17 nisse@webrtc.org New (empty) build target api:media_stream_interface 2019-09-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3cf04dec..2e4ccff8 (696812:696956) 2019-09-16 dinosaurav@chromium.org Refactor Rtp Receivers to accept SSRC 0. Created with: gclient setdep -r src/third_party/webrtc@c1c6284cd11f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I62e738167c00c9f355ee282fc485982662302d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808785Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cd3c3cc8eea4..69dd79c4f0ca git log cd3c3cc8eea4..69dd79c4f0ca --date=short --no-merges --format='%ad %ae %s' 2019-09-17 fmayer@google.com Merge "Add x86 ASAN to CI builds." 2019-09-17 hjd@google.com Merge "Guess resolution based on trace size" 2019-09-17 hjd@google.com Merge "Fix process summary on very long traces" 2019-09-17 hjd@google.com Merge "Dedupe ToHex" Created with: gclient setdep -r src/third_party/perfetto@69dd79c4f0ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ia05419642fb14b3f018ffa2ce5b658d8fcea60cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808236Reviewed-by:
-
chrome://flagAlexander Timin authored
Make it easier (or possible) to test bfcache on Android devices by exposing a flag via chrome://flags page. R=nasko@chromium.org CC=arthursonzogni@chromium.org,clamy@chromium.org,lowell@chromium.org,clamy@chromium.org Change-Id: If233505268bec27d2aa616ab1d5679e2a1ac3e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807317Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Auto-Submit: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#697170}
-
Camille Lamy authored
This CL simplifies the management of the HistoryItem of the DocumentLoader. It no longer has to clear it when taking into account a redirect, as the browser process will ensure no HistoryItem is provided in this case. The previous HistoryItem is also passed directly by the FrameLoader before committing the provisional DocumentLoader, instead of the DocumentLoader asking the FrameLoader about it at commit time. This is a preparatory CL to move the creation of the provisional DocumentLoader after the Unload event, part of a chain of CLs to remove the provisional DocumentLoader. Bug: 855189 Change-Id: I8c7ca86e5f5931dbfd91e688aaff391867b9595a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796356 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
-
Robbie Gibson authored
This demonstrates the use of accessibilityUserInputLabels. Before, the default Voice Control name for one of the settings rows was both the setting name and the value (e.g. "Search Engine Google"). This is because the default name comes from the text in the cell. Now, the name is manually set to just the type of setting (e.g. "Search Engine"), which is a better experience. Bug: 1004319 Change-Id: Ie79a5bba46f8c6b688f1a31be20ef802875a2a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806462 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#697168}
-
Alex Chau authored
- Committing proto change ahead of main CL, so we can export proto change to Sync server earlier Bug: 991971 Change-Id: I11807960d5f7486cc1c16def63da4956834ac326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806861 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#697167}
-
Wei Lee authored
The default value of mirror settings should be set to false only when it is a user-facing camera. For environment-facing and external cameras, the default value of mirror settings should be set to true. Bug: b/140842700 Test: Tested on betty and it works as expectedly. Change-Id: Ie864b00d8bb5cf48bbc1c33d9acb0922f1ec11ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808622 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#697166}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4b4c63ad..84da790b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie1500c7ebcd08156b72ec9c8f3318f9779bf02bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806843Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697165}
-
Alex Keng authored
This change enables MockTheme for color picker's pixel verification tests (except for color-picker-appearance.html and color-picker-appearance-disabled.html) so that when we change in-page UI ex border color we don't need to rebaselne hundreds of files (see https://chromium-review.googlesource.com/c/chromium/src/+/1792578/8 for example, where we need to change about 50 pngs for only one platform and there are total 7 platforms we need to consider). Change-Id: Ie452378dcfcd4170f9324e5ab046d5bf89e96d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808166 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#697164}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b19a360c1269..b4e53c4a9938 git log b19a360c1269..b4e53c4a9938 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 tmrts@chromium.org Enable snapshots and update Linux D8 to 7.7.299.11 to speed up TPMv2 Created with: gclient setdep -r src/third_party/catapult@b4e53c4a9938 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:1001953 Change-Id: I72cfe8185cf4304cd68bdab114577fe557c7ad9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808512Reviewed-by:
-
Anastasiia Nikolaienko authored
Bug: 1001384 Change-Id: I403d8215a377b991f65e036dd93585fcf250cf42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803927 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#697162}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b895066e074a..cd3c3cc8eea4 git log b895066e074a..cd3c3cc8eea4 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 treehugger-gerrit@google.com Merge "Revert "[GPU TRACE] Add GPU scheduling trace events"" Created with: gclient setdep -r src/third_party/perfetto@cd3c3cc8eea4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I7dcadf75262ae0977ee686b47af00ba0a4880f8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808511Reviewed-by:
-
Fergus Dall authored
BUG=none TEST=none Change-Id: Ic480d31aac9df461a52b63ec53c44d1140f6ceda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808296 Auto-Submit: Fergus Dall <sidereal@google.com> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#697160}
-
Dominic Battre authored
This CL moves the log_buffer.* implementation from browser/ to common/. This allows the LogBuffer to be used for structures that live in common and in the renderer. Bug: 928595 Change-Id: Ib249f88c997a3669008efad1a99240fe6d0d2cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804299Reviewed-by:
-
Victor-Gabriel Savu authored
Add two UMA histograms to check if and how install_attributes.pb validation fails on devices deployed in the field. More information about the monitored flow and the resulting data: https://docs.google.com/document/d/1vU4Lfy9EcBxb7TqrZ8FuLc_CWxU1AHG3x9yyLusZ3HU CL that added the metrics: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1800664 Bug: 1000305 Change-Id: I5271708bbe89e29888845a7d70fde29ab89b0fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800751 Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#697158}
-
Oleg Davydov authored
File policy_browsertest.cc contains integration tests for many unrelated policies, that makes this test file extremely large. It's better to split it into several parts according to testing section. This commit starts with splitting work by moving extension-related policy tests into separate file. Possible follow-up improvement could be: extract other sections into different files, leaving only generic policy tests in policy_browsertest.cc. Another possible follow-up: refactor PolicyTest base test class, eg., by moving its extension-related methods into new subclass in extension_policy_browsertest.cc. Bug: 1002483 Change-Id: I97f6286fd5ba0ba681fa95fc1f85107da4fe246c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763667 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#697157}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eba8215b6f4c..6e25bd5bbc4f Created with: gclient setdep -r src-internal@6e25bd5bbc4f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I903614c81a1537f2bc9b0d9df86bdb955f59cdfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809019Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697156}
-
Gyuyoung Kim authored
This CL applies pending_remote to the first argument of AddCompositionModeWatcher in CompositingModeReport interface. Bug: 955171 Change-Id: I331573a1245d2ea1348aa4109bdfbc23cd402c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804698Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
-
Alexander Dunaev authored
Implementations of PlatformWindow::SetBounds() in WaylandWindow and X11Window are different: the latter calls delegate's OnBoundsChanged always, while the former returns early if the new bounds were the same as the existing ones. There is a comment in the X11 implementation that says that we need to call delegate always because the call might be a result of the device scale factor being changed. We had a TODO in the Wayland implementation saying that we need to investigate this and maybe call the delegate always as well. The simple experiment has shown that when the device scale factor is changed, the window gets new bounds that are not the same as the existing ones, so the delegate is called anyway. As a conclusion, no change is needed, and the TODO can be removed. R=msisov@igalia.com Bug: 958314 Change-Id: I95fcffb43d09702d3dbcc6c2083d2087e7c166f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807823Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#697154}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/01dfe4048205..41079d70e469 git log 01dfe4048205..41079d70e469 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src fe0b2bd694bb..be467db7bdaa (2 commits) Created with: gclient setdep -r src/third_party/angle@41079d70e469 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: chromium:None Change-Id: I722dc5686ac58c7495db8ef065b8a52253214931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808507Reviewed-by:
-
Marina Ciocea authored
Increase opacity to 50% to obtain contrast ratio 3:1; reduce the thickness of the border to make it overlap less with the content of the share tab. Bug: 1000970 Change-Id: Idfaa0ddb3e1bd2e8a783862037b15474fdbe438e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807117Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#697152}
-
