Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 31 Oct, 2019 38 commits
  3. 30 Oct, 2019 2 commits
    • Alice Boxhall's avatar
      Revert "Implement transitions to home for homerview feature" · 0bbd90f6
      Alice Boxhall authored 
      This reverts commit 3ef63a6b.

Reason for revert: Looks like this has caused a crash, e.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8898135829966943488/+/steps/ash_unittests/0/logs/Deterministic_failure:_OverviewSessionWithHomerviewGestureTest.FadeOutExit__x2f_0__status_CRASH_/0

Original change's description:
> Implement transitions to home for homerview feature
> 
> Updates how device transitions to home when home button is tapped and
> when user clicks in empty space in overview grid when kHomerviewGesture
> feature is enabled.
> 
> When overview is active, it should use kFadeOutExit transition (instead
> of slide out) - this also fixes a bug where transform was not cleared on
> item windows when bounds were updated without animations (which was
> causing item window misplacement when the grid was updated while
> minimizing active window before exiting overview).
> FadeOutWindowsAndMaybeSlideOnExit is updated to take "slide" as an
> argument instead of deducing it depending on the animation type, as
> OVERVIEW_ANIMATION_EXIT_TO_HOME_LAUNCHER should slide if and only if
> using slide out overview exit transition (the animation can also be used
> by fade out exit).
> 
> When clicking home with a window active, the top window is minimized
> using transform to home screen (the same used during drag from shelf),
> while the rest of the windows are minimized with no animations. To make
> this easier, WindowTransformToHomeScreenAnimation is moved to a separate
> file, and is updated to better handle windows whose origin is not in the
> screen origin (which is useful for transforming top windows in split
> view).
> 
> Is split view, the top windows are transformed to home screen as the
> split view ends. If overview session is active together with split view,
> the overview session is ended immediately to avoid showing overview just
> after ending split view (during duration of the exit transition).
> 
> BUG=1005366
> 
> Change-Id: Ic23893866700f5e5580f4445915d815f188e8c0f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885972
> Commit-Queue: Toni Baržić <tbarzic@chromium.org>
> Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710953}

TBR=xiyuan@chromium.org,tbarzic@chromium.org,xdai@chromium.org

Change-Id: Id4020082bc736ec6fc9306fc26c5a7a237cb4c54
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1005366
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890392Reviewed-by: default avatarAlice Boxhall <aboxhall@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711045}
      0bbd90f6
    • Findit's avatar
      Revert "Remove HomeLauncherGestureHandlerObserver" · 4054a4e9
      Findit authored 
      This reverts commit 433bbd52.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 711038 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzQzM2JiZDUyMTA0MmRjOTcyMmQ2ZDg2Nzk0MzNjODE0MGRmOWQwNGMM

Sample Failed Build: https://ci.chromium.org/b/8898131381528610928

Sample Failed Step: compile

Original change's description:
> Remove HomeLauncherGestureHandlerObserver
> 
> HomeLauncherGestureHandler currently has two observers:
> *   AppListControllerImpl, which is also a HomeScreenDelegate
>     implementation (on which HomeScreenGestureHandler already
>     depends, so additional observer interface just
>     obscures/complicates this dependency)
> *   HomeLauncherStateWaiter which is used by interactive UI/perf tests
>     to wait for launcher animations to complete
> 
> For the former case, moving the observer methods to HomeScreenDelegate
> interface will work fine.
> For latter case, the test waiter can register a callback with
> AppListControllerImpl to be run when the home launcher animations are
> complete - the same way it's done by LauncherStateWaiter, an equivalent
> test waiter used in clamshell mode (or for waiting for non-visibility
> app list state transitions)
> 
> Change-Id: Ia333bedab2b8683d35da2d00030cf40df2c619f5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888652
> Reviewed-by: Manu Cornet <manucornet@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Commit-Queue: Toni Baržić <tbarzic@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#711038}


Change-Id: I449d4c15018c05c09953d445a50d1c1dc6f7c1a0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890735
Cr-Commit-Position: refs/heads/master@{#711044}
      4054a4e9