Commits · 85f5cc5344a24b21428f2978fc062b491dc95e7a · eriksson monteiro / tangled

19 Jan, 2021 40 commits

Handle sync paste deep scanning crash · 85f5cc53

Dominique Fauteux-Chapleau authored Jan 19, 2021

This fixes the crash observed in crbug.com/1166233 and adds tests for
it. See the comments in that bug for more details.

This fix also removes the dialog for unauthorized users for pasting
after the initial scan that does authentication, so crbug.com/1028133
is affected.

Bug: 1166233, 1028133
Change-Id: Id3c992fdeccfa92a9f88e25c13e7a15bcb1afd8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633701Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844787}

85f5cc53

Remove DidCreateInitialEmptyDocument · 42aa8d88

danakj authored Jan 19, 2021

There are no observers to inform as this happens before
RenderFrameCreated, so we can just remove it.

R=dcheng@chromium.org

Bug: 1158869
Change-Id: Ib42a75e89b6f2391c994062effb54f24d4b7d14a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633921Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844786}

42aa8d88

[battery]: Track the ukm::SourceID that has been visible the longest · 7f117b99

Sebastien Marchand authored Jan 19, 2021

Bug: 1153193
Change-Id: I09fcbbbe6335dfbc420d551957399a2999e3b97a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624768
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844785}

7f117b99

jni_generator.py: Include hashed name as comment when not in use · 46e54fb3

Andrew Grieve authored Jan 19, 2021

Codesearch indexes with is_java_debug=true, so this change will allow
looking up method hashes via codesearch.

Bug: None
Change-Id: I1d8d841073c5ef502d1e1b421a411894776e4cf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636297
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844784}

46e54fb3

Update Viz Flow tracing and Rotation Debug Traces · 69f5a0f9

Jonathan Ross authored Jan 19, 2021

With DCHECKs enabled base::HashInts uses a random seed, which is only
valid in its process. This means that a given viz::LocalSurfaceId would
have different hashes in different process. Which breaks performing
Traces with Flow.

Additionally while debugging issue 1060058 I noticed it was difficult to
know when Viz was blocked on pending surfaces, and when rotations were
occurring. This change adds a new trace to viz::Surface to list the
Surface being waited on. As well as adding new traces to LayerTreeHost
to denote the current viewport rect.

Bug: 1154826
Change-Id: I60d9f2f195ae6ca45e9eabd101df971462b34224
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633098
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844783}

69f5a0f9

Roll DevTools Frontend from 95612c220891 to 9e417d1e36be (5 revisions) · 687e9d29

chromium-autoroll authored Jan 19, 2021

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/95612c220891..9e417d1e36be

2021-01-19 alexrudenko@chromium.org Increase required contrast for color suggestions
2021-01-19 janscheffler@chromium.org [JSDOC2TS]: Migrate recorder
2021-01-19 tvanderlippe@chromium.org Migrate trimMiddle to string-utilities
2021-01-19 jacktfranklin@chromium.org Fix type of DataGrid renderer.
2021-01-19 alexrudenko@chromium.org Fix the size of the select in Layout pane

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1050549,chromium:1158760
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I0d323dd190b35774c6417ca7cc81496b462f44bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636926Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#844782}

687e9d29

base: Mark RefCountedDeleteOnSequence constructor as explicit. · a11a8952

Victor Costan authored Jan 19, 2021

The Google C++ style guide recommends explicit constructors, with a few
exceptions where implicit conversion is desirable. Implicit conversion
between TaskRunner and RefCountedDeleteOnSequence seems surprising.

This CL does not introduce any functional changes.

Change-Id: I1ccf85fa5a673e7a91dd6090676788d682890412
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634866
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844781}

a11a8952

Add flake expectations for tests blocking wpt import · 5183b701

Luke Zielinski authored Jan 19, 2021

Bug: 1168130
Change-Id: I6f7e3a0e5b6b9d5eb758c368d61d5366cbd3d6d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637455
Auto-Submit: Luke Z <lpz@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844780}

5183b701

Revert "[profiles] Clean up guest ephemeral profile on startup" · b62892aa

Xida Chen authored Jan 19, 2021

This reverts commit d660a480.

Reason for revert:
Test fails:
https://ci.chromium.org/ui/p/chromium/builders/ci/Win%207%20Tests%20x64%20(1)/76721/overview

Original change's description:
> [profiles] Clean up guest ephemeral profile on startup
>
> This CL fixes a bug which leads to the guest ephemeral profile not being
> cleaned up on startup if it has been left over in the previous session.
>
> ProfileManager::CleanUpEphemeralProfiles() needs to pass the `true`
> parameter in ProfileAttributesStorage::GetAllProfilesAttributes() to get
> the full list of registered profiles.
>
> Bug: 1167883
> Change-Id: I3051a9174e8472eb2af046126be88dbfb44bcb47
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635158
> Commit-Queue: Alex Ilin <alexilin@chromium.org>
> Reviewed-by: David Roger <droger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#844749}

TBR=droger@chromium.org,alexilin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I6fb55866ddcda42c54d60aaa2e823da18b353348
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1167883
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637395Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844779}

b62892aa

Reland "Support multiple receivers for Cros APIs." · 97095dcd

Hidehiko Abe authored Jan 19, 2021

This reverts commit 640009eb.

Reason for revert: The original CL looks wrongly identified as a
cause of test breakage. Even without this CL, the test is flaky.

Original change's description:
> Revert "Support multiple receivers for Cros APIs."
>
> This reverts commit 8aca3b4d.
>
> Reason for revert: I suspect the CL caused WindowOpenApiTest.PopupBlockingExtension failure
> https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/22177/overview
>
> [ RUN      ] WindowOpenApiTest.PopupBlockingExtension
> 2021-01-13T05:48:40.927570Z INFO browser_tests[28993:28993]: [content_main_runner_impl.cc(1055)] Chrome is running in full browser mode.
> 2021-01-13T05:48:41.111260Z WARNING browser_tests[28993:28993]: [audio_manager_linux.cc(69)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized.
> 2021-01-13T05:48:41.147293Z ERROR browser_tests[28993:28993]: [cras_audio_handler.cc(1627)] Failed to retrieve WBS mic deprioritized flag
> 2021-01-13T05:48:41.148942Z WARNING browser_tests[28993:29172]: [statistics_provider.cc(321)] Finished loading statistics.
> 2021-01-13T05:48:41.786294Z WARNING browser_tests[28993:28993]: [user_policy_manager_builder_chromeos.cc(123)] No policy loaded for known non-enterprise user
> 2021-01-13T05:48:42.161192Z WARNING browser_tests[28993:28993]: [merge_session_throttling_utils.cc(143)] Loading content for a profile without session restore?
> 2021-01-13T05:48:42.192143Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported
> 2021-01-13T05:48:42.205962Z ERROR browser_tests[28993:28993]: [proximity_auth_profile_pref_manager.cc(192)] Failed to find local state prefs for current user.
> 2021-01-13T05:48:42.726389Z WARNING browser_tests[28993:28993]: [merge_session_throttling_utils.cc(143)] Loading content for a profile without session restore?
> 2021-01-13T05:48:43.054799Z WARNING browser_tests[28993:28993]: [wallpaper_controller_client.cc(377)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances.
> 2021-01-13T05:48:43.218141Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported
> 2021-01-13T05:48:43.726830Z WARNING browser_tests[29202:29284]: [http_cache_transaction.cc(1192)] Unable to open or create cache entry
> 2021-01-13T05:48:44.322210Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported
> 2021-01-13T05:48:44.376219Z ERROR browser_tests[28993:28993]: [plugin_vm_manager_impl.cc(141)] New session has dispatcher unexpected already running. Perhaps Chrome crashed?
> 2021-01-13T05:48:44.859368Z INFO browser_tests[28993:28993]: [key_permissions_manager_impl.cc(495)] One-time key permissions migration started for token: 0.
> 2021-01-13T05:48:44.863796Z INFO browser_tests[28993:28993]: [android_sms_pairing_state_tracker_impl.cc(72)] No Pairing cookie found
> 2021-01-13T05:48:45.010359Z ERROR browser_tests[28993:29140]: [object_proxy.cc(621)] Failed to call method: org.chromium.U2F.IsUvpaa: object_path= /org/chromium/U2F: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.U2F was not provided by any .service files
> 2021-01-13T05:48:45.018258Z ERROR browser_tests[28993:29172]: [als_reader.cc(47)] Missing num of als
> 2021-01-13T05:48:45.681453Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported
> 2021-01-13T05:48:45.682492Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported
> 2021-01-13T05:48:45.685002Z INFO browser_tests[28993:28993]: [key_permissions_manager_impl.cc(520)] One-time key permissions migration succeeded for token: 0.
> 2021-01-13T05:48:45.768048Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported
> 2021-01-13T05:48:45.769933Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported
> 2021-01-13T05:48:46.230042Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported
> 2021-01-13T05:48:50.078030Z ERROR browser_tests[28993:29172]: [object_proxy.cc(621)] Failed to call method: org.chromium.debugd.GetPerfOutputFd: object_path= /org/chromium/debugd: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.debugd was not provided by any .service files
> 2021-01-13T05:49:10.763123Z WARNING browser_tests[28993:29410]: [embedded_test_server.cc(668)] Request not handled. Returning 404: /favicon.ico
> 2021-01-13T05:49:10.833186Z WARNING browser_tests[28993:29410]: [embedded_test_server.cc(668)] Request not handled. Returning 404: /favicon.ico
> ../../chrome/browser/extensions/window_open_apitest.cc:91: Failure
> Expected equality of these values:
>   num_browsers
>     Which is: 4
>   chrome::GetBrowserCount(browser->profile())
>     Which is: 2
> Google Test trace:
> ../../chrome/browser/extensions/window_open_apitest.cc:76: WaitForTabsPopupsApps tabs:5, popups:2, app_popups:1
> Stack trace:
> #0 0x56363e71a458 extensions::WaitForTabsPopupsApps()
> #1 0x56363e71c5aa extensions::WindowOpenApiTest_PopupBlockingExtension_Test::RunTestOnMainThread()
> #2 0x563646f1d248 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
> #3 0x563646f207ca base::internal::FunctorTraits<>::Invoke<>()
> #4 0x563646f20741 base::internal::InvokeHelper<>::MakeItSo<>()
> #5 0x563646f206e7 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE
> #6 0x563646f2068c base::internal::Invoker<>::RunOnce()
> #7 0x56363c76ba61 _ZNO4base12OnceCallbackIFvvEE3RunEv
> #8 0x563645c03021 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
> #9 0x563645c01fc2 ChromeBrowserMainParts::PreMainMessageLoopRun()
> #10 0x563640599fc6 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
> #11 0x7fb5dc82e9e5 content::BrowserMainLoop::PreMainMessageLoopRun()
> #12 0x7fb5dc8383ca base::internal::FunctorTraits<>::Invoke<>()
> #13 0x7fb5dc8382e1 base::internal::InvokeHelper<>::MakeItSo<>()
> #14 0x7fb5dc838267 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEiOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE
> #15 0x7fb5dc83820c base::internal::Invoker<>::RunOnce()
> #16 0x7fb5dcc03581 _ZNO4base12OnceCallbackIFivEE3RunEv
> #17 0x7fb5dda03df6 content::StartupTaskRunner::RunAllTasksNow()
> #18 0x7fb5dc82d3ad content::BrowserMainLoop::CreateStartupTasks()
> #19 0x7fb5dc83bfd3 content::BrowserMainRunnerImpl::Initialize()
> #20 0x7fb5dc82a804 content::BrowserMain()
> #21 0x7fb5de9aae56 content::RunBrowserProcessMain()
> #22 0x7fb5de9ac3c9 content::ContentMainRunnerImpl::RunBrowser()
> #23 0x7fb5de9abd27 content::ContentMainRunnerImpl::Run()
> #24 0x7fb5de9a9106 content::RunContentProcess()
> #25 0x7fb5de9a9a3d content::ContentMain()
> #26 0x563646f1cb13 content::BrowserTestBase::SetUp()
> #27 0x563645acb283 InProcessBrowserTest::SetUp()
> #28 0x563645ab3802 extensions::ExtensionBrowserTest::SetUp()
> #29 0x56364163b48b testing::internal::HandleSehExceptionsInMethodIfSupported<>()
> #30 0x56364162ee67 testing::internal::HandleExceptionsInMethodIfSupported<>()
>
>
>
> Original change's description:
> > Support multiple receivers for Cros APIs.
> >
> > With this CL, most of Cros API starts to support multiple receivers.
> > AshChromeService and LacrosChromeService are exceptions.
> >
> > Bug: 1148448
> > Test: Build and run Lacros on a DUT.
> > Change-Id: I1d1a0be111108ae15657d81ea747750a760bd2f8
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624323
> > Reviewed-by: James Cook <jamescook@chromium.org>
> > Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#842869}
>
> TBR=jamescook@chromium.org,hidehiko@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
>
> Change-Id: Id097eab1934d9a2afca29f249a007de57ef18d90
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1148448
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626229
> Reviewed-by: Maxim Kolosovskiy  <kolos@chromium.org>
> Commit-Queue: Maxim Kolosovskiy  <kolos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#842943}

TBR=jamescook@chromium.org,hidehiko@chromium.org,kolos@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1148448
Change-Id: Ic2ec65fa476b9b67a705497aad1cf3f1bffa0da2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633482Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Maxim Kolosovskiy  <kolos@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844778}

97095dcd

[sheriff] Add a bug number for a disabled test · ece9b296

Xida Chen authored Jan 19, 2021

TBR=rainhard@chromium.org
NOTRY=true

Bug: 1070886
Change-Id: I4bf958456b1602620f479802e0838d2f9dbea380
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636875Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Rainhard Findling <rainhard@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844777}

ece9b296

[build] Enable the ThinLTO cache also on Windows · ae27a35d

Hans Wennborg authored Jan 19, 2021

This speeds up builds when using ThinLTO. The resource leak preventing
this from being enabled before has been fixed upstream.

The only bots doing ThinLTO builds on Windows are ToT bots that use
upstream clang.

Bug: 871962
Change-Id: Ie7a250a5bab009a95f919631b5f268aafdcdffab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637620
Commit-Queue: Hans Wennborg <hans@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844776}

ae27a35d

mac: Update clang build script for the SDK 11.1 bump · 1b89cce2

Hans Wennborg authored Jan 19, 2021

The SDK was updated to 11.1 in crrev.com/844553. This updates the build
script to match

Bug: 1168134
Change-Id: Ia9054b5b49e7f24bc9135ccd6024e3c8af8cd518
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637477
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844775}

1b89cce2

Update V8 to version 9.0.14. · 23736e7f

v8-ci-autoroll-builder authored Jan 19, 2021

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/035dfc7b..b28c3b8f

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ibf6a72e6aae8ea915b16c8b1eb3f085fe9a785cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637814Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#844774}

23736e7f

Disable SavePageOriginalVsSavedComparisonTest.ObjectElementsViaHttp · 8532fc37

Xida Chen authored Jan 19, 2021

This test is flaky on a few platforms

TBR=rainhard@chromium.org
NOTRY=true

Bug: 1070886
Change-Id: I5ac13c73ab75be22d34b3f0f5749efa4cb11297b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636874Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844773}

8532fc37

CSP: Replace blink::CSPDirectiveList with mojo type · d50c0a54

Antonio Sartori authored Jan 19, 2021

In the Blink Content Security Policy code, we switch from using the
internal blink type blink::CSPDirectiveList to using the mojo type
network::mojom::blink::ContentSecurityPolicy for storing a parsed
Content Security Policy.

This is part of a project to harmonize the CSP code in Blink and in
services/network, and will make it easier to synchronize Content
Security Policies between the two.

Bug: 1021462,1149272
Change-Id: Idb11f4af00bae348140864584d9c522ad361559b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602125
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844772}

d50c0a54

[iOS][MICe] Fix UI crash when signing in to account with Sync password. · df71978f

Nohemi Fernandez authored Jan 19, 2021

This patch fixes a crash that occurs when a user goes through the
advanced Sync settings sign-in flow with an account that has a Sync
encryption password.

Starting from this patch Sync error cards are only displayed after the
sign-in flow has been completed.

Bug: 1125631
Change-Id: I877e59e25265e78a4220fbb66b7a3855757dceb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637575Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844771}

df71978f

[battery] Move the usage scenario files to a new sub dir in c/b/metrics · 598b91e4

Sebastien Marchand authored Jan 19, 2021

as discussed in https://chromium-review.googlesource.com/c/chromium/src/+/2621678

Bug: 1153193
Change-Id: Ib5068b627c9e91644857892a57213414b9cfd77c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627886Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844770}

598b91e4

TextDecorationInfo only allocated on the stack · 503a97d8

Rune Lillesveen authored Jan 19, 2021

Mark it as STACK_ALLOCATED. There's a ComputedStyle which is not
refcounted which would be dangerous if TextDecorationInfo gets allocated
on the heap.

Noticed this when reviewing moving ComputedStyle to Oilpan.

Change-Id: Ia3ec8ea0bfa542da817110d6c1b9b6c52315ad21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637834Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844769}

503a97d8

Quota: Mojofy Service Workers's QuotaClient. · b53ca149

Victor Costan authored Jan 19, 2021

Bug: 1163048
Change-Id: I1744df8280e11bc96073415354a0006f49fd6a9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628078Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844768}

b53ca149

Guard flag CSSAtRuleCounterStyle properly in AXLayoutObject::GetListStyle · e87e675a

Xiaocheng Hu authored Jan 19, 2021

A previous patch crrev.com/c/2629991 has a bug that it always enters a
code path that should be entered only when CSSAtRuleCounterStyle is
enabled.

This patch handles the flag properly.

Bug: 1167596
Change-Id: I15dcdae0d70a716185e5ab376a0c08bcb5f134dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636378
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844767}

e87e675a

[iOS Enterprise] BrowserSignin: Enable policy handler by default · 1683f26e

Guillaume Jenkins authored Jan 19, 2021

Installs the BrowserSignin policy handler by default. It was previously
hidden behind the --install-browser-signin-handler command-line flag
while the different parts of the implementation were being finished. The
policy now fully works, so the command-line flag is no longer needed.

Bug: 1155745
Change-Id: I58dda5bdc143cbfbd21cecbea13d184bc60100ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633352Reviewed-by: Nohemi Fernandez <fernandex@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Guillaume Jenkins <gujen@google.com>
Cr-Commit-Position: refs/heads/master@{#844766}

1683f26e

[CORS-RFC1918] Test inheritance for sandboxed iframes. · ee51fc4c

Titouan Rigoudy authored Jan 19, 2021

We test 6 out of the 7 possible URLs:

 - about:blank
 - the initial empty doc
 - about:srcodc
 - data:
 - blob:
 - filesystem:

We do not test javascript:, since we cannot load in a sandboxed iframe
(even with `sandbox = "allow-scripts"`).

Fixed: chromium:1167697
Change-Id: I8c4c634bd7c0cc7d1ed9a6c1148f63fa79f7dfcb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637616
Auto-Submit: Titouan Rigoudy <titouan@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Titouan Rigoudy <titouan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844765}

ee51fc4c

[Passwords] Extend more histograms · de328abd

Jan Wilken Dörrie authored Jan 19, 2021

This change extends the PasswordManager.BulkCheck.CanceledCredentials
and PasswordManager.OsPasswordStatus histograms.

R=chromium-metrics-reviews@google.com

Fixed: 1160745, 1167775
Change-Id: I2310afe4516b85fdbe9927cd03df267daf7d30ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637696
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844764}

de328abd

Quota: Extend expiry of PercentDiskAvailable2. · 22e212c1

Jarryd authored Jan 19, 2021

Bug: 1165235
Change-Id: I71582edc502c7bdee6b8826c5425de3bf2279d28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632854
Auto-Submit: Jarryd Goodman <jarrydg@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844763}

22e212c1

[EventTiming] Exclude target from toJSON · fafb4f34

Nicolás Peña Moreno authored Jan 19, 2021

This CL removes the target from the return value of toJSON from a
PerformanceEventTiming entry, and modifies the WPT accordignly.
Context: https://github.com/WICG/event-timing/issues/97

Change-Id: I2a2f27f845f297157ca9f5ae561a9730dc242d9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636058
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844762}

fafb4f34

Roll Chrome Mac PGO Profile · 838a8ee4

chromium-autoroll authored Jan 19, 2021

Roll Chrome Mac PGO profile from chrome-mac-master-1611035655-254822a7c03cbefbcbdc34527b5136e1083ea204.profdata to chrome-mac-master-1611057528-6f03f3ff553c2040abb87e84fc5d258c023feaa2.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I65f892333deacd7754adc18da184979a7cd323da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636925Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#844761}

838a8ee4

heap: Ephemeron visualization · 8dbc4c3a

Michael Lippautz authored Jan 19, 2021

Treating ephemerons strong during snapshot creation results in
strongification of the key, even though the right key->value edge is
added. This is a problem when the ephemeron container is closer
to a root than the actual object, as it hides the real retaining
path.

Instead, treat the backing weakly which results in only adding the
right key->value edge. In addition, give the edge a name as otherwise
regular properties would be indistinguishable from properties added
through ephemerons.

Example retainer entry:
  part of key -> value pair in ephemeron table
  (<blink::WeakMember<blink::Node>,
  blink::Member<blink::EventTargetData>>)
  in HTMLButtonElement@38789

Change-Id: Id9cc2fb5b31be6df68ec9d0f63c01c06dbb48bcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633264
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844760}

8dbc4c3a

Add scaled frames to VideoCapturerSource::VideoCaptureDeliverFrameCB. · cadf8786

Henrik Boström authored Jan 19, 2021

In this CL, VideoCaptureDeliverFrameCB gets an additional parameter.
The scaled video frames are versions of the original video frame
(existing parameter) but already downscaled by the capturer in the size
that the consumer wants. This saves on the consumer having to do SW
rescaling or GPU roundtrips. The intended use case is that when frames
reach the encoders in WebRTC we can acheieve "zero copy". A prototype
CL[1] suggests this might save 0.1-0.5 W in some cases.

Consumers like WebRTC can already communicate desired resolutions to
the Capturer on-the-fly using media::VideoFrameFeedback.

This CL does NOT add in-capturer scaling or updates the pipeline to
pass the additional frames, but if we can agree in this CL to update
this callback, the rest is "mostly plumbing" to be done in follow-up
CLs. In the meantime, the scaled video frames is an empty vector.

Changes:
- video_capturer_source.h: This is the callback that is changed.
- video_capture_impl.cc: This is the entry-point to the renderer
process, currently passing in an empty vector. In a future CL, frames
will be delivered Capturer -> Browser -> Renderer.
- video_track_adapter.cc: This is where scaling is soft-applied today.
We still soft-apply, but additionally pass along the scaled frames.
- media_stream_video_webrtc_sink.cc: This is the entry point to WebRTC.
Shortly after is where soft-applied frames get downscaled. In a future
CL we can pass the scaled frames there and skip downscaling the
original frame.

The rest of the changes is updating all the references to the callback
to have the correct number of arguments.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2577366

Bug: chromium:1157072
Change-Id: If806d56fb58022a1f1debace3ccbe7361d79554d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632669Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844759}

cadf8786

Add PushableMediaStreamAudioSource · 912c7141

Thomas Guilbert authored Jan 19, 2021

This CL adds PushableMediaStreamAudioSource, which mirrors the video
equivalent PushableMediaStreamVideoSource. This class allows one to
easily push audio data into a MediaStreamTrack.

Bug: 1157608
Change-Id: I6fe3adc26f257eb6f9a6e7d8ff8dad8929ab2a38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625829Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844758}

912c7141

Roll Fuchsia SDK from 0.20210118.3.1 to 0.20210119.1.1 · c1e394f8

chromium-autoroll authored Jan 19, 2021

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast
Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Change-Id: Id525d2319bc7dd130b94193115241ddde6fcf8e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636918Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#844757}

c1e394f8

[Passwords] Enable Password Weakness Check By Default · 5b2dbde2

Jan Wilken Dörrie authored Jan 19, 2021

This change enables the PasswordsWeaknessCheck feature by default and
removes the corresponding field trial testing config.

Bug: 1119752
Change-Id: I8e0908f796a56c7eed3bc8945b7c741f15a14838
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637574Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844756}

5b2dbde2

raw-audio-capture: Include WASAPIRawAudioCapture on Win · c66d101f

henrika authored Jan 19, 2021

This change makes WASAPIRawAudioCapture accessible from chrome://flags
via the raw-audio-capture flag so that the feature
is togglable by consumers in the UI.

Bug: 1133643
Change-Id: I5eee5b9568e787283bd21a9aa88cc2ec6473cef0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636356
Commit-Queue: Henrik Andreasson <henrika@chromium.org>
Reviewed-by: Markus Handell <handellm@google.com>
Cr-Commit-Position: refs/heads/master@{#844755}

c66d101f

clang roll script: Remove linux_chromium_chromeos_asan_rel_ng from cq bots. · bc9b7fe2

Nico Weber authored Jan 19, 2021

The bot always times out and doesn't find anything useful. Let's just not run
it.

Bug: 1144484f
Change-Id: Iabd8150ffd6fef99782de28ad084a4cce80298c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637714
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844754}

bc9b7fe2

[ios] Remove unused constant · 33614675

Sylvain Defresne authored Jan 19, 2021

Bug: none
Change-Id: I07c797cab7f97428ea17ec30fe33aa9739553d99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632945
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844753}

33614675

[gin] Add a feature for unsafe fast JS calls · 232168db

Maya Lekova authored Jan 19, 2021

The feature is disabled by default, as is the current state of the flag
in V8. This CL is intended to allow us to start a Finch experiment for
enabling the feature over time.

Bug: chromium:1052746
Change-Id: I8f7f29fe7661bfeb911c63e0a892905efb3edb80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632682Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Maya Lekova <mslekova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844752}

232168db

Revert "[Profile creation] Add {back,reload} accelerators for navigation" · 41e98a96

Jan Krcal authored Jan 19, 2021

This reverts commit bedb24da.

Reason for revert: the test is flaky / failing on MSan

Original change's description:
> [Profile creation] Add {back,reload} accelerators for navigation
>
> This CL adds two accelerators into the profile creation flow to improve
> accessibility and usability:
>  - the back action for screens that actually show the back button
>  - the reload action for the sign-in flow that happens over the internet
>    and thus loading of the page can fail.
>
> Bug: 1126913, 1167675
> Change-Id: I3c197dea2859c0136db62249064249e0569a93da
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627403
> Auto-Submit: Jan Krcal <jkrcal@chromium.org>
> Commit-Queue: David Roger <droger@chromium.org>
> Reviewed-by: David Roger <droger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#844695}

TBR=droger@chromium.org,jkrcal@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I50060ea130339fe25df000ecffaf7e474ba285b8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1126913
Bug: 1167675
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637595Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844751}

41e98a96

Roll clang llvmorg-12-init-16296-g5e476061-2 : llvmorg-12-init-16548-gf1d5cbbd-1. · 3d31c12b

Nico Weber authored Jan 19, 2021

Ran `./tools/clang/scripts/upload_revision.py f1d5cbbdee5526bc86eac0a5652b115d9bc158e5`.

Bug: 1166673
Change-Id: Ie034b123905ec30d68db754485b8259311e5dddb
Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel
Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel
Cq-Include-Trybots: chromium/try:linux-chromeos-dbg
Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng
Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng
Cq-Include-Trybots: chromium/try:mac-arm64-rel,mac_chromium_asan_rel_ng
Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64
Cq-Include-Trybots: chromium/try:win-asan,win7-rel,win-angle-deqp-rel-32
Cq-Include-Trybots: chrome/try:iphone-device,ipad-device
Cq-Include-Trybots: chrome/try:linux-chromeos-chrome
Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627087Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844750}

3d31c12b

[profiles] Clean up guest ephemeral profile on startup · d660a480

Alex Ilin authored Jan 19, 2021

This CL fixes a bug which leads to the guest ephemeral profile not being
cleaned up on startup if it has been left over in the previous session.

ProfileManager::CleanUpEphemeralProfiles() needs to pass the `true`
parameter in ProfileAttributesStorage::GetAllProfilesAttributes() to get
the full list of registered profiles.

Bug: 1167883
Change-Id: I3051a9174e8472eb2af046126be88dbfb44bcb47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635158
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844749}

d660a480

Roll DevTools Frontend from b81bf5f2ec4b to 95612c220891 (1 revision) · 5018b50c

chromium-autoroll authored Jan 19, 2021

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b81bf5f2ec4b..95612c220891

2021-01-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I7074156dd73e6c0c0e901b60de1779469ad8f116
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636922Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#844748}

5018b50c