GitLab

This CL is a reland of https://codereview.chromium.org/479403004/ without the part enabling the test. The test is failing due to several bugs, some of which are fixed in this CL and some others lingering. The goal is to reland these fixes without enabling the test and fixing the rest of the issues in followup changes.

BUG=304341
R=avi@chromium.org, creis@chromium.org

Review URL: https://codereview.chromium.org/509063004

Cr-Commit-Position: refs/heads/master@{#292486}

The Blob type was serialized/restored correctly on the Blink side, but
not on the Chromium side, so when reading a Blob as a stream the
type would be unset.

BUG=408120
R=cmumford@chromium.org
TEST=https://codereview.chromium.org/509213005

Review URL: https://codereview.chromium.org/511373002

Cr-Commit-Position: refs/heads/master@{#292485}

BUG=401365

Review URL: https://codereview.chromium.org/514083002

Cr-Commit-Position: refs/heads/master@{#292484}

This will cancel the virtual keyboard.

BUG=404110, 403813
R=oshima@chromium.org
TEST=manually && athena_unittests

Review URL: https://codereview.chromium.org/512963002

Cr-Commit-Position: refs/heads/master@{#292483}

This is now only used in the context of the browser compositor, so
move the code there.

Move the software layer code over to compositor as well.

Rename structures to de-empahsize 'compositing' (everything is running
through the compositor now).

BUG=314190
TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/511923004

Cr-Commit-Position: refs/heads/master@{#292482}

Revert of Revert of Fix assorted issues with remote CoreAnimation (patchset #1 of https://codereview.chromium.org/517733002/)

Reason for revert:
Patch was reverted in error

Original issue's description:
> Revert of Fix assorted issues with remote CoreAnimation (patchset #2 of https://codereview.chromium.org/516643002/)
>
> Reason for revert:
> Speculatively reverting to see if this helps the mac perf bots:
> https://code.google.com/p/chromium/issues/detail?id=408673
>
> Original issue's description:
> > Fix assorted issues with remote CoreAnimation
> >
> > These issues came up while running for a few days with the
> > flag --enable-remote-core-animation.
> >
> > Fix flashes of old frames by hooking up the DiscardBackbuffer (which
> > happens when being made non-visible) to re-set the CAContext and
> > CALayer (so the browser gets a new one with new content for the next
> > frame).
> >
> > Add support for disabling vsync by using setNeedsDisplay to draw.
> >
> > Change the backpressure mechanism to rely on the browser to apply
> > backpressure in its compositor via the cc:: output surface.
> >
> > Add a ScopedSetGLToRealGLApi structure to ensure that we are talking
> > to the real GL API while in the CoreAnimation callback.
> >
> > BUG=312462
> >
> > Committed: https://chromium.googlesource.com/chromium/src/+/3b6aee8ed0393d852ed21fae78f539ffffe3e8f8
>
> TBR=piman@chromium.org,ccameron@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=312462
>
> Committed: https://chromium.googlesource.com/chromium/src/+/07539c445c9fa7161b3da9031cf440a2b657dd18

TBR=piman@chromium.org,epenner@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=312462

Review URL: https://codereview.chromium.org/517143002

Cr-Commit-Position: refs/heads/master@{#292481}

BUG=none
R=bradnelson@google.com, bradnelson@chromium.org

Review URL: https://codereview.chromium.org/495423010

Cr-Commit-Position: refs/heads/master@{#292480}

https://chromium.googlesource.com/chromium/blink/+log/fd759a525b9eb5c4889947a317439bd510b2a969..5d3187faa8b0dc282ac6f16311c8ba96bfb91bd8
TBR=mlamouri@chromium.org,hclam@chromium.org

Review URL: https://codereview.chromium.org/517783002

Cr-Commit-Position: refs/heads/master@{#292479}

R=binji@chromium.org

Review URL: https://codereview.chromium.org/514333002

Cr-Commit-Position: refs/heads/master@{#292478}

AppView internal API doesn't need to go through ExtensionsAPIClient anymore, since AppView is now in extensions.

BUG=352290

Review URL: https://codereview.chromium.org/498303002

Cr-Commit-Position: refs/heads/master@{#292477}

If the script is switching between Blink and WebKit during bisect, over a year it's been only blink
for chromium and we don't need these codes.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/513253003

Cr-Commit-Position: refs/heads/master@{#292476}

$ git log b8aeeaef0..e7d8b9884 --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//'
2014-08-26 vadimsh Fix cacert.pem extraction from zip.
2014-08-26 kmg Add output location on isolateserver to JSON
2014-08-25 vadimsh Make net.url_open reuse connections again.

R=vadimsh@chromium.org
BUG=

Review URL: https://codereview.chromium.org/514173002

Cr-Commit-Position: refs/heads/master@{#292475}

BUG=338449

Review URL: https://codereview.chromium.org/503503003

Cr-Commit-Position: refs/heads/master@{#292474}

BUG=404472

Review URL: https://codereview.chromium.org/512983003

Cr-Commit-Position: refs/heads/master@{#292473}

-state is disabled by default.

BUG=336558
TEST=None.
R=tonyg
NOTRY=True

Review URL: https://codereview.chromium.org/512383002

Cr-Commit-Position: refs/heads/master@{#292472}

These tests were not previously triggered, but were previously
failing.

BUG=408251
TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/512353003

Cr-Commit-Position: refs/heads/master@{#292471}

Add more checks to test to detect that the resource type of
the URL request is indeed OBJECT.
Would like to get this merged to the M38 branch.

BUG=401755

Review URL: https://codereview.chromium.org/471233003

Cr-Commit-Position: refs/heads/master@{#292470}

BUG=none
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/509093003

Cr-Commit-Position: refs/heads/master@{#292469}

The changes in this patch:
. If in split-view mode, the left and right windows remain fixed in the overview
  state.
. Selecting either of the left/right windows returns to the split-view mode with
  the same windows.
. Selecting one of the other windows in the stack gets out of split-view mode,
  and switches to the selected window.

In subsequent patches:
. Allow dragging a window from the stack on top of the left/right windows to
  switch that window and remain in split-view mode.
. Allow dragging one of the left/right windows to get out of split-view mode and
  switch to that window.

BUG=404119
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/495193003

Cr-Commit-Position: refs/heads/master@{#292468}

BUG=110610

Review URL: https://codereview.chromium.org/511313002

Cr-Commit-Position: refs/heads/master@{#292467}

Prior to this change, on Windows, GetComputerName resulted in a call to
GetComputerNameA, which returns an ANSI string (not ASCII, not UTF-8).
Call GetComputerNameW instead and convert the returned wide string to
UTF-8.

Tested by adding U+00AB to the computer name.  Saw in about:sync the
name contained a U+FFFD instead (symbol for unrepresentable character).
Performed sync dashboard clear, applied patch, saw that the name
correctly contained U+00AB.

This CL does not address corrupted device info that's already in the
field.  Depending on impact that may be addressed in a future CL.

BUG=406470

Review URL: https://codereview.chromium.org/479703004

Cr-Commit-Position: refs/heads/master@{#292466}

https://codereview.chromium.org/478033004/ broke the dialog screen, causing it
to cover the title-bar in apps v2. This fixes it be adding an explicit <div>
representing the window client area (the logical <body> for apps v2).

Review URL: https://codereview.chromium.org/507013002

Cr-Commit-Position: refs/heads/master@{#292465}

This is on similar lines as Windows 8. The difference being launching into ASH on Windows 8 launches
ASH into Windows 8 metro environment.

Reused the existing tunneling we have via delegate_execute to ensure that the calling process is terminated
before launching the browser into the other environment.

Removed the erstshile Open Ash Desktop and Close Ash Desktop menu options as they are no longer needed and they
don't work correctly anyways.

BUG=356475

Review URL: https://codereview.chromium.org/498573003

Cr-Commit-Position: refs/heads/master@{#292464}

Revert of Revert of Remove the last piece of deprecated synchronous IO code. (patchset #1 of https://codereview.chromium.org/509893002/)

Reason for revert:
https://codereview.chromium.org/510893003/ fixed the ledger bot, so I am going to revert this revert CL.

Original issue's description:
> Revert of Remove the last piece of deprecated synchronous IO code. (patchset #5 of https://codereview.chromium.org/460373002/)
>
> Reason for revert:
> Build failure on Google Chrome ChromeOS:
>
> http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20ChromeOS&number=71164
>
> Original issue's description:
> > Remove the last piece of deprecated synchronous IO code.
> >
> > BUG=337096
> > TEST=bots
> >
> > Committed: https://chromium.googlesource.com/chromium/src/+/c4a64ffdd0d511c66d774341fa0a318af7911193
>
> TBR=dalecurtis@chromium.org,ajm@chromium.org,rkc@chromium.org,avi@chromium.org,palmer@chromium.org,xians@chromium.org
> NOTREECHECKS=true
> BUG=337096
>
> Committed: https://chromium.googlesource.com/chromium/src/+/3e8c19c89c16fe8a7c2dfe0cae2990cd4a004339

TBR=dalecurtis@chromium.org,ajm@chromium.org,rkc@chromium.org,avi@chromium.org,palmer@chromium.org,tnagel@chromium.org
NOTREECHECKS=true
BUG=337096

Review URL: https://codereview.chromium.org/518433002

Cr-Commit-Position: refs/heads/master@{#292463}

More-or-less consolidate calls to show an ExtensionAction's
popup into ExtensionActionAPI. This has the happy effect of
reducing the amount of piping we have to do in the UI code
(cutting a few steps out of the Browser -> BrowserWindow ->
Toolbar -> BrowserActionsContainer -> BrowserActionView chain),
and, more importantly, lets page action command executions
happen in the BrowserActionsContainer when the redesign is
enabled.

Hopefully, this means that we can stop showing page actions
in the location bar with the switch enabled - but that's
another patch.

BUG=397259
TBR=sky@chromium.org (minor changes to test_browser_window)

Review URL: https://codereview.chromium.org/489183005

Cr-Commit-Position: refs/heads/master@{#292462}

https://skia.googlesource.com/skia/+log/dc53701216c0e9f98eacf6c0cda769ebbd200b59..60cc7d353b2adc8fcc1712e1f7a965e70121ebcc

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/510393002

Cr-Commit-Position: refs/heads/master@{#292461}

1. URLLoaders can't be reused, so we need to construct one
   per-load. This became too gnarly to handle with callbacks
   so I put it back to having a loader object that owns the
   URLLoader.

2. The relevant URLLoader needs to be passed to
   ContentHandler::OnConnect() so that it stays alive long
   enough to read the entire response.

BUG=

Review URL: https://codereview.chromium.org/513573002

Cr-Commit-Position: refs/heads/master@{#292460}

They were disabled because they flakily time out.  Now with the switch
to Aura, I don't see timeouts anymore.  All the tests I enable in this
changelist pass 10/10 on my machine.

Trybots seem okay with it.

BUG=131179,165765

Review URL: https://codereview.chromium.org/517683002

Cr-Commit-Position: refs/heads/master@{#292459}

It seems that the cons are fairly weak and the benefits might be worth it.
This flag breaks WebView builds.

BUG=None

Review URL: https://codereview.chromium.org/502743002

Cr-Commit-Position: refs/heads/master@{#292458}

This change excludes libvpx from linking if it is disabled. This is
needed to enable linking Chrome with GN, since libvpx is not building
with GN yet.

Review URL: https://codereview.chromium.org/501153003

Cr-Commit-Position: refs/heads/master@{#292457}

BUG=407858

Review URL: https://codereview.chromium.org/504413004

Cr-Commit-Position: refs/heads/master@{#292456}

Tabbing should navigate through all the visible controls.

I've changed the EditablePhotoButton to actually be a button and
not just an image, so that tabbing and pressing enter actually
works.

BUG=405056

Review URL: https://codereview.chromium.org/489143002

Cr-Commit-Position: refs/heads/master@{#292455}

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=180973%3A181040&mode=html

TBR=hclam@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/512283002

Cr-Commit-Position: refs/heads/master@{#292454}

Simple rename patch, in preparation for making the DataTypeStatusTable
copy-able and having it track more than just errors.

BUG=368834

Review URL: https://codereview.chromium.org/513543004

Cr-Commit-Position: refs/heads/master@{#292453}

BUG=110610

Review URL: https://codereview.chromium.org/514233002

Cr-Commit-Position: refs/heads/master@{#292452}

BUG=none

Review URL: https://codereview.chromium.org/511253002

Cr-Commit-Position: refs/heads/master@{#292451}

BUG=
R=tonyg@chromium.org

Review URL: https://codereview.chromium.org/514143003

Cr-Commit-Position: refs/heads/master@{#292450}

Adding droppedframecount UMA to monitor videoplayback quality. Metric gets logged only if the pipeline has video & has decoded atleast one video frame.

BUG=
R=dalecurtis

Review URL: https://codereview.chromium.org/497913002

Cr-Commit-Position: refs/heads/master@{#292449}

Review URL: https://codereview.chromium.org/512663002

Cr-Commit-Position: refs/heads/master@{#292448}

The yasm uses of compiled action used sources instead of inputs. Sources applies to the _foreach version but not the plain "compiled_action". These did not trigger an unused variable warning because the declarations themselves dereferenced the sources variable for computing args to the script.

This adds some extra documentation and assertion to the compiled action template. It also adds the binary itself as an input. This should be strictly unnecessary since there should be an implicit dependency on the target, but I like this since it makes things more explicit.

R=ajwong@chromium.org

Review URL: https://codereview.chromium.org/505403002

Cr-Commit-Position: refs/heads/master@{#292447}