- 16 Nov, 2017 40 commits
-
-
Steven Bennetts authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ef632e4a473b..aed007c17605 $ git log ef632e4a4..aed007c17 --date=short --no-merges --format='%ad %ae %s' 2017-11-13 cywang auto_updater: Apply cold reboot for AU 2017-11-15 dgarrett cros tryjob: Fix submission of unknown build configs. 2017-11-15 dgarrett cros_tryjob: Add go link to -tryjob error messages. 2017-11-16 phobbs Revert "gob_util: Support Appengine Gerrit credentials." 2017-11-14 dgarrett branch-util: Fix branch-util-tryjob for testing. 2017-11-15 shapiroc Fix issue with model specific au fanout 2017-11-07 aelder deploy_chrome: Add --private_key option 2017-11-09 phobbs locking: Fix errno.EDEADLK reference. 2017-11-15 cmtice Revert "generic_stages: temporarily ignore all target prebuilts." 2017-11-15 chrome-bot Update config settings by config-updater. 2017-11-15 hiroh TestSimpleChromeWorkflowStage: Pass --nogn-gen to cros chrome-sdk 2017-11-09 phobbs gob_util: Support Appengine Gerrit credentials. 2017-11-08 achuith [cros_vm]: Use virtio instead of cirrus. 2017-11-14 cmtice generic_stages: temporarily ignore all target prebuilts. 2017-11-13 shapiroc Configure coral for chrome/android pfq and paladin 2017-09-13 vapier cros tryjob: restore metavar 2017-11-14 stevenjb TestSimpleChromeWorkflowStage: Pass --nogngen to cros chrome-sdk 2017-11-14 chrome-bot Update config settings by config-updater. 2017-11-13 xixuan cros-update: use curl instead of wget to check devserver health. 2017-11-13 chrome-bot Update config settings by config-updater. 2017-09-29 stevenjb cros_chrome_sdk: Automatically generate args.gn files 2017-11-11 manojgupta Revert "generic_stages: temporarily ignore all target prebuilts." 2016-07-20 sjg commands: Use cros_config_host instead of fdtget 2017-11-08 dgarrett cbuildbot: Enforce tryjob safe configs. 2017-11-01 dgarrett cros tryjob: Enforce tryjob safe configs. 2017-11-07 manojgupta generic_stages: temporarily ignore all target prebuilts. 2017-11-09 akeshet summarize_build_stats: link to new cq-weekly dashboard 2017-11-09 akeshet summarize_build_stats: drop the "Top reasons" table 2017-11-09 akeshet summarize_build_stats: add a category picker to the top X lists 2017-11-10 chrome-bot Update config settings by config-updater. 2017-11-09 dgarrett chromeos_config: Remove tryjob config overrides. 2017-11-01 dgarrett cros tryjob: Update --list for production vs tryjob. 2017-11-07 vapier image_test: move security_CroshModules autotest here 2017-11-08 derat chromite: Make TastVMTestStage unforgiving. 2017-11-06 nxia Get current builders_array from metadata. 2017-11-09 stevenjb chrome_chromeos_lkgm: Add --email to 'git cl upload' 2017-11-08 derat chromite: Run ARC Tast VM tests on betty-release. 2017-11-08 ayatane Fix typo 2017-11-06 ayatane Exclude provision suite from subsystems 2017-08-21 smbarber chromeos_config: Add tatl-full builder on external waterfall 2017-11-08 lhchavez Remove support for aosp_bertha* Android targets 2017-11-08 stevenjb chrome_chromeos_lkgm: Remove any existing chrome checkout 2017-11-08 chrome-bot Update config settings by config-updater. 2017-09-28 nxia chromite changes for Cros_CL_Status_Viewer 2017-11-06 phobbs cidb: Changes for cl_exonerator 2017-11-07 dgarrett chromeos_config: Update generated files together. 2017-11-07 achuith [cros_vm]: Better error messages for qemu. 2017-11-03 pprabhu cidb_integration_test: Wait longer for mysqld to initialize. 2017-11-08 chrome-bot Update config settings by config-updater. 2017-10-20 dgarrett chromeos_config: Create mirrored tryjob build configs. 2017-11-07 stevenjb cros_chromeos_lkgm: Add UploadNewLKGM stage (take 4) 2017-11-06 akeshet pre-cq: mark failed-to-apply changes as pre-cq-failed so they don't loop 2017-10-27 davidriley Reland "cbuildbot: Emit partition files for provisioning purposes." 2017-11-06 derat chromite: Ensure TastVMTest runs after VMTest failure. 2017-11-06 pprabhu cq_stats: deploy the correct cidb credentials. 2017-11-06 pprabhu Update cidb settings for gen2 SQL instances. 2017-11-06 pprabhu Hack fake_modules some more to allow chromite import. 2017-10-31 dgarrett cros_uprevchrome: Tweak tempdir creation. 2017-11-06 dgarrett cros_tryjob: Add --chrome_version passthrough option. 2017-11-03 llozano chromite: cleanup board lists for llvm-toolchain configs. Created with: roll-dep src/third_party/chromite Bug: 762650 Change-Id: Ib17a3570e32c98bae423d88c6320a5be95a26fef Reviewed-on: https://chromium-review.googlesource.com/775023Reviewed-by:
Xiaoyin Hu <xiaoyinh@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#517193}
-
Xianzhu Wang authored
The test seems still flaky, but the incorrect text expectation shadowed the image flakiness. Rebaseline the text expectations to expose the real image flakiness. Bug: 777259 Change-Id: I176c37017288122becd018aa154f44465b5e574c Reviewed-on: https://chromium-review.googlesource.com/774501 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#517192}
-
Alexandr Ilin authored
This reverts commit e378a8f4. Reason for revert: Several performance regressions was found. The feature will be re-enabled after all issues are fixed. Original change's description: > Enable SpeculativePreconnect Field Trial Testing > > The predictors::kSpeculativePreconnectFeature is explicitly disabled in > net::Predictor browser tests because the LoadingPredictor if enabled > intercepts all prefetch and preconnect coming from a renderer. > > WarmupManagerTest.testPreconnect() was expecting two connections to be > opened but it's not the case for the LoadingPredictor, it opens only > one connection. > > Bug: 699080 > Change-Id: I73537c3a59818793e41c5741762fe675a4efa97f > Reviewed-on: https://chromium-review.googlesource.com/754837 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Helen Li <xunjieli@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Commit-Queue: Alexandr Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515502} TBR=jwd@chromium.org,tedchoc@chromium.org,xunjieli@chromium.org,alexilin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 699080, 784206 Change-Id: I315b11b955b4aee52b6644835d649414507265f4 Reviewed-on: https://chromium-review.googlesource.com/774779Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#517191}
-
Henrique Nakashima authored
Bug: 665554 Change-Id: I96b716d38a51c13a5d94595c2b568f06471a33aa Reviewed-on: https://chromium-review.googlesource.com/774980Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#517190}
-
Kyle Horimoto authored
When GATT services are unavailable, BluetoothLowEnergyWeaveClientConnection bubbles an event up to SecureChannel, which subsequently bubbles an event up to BleConnectionManager. This CL will be used in a follow-up CL to work around the GATT services issue. Bug: 784968, 672263 Change-Id: I63de1eb025fcef9bec32bd10f3f3956d53c14cca Reviewed-on: https://chromium-review.googlesource.com/773586Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#517189}
-
Kevin Bailey authored
Moved resolution of template URL service earlier, as well as DCHECKs. Removed subsequent unnecessary null tests. Bug: 766382 Change-Id: I7ee5460e8a02bf28dc5984d5424f5ab7c826896f Reviewed-on: https://chromium-review.googlesource.com/772071 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#517188}
-
Greg Thompson authored
The test harness is less flaky now, so perhaps this can run reliably. BUG=665296 R=sky@chromium.org Change-Id: Iae61f9aa6cce8eaa4d99ed2cf7d8794e9dec1094 Reviewed-on: https://chromium-review.googlesource.com/774599Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#517187}
-
Daniel Park authored
Bug: 783991 Change-Id: I3ba066c89f8733e2b20acc71e2103f467749cae4 Reviewed-on: https://chromium-review.googlesource.com/772800Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Daniel Park <danielpark@chromium.org> Cr-Commit-Position: refs/heads/master@{#517186}
-
Greg Thompson authored
The test harness is less flaky now, so perhaps this can run reliably. BUG=468660 R=lazyboy@chromium.org Change-Id: I3b1ffcc07c8c926f1d7aea92b959ab267f5ffc3e Reviewed-on: https://chromium-review.googlesource.com/774658Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#517185}
-
Matt Menke authored
Bug: 785125 Change-Id: I018a94e0ea980c2971a8d085adf394cf13992fa3 Reviewed-on: https://chromium-review.googlesource.com/775141Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#517184}
-
Anita Woodruff authored
- Created a KeyedService, NotificationMetricsLogger, now called by PlatformNotificationService to record the user actions it was previously recording inline. Bug: 780534 Change-Id: Icde7dbf2d141359098043c6b8745d709178e4498 Reviewed-on: https://chromium-review.googlesource.com/766792 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#517183}
-
Lucas Furukawa Gadani authored
Also marks members as private, which was accidentally removed on a previous patch. Change-Id: I741d1e7013413d48e9841f0df70fe5124b3b0887 Reviewed-on: https://chromium-review.googlesource.com/774982Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#517182}
-
Khushal authored
Using this object for every op impacts rasterization performance. Restrict it only to cases which need an override. Also use StackVector in DecodeStashingImageProvider for the common case of image shaders which have a single image. R=enne@chromium.org Bug: 784377 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7ee99abf890e65f3e347185fa0d53f92acf8f2fe Reviewed-on: https://chromium-review.googlesource.com/773779 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#517181}
-
Toni Barzic authored
Lock screen item data was incorrectly saved in the same value store for all users (though, given that all data items are encrypted by a user specific encryption key, the app can only read the current user's data items). This fixes the lock screen item storage to use per-user value store, and migrates data items encrypted by the users key from the deprecated value store to the introduces, per-user value store location. PART 2/2: Hook up lock screen value store migrator to item storage - ensure data items for an extension are migrated before allowing the lock screen data API access to the extension's data. Bug: 779277 Change-Id: I1cb259d272ea6cf5d4cf6263c0f03246f71f335f Reviewed-on: https://chromium-review.googlesource.com/756327 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#517180}
-
Victor Costan authored
This CL replaces the std::string ("Set-Cookie:" HTTP header line) argument to ContentBrowserClient::AllowSetCookie with a net::CanonicalCookie and propagates the change throghout the codebase. This is a prerequisite for using ContentBrowserClient::AllowSetCookie in RestrictedCookieManagerImpl, which does not use HTTP header strings. This CL stops propagating the change at ChromeNetworkDelegate::OnCanSetCookie(). That will be done in a follow-up CL, because it's expected to generate a non-trivial number of changes, all isolated to //net. RestrictedCookieManagerImpl is a part of the upcoming Network Service, and is used by the Async Cookies API implementation. Bug: 756093 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I20eb818515dbec4dfb527ce90be52b61b0a2b739 Reviewed-on: https://chromium-review.googlesource.com/771510Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#517179}
-
Kenneth Russell authored
These can easily affect pixel test results so it's essential that this trybot be triggered for such changes. BUG=785392 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I5ba69ac4cf46b843fd507b85234985915ed47c8d Reviewed-on: https://chromium-review.googlesource.com/773560Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#517178}
-
Yash Malik authored
Minor change to keep exit prompt hidden initially and add a DCHECK to ensure that we're not drawing the exit prompt before setting the text for the prompt. Bug: None Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia5e9a0ca83ab6ca2bac04f214b93e784d7a3ca25 Reviewed-on: https://chromium-review.googlesource.com/774198Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#517177}
-
Eugene But authored
This CL implements DownloadTask public interface. DownloadControllerImpl CL: crrev.com/c/758525 Design doc: http://go/ios-web-download-api Bug: 780646 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2c508e77f3e529223499d6f2791b28011589fe90 Reviewed-on: https://chromium-review.googlesource.com/758506Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gregory Chatzinoff <gchatz@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#517176}
-
Lucas Garron authored
This should allow the presubmit to know that *ForTesting() functions are okay to call from ssl_browsertest.cc Files have been reformatted using `git cl format` to make `git cl upload` happy, but there have been no other changes to the test files. Bug: 770333, 785053 Change-Id: I01c4cb43ab8fea3b4ef7fe1a5f9abfccb49fe67d Reviewed-on: https://chromium-review.googlesource.com/774118Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Lucas Garron <lgarron@chromium.org> Cr-Commit-Position: refs/heads/master@{#517175}
-
Xiangjun Zhang authored
Currently media remoting falls back to normal tab mirroring when playback is continously delayed for about 750ms. This CL increased the duration to around 2.5s to make the logic less sensitive to noises. Bug: 768581 Change-Id: I1cfdb9369b6a5a7d35800791de940aa768b54310 Reviewed-on: https://chromium-review.googlesource.com/773572 Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#517174}
-
Reilly Grant authored
This patch copies the logic for loading gzipped WebUI resources from the non-iOS WebUI loading code and disables the exception in Grit that prevented resources from being gzipped in the iOS build. This reduces the size of resources.pak on iOS by 243 kB and starts to unify more of the WebUI infrastructure between iOS and other platforms. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I24473ea75b172210060723afa219281d0937c398 Bug: 619091 Reviewed-on: https://chromium-review.googlesource.com/770325 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#517173}
-
John Budorick authored
Bug: 783158 Change-Id: I83f27f465828f59fa8a213b7273ab430934f5499 Reviewed-on: https://chromium-review.googlesource.com/763989 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Zhiling Huang <hzl@chromium.org> Cr-Commit-Position: refs/heads/master@{#517172}
-
Lucas Furukawa Gadani authored
Bug: 784710 Change-Id: I74c7ae6edc0394224b997acd8d7e9fb34105aeba Reviewed-on: https://chromium-review.googlesource.com/773202Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#517171}
-
Lei Zhang authored
Change-Id: I92e185b74416da823d9d697de05494de3c4bd65a Reviewed-on: https://chromium-review.googlesource.com/774689Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#517170}
-
Vlad Tsyrklevich authored
Because CertVerifyProcNSS dynamically resolves a pointer to the function CERT_CacheOCSPResponseFromSideChannel(), Control Flow Integrity [1] indirect call (cfi-icall) checking can not verify that it is the intended target for that function pointer call site. Since we can not use cfi-icall to check the function pointer, instead we place the pointer in ProtectedMemory, a wrapper for keeping variables in read-only memory except for when they are initialized. After setting the pointer in protected memory we can use the UnsanitizedCfiCall wrapper to disable cfi-icall checking when calling it since we know it can not be tampered with. [1] https://www.chromium.org/developers/testing/control-flow-integrity Bug: 771365 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5d65b3591681f3daa917b6516eec1e5e47513d12 Reviewed-on: https://chromium-review.googlesource.com/765098Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#517169}
-
Alexei Svitkine authored
BUG=785341 Change-Id: I23c09aba5b81386c6ebefacd4a51b9e4fc3c4f30 Reviewed-on: https://chromium-review.googlesource.com/774902Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#517168}
-
Will Chen authored
This test became flaky after migrating it to the new test framework. Looks like there's some sort of the race with the base tag. Will unflake this soon. TBR=dgozman@chromium.org Bug: 667560 Change-Id: Idbc7c298a0e9f45703586d66aff39a45c92b76cd Reviewed-on: https://chromium-review.googlesource.com/773490 Commit-Queue: Will Chen <chenwilliam@chromium.org> Reviewed-by:
Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#517167}
-
Fredrik Solenberg authored
Bug: webrtc:8529 Change-Id: I78ae0de9078c128a7b44b12bc93aba7b9fa49a5d Reviewed-on: https://chromium-review.googlesource.com/772918 Commit-Queue: Fredrik Solenberg <solenberg@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#517166}
-
Matthew Jones authored
Swipes left and right on the toolbar are very easily triggered in the ToolbarSwipeHandler. This causes an issue for the bottom sheet when it is using the velocity swipe model; the page would shudder because the toolbar swipe layout would be triggered. This change only detects directional swipes if the initial direction is within 25 degrees or left, right, or down. This makes accidentally triggering a different layout more difficult. BUG=779615 Change-Id: Ied417f3e71e79431168410d4e305fa29a2f57b9b Reviewed-on: https://chromium-review.googlesource.com/772830 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#517165}
-
Ben Chan authored
SMS messages, notified by chromeos::NetworkSmsHandler, are encoded in UTF-8. ash::SmsObserver incorrectly treats the received SMS messages as ASCII, which causes incorrect characters to be shown in the notification window. correctly in the notification. Bug: 785583 Test: Verify that SMS messages with Unicode characters are shown Change-Id: I6a4f90d4e3c01b537f8b103e8038f7ad423b7621 Reviewed-on: https://chromium-review.googlesource.com/773620Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#517164}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/a708a70f7608..a6ed3f9aee51 $ git log a708a70f7..a6ed3f9ae --date=short --no-merges --format='%ad %ae %s' 2017-11-16 dproy Add limited cpu time metric Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I5ea6984634a7bbced092eab32fd9714cb33d47ec Reviewed-on: https://chromium-review.googlesource.com/775027 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#517163}
-
Lei Zhang authored
Change-Id: Ibab32e3da920f0fb643efcd1e3807630fd62a849 Reviewed-on: https://chromium-review.googlesource.com/775180Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#517162}
-
Lei Zhang authored
Add a couple small optimizations too. Change-Id: Ifaafc6486cbeb543c22348819ad71dcc736c5cc4 Reviewed-on: https://chromium-review.googlesource.com/775018Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#517161}
-
James Cook authored
The underlying bug was fixed and it's stable on the FYI bot. Bug: 781391 Change-Id: I291f5b1ec376c27801c03c6217de65b9b98fd664 Reviewed-on: https://chromium-review.googlesource.com/772873 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#517160}
-
Hui(Andy) Wu authored
Current rationalization logic of phone numbers runs in fields detection phase, where the fields' is_focusable state might be obselete. The rationalization use this state to determine if the logic will run. Some form have phone fields initally non-focusable, then present them dynamically, the rationalization will skip those fields. Moving the logic to filling phase should address this issue. Bug: 784935 Change-Id: I579a3dab6efad3c2f09a72562b8ae7ab4c376311 Reviewed-on: https://chromium-review.googlesource.com/768295Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Hui Wu <wuandy@chromium.org> Cr-Commit-Position: refs/heads/master@{#517159}
-
Lei Zhang authored
BUG=646113 Change-Id: I0f4591d38064ca0e8f27a514fbcb633ab2c52348 Reviewed-on: https://chromium-review.googlesource.com/764955 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#517158}
-
clamy authored
Sending renderer debug URLs to the network stack will result in trying to commit an error page, which is when the debug URL will actually be handled. This causing issues when trying to block them. This CL also ensures that debug URLs will never commit. BUG=776528,760732 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: Iaae35029e5fcd0b66c470468a8f90ca9736fff3e Reviewed-on: https://chromium-review.googlesource.com/731083 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#517157}
-
Andrey Kosyakov authored
... by posting a weak pointer as is rather than dereferencing it on a wrong thread. Change-Id: I12c66a0143b2e980bff989965454def2c29092d8 Reviewed-on: https://chromium-review.googlesource.com/774018Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#517156}
-
Ted Choc authored
Clean up of stuff I missed from: https://chromium-review.googlesource.com/c/chromium/src/+/762036 BUG=780139 Change-Id: Icc79f75e49dd9c8e2327ffee22e53cafe81bec41 Reviewed-on: https://chromium-review.googlesource.com/773503Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#517155}
-
mallikarjun82 authored
This CL migrates socket_dispatcher_host.h to use NetworkChangeObserver. More details are in the following bug Bug: 780470 Change-Id: If48f749c81272d32bfcee84ea5f5b5639157f5a0 Reviewed-on: https://chromium-review.googlesource.com/754765Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#517154}
-