GitLab

Change-Id: I41469fc27e3c88e8aff19532abd2d5ac307824bf
Bug: 
Reviewed-on: https://chromium-review.googlesource.com/682651Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Anton Vayvod <avayvod@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504466}

This Cl fixes a race in Time Zone Resolver Manager when checking if Local State
has been initialized.

Bug: b/64065854
Change-Id: If681dc675e0219fda7c9b37307c7f205394c62fd
Reviewed-on: https://chromium-review.googlesource.com/682734
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504465}

Code clean up and no behavior change.

Bug: None
Change-Id: I503e2ada644d827be7a5fe8b3e7f228130287b36
Reviewed-on: https://chromium-review.googlesource.com/685299Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504464}

Before this patch, when the user closes the PaymentRequest error message
that states "Transaction failed, please try again,"
PaymentResponse.complete() promise would be rejected. This is contrary
to the spec, which says the PaymentResponse.complete() promise should be
resolved when the user closes the UI.

Spec:
https://www.w3.org/TR/payment-request/#complete()-method

This patch changes the behavior of closing browser to resolve the
PaymentResponse.complete() promise instead.

After this patch, when the user closes the PaymentRequest error message
that states "Transaction failed, please try again,"
PaymentResponse.complete() promise is resolved with undefined.

Bug: 756298
Test: CompleteTest.ResolveCompletePromiseOnUnknownError
Test: CompleteTest.ResolveCompletePromiseOnUserClosingUI
Test: https://w3c-test.org/payment-request/payment-response/complete-method-manual.https.html
Change-Id: If21b4b1c459432acf6f3156ddf26304f04f87918
Reviewed-on: https://chromium-review.googlesource.com/682794
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504463}

Bug: 482154
Change-Id: I634489e826f6f92d45977d438a6e1f39e862a330
Reviewed-on: https://chromium-review.googlesource.com/677585Reviewed-by: Nicolas Zea <zea@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504462}

Instead of being friended by the SimpleFeature class, have unittests
use the public setters. In addition to being more clear, this cleans up
the header file.

Bug: None
Change-Id: Ia20359cf8ca35fc55eca8df1b7414b1d4f3ffea1
Reviewed-on: https://chromium-review.googlesource.com/679741
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504461}

BUG=768020
R=thestig@chromium.org

Change-Id: Iaf520e6f064cdc44977607fdac8be7137648bbfd
Reviewed-on: https://chromium-review.googlesource.com/685506Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504460}

left of and non-overlapping with a hovered UIElement.

In Chrome UI Devtools, users enter the inspection mode and pin an
element by left-clicking on a window/widget or view on the Chrome UI.
When user moves the cursor outside of the current UIElement, if the
pinned UIElement is on the top left of and doesn't overlap with the
hovered UIElement rectangle, the layout will display horizontal and
vertical distances between the pinned UIElement and the UIElement under
cursor as shown in picture below. This case refers to
R1_TOP_PARTIAL_LEFT_R2.

Bug: 750143
Change-Id: I03923aa251af63a4d820efd88c974679bf1e7c93
Reviewed-on: https://chromium-review.googlesource.com/591930
Commit-Queue: Thanh Pham <thanhph@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504459}

In this teste there's a (rather) deeply nested subtree of column-flow flex
containers. The root of this subtree is itself a flex item in a row-flow
container. It has a sibling item whose child changes width, without affecting
the flexed size of the deeply nested subtree. This shouldn't require the
subtree to be re-laid out, but it currently does get re-laid out, thanks to the
fix for bug 752078.

Bug: 766633
Change-Id: I3d76736730f18082a299907f7b2a543d2b087ba8
Reviewed-on: https://chromium-review.googlesource.com/680216Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@opera.com>
Cr-Commit-Position: refs/heads/master@{#504458}

Captive portal interstitial is currently only compiled if
ENABLE_CAPTIVE_PORTAL_DETECTION is present. This flag enables Chrome's
own captive portal detection and is off on Android. However, we still
want to be able to display a captive portal interstitial on Android, by
way of checking the certificates served by portals.

For that reason, this CL enables the captive portal interstitial on Android
and uses the CaptivePortalCertificateList feature to detect captive portal
related certificates. It also adds a Java test for the new interstitial.

Bug: 642993
Change-Id: I6be15ce10a5039fb1b1d8da0e7ef2f2c27dc48b4
Reviewed-on: https://chromium-review.googlesource.com/661795
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504457}

Introduces a setting in policy_templates.json to specify whether a
Chrome OS policy is managed by Google cloud management ('gc') or by
Active Directory ('ad'). Sets a bunch of policies to 'gc'-only that
don't work for Active Directory (e.g. device reporting, kiosk).

The following changes for 'gc'-only policies:
- The authpolicy daemon, which converts Active Directory GPO to
  policy protobufs, ignores them, see CL:608134.
- They are not included in Chrome OS ADMX templates since they're
  specified with Google's web UI, not through Active Directory GPO.
- Likewise, the HTML docs don't show example values, registry
  locations etc.

BUG=chromium:662417
TEST=components/policy/tools/template_writers/test_suite_all.py
     Checked ADMX and HTML docs from
     ninja -C out/Release -j 2000 policy_templates

Change-Id: Ib02ae8095c1052efb44a957e47b4b7628a4bdda5
Reviewed-on: https://chromium-review.googlesource.com/677289
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504456}

This patch removes a few debugging artifacts that were left in the
reporting-observer/intervention.html layout test.

Change-Id: I132a73b87c32d9a2fdb83a241ef733cb61f727e9
Reviewed-on: https://chromium-review.googlesource.com/677976Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Paul Meyer <paulmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504455}

We switched over to a new bot, which has a different gpu. This CL
updates the swarming dimensions to have the correct GPU.

NOTRY=true

Bug: 732463
Change-Id: Ibb4f034ad78e4ec294be679e70bb9f3b0ef5f61c
Reviewed-on: https://chromium-review.googlesource.com/685475
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#504454}

Change-Id: I3510dcafacab2471b02762670527dc299411c7b2
Reviewed-on: https://chromium-review.googlesource.com/683616
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504453}

Bug: 753363
Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Change-Id: Ic9045893035329b8434fd8ca7fe18735c57f842c
Reviewed-on: https://chromium-review.googlesource.com/684874Reviewed-by: Robert Shield <robertshield@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504452}

These view controllers are currently contained children of MainViewController.
When the experiment is enabled, they are presented instead.

This CL also adds a completion handler to [MainViewController
setActiveViewController:completion:].  This handler will be used in a future CL.

BUG=768563

Change-Id: Iefead6de0a1471dcd07c67d634acbab15c70b9c3
Reviewed-on: https://chromium-review.googlesource.com/683196Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504451}

Bug: 767970
Change-Id: I9d8ccbd188c4e38bf1059d7b850ccc43b1a079c4
Reviewed-on: https://chromium-review.googlesource.com/684617Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#504450}

Add chrome://download-internals to expose long-running download state,
as the system is now a root service of multiple other features.  This
CL sets up the initial skeleton and pipeline.  Future CLs will add
more capabilities.  This page will be used by more download-related
features in the near future (e.g. background fetch).

Sets up the following framework in the download service:

Logger: The public interface to the log code.  Can be queried for state
and returns base::Value objects.
Logger::Observer: Used to notify external components (e.g. WebUI) about
internal state changes.
LogSink: The internal interface that should be notified by internal
components about potential log-worthy changes.
LogSource: The internal interface that Logger will request state from.

BUG=736235

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0df66753884a2bc3f8e5ef7e0466cc879616a3a1
Reviewed-on: https://chromium-review.googlesource.com/592314
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504449}

Currently the code assumes that a TYPE_DEFAULT MesssageLoop will be backed by
CFRunLoop, which is required to receive the CoreMIDI callbacks. In the future,
that assumption may not be true, so explicitly request a TYPE_UI (CFRunLoop)
pump.

Bug: 753544
Change-Id: I5464e1299d8cb99d6fbf37d8b342417487117744
Reviewed-on: https://chromium-review.googlesource.com/682834
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504448}

This reverts commit b29b6884.

Reason for revert: CrOS browser_tests failing in debug builds
Bug: 768949

Original change's description:
> cros: AuthSyncObserver observes SigninErrorController
> 
> - Make AuthSyncObserver observe SigninErrorController in addition
>   to sync service so that auth errors caused by other services
>   are caught as well.
> - Fix an edge case that OAuth2LoginManager marks valid oauth2
>   token when it thinks /MergeSession succeeds regardless of
>   whether there is any auth error;
> 
> Bug: 760610
> Test: OAuth2Test.SetInvalidTokenStatus
> 
> Change-Id: Idbaee9f7faa1aa2aff939a1540bfcfdd9f49c96c
> Reviewed-on: https://chromium-review.googlesource.com/658378
> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#504391}

TBR=xiyuan@chromium.org,achuith@chromium.org

Change-Id: If3421269787c16081e1fd00382e5d92f73d8f082
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 760610
Reviewed-on: https://chromium-review.googlesource.com/685398Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504447}

Wasm's trap-based bounds checks are only supported on Linux x64 right
now. This test makes sure it is not incorrectly enabled on other
platforms.

Bug: v8:5277
Change-Id: Id95ba47d228707ba5ccbfde50b59ff8b26e8c79e
Reviewed-on: https://chromium-review.googlesource.com/682874
Commit-Queue: Eric Holk <eholk@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504446}

https://pdfium.googlesource.com/pdfium.git/+log/15dffdf6bd8d..7d04f1b0ab48

$ git log 15dffdf6b..7d04f1b0a --date=short --no-merges --format='%ad %ae %s'
2017-09-26 dsinclair Hide FX_HandleParentPath
2017-09-26 dsinclair Share public part of CFGAS_FontMgr declaration
2017-09-26 dsinclair Move font source into CFGAS_FontMgr

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Ifcb623446f57ef4d53f6b930b2a73fc67cee3840
Reviewed-on: https://chromium-review.googlesource.com/685256
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504445}

This reverts commit e3f445df.

Reason for revert: 
Broke compile: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20KitKat%20Builder/builds/3365

Original change's description:
> Remove //chrome/android:chrome alias
> 
> Downstream rename is now complete.
> 
> Bug: 731186
> Change-Id: I78be4e134d0a4ea0cf98c714f92d4835902de5e9
> Reviewed-on: https://chromium-review.googlesource.com/684956
> Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#504437}

TBR=nyquist@chromium.org,agrieve@chromium.org

Change-Id: I65a66e72aabc72986c8e9aacef485807cab98c3c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 731186
Reviewed-on: https://chromium-review.googlesource.com/685635Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504444}

When a connection is closed by the host, ChromotingClient will first
get the notification on network thread, then free the connection object
and notify UI components on the UI thread. In some rare situations,
a mouse event may be posted to the network thread after the connection
is reset and before ChromotingSession starts cleaning up resources, and
causes segfault because the input_stub is already freed by the
connection.

This CL fixes this problem by immediately resetting the input_stub when
the connection is being reset.

Bug: 766698
Change-Id: I95d230565154dfe3762b9de516f5fa02dabb2bba
Reviewed-on: https://chromium-review.googlesource.com/683801Reviewed-by: Scott Nichols <nicholss@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504443}

BUG=angleproject:2137

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5e50aab356858f84c6d198dc8dc387eed5998480
Reviewed-on: https://chromium-review.googlesource.com/685035Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504442}

Previously, WebView would explicitly post onPageStarted for
loadDataWithBaseUrl, since this navigation was handled by blink and it
did not generate the event.

With browser-side navigation (PlzNavigate), this is no longer the case
and the navigation code will post this event under the normal pipeline.
For this reason, we need to disable the extra postOnPageStarted when
browser-side is turned on.

As part of the implementation, this adds a Java wrapper around
IsBrowserSideNavigationEnabled.

This also modifies an integration test to check that we only get
onPageStarted called once.

Bug: 702785
Test: run_webview_instrumentation_test_apk -f LoadDataWithBaseUrlTest#testloadDataWithBaseUrlCallsOnPageStarted
Change-Id: I3abc7b3503feee26e5b2438f9b039be30750e4ef
Reviewed-on: https://chromium-review.googlesource.com/683634Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504441}

This reverts commit be622beb.

Reason for revert: Breaks PDFToPWGRasterBrowserTest.TestSuccess

Bug: 768938

Original change's description:
> Roll src/third_party/freetype/src/ 6f2b6f8f7..02e80da60 (1 commit)
> 
> https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/6f2b6f8f72ff..02e80da6090c
> 
> $ git log 6f2b6f8f7..02e80da60 --date=short --no-merges --format='%ad %ae %s'
> 2017-09-24 apodtele Tweak per-face LCD filtering controls.
> 
> Created with:
>   roll-dep src/third_party/freetype/src
> R=​bungeman@chromium.org,drott@chromium.org
> 
> Change-Id: Ief384669998d1994f574fdf86229a05ec16f6426
> Reviewed-on: https://chromium-review.googlesource.com/682176
> Reviewed-by: Dominik Röttsches <drott@chromium.org>
> Commit-Queue: Ben Wagner <bungeman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#504362}

TBR=bungeman@chromium.org,drott@chromium.org

Change-Id: I5d8d33e6800dd282538a066bc0109620f8e36521
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/685397Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504440}

WorkerPool is being deprecated in favor of TaskScheduler.

NSS functions may reenter //net via extension hooks. If the reentered
code needs to synchronously wait for a task to run but the thread pool
in which that task must run doesn't have enough threads to schedule it,
a deadlock occurs. To prevent that, calls to NSS functions are made
within the scope of a MAY_BLOCK base::ScopedBlockingCall which
increments the thread pool capacity after a short timeout.

Bug: 659191
Change-Id: I2a2719f7c104f1ecf8cac7e4019836920c777261
Reviewed-on: https://chromium-review.googlesource.com/648328
Commit-Queue: Francois Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504439}

We want a mechanism to defer ui::Layer painting during animation.
There are two benefits. First, we will not do layer compositing and
rasterization at the same time. Second, we can cache the render surface
of the animating layer. In deferred paint mode, the |damaged_region_| in
SchedulePaint() will be accumulated and drawn after the deferred paint
request is removed.

Changes:
1. Added APIs of [Add|Remove]DeferredPaintRequest().
2. Modified SchedulePaint() and SendDamagedRects() to defer painting.

Bug: 761109
Test: linux build and device.
Change-Id: I7d9710b7a6e758b6a70550d62e9cbce64333ee6b
Reviewed-on: https://chromium-review.googlesource.com/646906
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504438}

Downstream rename is now complete.

Bug: 731186
Change-Id: I78be4e134d0a4ea0cf98c714f92d4835902de5e9
Reviewed-on: https://chromium-review.googlesource.com/684956Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504437}

This patch does the following:
- Moves the decode implementation to ImageLoader
- Adds the decode functionality to SVGImageElement
- Reworks the decode functionality to use microtasks to align
  with the proposed spec changes:
  https://github.com/whatwg/html/pull/2965

This patch also cleans up some tests and adds <picture> tests.

R=fs@opera.com, domenic@chromium.org

Bug: 705669
Change-Id: I736f44c59cc173bda9f89000eaea309ddfbbeb85
Reviewed-on: https://chromium-review.googlesource.com/665381
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#504436}

Add WrapRefCounted() which is a better named version of
make_scoped_refptr(). The new name matches the MakeUnique/WrapUnique
convention already established. Update a subset of callsites to use the
WrapRefCounted() or MakeRefCounted<T>() if possible.

Other callsites will be updated in a followup CL and make_scoped_refptr
will be deleted.

Bug: 765333
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iea443d3d60f7b158b4bbbc0f43f5c3b4fad1c079
Reviewed-on: https://chromium-review.googlesource.com/684557
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504435}

onPrivetCapabilitiesSet_ expects to always get an array back from
parsePrivetDestination, even if it only contains 1 element. Change this
to work with the new changes from
https://chromium-review.googlesource.com/c/chromium/src/+/666183, which
allow parsePrivetDestination to return a destination if there is only
1 destination obtained.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2e3dc4a1d0606d08cbce29b1839b13a6445cc6e7
Reviewed-on: https://chromium-review.googlesource.com/683301
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504434}

Bug: None
Change-Id: I17162ce72e6047e0d26613fad6a041703e8f2698
Reviewed-on: https://chromium-review.googlesource.com/684699Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504433}

File containing previous chrome logs is /var/log/chrome/chrome.PREVIOUS

If log upload happens soon after log rotation, then we are left
with a very small amount of Chrome logs available in the CPanel Admin Console.
Similar to this CL: codereview.chromium.org/1394243004

BUG=b:65739107
CPanel to verify that chrome.PREVIOUS was uploaded.

TEST: Deployed Chrome to device, waited for a log upload, and checked
Change-Id: I06d7ee8e4d01f006f0d29ceaea0138e9758d06cc
Reviewed-on: https://chromium-review.googlesource.com/680536Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Niranjan Kumar <kumarniranjan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504432}

This CL adds a new type of transient element that is visible for at least a
minimum and at most a maximum duration.

It also refactors constants from UiSceneManager so they could be used in tests.

Bug: 768598
Change-Id: I6da7c6c25c106c404914aa26abadb3bc14567171
Reviewed-on: https://chromium-review.googlesource.com/683300
Commit-Queue: Yash Malik <ymalik@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504431}

ReplaceChars and RemoveChars can actually be implemented in terms of
the algorithm used for ReplaceSubstringsAfterOffset(), which is already
finely tuned to do this operation in linear time. The only difference
is to swap out which find function is used, which is accomplished here
by a boolean parameter.

Bug: 756585
Bug: 760330
Change-Id: I780dc996e360b75dc8845af90cfc7e2afed2cd6d
Reviewed-on: https://chromium-review.googlesource.com/642357
Commit-Queue: Nick Carter <nick@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504430}

Bug: 767245
Change-Id: I059d4e783510b9dd3b5db5e8cfd7312e9cd43146
Reviewed-on: https://chromium-review.googlesource.com/679934Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504429}

backup_table_extension stopped being used in c006a0ae.
Also fixed a signed/unsigned warning.

Bug: None
Change-Id: I7407cfd7546da9f40389075c1eea1bcfdd94d8bc
Reviewed-on: https://chromium-review.googlesource.com/683076Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504428}

When the user triggers a fetch through the more button, if the fetch
fails, display a Snackbar. Ideally in the future we can offer the user
information specific to how it failed and actions to remedy it.

Bug: 663376, 765603
Change-Id: I12fb27631454fb015803ae4a24a3d69c0a13357c
Reviewed-on: https://chromium-review.googlesource.com/671269Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504427}