GitLab

On OSX, NodeChannel::ShutDown() calls into
NodeController::GetMachPortRelay() which acquires |parent_lock_| and
deadlocks due to a recursuve lock acquisition.

BUG=582468

Review URL: https://codereview.chromium.org/1808233003

Cr-Commit-Position: refs/heads/master@{#381852}

This change better handles the non-user-triggered focus event that happens when the dialog loads. The behavior only appears on Mac and when the dialog initially is opened; however, it appears 100% of the time in these cases.

This adds an element with the sole purpose of triggering focus on that element when the dialog is open rather than any of the other header elements. This prevents messing with the tabindex (whether elements are focusable and in what priority) of the other elements. The tabindex of this element is then updated to be unfocusable so that the user cannot accidentally tab to the element.

BUG=594951

Review URL: https://codereview.chromium.org/1807803002

Cr-Commit-Position: refs/heads/master@{#381851}

A performance optimization. This avoids any heap allocations.

BUG=595584
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1806223002

Cr-Commit-Position: refs/heads/master@{#381850}

Avoid most window->shelf lookup calls; misc cleanup.
Remove some ChromeLauncherController auto-hide functions.
(inline pref lookup function call, context menu ops)

Add Shell::OnShelfAlignmentChanged to revise set pattern.
(support ShelfLayoutManager::SetAlignment, w/o Shell::SetShelfAlignment)

Prerequisite for https://codereview.chromium.org/1760743002

BUG=557406
TEST=No behavior changes or regressions.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/1812013003

Cr-Commit-Position: refs/heads/master@{#381849}

BUG=547073

Review URL: https://codereview.chromium.org/1807703002

Cr-Commit-Position: refs/heads/master@{#381848}

I expect to add 2 more documents in the follow up:

- clusterfuzz-libfuzzer integration documentation (build bots, corpus, status links, reports)
- reference (fuzzer_test reference, fuzzer options, dictionaries, etc.)

BUG=539572

Review URL: https://codereview.chromium.org/1809843002

Cr-Commit-Position: refs/heads/master@{#381847}

BUG=357747

Review URL: https://codereview.chromium.org/1807893002

Cr-Commit-Position: refs/heads/master@{#381846}

Adds a browser proxy object and implements the setup flow. Tests in a
separate CL.

BUG=563721

Review URL: https://codereview.chromium.org/1806123002

Cr-Commit-Position: refs/heads/master@{#381845}

In r380416, we switched to one accessibility tree per frame, whether site
isolation is on or not. On Android we only want the main frame's
BrowserAccessibilityManager to be connected to the ContentViewCore, not
any child frames.

I modified RWHVAndroid::CreateBrowserAccessibilityManager in that change so
that it wouldn't associate child frames with ContentViewCore, but I got my
logic flipped (in a way that made tests pass, but didn't work in practice).

In fixing it here, I realized that it may not be safe to assume that the
main frame is the first one to create a BrowserAccessibilityManager.
A more robust fix is for RFHI to pass a flag indicating whether it wants
a BAM for the main frame or for another frame.

In the future we may want to use that flag on other platforms, too - like
on Mac really only the main frame's BAM should have the cocoa_view_, but
I'll do that in a follow-up.

BUG=595150
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1809793002

Cr-Commit-Position: refs/heads/master@{#381844}

The first time IOSurface 2D Canvas was enabled, there were no test failures over
several days. The second time it was enabled (along with a bug fix, and some new
tests), trace_test.IOSurface2DCanvas started flakily failing.

BUG=595754

Review URL: https://codereview.chromium.org/1813073002

Cr-Commit-Position: refs/heads/master@{#381843}

BUG=NONE
TEST=NONE
R=sky@chromium.org

Review URL: https://codereview.chromium.org/1811203002

Cr-Commit-Position: refs/heads/master@{#381842}

We want to get rid of mojom::EventPtr and use ui::Event instead at some point.
This CL removes mojom::EventPtr from one more layer in mus+ash.

BUG=578206

Review URL: https://codereview.chromium.org/1814533002

Cr-Commit-Position: refs/heads/master@{#381841}

In VS 2015 builds every call to realloc triggers a warning like this:

Error #1: INVALID HEAP ARGUMENT: allocated with Windows API layer, queried with C library layer
  0 replace_malloc_usable_size
  1 _recalloc_base
  2 <lambda_4e60a939b0d047cfe11ddc22648dfba9>::operator()
  3 __crt_seh_guarded_call<>::operator()<>
  4 __acrt_lock_and_call<>
  5 _register_onexit_function
  6 _crt_atexit
  7 _onexit
  8 atexit
  9 testing::`dynamic initializer for 'FLAGS_gmock_verbose''

This mismatch is harmless (because the CRT always uses the Windows heap)
and out of our control. Therefore it should be suppressed.

With this suppression I now get a clean run on this previously failing
test:

tools\valgrind\chrome_tests.bat -t content_browsertests --tool \
    drmemory_light --build-dir=out\Release \
    --gtest_filter=ManifestBrowserTest.DummyManifest

BUG=440500,594808

Review URL: https://codereview.chromium.org/1813063002

Cr-Commit-Position: refs/heads/master@{#381840}

I accidentally added a media dependency in my last CL:
https://codereview.chromium.org/1799713002/

This CL removes the dependency since we're trying to decouple
media from gpu.

BUG=586384

Review URL: https://codereview.chromium.org/1807263002

Cr-Commit-Position: refs/heads/master@{#381839}

Left upper corner of the rect may not always be the starting position
in the DOM hierarchy, and this assumption was causing crashes.

BUG=589082

Review URL: https://codereview.chromium.org/1806813004

Cr-Commit-Position: refs/heads/master@{#381838}

This change supplements the existing build-time heuristic (which
renders the bad-clock interstitial only when the system clock is outside
the range (build-2d,build+365d)) with a comparison of the system clock
to network time, fetched from |NetworkTimeTracker|.

Network time has priority: if the network time says the clock is
accurate, the bad-clock intersitial will not be used.

The |CLOCK_FUTURE| and |CLOCK_PAST| metrics are recorded only when the
interstitial is shown, however the decision was made.  The new
histograms |interstitial.ssl.clockstate.build_time| and
|interstitial.ssl.clockstate.network| provide data about the state of
the system clock whenever a |CERT_DATE_INVALID| error is encountered.
This should help us to assess the effects of the change.

Future work will focus on providing better network time in more cases.

BUG=589700

Review URL: https://codereview.chromium.org/1772143002

Cr-Commit-Position: refs/heads/master@{#381837}

This is in aid of reusing this code to obtain secure time.

BUG=589700

Review URL: https://codereview.chromium.org/1805263002

Cr-Commit-Position: refs/heads/master@{#381836}

The comment should mention that bumping the version also flushes the
theme cache. I had intended to add that with my recent change but it
slipped my mind. Having the mentioned explicitly would have helped me
when working on the theme regression that needed the version number bump.

BUG=595510

Review URL: https://codereview.chromium.org/1811803002

Cr-Commit-Position: refs/heads/master@{#381835}

Method evaluateOnCallFrame was moved to V8DebuggerAgentImpl.
While evaluatiom on call frame for command line API support, method based on V8WindowCustom binding is used instead existing scope_extension argument. In consequent callFrame was removed from CommandLineLineAPI constructor.
Introduced InjectScopeExtensionByName helper class.

BUG=595206
R=dgozman@chromium.org
TBR=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/1811853002

Cr-Commit-Position: refs/heads/master@{#381834}

This makes it possible for a client to prevent surface contents
from appearing in screenshots or from being visible on
non-secure outputs.

This also removes some oom checks from server.cc that should have
been removed by: https://codereview.chromium.org/1717773002

BUG=549781

Review URL: https://codereview.chromium.org/1802993003

Cr-Commit-Position: refs/heads/master@{#381833}

The resampler can partially consume audio samples (since when resampling,
one output sample can correspond to fractional input samples). By keeping
track of the partially-consumed samples, we can improve the accuracy of
the estimated rendering delay.

BUG=

Review URL: https://codereview.chromium.org/1809203003

Cr-Commit-Position: refs/heads/master@{#381832}

R=dpapad@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/1801293005

Cr-Commit-Position: refs/heads/master@{#381831}

The comment claims it only fails on 10.6, which we don't test anymore.

R=kbr@chromium.org, piman@chromium.org

Review URL: https://codereview.chromium.org/1813883003

Cr-Commit-Position: refs/heads/master@{#381830}

Previously, GN builds would not properly include the Chromium version
build and patch numbers in the Chrome-Proxy header sent to the Data
Reduction Proxy. This CL fixes this, and adds assertions and tests to
ensure that the build and patch numbers are always present.

BUG=595471

Review URL: https://codereview.chromium.org/1808333002

Cr-Commit-Position: refs/heads/master@{#381829}

Autofill wallet metadata notification identifier should be
"WALLET_METADATA" instead of "AUTOFILL_WALLET_METADATA" on the client
side to match the server side sync. The server uses the name of the
protobuf WalletMetadataSpecifics to derive the identifier. This affects
only wallet metadata update notifications.

BUG=593546

Review URL: https://codereview.chromium.org/1806853006

Cr-Commit-Position: refs/heads/master@{#381828}

ESC should be handled when pressed independently from other keys. Otherwise, we'll be overriding combinations such as shift+esc, which are keyboard shortcuts.

BUG=592422

Review URL: https://codereview.chromium.org/1800213002

Cr-Commit-Position: refs/heads/master@{#381827}

We can expose test_runner::WebTask as blink::WebTaskRunner::Task.
Doing this means that components/test_runner/web_task.h header
no longer needs to be included outside of components/test_runner.

BUG=595089

Review URL: https://codereview.chromium.org/1805753002

Cr-Commit-Position: refs/heads/master@{#381826}

The spinner is takes up more height than the "Device missing?" text, so there's some seemingly janky behavior with the dialog a few seconds after the dialog is opened if there are no devices found. This change ensures the dialog doesn't resize immediately after opening when transitioning to showing "Device missing?".

BUG=595021

Review URL: https://codereview.chromium.org/1805533004

Cr-Commit-Position: refs/heads/master@{#381825}

BUG=592869

Review URL: https://codereview.chromium.org/1814703002

Cr-Commit-Position: refs/heads/master@{#381824}

Change discoverNow to fire the deviceList event with the latest
device list even if the list had not changed. The patch ensures that
by incrementing the registry generation if discovery was started
during discoverNow.

BUG=595204

Review URL: https://codereview.chromium.org/1810433002

Cr-Commit-Position: refs/heads/master@{#381823}

Open all links from the dialog (JS side) in a new tab. This prevents navigating the user away from whatever they're currently doing on the current active tab. The dialog remains open on the original tab.

URLs that are opened on the C++ side already open in a new tab.

BUG=594653

Review URL: https://codereview.chromium.org/1809463002

Cr-Commit-Position: refs/heads/master@{#381822}

A problem with the design in that blocking touch events could get
ahead of the non-blocking events was revealed in discussions. Change
the queue so that it processes all events going to the main thread.
It may elect to put blocking events in queues that it maintains so that
events are not re-ordered when dispatched to the main thread.

Force the ack behavior in the renderer to match the disposition
of the event. The benefit of this is uncancelable touch events
now can be coalesced if the main thread is behind.

BUG=489802

Review URL: https://codereview.chromium.org/1780953003

Cr-Commit-Position: refs/heads/master@{#381821}

BUG=580337

Review URL: https://codereview.chromium.org/1810843002

Cr-Commit-Position: refs/heads/master@{#381820}

To simplify public API surface of components/test_runner we can hide
LayoutDumpFlags behind WebTestRunner interface.  For example - instead
of returning the whole LayoutDumpFlags struct, we can only expose
IsRecursiveLayoutDumpRequested method - this is consistent with how
other similar methods are exposed via WebTestRunner (i.e. we already
have ShouldDumpAsAudio and/or ShouldGeneratePixelResults).

After doing this components/test_runner/layout_dump_flags.h and
components/test_runner/layout_dump.h headers no longer needs to be
included outside of components/test_runner.

BUG=595089

Review URL: https://codereview.chromium.org/1805243002

Cr-Commit-Position: refs/heads/master@{#381819}

MB was originally intended to be used to manage non-bot configs
as well, but we ended up not using this. This CL removes a bunch
of associated code that was hence no longer needed.

R=jbudorick@chromium.org, kjellander@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1808093002

Cr-Commit-Position: refs/heads/master@{#381818}

Revert of Use PhantomReference for CleanupReference (patchset #1 id:1 of https://codereview.chromium.org/1802233002/ )

Reason for revert:
Found out that PhantomReference can survive (ie not get enqueued) a GC pass. Tested on Android M.

This would cause unacceptable memory regressions for apps that relies on gc to clean up webview.

Original issue's description:
> android: Use PhantomReference for CleanupReference
>
> PhantomReference is less of a burden on dalvik/art gc systems.
>
> Committed: https://crrev.com/9b1b3599500eca2b8d664714edf6b6771a789123
> Cr-Commit-Position: refs/heads/master@{#381173}

TBR=dtrainor@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review URL: https://codereview.chromium.org/1815443002

Cr-Commit-Position: refs/heads/master@{#381817}

https://chromium.googlesource.com/native_client/src/native_client.git/+log/fc8541e88a9b..4bac1a1e26d2

$ git log fc8541e88..4bac1a1e2 --date=short --no-merges --format='%ad %ae %s'
2016-03-17 petarj [MIPS] Add missing -L flag to mips newlib nexe action

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
TBR=mseaborn@chromium.org

Review URL: https://codereview.chromium.org/1815483002

Cr-Commit-Position: refs/heads/master@{#381816}

A few flakes in the test have been resolved and it is passing
everywhere. Re-enable it for the Win8 TSan build in hopes that
it won't occur.

BUG=588199

Review URL: https://codereview.chromium.org/1806853007

Cr-Commit-Position: refs/heads/master@{#381815}

Ownership of MockScreenOrientationClient can be moved to TestRunner
(which holds ownership of other things that can be influenced by
javascript bindings).

Furthermore, TestRunner doesn't need to take a detour via
WebTestDelegate (aka BlinkTestRunner) to interact with
MockScreenOrientationClient.  This means that we can remove three
screen-orientation-related methods from WebTestDelegate.  This in turn
means that components/test_runner/mock_screen_orientation_client.h
header no longer needs to be included outside of components/test_runner.

BUG=595089

Review URL: https://codereview.chromium.org/1807733002

Cr-Commit-Position: refs/heads/master@{#381814}

+ Also fixes a bug where the proxy, firewall suggestion link opens an invalid URL.

BUG=591987,584615

Review URL: https://codereview.chromium.org/1786113002

Cr-Commit-Position: refs/heads/master@{#381813}