GitLab

Replace DCHECK(BrowserThread::CurrentlyOn) with DCHECK_CURRENTLY_ON in content/browser/renderer_host.

This is a follow-up to
https://src.chromium.org/viewvc/chrome?revision=256913&view=revision that makes
error messages more descriptive.

It was automatically produced with

git grep -l 'DCHECK(.*CurrentlyOn' content/browser/renderer_host/|xargs sed -i -e 's/DCHECK(BrowserThread::CurrentlyOn(\([^)]*\)))/DCHECK_CURRENTLY_ON(\1)/' -e 's/DCHECK(content::BrowserThread::CurrentlyOn(\([^)]*\)))/DCHECK_CURRENTLY_ON(\1)/'

Review URL: https://codereview.chromium.org/216473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260340 0039d316-1c4b-4281-b951-d872f2087c98

This supports registration and unregistration from the UI thread.

BUG=355131

Review URL: https://codereview.chromium.org/208843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260338 0039d316-1c4b-4281-b951-d872f2087c98

Click-to-play was broken when the plugin resizing code was
changed to update plugin style instead of width/height fields
directly. Problem is that 
remoting.ClientPlugin.showPluginForClickToPlay() was still using
trying to set width/height which are overridden by the CSS size.

NOTRY=true

Review URL: https://codereview.chromium.org/217353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260337 0039d316-1c4b-4281-b951-d872f2087c98

SIMD requires aligned loads or it'll crash.

BUG=357840
TEST=new unittest. played video back in crashes.
R=rileya@chromium.org, scherkus@chromium.org
TBR=scherkus

Review URL: https://codereview.chromium.org/217923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260336 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357593
NOTRY=true

Review URL: https://codereview.chromium.org/216693005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260335 0039d316-1c4b-4281-b951-d872f2087c98

The download item code tried to be helpful and make sure Blink could
navigate to download items dropped in a web contents by setting a file
URL in the drop data. Unfortunately, this doesn't work because
RenderViewHostImpl::DragTargetDragEnter filters out file URLs and
rewrites it to about:blank, and Blink happily navigates there instead of
the file.

As it turns out, this is unnecessary because Blink already converts the
filename to a URL when it attempts to turn drops into navigations so we
get this behavior for free by omitting the call to SetURL.

It also confuses some Linux file managers, causing them to link to the
file instead of making a copy when the item is dragged from the download
bar.

BUG=356794
TEST=drag download bar items to the desktop (should copy) and to another
     Chrome window (should navigate)

R=thakis@chromium.org

Review URL: https://codereview.chromium.org/217243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260334 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a bug where we failed to set the proper channel count on
AudioBuffers with the CHANNEL_LAYOUT_DISCRETE channel layout.

BUG=357801
R=dalecurtis@chromium.org
TBR=dmichael

Review URL: https://codereview.chromium.org/212103013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260333 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/216433008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260330 0039d316-1c4b-4281-b951-d872f2087c98

This patch allows using OutputConfigurator and helpers to support configration on platforms other than X11 (such as Ozone).

This CL depends on https://codereview.chromium.org/214513006/

BUG=333413

Review URL: https://codereview.chromium.org/214693010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260329 0039d316-1c4b-4281-b951-d872f2087c98

Undoing the revert, since the MultiProfileFileManagerBrowserTest failure was
caused by Blink 170311 instead.  Sorry for the disruption.

> Revert 260198 "[VideoPlayer] Browser tests for new separated vid..."
> 
> I suspect it was the cause of these file_manager_browsertest.cc failures:
> http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/22673
> 
> > [VideoPlayer] Browser tests for new separated video player app
> > 
> > BUG=357621
> > TEST=manually tested
> > 
> > R=hirono@chromium.org
> > TBR=arv@chromium.org
> > # TBRing for adding a resource.
> > 
> > Review URL: https://codereview.chromium.org/209853011
> 
> TBR=yoshiki@chromium.org
> 
> Review URL: https://codereview.chromium.org/216183006

TBR=yoshiki@chromium.org

Review URL: https://codereview.chromium.org/216793013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260328 0039d316-1c4b-4281-b951-d872f2087c98

Undoing the revert, since MultiProfileFileManagerBrowserTest failure was
caused by Blink 170311 instead.  Sorry for the disruption.

> Revert 260222 "Separate audio player tests from special file tes..."
> 
> Still trying to track down cause of MultiProfileFileManagerBrowserTest failures:
> http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/22674
> 
> 
> > Separate audio player tests from special file test of Files.app (2nd)
> > 
> > I have a plan to add more audio player tests. Before that, make audio player tests
> > separated for readability.
> > 
> > This is the 2nd (last) part of the work of crrev.com/214463002. First part is committed as crrev.com/260069.
> > 
> > BUG=none
> > TEST=browser_test passes
> > TBR=hirino@chromium.org
> > 
> > Review URL: https://codereview.chromium.org/212123008
> 
> TBR=yoshiki@chromium.org
> 
> Review URL: https://codereview.chromium.org/217743002

TBR=yoshiki@chromium.org

Review URL: https://codereview.chromium.org/218013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260327 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322664

Review URL: https://codereview.chromium.org/211483004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260326 0039d316-1c4b-4281-b951-d872f2087c98

R=markusheintz@chromium.org
BUG=356741

Review URL: https://codereview.chromium.org/215273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260325 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org

Review URL: https://codereview.chromium.org/217443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260324 0039d316-1c4b-4281-b951-d872f2087c98

It works for me on my Linux box. It only supports binary tests, not
Python. :/

R=darin@chromium.org

Review URL: https://codereview.chromium.org/217043005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260321 0039d316-1c4b-4281-b951-d872f2087c98

1. Rename a folder name if it is a normal folder.
2. Maximum folder name length.
3. Folder name not editable for oem folder.

BUG=354627
R=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/217473005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260320 0039d316-1c4b-4281-b951-d872f2087c98

BUG= 357703

TESTED=try jobs passed
NOTRY=true

Review URL: https://codereview.chromium.org/216693007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260319 0039d316-1c4b-4281-b951-d872f2087c98

Processed 357 files (out of 414 files) in 01:13:43s
Result : 232959 => 168148 bytes (64811 bytes : 27 %)

BUG=357833
TBR=msw@chromium.org

Review URL: https://codereview.chromium.org/216483010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260317 0039d316-1c4b-4281-b951-d872f2087c98

This is the first step towards moving APIDataSource to DataSourceRegistry

BUG=275039
NOTRY=true

Review URL: https://codereview.chromium.org/216943006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260316 0039d316-1c4b-4281-b951-d872f2087c98

Chrome Shell shows a black screen when we play a video.
Some parts of the fullscreen video feature was changed recently, but the changes were applied to only Content Shell.
Please refer to https://codereview.chromium.org/182493003.

Review URL: https://codereview.chromium.org/212663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260315 0039d316-1c4b-4281-b951-d872f2087c98

R=teravest@chromium.org
TBR=binji
BUG=330851,353717

Review URL: https://codereview.chromium.org/212023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260314 0039d316-1c4b-4281-b951-d872f2087c98

BUG=342317

Review URL: https://codereview.chromium.org/211973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260313 0039d316-1c4b-4281-b951-d872f2087c98

Processed 88 files (out of 301 files) in 00:19:24s
Result : 90523 => 36274 bytes (54249 bytes : 59 %)

BUG=357833
TBR=msw@chromium.org

Review URL: https://codereview.chromium.org/217883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260312 0039d316-1c4b-4281-b951-d872f2087c98

For features that need to be determined if used in the browser,
keep all the logic on browser side rather than duplicating it
in the renderer.

BUG=354449

Review URL: https://codereview.chromium.org/212003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260311 0039d316-1c4b-4281-b951-d872f2087c98

Add commands similar to WebKit text editing commands.
Translate key events to commands for textfield execution.
Consolidate key handling and command execution code.
Fix unit tests.

Modify Windows behavior for CTRL+SHIFT+[BACK|DEL].
(now behaves the same as CTRL+[BACK|DEL], not no-op)

BUG=319437
TEST=No behavior changes except for CTRL+SHIFT+[BACK|DEL] on Windows.
R=oshima@chromium.org, erg@chromium.org

Review URL: https://codereview.chromium.org/211593006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260310 0039d316-1c4b-4281-b951-d872f2087c98

Canary connection attempts occur on network changes, and are capable of
bypassing backoff (without resetting it). As such they happen immediately
if no connection attempt is already in progress, but if they fail backoff
will be increased accordingly.

BUG=355126
R=asvitkine@chromium.org, jianli@chromium.org

Review URL: https://codereview.chromium.org/213693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260308 0039d316-1c4b-4281-b951-d872f2087c98

Processed 72 files (out of 76 files) in 00:13:33s
Result : 36076 => 25724 bytes (10352 bytes : 28 %)

BUG=357833
TBR=msw@chromium.org

Review URL: https://codereview.chromium.org/212103014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260307 0039d316-1c4b-4281-b951-d872f2087c98

BUG=341275
NOTRY=true

Review URL: https://codereview.chromium.org/213673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260306 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357683

NOTRY=true

TESTED= try jobs passed

Review URL: https://codereview.chromium.org/217303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260305 0039d316-1c4b-4281-b951-d872f2087c98

R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/217403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260304 0039d316-1c4b-4281-b951-d872f2087c98

Document the "remote get nexe <path>" and
"remote get irt <other-path>" commands.
Also document the --nacl-debug-mask=<pattern_set> flag.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=3765
NOTRY=true

Review URL: https://codereview.chromium.org/217683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260303 0039d316-1c4b-4281-b951-d872f2087c98

TODO: Add a regression test to cros repository or figure out how credentials.json
can be used for a unit test.

BUG=308757
TEST=manual
NOTRY=True

Review URL: https://codereview.chromium.org/205763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260302 0039d316-1c4b-4281-b951-d872f2087c98

Include the disk serial number as a factor that is neither easily predictable nor known to the server side as well as a quantized time stamp, so the identifiers become invalid after a while.

BUG=chromium:352599
TEST=Forced re-enrollment still works.
R=joaodasilva@chromium.org, stevenjb@chromium.org, xiyuan@chromium.org

Review URL: https://codereview.chromium.org/212653004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260301 0039d316-1c4b-4281-b951-d872f2087c98

> Give localserver time to shut down
> 
> On machines with slow I/O, the localserver might not shut down immediately,
> wait for it if necessary.
> 
> BUG=
> 
> Review URL: https://codereview.chromium.org/145873004

TBR=sigbjorn@opera.com

Review URL: https://codereview.chromium.org/217913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260300 0039d316-1c4b-4281-b951-d872f2087c98

Still trying to track down cause of MultiProfileFileManagerBrowserTest failures:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/22674


> Separate audio player tests from special file test of Files.app (2nd)
> 
> I have a plan to add more audio player tests. Before that, make audio player tests
> separated for readability.
> 
> This is the 2nd (last) part of the work of crrev.com/214463002. First part is committed as crrev.com/260069.
> 
> BUG=none
> TEST=browser_test passes
> TBR=hirino@chromium.org
> 
> Review URL: https://codereview.chromium.org/212123008

TBR=yoshiki@chromium.org

Review URL: https://codereview.chromium.org/217743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260298 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Broke build.

http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29/builds/71042/steps/compile/logs/stdio#error1

Original issue's description:
> Rename PrivateMode enum values:
> 
> kPrivacyModeDisabled => PRIVACY_MODE_DISABLED
> kPrivacyModeEnabled  => PRIVACY_MODE_ENABLED
> 
> To match the chromium style guide:
> 
> Though the Google C++ Style Guide now says to use kConstantNaming for enums,
> Chromium was written using MACRO_STYLE naming.  Continue to use this style for consistency.
> 
> R=mef@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260281

TBR=mef@chromium.org,zea@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/217053010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260296 0039d316-1c4b-4281-b951-d872f2087c98

to QuicStreamFactory.

Review URL: https://codereview.chromium.org/209413005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260295 0039d316-1c4b-4281-b951-d872f2087c98

Bonus Fix:
fillFromChromeLocalStorage now handles undefined defaults correctly.

BUG=353703
R=rgustafson@chromium.org, skare@chromium.org, xiyuan@chromium.org

Review URL: https://codereview.chromium.org/217263005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260294 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=jam@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/211383007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260293 0039d316-1c4b-4281-b951-d872f2087c98

The link is not underlined and there is 10px padding between the link and the right edge.

BUG=354893

NOTRY=true

Review URL: https://codereview.chromium.org/208643004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260290 0039d316-1c4b-4281-b951-d872f2087c98