- 03 Nov, 2020 40 commits
-
-
Clemens Arbesser authored
This CL adds the basic file structure for trigger scripts. Most classes are only stubs, but the TriggerScript condition checking is already in place. Subsequent CLs will replace the stubs to make this fully functional. Bug: b/171776026 Change-Id: Ic6b687242048c3f6ebf665d7611ff115a9a91ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513595 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#823523}
-
Ramin Halavati authored
CookieSettingsFactory unittest is updated to cover ephemeral Guest profiles. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: I71fa7a2027df6abf70a15bcde20ca0a3f749af0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516939Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#823522}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e0ff8ffa..33fdba02 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia4168755ae2514f12e6fc18c31daa6062b500f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516002Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823521}
-
Chris Cunningham authored
Prior to this CL, video decoding used the main thread whenever gpu acceleration is unavailable/disabled, and audio decoding always used the main thread. Now both cases use a SequencedTaskRunner from the worker (no relation to web workers) pool. Also Bug: 1095786 Change-Id: I1c6265cdb63bcd4dadf48fdbe9bd27622218b948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500526 Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#823520}
-
Sergey Poromov authored
This test checks that the configured DLP policy is correctly converted into the corresponding Content Restriction. Bug: 1109783 Change-Id: I17bba26c6d0eb791cbcd7483b94e1537f64609d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515683 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#823519}
-
Denis Kuznetsov authored
This CL establishes a way to provide shared OOBE components via individual URLs, using oobe_i18n_behavior as an example. Bug: 1144159 Change-Id: I918c9f5c80ddc581813cdad65e68af032c9d34a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509515Reviewed-by:
Renato Silva <rrsilva@google.com> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#823518}
-
Ramin Halavati authored
|ChromeWebContentsHandler::AddNewContents| assumed that a browser object can be created in all situations but this is not true, at least if the request comes during browser shutdown. |ChromeWebContentsHandler::AddNewContents| is updated to consider the case that browser cannot be created and gracefully exit. Bug: 1141608, 1121894 Change-Id: Iaf0b2b4c1359ccf9b3b07ed606521a62c98ea4e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513209 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#823517}
-
Francois Beaufort authored
This CL makes sure "camera" in page info UI is hidden when camera PTZ is granted or blocked, regardless the state of the "Experimental Web Platform features" switch. This is needed anymore as the MediaCapturePanTilt feature is now enabled by default. Bug: 1144253 Change-Id: If212a72c00e4bede8ad1a0ebacb9a306a7d38409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516223Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#823516}
-
Andrey Zaytsev authored
* Recorded the Safety check start in the Interactions histogram * Added missing non-error PasswordsResult values * Fixed UpdatesResult to use UPDATED instead of UPDATING Bug: 1145123, 1070620 Change-Id: I5c00fc8a9f34d6f802ce47263a3a6d5ec39d98f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516224Reviewed-by:
Martin Šrámek <msramek@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#823515}
-
Rahul Goyal authored
Bug: b/171025821 Change-Id: I45cb6e3af454c7790fb8ad4ee6494ece06b847e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516500 Commit-Queue: Rahul Goyal <goyalrahul@google.com> Reviewed-by:
Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#823514}
-
Michael Ershov authored
Add a function to wait for EMCert to be uploaded and call it in TpmChallengeKey* objects before replying to Verified Access challenges. Bug: 1092653 Test: *TpmChallenge*, *MachineCertificateUploader* Change-Id: Ied402214b9bda7783b1d3c5b6856b5c908807ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452730 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#823513}
-
Nate Fischer authored
No change to production logic. This unbatches AwSettingsTest. This is to work around a bug with the @Batch annotation: if a test fails or crashes, then all subsequent tests have status "unknown" and appear as failures. We've received several "flaky test" bugs for tests which are themselves perfectly fine but are failing due to a previous test's failure. It seems more effective to unbatch this test suite until https://crbug.com/1127935 is resolved. Bug: 1144352 Test: run_webview_instrumentation_test_apk -f AwSettingsTest.* Change-Id: I8d42330909782d071ee2ffcec028a0171a4ad788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515785 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#823512}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/30ad9ea33821..89cf59f82a6b 2020-11-03 alexrudenko@chromium.org Add baseline icons for flexbox properties in the Styles panel 2020-11-03 jacktfranklin@chromium.org Migrate emulation/DeviceModeModel to TS. 2020-11-03 yangguo@chromium.org [ts] Typecheck RenderingOptions.js 2020-11-03 aerotwist@chromium.org TypeScriptify EventListenersView.js 2020-11-03 kimanh@chromium.org Add value interpreter to linear memory inspector 2020-11-03 yangguo@chromium.org [ts] Typecheck DefaultCodeMirrorMimeMode.js 2020-11-03 janscheffler@chromium.org Fix keyboard accessibility in security panel 2020-11-03 yangguo@chromium.org [ts] Typecheck LayerPaintProfilerView.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1110202,chromium:1139945 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I457bc85e26a10731ae775e01dff4b05f9fec0ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516492Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823511}
-
Jan Wilken Dörrie authored
This change performs remaining TODOs in the context of moving PasswordForm to components/password_manager. These include removing the password_form_forward.h header, as well as deleting the autofill.mojom.PasswordFormFieldPredictionType enum. TBR=dcheng,vasilii,sdefresne Fixed: 1067347 Change-Id: I88bf0d074a4920bb3b371aefad1864917ee6550d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515684Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#823510}
-
Finnur Thorarinsson authored
Reland modularization of banners/ code. Necessary dependencies on external repo have been added. This reverts commit 9c0ee959. This CL moves AppBanner* code from: chrome/android/banners ... to ... chrome/browser/banners/android ... and modularizes it in the process. Bug: 1135551 Change-Id: I80d52038bff391239f7cbc43bdcb1f1f14767916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509571 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#823509}
-
Oleg Davydov authored
And rename it to CanUseUpdateService for the consistency. The UpdateService::CanUpdate method doesn't use much from its class (only a browser context to access one keyed service). From other side, in the future we want this method to depend on extension management, which is available for chrome/, but not for extensions/ layers. And the only usage of CanUpdate is inside ExtensionUpdaters (which is already in chrome/ layer). Therefore, it makes sense to move this method in chrome/ layer, specifically into ExtensionUpdater class. As a bonus, now this method is private. Bug: b:171782200 Change-Id: I6afd7e784e8cd95f8927aab8f818f307352f58a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503690 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#823508}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/959f41988a18..b5bf82693f85 2020-11-03 jari.komppa@siru.fi Add script to verify proper Memset template use If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I3cd4a79c53c3502fc257c9b491752be719a3a949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516388Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/71d2e1d23d49..43ef0a365b84 2020-11-03 cwallez@chromium.org ValidationTest: Make custom device creation go through a virtual method If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1138528 Tbr: cwallez@google.com Change-Id: I245ed992beaf85f57ced0076ca90534ffdcebe3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516489Reviewed-by:
-
Gyuyoung Kim authored
This CL replaces all uses of blink::MediaDeviceType with blink::mojom::MediaDeviceType in order to reduce type conversion between them. Bug: 919392 Change-Id: I37bc2effefa790a2c0a1874738e94e41dada12ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505347 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#823505}
-
Richard Knoll authored
Bug: b/171901437 Change-Id: Id0785abc0161a1f4f23e85050ab7f3c4f6007408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515682Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#823504}
-
Nicholas Verne authored
This is a reland of 6b11534a OK, this time for sure. The tast-test change below was submitted, but the relevant ChromeOS uprev was blocked for days. This is now through so we can reland again, for real this time. Original change's description: > Reland "Crostini settings string changes." > > This is a reland of da531d49 > > Now that https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/2505407 > is landed, this should be safe. > > Original change's description: > > Crostini settings string changes. > > > > Instead of "Linux (Beta)", now shows as "Developers" > > > > Bug: 1140370 > > Change-Id: Id4e076b5d918e41e22e5c59d65958da9e75a3f55 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486528 > > Commit-Queue: Nicholas Verne <nverne@chromium.org> > > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > > Reviewed-by: David Munro <davidmunro@google.com> > > Auto-Submit: Nicholas Verne <nverne@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#820205} > > Bug: 1140370 > Change-Id: Ibb5bd28f9647847dddaf109e9da86d91b17dd863 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505324 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: David Munro <davidmunro@google.com> > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822525} Bug: 1140370 Change-Id: I76e0dfa45877db5d633a70126c0f5bd2a70a15f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515799Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#823503}
-
Henrik Boström authored
This class supports pixel conversions and rescaling, backed up by both libyuv functions for SW conversions and PixelBufferTransferer for HW conversions. It supports conversions from all supported capture formats (NV12, YUY2, UYVY, MJPEG) to NV12 and I420. (The pixel transfer path supports even more destination pixel formats, but libyuv's destination must be NV12 or I420, and these are the only two of interest to us.) Whether HW or SW conversion is used, the resulting buffer is put in an IOSurface-backed pixel buffer. Code paths: - When we have a pixel buffer, i.e. this is NOT MJPEG: - PixelBufferTransferer: X -> I420/NV12 in a single step. - libyuv: X -> I420 in a single step. X -> NV12 may involve an intermediate step X -> I420 -> NV12. Conversion and rescaling are done in separate steps. - MJPEG (when we only have a sample buffer): - PixelBufferTransferer: Not supported. - libyuv: MJPEG -> I420 in a single step. MJPEG -> NV12 in two steps MJPEG -> I420 -> NV12. Conversion and rescaling are done in separate steps. In a follow-up, we will do MJPEG -> NV12 in a single step based on the libyuv CL that eshr@ recently landed. Measurements show that which conversion method is most efficient is dependent on input and output pixel formats and may even be affected by cache hits/misses. In future CLs, we should wire up and measure the optimal SampleBufferTransformer configurations (in which formats to use libyuv and in which formats to use pixel transfer). Bug: chromium:1132299 Change-Id: I4f6053c65c0c3b02483d130e25bebd1f656abd89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498563 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#823502}
-
Bartek Nowierski authored
Current issues: - PA_DCHECK fires when partition page isn't 16kB - pages for quarantine bitmaps are committed unconditionally, even if the feature is never enabled These need to be addressed before re-enabling. Bug: 1144990, 11297512 Change-Id: Ia5fada4d84f5d9c28b5768322aacbccc72f5f487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515506 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cde27a683736..30ad9ea33821 2020-11-03 mathias@chromium.org Sort and reformat AUTHORS 2020-11-03 szuend@chromium.org Add Peter and myself as i18n/ owners 2020-11-03 jobay@google.com Add optional handler argument to $, $$, and waitFor 2020-11-03 bmeurer@chromium.org [wasm] Generate disassembly in chunks using the WasmParser API. 2020-11-03 soxia@microsoft.com Support page script in fetch handler If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1141781 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I06412b817f384a39631a13265f3614103bb3e2a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516480Reviewed-by:
-
Dominik Inführ authored
Bug: v8:10315 Change-Id: I6ff1be184e6f1a5b803abd673760f1cf81611c93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467998Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#823499}
-
Elad Alon authored
TL;DR: * This is an API for capturing the current tab. * This CL handles the Blink part. Explainer: https://docs.google.com/document/d/1CIQH2ygvw7eTGO__Pcds_D46Gcn-iPAqESQqOsHHfkI Design doc: go/get-current-browsing-context-media Intent-to-Prototype: https://groups.google.com/u/3/a/chromium.org/g/blink-dev/c/NYVbRRBlABI/m/MJEzcyEUCQAJ PR against spec: https://github.com/w3c/mediacapture-screen-share/pull/148 Next steps: * Implement the confirmation-box. * Implement unit-tests that rely on the confirmation-box. * Graduate this to an origin-trial. Bug: 1136942 Change-Id: I81333274075cd56d7e628a8a0eb025b1ae08645a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500841Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#823498}
-
Matthew Denton authored
Cert verification is moving out of the Network Service into a CertVerifierService for sandboxing purposes. Embedders should now include a remote to a CertVerifierService in the NetworkContextParams when creating a NetworkContext. This CL does that for Chromecast's system network context, in preparation for making the CertVerifierService enabled by default. Bug: 1015134, 1098689 Change-Id: I1b9011b7aec40326307ec11d4cde17b086c7be73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509689Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#823497}
-
Anders Hartvoll Ruud authored
This is using the exact same approach as for @property [1]: - When adding user @scroll-timeline rules, clear all rules (including author), then add user rules. - MarkDocumentDirty + SetNeedsAppendAllSheets, to ensure that we ApplyRuleSetChanges for author rules. - When adding author @scroll-timeline rules, clear all rules (including user), then add all user rules, then author rules. Marking for recalc was moved such that it only takes place if a @scroll-timeline rule is actually seen (same as for @property). This is to avoid unnecessary recalcs on media changes. [1] http://crrev.com/84a440a4818bae43a972cfc7c7c67ba4a0318003 Bug: 1074052 Change-Id: Ic081037f9a6c91fece22ee75da2f884f1902322c Fixed: 1097055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513658 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#823496}
-
Victor Hugo Vianna Silva authored
crrev.com/c/2470524 made some changes to the UI of the bubble used to offer moving a password to the account. This CL applies the same changes to its corresponding dialog in chrome://settings/passwords/device. The changes are: - Replacing the favicon elevation with a 1px border. The border is separated from the inner favicon by a 3px padding. - The borders of the avatar, favicon and computer icon share the same color, which is different in dark mode. - The favicon background changes color when in dark mode. Screenshots can be found here crbug.com/1100814#c20. Bug: 1100814 Change-Id: I05d4e5677f2fa6f4f52e70c1fdfbd38f0fa33ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514207Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#823495}
-
Anders Hartvoll Ruud authored
This reverts commit 38e15fd1. Reason for revert: Causes crash - https://crbug.com/1145094 Original change's description: > Roll ICU to 68-1 > > See https://chromium-review.googlesource.com/c/chromium/deps/icu/+/2511803 > for the actual changes and the details of the data size changes. > > > Cq-Include-Trybots: luci.chromium.try:linux-blink-heap-concurrent-marking-tsan-rel,linux_chromium_tsan_rel_ng,android-asan,linux-libfuzzer-asan-rel,linux_chromium_asan_rel_ng,linux_chromium_chromeos_asan_rel_ng,win-asan,linux_chromium_msan_rel_ng,linux_chromium_chromeos_msan_rel_ng,linux_chromium_ubsan_rel_ng,linux-gcc-rel;luci.webrtc.try:linux_tsan2,linux_asan,mac_asan,win_asan,linux_msan,linux_ubsan,linux_ubsan_vptr,linux_compile_gcc_rel > > Bug: 1138555,854201,927703 > Change-Id: I8f1b6157f2f1c13c2864836b38e36a37b8c778bf > Binary-Size: 40K ICU increase due to increase version of ICU. > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474093 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Jungshik Shin <jshin@chromium.org> > Reviewed-by: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823458} TBR=jshin@chromium.org,ftang@chromium.org Change-Id: I92d549bc306aed6e01a485faed63f02cbdd57ba7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1138555 Bug: 854201 Bug: 927703 Bug: 1145094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516560 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#823494}
-
Thomas Tellier authored
On the login screen, ADB sideloading enabled could be notified before system info such as os_version_label_text, enterprise_info_text and bluetooth_name are set, resulting into a failed DCHECK. Bug: 1141348 Change-Id: I0b607d779a1995f22d171d204cd4ca1299c2039c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515681Reviewed-by:
-
Christian Dullweber authored
Bug: 1077766 Change-Id: I50ab1b94060b590f01225a8891211f2266db9b93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513653Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#823492}
-
Jinsuk Kim authored
ToolbarColors is a collection of public static methods that returns the right color of various toolbar ui components which gets customized when the current tab is showing NTP. This CL refactors the customized logic by moving it behind NativePage interface, so that the class doesn't have direct dependency on NewTabPage. Bug: 1127732 Change-Id: Ib1b139467a0f1cc216792d112b13b40168c44c3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486526 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#823491}
-
arthursonzogni authored
Most tests about navigation defines web_contents() to avoid doing some static_cast<WebContentsImpl>(shell->web_contents()) every times the tests want to access anything. Similarly, they also define current_frame_host() for getting the current main document. For instance, see RenderFrameHostImplBrowserTest. This patch introduce the same shorthand. It makes every tests to use them. (File size reduced by ~3.5% overall). Bug: None Change-Id: I76b196ad4da8d3ce12a4fe82c076fd59f31016ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506048 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#823490}
-
Christian Dullweber authored
Bug: 1077766 Change-Id: Id80436da160c1fcb46e562713f87171415b16c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512898Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I2e8d365623cc63dae6ccae7105dcf69ac2afd4de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516379Reviewed-by:
-
Jan Wilken Dörrie authored
This change moves password_form.h and password_form.cc from /autofill/core/common to /password_manager/core/browser and fixes remaining compilation issues. TBR=vasilii,dvadym Bug: 1067347 Change-Id: I562e14ed8a0d78b5e285b9d47c98a9e036af3d24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516220 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Rohit Agarwal authored
This CL removes the deprecated Profile#hasOffTheRecordProfile method which invoked Profile#hasPrimaryOTRProfile internally. The remaining callers of hasOffTheRecordProfile are updated to directly call hasPrimaryOTRProfile instead. The code requiring the check of primary OTR profile would rely on invoking the method Profile#hasPrimaryOTRProfile explicitly instead. Bug: 1060940 Change-Id: I0955789b0cdb7c3ea86eccb2840d35c0e10d79d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516222Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#823486}
-
Gauthier Ambard authored
This CL makes sure that the documentURL is correctly updated, or is not updated when the user is reloading an error page with the new workflow. Bug: 1139303 Change-Id: I11d5f70eeb58077c0ed40f0b183c3f762f749ab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514205 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#823485}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/037ccdfb..e0ff8ffa Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I654c9d7be80e762e6e1c0ef0a52decba1532f2d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516001Reviewed-by:
-
