GitLab

Revert of Remove OneClickSigninHelper since it is no longer used. (patchset #5 id:340001 of https://codereview.chromium.org/914363003/)

Reason for revert:
Broke the tab_switching.tough_energy_cases benchmark on the perf bots.

BUG=465692

Original issue's description:
> Remove OneClickSigninHelper since it is no longer used.
>
> BUG=260022,350202
>
> Committed: https://crrev.com/be592667bdf919fb8292c88c1b59767add856ba4
> Cr-Commit-Position: refs/heads/master@{#319662}

TBR=noms@chromium.org,asvitkine@chromium.org,sky@chromium.org,rogerta@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=260022,350202

Review URL: https://codereview.chromium.org/998513002

Cr-Commit-Position: refs/heads/master@{#319862}

BUG=454505
TEST=manual

Review URL: https://codereview.chromium.org/978273002

Cr-Commit-Position: refs/heads/master@{#319861}

The new format is not backward compatible with the old one, therefore this CL updates the client side protobuf definitions to be in line with the API definition. However, this CL does not yet make use of any additional fields introduced in the new wire format.

BUG=437865

Review URL: https://codereview.chromium.org/996613002

Cr-Commit-Position: refs/heads/master@{#319860}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ceb9cf3c..17e6b228

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/992203002

Cr-Commit-Position: refs/heads/master@{#319859}

BUG=459167

Review URL: https://codereview.chromium.org/985073003

Cr-Commit-Position: refs/heads/master@{#319858}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e60fa38..8fc89ec

TBR=dstockwell@chromium.org

Review URL: https://codereview.chromium.org/991183002

Cr-Commit-Position: refs/heads/master@{#319857}

Implement OnReceivedHttpError via NetworkDelegate::OnHeadersReceived
for status codes >= 400.

BUG=456782

Review URL: https://codereview.chromium.org/976393002

Cr-Commit-Position: refs/heads/master@{#319856}

This CL move some code from
autofill_dialog_common and autofill_dialog_types
into the autofill components so that they can be
used on iOS.

It is only a code move (+git cl format).

TBR=sky

Review URL: https://codereview.chromium.org/974323002

Cr-Commit-Position: refs/heads/master@{#319855}

This happens a lot because the update check sees the worker is byte-by-byte
identical and then dooms the worker before it finishes starting.

BUG=448003

Review URL: https://codereview.chromium.org/995713002

Cr-Commit-Position: refs/heads/master@{#319854}

BUG=413541
TEST=manually tested by chaning write_supported in volume_manager.cc to true.

Review URL: https://codereview.chromium.org/982283002

Cr-Commit-Position: refs/heads/master@{#319853}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d64f94e..e60fa38

TBR=dstockwell@chromium.org

Review URL: https://codereview.chromium.org/984203004

Cr-Commit-Position: refs/heads/master@{#319852}

Just a refactoring. It's easier to reason about a single timeout timer
than multiple ones.

BUG=448003, 372436

Review URL: https://codereview.chromium.org/991743002

Cr-Commit-Position: refs/heads/master@{#319851}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c465abe..d64f94e

TBR=jbroman@chromium.org,dstockwell@chromium.org

Review URL: https://codereview.chromium.org/991173002

Cr-Commit-Position: refs/heads/master@{#319850}

Previously, devtools_http created a new tcp connection to Chrome for every
request. The large_profile generator makes tens of thousands of requests to
Chrome over a very short period of time. A socket used for a TCP connection
stays in the TIME_WAIT state for 240s after the connection has been closed.
This causes the large_profile generator to exhaust the socket limit on Windows.

Reusing the http connection fixes this problem.

BUG=464609

Review URL: https://codereview.chromium.org/980073006

Cr-Commit-Position: refs/heads/master@{#319849}

BUG=11746

Review URL: https://codereview.chromium.org/917863005

Cr-Commit-Position: refs/heads/master@{#319848}

TBR=tsepez@chromium.org,ccameron@chromium.org

Review URL: https://codereview.chromium.org/988413005

Cr-Commit-Position: refs/heads/master@{#319847}

Cr-Commit-Position: refs/heads/master@{#319846}

This CL enables suid sandbox on nacl_helper_nonsfi.

BUG=358465
TEST=Ran trybots. Ran Non-SFI NaCl app with nacl_helper_nonsfi.

Review URL: https://codereview.chromium.org/888903004

Cr-Commit-Position: refs/heads/master@{#319845}

BUG=436681

Review URL: https://codereview.chromium.org/988263002

Cr-Commit-Position: refs/heads/master@{#319844}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/167eb17..732a92d

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/994853002

Cr-Commit-Position: refs/heads/master@{#319843}

Add GetMaxResolutionForVAConfigID function to get hardware supported maximum
resolution for video encode and decode. This is also the preparation of
removing --ignore-resolution-limits-for-accelerated-video-decode flag.
Because this function uses va_config_id as parameter, we refactor
vaapi_wrapper and add LazyInstance to initialize supported profile
infos once and reuse it in Initialize and GetSupportedEncodeProfiles
functions.

BUG=350197
TEST=Test on squawks, and lumpy. Make sure this function works well.

Review URL: https://codereview.chromium.org/872623002

Cr-Commit-Position: refs/heads/master@{#319842}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/dc948a2..c465abe

TBR=jbroman@chromium.org,dstockwell@chromium.org

Review URL: https://codereview.chromium.org/995693003

Cr-Commit-Position: refs/heads/master@{#319841}

In order to support impl-side painting plus an embedder without a
message loop, cc needs a setting to disable raster.  Rastering with
impl-side painting requires a task runner (and DCHECKs this).  This
setting notifies cc that there's no need for a tile manager.

Thankfully, tile manager is already considered optional in almost all
contexts, and so just a few more callsites needed to be cleaned up to
fix a few crashes.

With this patch, all cc unittests pass with impl-side painting on by
default.

Review URL: https://codereview.chromium.org/984113004

Cr-Commit-Position: refs/heads/master@{#319840}

BUG=464373

Review URL: https://codereview.chromium.org/981063003

Cr-Commit-Position: refs/heads/master@{#319839}

We cannot commit them at this point because we are running on the IO thread.

BUG=465586

Review URL: https://codereview.chromium.org/987583005

Cr-Commit-Position: refs/heads/master@{#319838}

Note: chromium doesn't support v4 profiles at this time. Apply mozilla
fix by Benoit Girard, http://bugzil.la/1132468

BUG=458026,458027

Review URL: https://codereview.chromium.org/984333002

Cr-Commit-Position: refs/heads/master@{#319837}

BUG=464836

Review URL: https://codereview.chromium.org/997433002

Cr-Commit-Position: refs/heads/master@{#319836}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/95e34ab..dc948a2

TBR=jbroman@chromium.org,dstockwell@chromium.org

Review URL: https://codereview.chromium.org/996433004

Cr-Commit-Position: refs/heads/master@{#319835}

For legacy reasons, extensions can only request quota if there is an
infobar service. In practice, this means that extension background pages
are excluded. We should keep this same constraint to avoid changing
callback behavior with permission bubbles.

BUG=

Review URL: https://codereview.chromium.org/989363003

Cr-Commit-Position: refs/heads/master@{#319834}

This CL updates the createGuest API to return an optional contentWindow.

This CL renames GuestSizer to GuestProxyHost which better represents what it does.

GuestProxyHost exposes "LoadURLWithParams" which, after navigating, creates a swapped out RenderView for the guest in the embedder's process.

This CL removes RegisterDestructionCallback from BrowserPluginGuestDelegate.

BUG=456118

Test=WebViewTest.NoContentSettingsAPI runs with display:none now.

Review URL: https://codereview.chromium.org/910073003

Cr-Commit-Position: refs/heads/master@{#319833}

Remove unnecessary net:: qualifiers in spdy_network_transaction_unittest.cc.

BUG=

Review URL: https://codereview.chromium.org/984573007

Cr-Commit-Position: refs/heads/master@{#319832}

Review URL: https://codereview.chromium.org/981723007

Cr-Commit-Position: refs/heads/master@{#319831}

First attempt at browsers tests. I've added two tests to cover a regression
issue that came up recently where clicking the search result in the
autocomplete box didn't show all of the results. Pressing enter didn't do
anything either.

I have refactored drive_specific/autocomplete so I could make use of it.

BUG=chromium:440251,chromium:454907
TEST=browser_tests --gtest_filter="*DriveSpecific/FileManagerBrowserTest.Test/{5/6}"

Review URL: https://codereview.chromium.org/983983002

Cr-Commit-Position: refs/heads/master@{#319830}

This CL implements Fetchers which can call endpoints defined for the
IDP IFrame protocol, specifically listSessions and getToken. This will
be used as part of the Cross-Device Promo so that Chrome can mint
access tokens of a particular scope based on cookies.

BUG=463611

Review URL: https://codereview.chromium.org/973953002

Cr-Commit-Position: refs/heads/master@{#319829}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/baae7d7..95e34ab

TBR=jbroman@chromium.org,dstockwell@chromium.org

Review URL: https://codereview.chromium.org/992873002

Cr-Commit-Position: refs/heads/master@{#319828}

For target android_webview_apk. This only fixes a subset
of the issues.

BUG=

Review URL: https://codereview.chromium.org/991783006

Cr-Commit-Position: refs/heads/master@{#319827}

Widen the keyboard detection logic on Windows 8 touch devices and detect slate mode to force OSK on.

Changes in this patch as below:-

1. We now check if the device is docked and avoid displaying the OSK in this case.

2. Check the auto rotation state of the device via the
   GetAutoRotationState API. If auto rotation is disabled
   or not supported we can safely assume that a keyboard
   is present on the system.

3. Allow ACPI\* device names in the keyboard device name matching code.

4. Detect if the device is in slate mode, i.e. the keyboard is flipped. We need to display
   the OSK in this case.

BUG=335735

Review URL: https://codereview.chromium.org/988883003

Cr-Commit-Position: refs/heads/master@{#319826}

BUG=358678
R=hclam@chromium.org

Review URL: https://codereview.chromium.org/983143004

Cr-Commit-Position: refs/heads/master@{#319825}

Review URL: https://codereview.chromium.org/955283002

Cr-Commit-Position: refs/heads/master@{#319824}

This CL adds the plumbing to replicate window.name updates to the
associated RenderFrameProxies.  This consists of:
- sending a FrameHostMsg_DidChangeName to the browser process whenever
  there's a window.name update in JS
- recording the changed name in the frame's FrameReplicationState
- forwarding the updated name to any of the frame's proxies in other
  renderer processes via FrameMsg_DidUpdateName.

This is a Chromium-only patch since the plumbing for getting
window.name notifications out of Blink was already in place and used
in <webview>.  <webview>'s Chromium-side window.name code is
refactored to use the new plumbing in this CL.

BUG= 426512

Review URL: https://codereview.chromium.org/974723002

Cr-Commit-Position: refs/heads/master@{#319823}