GitLab

Also remove unused forward declaration of AXObject.

Review-Url: https://codereview.chromium.org/2589263002
Cr-Commit-Position: refs/heads/master@{#439858}

Move ongot/lostpointercapture handlers from
Element.idl to GlobalEventHandlers as per latest
spec change:
https://github.com/w3c/pointerevents/pull/158

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/?hl=en#!topic/blink-dev/T_amUSoAzHA

BUG=674290

Review-Url: https://codereview.chromium.org/2584723004
Cr-Commit-Position: refs/heads/master@{#439857}

BUG=666773

Review-Url: https://codereview.chromium.org/2591553002
Cr-Commit-Position: refs/heads/master@{#439856}

Before we can convert from a visual point to a flow thread point, we need the
input point to be exactly relative to the flow thread, or we might end up
mapping it to the wrong column.

In other words, we need to add the flow thread object's location before
converting into the flow thread coordinate space. While the flow thread indeed
is at 0,0 (or at least close enough to 0,0) relatively to the multicol
container in very many cases, this isn't true when the multicol container is in
rtl writing-mode, or when it's scrollable, or even when the multicol container
has borders and/or padding.

BUG=663062

Review-Url: https://codereview.chromium.org/2593633002
Cr-Commit-Position: refs/heads/master@{#439855}

MenuItemView was using ButtonDisabledColor for coloring menuitem
subtext (usually used for accelerator shortcuts).  However, Adwaita on
Gtk3.0 uses the same color for disabled button text as for menu
backgrounds, meaning menuitem subtext appeared invisible.  This CL
adds MenuItemSubtitleColor to fix this issue.

BUG=132847
R=sky@chromium.org,erg@chromium.org

Review-Url: https://codereview.chromium.org/2575343005
Cr-Commit-Position: refs/heads/master@{#439854}

https://skia.googlesource.com/skia.git/+log/22f4a1fd4859..86cedfc31588

$ git log 22f4a1fd4..86cedfc31 --date=short --no-merges --format='%ad %ae %s'
2016-12-20 robertphillips Fix iOS build
2016-12-20 brianosman Tag string bitmaps (for GMs) as sRGB
2016-12-20 robertphillips Restore getDevice_just_for_deprecated_compatibility_testing
2016-12-20 brianosman Do color space conversion in XfermodeImageFilter
2016-12-20 jvanverth Floor to scalar for SDF paths.
2016-12-20 scroggo Update libwebp to v0.5.2-rc2

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=rmistry@google.com

Review-Url: https://codereview.chromium.org/2590783004
Cr-Commit-Position: refs/heads/master@{#439853}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8bf02eb7..95ddaea4

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2590983002
Cr-Commit-Position: refs/heads/master@{#439852}

R=brettw@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2595503003
Cr-Commit-Position: refs/heads/master@{#439851}

This CL refactors ArcBridgeServiceImpl focusing on the
retry mechanism.
- With this CL, it starts to use OneShotTimer, which supports
cancel operation.
- Rename "reconnect" to "restart" for wording consistency.
- Introduce restart_delay_ for testing, instead of special
  bool flag. Also, for restarting of testing, get rid of
  synchronous PrerequisitesChanged() call, instead PostTask always.
- Extract StartArcSession() for sharing PrerequisitesChanged()
  and restarting.
- Added more DCHECKs.

BUG=657687
BUG=b/31079732
TEST=Ran bots.

Review-Url: https://codereview.chromium.org/2582003002
Cr-Commit-Position: refs/heads/master@{#439850}

In particular this fixes:
- loading data from leveldb should strip the prefix from the keys
- writing data to leveldb should preprend the prefix to the keys
- CommitChanges should actually commit changes

BUG=586194

Review-Url: https://codereview.chromium.org/2583253002
Cr-Commit-Position: refs/heads/master@{#439849}

Not needed at the Image interface level.

R=junov@chromium.org

Review-Url: https://codereview.chromium.org/2590573002
Cr-Commit-Position: refs/heads/master@{#439848}

BUG=602666

Review-Url: https://codereview.chromium.org/2590943002
Cr-Commit-Position: refs/heads/master@{#439847}

BUG=675266

Review-Url: https://codereview.chromium.org/2578323006
Cr-Commit-Position: refs/heads/master@{#439846}

Previously chrome --mash would always create the shelf on startup, even at
the login screen. Now it waits until login is complete, like classic ash.

Ash watches for SessionState::ACTIVE via a SessionStateObserver to create the
shelf, rather than NOTIFICATION_LOGIN_USER_PROFILE_PREPARED. For most login
flows this doesn't matter, but for supervised user creation it means that the
shelf is not created until the flow is completed. This is an improvement
because in the old code the shelf would be created too early and had to be
explicitly hidden.

Always create a SessionControllerClient in chrome, even in classic ash. This
allows classic ash to use the mojo pathway via ash::SessionController.

Remove WmShell::ShowShelf(), which was introduced in crrev.com/10693003 to
delay showing the shelf until post-login OOBE (like avatar picture select)
was complete. It does not seem to be needed anymore, either in production or
in tests.

Change AshTestImplMus to simulate a user logging in which is required to
create the shelf on the primary display and also to have a non-zero user
count to create the shelf on additional displays.

Remove some unnecessary OS_CHROMEOS ifdefs in //c/b/ui/ash.

BUG=666021
TEST=ash_unittests and chrome browser_tests

Review-Url: https://codereview.chromium.org/2573703003
Cr-Commit-Position: refs/heads/master@{#439845}

Test test reads body right after receiving a response, but it leads to some
flakiness. It is not guaranteed that the response body is available at the
moment.

This change fixes the problem by reading response body after the loading
finishes.

BUG=675924
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2592663002
Cr-Commit-Position: refs/heads/master@{#439844}

The update icon in the system tray was small and blurry on 1x displays.

BUG=643401

Review-Url: https://codereview.chromium.org/2595623002
Cr-Commit-Position: refs/heads/master@{#439843}

Pass the URL instead of the VirtualURL to the native providers and the
webUI.

BUG=671964

Review-Url: https://codereview.chromium.org/2590803002
Cr-Commit-Position: refs/heads/master@{#439842}

Currently, we activate the time source as soon as one observer becomes
pending. If that observer is removed, the time source may currently do
an unneccessary tick, because we only deactivate the time source if
all observers were removed.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2591773002
Cr-Commit-Position: refs/heads/master@{#439841}

Disable WebViewClientTest testShouldOverrideUrlLoadingOnCreateWindow,
which has been flaky on L and N bot, and ServiceWorkerClientTest
testServiceWorkerClientInterceptCallback, which has been failing on N bot

BUG=659077, 675809

Review-Url: https://codereview.chromium.org/2590053002
Cr-Commit-Position: refs/heads/master@{#439840}

This CL makes use of the resetting function VariationParamsManager.
This should work now and therefore it is sufficient to hold the manager
as a simple member.

BUG=672010

Review-Url: https://codereview.chromium.org/2592663003
Cr-Commit-Position: refs/heads/master@{#439839}

Controlled by the NTPPreferAmpUrls feature, enabled by default.

BUG=668095
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2593573003
Cr-Commit-Position: refs/heads/master@{#439838}

Per the specs at go/fns-ui-spec, the "Login not secure" warning should
show up in username fields as well as password fields. Which makes sense
because usernames are sensitive information too. Thus, this CL populates
the "Login not secure" warning in the suggestions dropdown of a password
form regardless of whether the field is a password field or not.

BUG=675696
TEST=Enable #enable-http-form-warning in chrome://flags and relaunch
Chrome. Save a username/password in the Name/Password form in
http://rsolomakhin.github.io/autofill/. Focus the "Name" field and
observe a "Login not secure" warning in the autofill dropdown.

Review-Url: https://codereview.chromium.org/2585173006
Cr-Commit-Position: refs/heads/master@{#439837}

BUG=621548
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2313103002
Cr-Commit-Position: refs/heads/master@{#439836}

The LevelDB folder backing ModelTypeStore is inside Sync Data folder.
While this change is being driven by race conditions from sync trying
to delete this folder while it is being used, this setup is fundamental
flawed. The ModelTypeStores will hold model type specific information
that needs to be persistent across sign outs and disabling sync.

The approach this CL takes to fix this problem is the modify the
deletion logic to only affect the Directory (sqllite3) files. This
means that the Sync Data folder will still exist even when sync is off.

BUG=673508,673887

Review-Url: https://codereview.chromium.org/2568743004
Cr-Commit-Position: refs/heads/master@{#439835}

Android InputDevice sources are not represented by single set bits,
and so or'ing them together is not correct.

BUG=672907

Review-Url: https://codereview.chromium.org/2594733002
Cr-Commit-Position: refs/heads/master@{#439834}

MediaStreamAudioDestinationNode needs a constructor.  This was
inadvertently missed in issue 626449.

Also, modified the exception type when an invalid channel count is
specified.  All other AudioNodes throw NotSupportedError instead of
IndexSizeError.  This requires updating one test.

BUG=674508, 626449
TEST=constructor/mediastreamaudiodestination.html,
mediastreamaudiodestinationnode.html

Review-Url: https://codereview.chromium.org/2578243002
Cr-Commit-Position: refs/heads/master@{#439833}

BUG=chromium:468240

Review-Url: https://codereview.chromium.org/2592653002
Cr-Commit-Position: refs/heads/master@{#439832}

https://skia.googlesource.com/skia.git/+log/3711e1185d53..22f4a1fd4859

$ git log 3711e1185..22f4a1fd4 --date=short --no-merges --format='%ad %ae %s'
2016-12-20 robertphillips Remove getDevice_just_for_deprecated_compatibility_test()
2016-12-19 msarett Implement SkICC::WriteICC()
2016-12-19 brianosman Respect color space in GrTextureDomainEffect

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=rmistry@google.com

Review-Url: https://codereview.chromium.org/2596433002
Cr-Commit-Position: refs/heads/master@{#439831}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/54a5b164..8bf02eb7

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2590233002
Cr-Commit-Position: refs/heads/master@{#439830}

BUG=671743

Review-Url: https://codereview.chromium.org/2559793002
Cr-Commit-Position: refs/heads/master@{#439829}

This patch is a preparation for a "badged icons" instead of green
checkmarks in the "persistence2" experiment.

Currently, TabbedPane.setTabIcon method accepts icon type and icon
titles. This works fine, but we'd like to pass in a more complex
objects - badged icons.

For this to work, the TabbedPane.setTabIcon has to accept general
instances of UI.Icon class.

BUG=675856
R=dgozman

Review-Url: https://codereview.chromium.org/2587293002
Cr-Commit-Position: refs/heads/master@{#439828}

When adding a bookmark with a non ASCII bookmark, a DCHECK was hit when
converting to UTF16.

BUG=675981

Review-Url: https://codereview.chromium.org/2590973002
Cr-Commit-Position: refs/heads/master@{#439827}

Change the share view animation from fade in/slide up to slide up/slide down.

BUG=672773

Review-Url: https://codereview.chromium.org/2593563002
Cr-Commit-Position: refs/heads/master@{#439826}

Using update-w3c-deps in Chromium d0059913.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7835

TBR=qyearsley@chromium.org
NOEXPORT=true

Review-Url: https://codereview.chromium.org/2590903002
Cr-Commit-Position: refs/heads/master@{#439825}

Calling |ClearAllVariationParams| will now create a new instance of the
FieldTrialList so |SetVariationParamsWithFeatureAssociations| will
work again.

BUG=672010

Review-Url: https://codereview.chromium.org/2590883002
Cr-Commit-Position: refs/heads/master@{#439824}

BUG=675624

Review-Url: https://codereview.chromium.org/2589763002
Cr-Commit-Position: refs/heads/master@{#439823}

Test ChromeVisibilityObserverBrowserTest.VisibilityTest is flacky on Linux:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20(dbg)(1)
(32)/builds/36743/steps/browser_tests/logs/stdio

Actually problem on showing window after browser creation but it is better to
wait all async operations with RunLoop.

BUG=

Review-Url: https://codereview.chromium.org/2591783002
Cr-Commit-Position: refs/heads/master@{#439822}

Rebase protobuf to current HEAD to pull the 3 following changes:
* 4c5d3ed Fix integer overflow in FastUInt32ToBufferLeft
* 4587a3f [arm/gcc] Don't rely on KUSER_HELPERS feature for atomics
* a5a2c1d generic atomicops: Use strong compare_exchange

This change has been made following steps described in
third_party/protobuf/README.chromium file, please refer to it
for further information.

BUG=599051,673488

Review-Url: https://codereview.chromium.org/2495533002
Cr-Commit-Position: refs/heads/master@{#439821}

Rebaselines for this test should be complete.

BUG=673752
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2588033003
Cr-Commit-Position: refs/heads/master@{#439820}

These tests are flaky, and until we can figure out how to enable
retries only on this config, we should disable them.

BUG=674932
TBR=kbr@chromium.org,ynovikov@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2594713002
Cr-Commit-Position: refs/heads/master@{#439819}