GitLab

In the new translation infobar, when the number consecutive translations
reaches a threshold, it will trigger Always-Translate automatically.
This CL is trying to implement this feature without altering the
behavior of the existing infobars.

BUG=703887

Review-Url: https://codereview.chromium.org/2871783003
Cr-Commit-Position: refs/heads/master@{#471196}

If browser process is killed, tapping on download notification leads to
a crash. Currently this is happening due to an early call to
getLastUsedProfile() used by FeatureEngagementTracker. This can be
prevented by adding an extra check for browser statup complete.

Also reordered the openDownloadedContent function to open the
downloaded item instead of download home in that scenario. That alone
should also prevent the crash.

BUG=715442

Review-Url: https://codereview.chromium.org/2876973002
Cr-Commit-Position: refs/heads/master@{#471195}

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2876813003
Cr-Commit-Position: refs/heads/master@{#471194}

This will be used to map dlls to a particular program.

BUG=717696

Review-Url: https://codereview.chromium.org/2854143005
Cr-Commit-Position: refs/heads/master@{#471193}

https://pdfium.googlesource.com/pdfium.git/+log/dbc3d3e1e0b2..3c58aa0bf51c

$ git log dbc3d3e1e..3c58aa0bf --date=short --no-merges --format='%ad %ae %s'
2017-05-11 thestig Use clamp() in a couple more places.
2017-05-11 dsinclair Rename render device classes
2017-05-11 dsinclair Remove unused GetPlatformSurface and GetDC methods
2017-05-11 dsinclair Add missing CheckUnsupportedError
2017-05-11 npm Do not use vector data() when it is empty
2017-05-11 dsinclair Move map and codec loading into manager

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I7120222e0c3c5f7de30df1a09c779c5dddd6bb42
Reviewed-on: https://chromium-review.googlesource.com/503538
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471192}

R=dougt@chromium.org, dmazzoni@chromium.org, ananta@chromium.org
BUG=703369
TESTED=Manually with Jaws 18

Review-Url: https://codereview.chromium.org/2879623003
Cr-Commit-Position: refs/heads/master@{#471191}

simulatePreconnectedPeripherals allows clients to simulate peripherals
that already connected to the system but that the UA doesn't know about.

Adds a new helper method to create system-connected devices and uses
the method in a couple of tests.

BUG=569709

Review-Url: https://codereview.chromium.org/2858803003
Cr-Commit-Position: refs/heads/master@{#471190}

This CL adds a memory pressure listener to blob storage memory
controller and evicts the blob items to disk on pressure. The evictions
are throttled to 30seconds to avoid thrashing disk. Records histograms
of sizes evicted with reasons.

BUG=715859

Review-Url: https://codereview.chromium.org/2857283002
Cr-Commit-Position: refs/heads/master@{#471189}

Marking the DOM for layout tree rebuild and the actual rebuilding is
now contained in the lifecycle update at a point where the shadow dom
distribution is up-to-date. We can therefore safely mark the flat-tree
ancestor chain without risking that it's broken by a distribution.

The point of doing RebuildLayoutTree in flat tree order is that layout
boxes can then be re-attached in the layout tree order which makes it
simpler to handle whitespace reattachment. For shadow trees and slotted
elements, when using the shadow-including tree order, we could have
elements rebuild their layout boxes in an order arbitrarily decided by
the slot assignments and slot positions in the shadow tree.

Note that while the RebuildLayoutTree traversal used to happen in the
shadow-including order, the layout attachment already happens in the
flat tree order.

See [1] for a plan to fix correctness and performance of whitespace
re-attachment.

This CL is doing the following changes:

1. Modify MarkAncestorsWithChildNeedsReattachLayoutTree to mark flat
   tree ancestry.

2. Rebuild distributed children for InsertionPoint and HTMLSlotElement.
   These children were rebuilt after their host's shadow tree before
   this change.

3. Factored out RebuildLayoutTreeForChild() as common code for both
   walking light tree children in ContainerNode, and distributed
   children in InsertionPoint and HTMLSlotElement.

4. Made FinalDestinationSlot() a member of node instead of a static
   function as it is now needed in multiple files.

[1] http://bit.ly/2ozyBdx

Review-Url: https://codereview.chromium.org/2836753002
Cr-Commit-Position: refs/heads/master@{#471188}

The GPU service scheduler runs tasks (closures) containing command
buffer work. Tasks are enqueued in sequences which represent indepdent
streams of execution. A task in one sequence may wait on a sync token
fence that's released on another sequence. Tasks can specify their sync
token fences beforehand so that the scheduler won't run a sequence only
to disable it due to a sync token wait. Tasks can check if they should
yield so that a higher priority task may run. If a task decides to
yield, it can continue execution by supplying a new closure which will
run before any other scheduled tasks in that sequence.

The scheduler maintains a priority queue of sequences ordered by
sequence priority and then order number. Priority inversion because of
sync token dependencies is handled by a simple priority ceiling scheme.
Sequences which are expected to release sync tokens dependencies are
assigned a priority (HIGH) that's higher than any client specified
priorities. However, browser view context sequences can have an even
higher priority (REAL_TIME).

GPU channel IPC messages are run as tasks in the scheduler. Each client
side stream is mapped to a sequence. The client is expected to use a
small number of streams to partition its command buffers so there is no
tracking of stream lifetimes in the service. The message filter posts
messages as tasks. AsyncFlush is the only message for which sync token
dependencies are given to the scheduler.

The initial implementation uses the GPU main thread to run scheduled
tasks. Future implementations, for example, could use a worker pool
with task traits to specify which thread a task should run on.

R=piman@chromium.org
BUG=514813
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2814843002
Cr-Commit-Position: refs/heads/master@{#471187}

base::ScopedVector is deprecated, see bug.

BUG=554289, 588249

Review-Url: https://codereview.chromium.org/2871503002
Cr-Commit-Position: refs/heads/master@{#471186}

Top/bottom/left/right have special meaning for sticky elements. So when
calling getComputedStyle on sticky elements whose style contains
"top: auto;", we should return "auto" rather than "0px" to eliminate
ambiguity.
Chromium followed the spec which specifies that getComputedStyle should
return used value (0px) for sticky elements with "top: auto;". That is
incorrect. A spec issue has been added:
https://github.com/w3c/csswg-drafts/issues/1346

BUG=703816
TEST=LayoutTests/fast/css/sticky/sticky-top-auto-get-computedstyle.html

Review-Url: https://codereview.chromium.org/2870983002
Cr-Commit-Position: refs/heads/master@{#471185}

This CL hides a bunch of the debug logging we added for crbug.com/708681
so that we only get the info if something goes awry (and not all of the time).

R=tansell@chromium.org
BUG=708681

Review-Url: https://codereview.chromium.org/2846593004
Cr-Commit-Position: refs/heads/master@{#471184}

A couple of the widgets in the settings menu (text scaling slider, clear
data timespan dropdown, learn more link) were not accessible via
bluetooth keyboard. This change allows those items to receive focus
within the containing ListView.

BUG=674736

Review-Url: https://codereview.chromium.org/2877003002
Cr-Commit-Position: refs/heads/master@{#471183}

This conforms to the spec:
https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-dommatrixreadonly

And ensures that we don't call SetMatrixValueFromString inside a worker

BUG=703908

Review-Url: https://codereview.chromium.org/2868953002
Cr-Commit-Position: refs/heads/master@{#471182}

TEST=manually verified that the histogram added to chrome://histograms/
BUG=720189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2873903004
Cr-Commit-Position: refs/heads/master@{#471181}

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2874083002
Cr-Commit-Position: refs/heads/master@{#471180}

Bug: 709296
Change-Id: I79d50b9faaab080f79b95d7da334b500aa37a5b4
Reviewed-on: https://chromium-review.googlesource.com/503490Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471179}

It will be used in CWVScrollView.

Review-Url: https://codereview.chromium.org/2876693006
Cr-Commit-Position: refs/heads/master@{#471178}

Previously, ImageLoader::SetImage() is used in three ways:
1. SetImage(nullptr),
2. SetImage(non-null) for ImageDocument, and
3. SetImage(non-null) for unit tests for non-ImageDocument.
and SetImage() sets has_pending_load_event_ = false and
image_complete_ = true for all of these.

This flag setting is consistent for 1., but not for 3., and causes
assertion failures when we apply stronger assertions in [1].

This CL fixes this by splitting SetImage() for separate methods:
1. ClearImage(),
2. SetImageForImageDocument(), and
3. SetImageForTest(),
and introducing UpdateImageState() that sets:
- image_
- has_pending_load_event_
- image_complete_

This CL
- Doesn't change non-test behavior, i.e. keeps the behavior for
  Cases 1 and 2.
  Particularly, this leaves the flag values that are apparently
  inconsistent but needed for the current implementation in Case 2 in
  SetImageForImageDocument().
- Changes the test-only behavior of Case 3, to set
    has_pending_load_event_ = true and
    image_complete_ = false in SetImageForTest().
  This doesn't affect the tested behavior but fixes the assertion
  failures in [1].

[1] https://codereview.chromium.org/2859383002

BUG=624697, 719759

Review-Url: https://codereview.chromium.org/2864253003
Cr-Commit-Position: refs/heads/master@{#471177}

renamed TaskRunner::RunsTasksOnCurrentThread() to
TaskRunner::RunsTasksInCurrentSequence() in //content

BUG=665062

Review-Url: https://codereview.chromium.org/2873333004
Cr-Commit-Position: refs/heads/master@{#471176}

R=rch@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2874333002
Cr-Commit-Position: refs/heads/master@{#471175}

Add a data structure that is structured in the same way as the UnackedPacketMap, in hope we can replace some of the remaining linked_hash_map instances and save CPU.

Merge internal change: 155789043

R=rch@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2877783003
Cr-Commit-Position: refs/heads/master@{#471174}

No .gn files reference this file anymore, and base_nacl_win64 target
which used to reference it does not exist anymore as well.

BUG=661774
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2872133007
Cr-Commit-Position: refs/heads/master@{#471173}

When the last display is removed, the |primary_display_id| is set to
invalid. In this case, we should return root window of the
|primary_tree_host_for_replace_|.

BUG=718232
Test=tested on local device

Review-Url: https://codereview.chromium.org/2870253006
Cr-Commit-Position: refs/heads/master@{#471172}

unnecessary after https://chromium-review.googlesource.com/c/497271/

BUG=716117

Review-Url: https://codereview.chromium.org/2869053003
Cr-Commit-Position: refs/heads/master@{#471171}

This CL flips `use_once_calback` flag on the Mojo code generator, and
fixes all compile errors after it. After this CL, Mojo interfaces in
//components/autofill starts using base::OnceCallback instead of
base::Callback on its return value handling.

The migration recipe was:
 - Convert pass-by-ref callback objects to pass-by-value.
 - Use std::move() to forward it to other consumer, or to invoke it
   with Callback::Run().
 - Handle wherever copies are required manually.
 - Check if the conversion doesn't change the semantics. As the transfer
   and invocation clobber the callback object, care about use-after-move.
   It's considered safe to consume almost scoped-out callback.

BUG=714018

Review-Url: https://codereview.chromium.org/2869673002
Cr-Commit-Position: refs/heads/master@{#471170}

This bot has been added in https://chromium-review.googlesource.com/c/502573/

Review-Url: https://codereview.chromium.org/2877853002
Cr-Commit-Position: refs/heads/master@{#471169}

It will be used in CWVScrollView.

Review-Url: https://codereview.chromium.org/2868333005
Cr-Commit-Position: refs/heads/master@{#471168}

When we find the id for the internal display it gets set and
Display::HasInternalDisplay() returns true. The internal display id
isn't reset, even when an internal display is removed. So even though we
might have an internal display id, there is no guarantee there is a
RootWindow for it.

BUG=721452
TEST=local device

Review-Url: https://codereview.chromium.org/2875123002
Cr-Commit-Position: refs/heads/master@{#471167}

BUG=349871
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2854263006
Cr-Commit-Position: refs/heads/master@{#471166}

 * Store the toolchain prefix in metadata
 * Resolve toolchain path when found from $PATH
 * Pass --prefix and --prefix-strip to objdump

Also:
WhereBiggerThan() -> WhereSizeBiggerThan() + WherePssBiggerThan()

BUG=695182

Review-Url: https://codereview.chromium.org/2881563003
Cr-Commit-Position: refs/heads/master@{#471165}

change ElementAnimtaions to take KeyframeAnimationOptions as arg.

See https://w3c.github.io/web-animations/#dictdef-keyframeanimationoptions

NOTE: this IDL change doesn't affect out shipping behaviour, and has low compatibility risk. Hence there is no need for an intent-to-ship notification.

Blink currently deviates from the spec in that the "id" field should be
in KeyframeAnimationOptions instead of KeyframeEffectOptions. Interface
Element should also take KeyframeAnimationOptions as arg. This cl
contains the following changes
- Add a new KeyframeAnimationOptions interface.
- Move "id" from KeyframeEffectOptions to KeyframeAnimationOptions.
- Change ElementAnimations to take KeyframeAnimationOptions as arg.
- Updates TimingInput to support KeyframeAnimationOptions.
- Add unit tests for TimingInput to cover KeyframeAnimationOptions.

BUG=700267

Review-Url: https://codereview.chromium.org/2875673005
Cr-Commit-Position: refs/heads/master@{#471164}

R=dgrogan@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2878723003
Cr-Commit-Position: refs/heads/master@{#471163}

This was released a long time ago. Removing flag to clear clutter.

BUG=338334

Review-Url: https://codereview.chromium.org/2875153002
Cr-Commit-Position: refs/heads/master@{#471162}

Inline the one internal reference in LayerImpl.

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2882543002
Cr-Commit-Position: refs/heads/master@{#471161}

BUG=718386
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2873823002
Cr-Commit-Position: refs/heads/master@{#471160}

Replacing eventSender by pointerActionSequence is not trivial. The deprecation
message should be a warning, so that CLs with eventSender can be at least
uploaded for reference or discussion purposes.

BUG=n/a

Review-Url: https://codereview.chromium.org/2872133011
Cr-Commit-Position: refs/heads/master@{#471159}

For an absolute positioned element, if its containing block is the body
it's not supposed to move as scroll. However, on low dpi devices, it
doesn't get composited if its ancestor is isolated composited therefore
it moves unexpectedly.

BUG=719533
TEST=third_party/WebKit/LayoutTests/compositing/overflow/absolute-element-in-isolated-composited-ancestor.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2869813002
Cr-Commit-Position: refs/heads/master@{#471158}

Move "Field is required" to content of editors
Change Cancel button in editors to "Cancel Payment"

BUG=718548

Review-Url: https://codereview.chromium.org/2882463002
Cr-Commit-Position: refs/heads/master@{#471157}